jimtcl: explicitly set --host / --build
PATCH 1/2 jimtcl: explicitly set --host / --build
Fixes:
http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/
Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
--- package/jimtcl/jimtcl.mk | 2 ++ 1 file changed, 2 insertions(+)
package/jimtcl/jimtcl.mk +2 -0
@@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS (cd $(@D); \ $(TARGET_CONFIGURE_OPTS) CCACHE=none \ ./configure --prefix=/usr \ + --host=$(GNU_TARGET_NAME) \ + --build=$(GNU_HOST_NAME) \ $(JIMTCL_SHARED) \ ) endef
Signature · 1 line
2.11.0
PATCH 1/2 jimtcl: explicitly set --host / --build
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Fixes:
http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
Quoted 6 lines
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
Signed-off-by Peter Korsgaard <[email protected]>
Committed to 2017.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/2 jimtcl: explicitly set --host / --build
In reply to Peter KorsgaardQuoted 21 lines · Peter Korsgaard
Fixes:
http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
Signed-off-by Peter Korsgaard <[email protected]>--- package/jimtcl/jimtcl.mk | 2 ++ 1 file changed, 2 insertions(+)package/jimtcl/jimtcl.mk +0
-0
package/jimtcl/jimtcl.mk define JIMTCL_CONFIGURE_CMDS · line 46
Quoted 5 lines
package/jimtcl/jimtcl.mk +2
-0@@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS (cd $(@D); \ $(TARGET_CONFIGURE_OPTS) CCACHE=none \ ./configure --prefix=/usr \ + --host=$(GNU_TARGET_NAME) \ + --build=$(GNU_HOST_NAME) \
For consistency with pkg-autotools, perhaps you should specify --target as well?
Regards,
Arnout
Quoted 4 lines
package/jimtcl/jimtcl.mk +0
-0$(JIMTCL_SHARED) \ ) endef
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/2 jimtcl: explicitly set --host / --build
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Quoted 16 lines · Peter Korsgaard
Fixes:
http://autobuild.buildroot.net/results/d13/d137680bf1c0ebfacef635cb2f0fc14524759143/Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
Signed-off-by Peter Korsgaard <[email protected]>---
package/jimtcl/jimtcl.mk| 2 ++1 file changed, 2 insertions(+)
Quoted 12 lines
package/jimtcl/jimtcl.mk define JIMTCL_CONFIGURE_CMDS · line 46
Quoted 10 lines
package/jimtcl/jimtcl.mk +2
-0@@ -42,6 +42,8 @@ define JIMTCL_CONFIGURE_CMDS (cd $(@D); \ $(TARGET_CONFIGURE_OPTS) CCACHE=none \ ./configure --prefix=/usr \ + --host=$(GNU_TARGET_NAME) \ + --build=$(GNU_HOST_NAME) \For consistency with pkg-autotools, perhaps you should specify --target as well?
--target is only for cross compilers, and the configure script (or rather system.tcl) doesn't accept it:
Error: Unknown option --target
Try: 'configure --help' for options
So committed as is, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/2 usb_modeswitch: explicitly set --host / --build for the embedded jimtcl
In reply to Peter KorsgaardFixes:
http://autobuild.buildroot.net/results/106/106af20196089e74c35daabdae46f030981600bd/
Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
Passing extra jimtcl configure flags is unfortunately not forseen in the usb_modeswitch Makefile, so add a small patch making this possible.
--- ...low-extra-configure-flags-to-be-passed-to.patch | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch
package/usb_modeswitch/0001-Makefile-allow-extra-configure-flags-to-be-passed-to.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 1309df373c882f27f476130b06746a6d1e1a0f85 Mon Sep 17 00:00:00 2001 +From: Peter Korsgaard <[email protected]> +Date: Fri, 3 Nov 2017 23:21:44 +0100 +Subject: [PATCH] Makefile: allow extra configure flags to be passed to jimtcl + on the make command line + +E.G. to pass --host / --build for cross compilation. + +Signed-off-by: Peter Korsgaard <[email protected]> +--- + Makefile | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Makefile b/Makefile +index a151e2a..94dabd9 100644 +--- a/Makefile ++++ b/Makefile +@@ -19,7 +19,7 @@ TCL ?= $(HOST_TCL) + else + TCL ?= /usr/bin/tclsh + endif +-JIM_CONFIGURE_OPTS = --disable-lineedit \ ++override JIM_CONFIGURE_OPTS += --disable-lineedit \ + --with-out-jim-ext="stdlib posix load signal syslog" --prefix=/usr + + .PHONY: clean install install-common uninstall \ +-- +2.11.0 +
Signature · 1 line
2.11.0
PATCH 2/2 usb_modeswitch: explicitly set --host / --build for the embedded jimtcl
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Peter" == Peter Korsgaard <[email protected]> writes:
Fixes:
http://autobuild.buildroot.net/results/106/106af20196089e74c35daabdae46f030981600bd/Otherwise the (handwritten) configure script uses a config.guess script from 2010 to figure out the build host, breaking builds on ppc64le hosts.
The result of --host / --build is only used to detect if we are building for Windows or not, which is why things are working on x86(-64) build hosts without specifying --host even though we are cross compiling - But this may change in the future, so we better pass the correct values.
Quoted 6 lines
Passing extra jimtcl configure flags is unfortunately not forseen in the
usb_modeswitchMakefile, so add a small patch making this possible.Signed-off-by Peter Korsgaard <[email protected]>--- ...low-extra-configure-flags-to-be-passed-to.patch | 29 ++++++++++++++++++++++
Gaah, this is missing the usb_modeswitch.mk hunk. Will resend.
Signature · 1 line
Bye, Peter Korsgaard