ARM: mx5: add support for USB armory board

From: Andrej Rosano <[email protected]>

Move the MX5 based boards to arch/arm/cpu/armv7/mx5, following the
commit: 89ebc82137bebb11a8191f8b9cbf08f2533ae8bc

Signed-off-by Andrej Rosano <[email protected]>

Cc Stefano Babic <[email protected]>

Cc Vagrant Cascadian <[email protected]>

From: Andrej Rosano <[email protected]>

Add support for Inverse Path USB armory board, an open source flash-drive sized computer based on Freescale i.MX53 SoC.

http://inversepath.com/usbarmory

From: Andrej Rosano <[email protected]>

Hello,

this series adds support for USB armory board. The patches are prepared against imx tree as it uses the new arch/board approach.

The first patch add introduces the arch/board approach for mx5, as already done for mx6.

The second patch adds basic support for USB armory board and is an updated version (v4) with the modifications described bellow.

Changes for v4:
- Remove ifdef for CONFIG_FSL_ESDHC as it must always be present
- Remove explicit GPIO input setup (all GPIO are input after reset)
- Remove dummy board_late_init() and CONFIG_BOARD_LATE_INIT
- Remove CONFIG_BOOTARGS
- Fix compiling errors due to config_distro_bootcmd.h inclusion position

Changes for v3:
- Add config_distro support

Changes for v2:
- Fix double print_cpuinfo() call
- Fix CONFIG_BOOTCOMMAND typo
- Fix CONFIG_SYS_FSL_ESDHC_NUM to 1

Andrej Rosano (2):
ARM: mx5: move to a standard arch/board approach
ARM: mx5: add support for USB armory board

Andrej Rosano (2):
ARM: mx5: move to a standard arch/board approach
ARM: mx5: add support for USB armory board

Quoted 9 lines · On Thu, Mar 26, 2015 at 4:49 AM, <[email protected]> wrote:

From: Andrej Rosano <[email protected]>

Hello,

this series adds support for USB armory board. The patches are prepared against imx tree as it uses the new arch/board approach.

The first patch add introduces the arch/board approach for mx5, as already done for mx6.

Yep, that works.

Quoted 2 lines

The second patch adds basic support for USB armory board and is an updated version (v4) with the modifications described bellow.

If I test this against HEAD as of f643d9294f45487f22e8f33d6572530f17eff4e9, I get an error reated to IMX_CONFIG.

"board/inversepath/usbarmory/Kconfig:3:warning: config symbol defined without type"

Here's a diff to fix that

board/inversepath/usbarmory/Kconfig +0 -3

index c2cd544..4776b1d 100644
@@ -1,8 +1,5 @@
 if TARGET_USBARMORY
 
-config IMX_CONFIG
-    default "board/inversepath/usbarmory/imximage.cfg"
-
 config SYS_BOARD
     default "usbarmory"
 

configs/usbarmory_defconfig +1 -0

index 10bdd9e..237b1ca 100644
@@ -1,3 +1,4 @@
 CONFIG_ARM=y
 CONFIG_ARCH_MX5=y
 CONFIG_TARGET_USBARMORY=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/inversepath/usbarmory/imximage.cfg"

Quoted 8 lines

Changes for v4:
- Remove ifdef for CONFIG_FSL_ESDHC as it must always be present
- Remove explicit GPIO input setup (all GPIO are input after reset)
- Remove dummy board_late_init() and CONFIG_BOARD_LATE_INIT
- Remove CONFIG_BOOTARGS
- Fix compiling errors due to config_distro_bootcmd.h inclusion position

Tested-by Chris Kuethe <[email protected]>

Quoted 8 lines

Changes for v3:
- Add config_distro support

Changes for v2:
- Fix double print_cpuinfo() call
- Fix CONFIG_BOOTCOMMAND typo
- Fix CONFIG_SYS_FSL_ESDHC_NUM to 1

Quoted 8 lines

Andrej Rosano (2):
ARM: mx5: move to a standard arch/board approach
ARM: mx5: add support for USB armory board

Andrej Rosano (2):
ARM: mx5: move to a standard arch/board approach
ARM: mx5: add support for USB armory board

Signature · 1 line

GDB has a 'break' feature; why doesn't it have 'fix' too?

Please note that the patch is prepared against imx tree and not the mainline one, where the "arch/board approach" is not yet merged.

Quoted 2 lines · Andrej Rosano

Please note that the patch is prepared against imx tree and not the mainline one, where the "arch/board approach" is not yet merged.

OK, it all works for me.

--
GDB has a 'break' feature; why doesn't it have 'fix' too?

Any chance of this being accepted into 2015.04?

Hi Chris,

Quoted 2 lines · Chris Kuethe

Any chance of this being accepted into 2015.04?

Quoted 2 lines · Stefano Babic

Quoted 1 line · Chris Kuethe

Any chance of this being accepted into 2015.04?

checpatch reports some issues by patch 2/2. Can you please fix them and resubmit ? Thanks !

Quoted 6 lines · Stefano Babic

Quoted 2 lines · Stefano Babic

Quoted 1 line · Chris Kuethe

Any chance of this being accepted into 2015.04?

checpatch reports some issues by patch 2/2. Can you please fix them and resubmit ? Thanks !

Applying the patch below corrects most of the issues, but not all of the reported issues:

Cleaned 2 patches
0 errors, 1 warnings, 0 checks for 0001-ARM-mx5-move-to-a-standard-arch-board-approach.patch:
warning: arch/arm/Kconfig,440: please write a paragraph that describes the config symbol fully

0 errors, 1 warnings, 1 checks for 0002-ARM-mx5-add-support-for-USB-armory-board.patch:
check: board/inversepath/usbarmory/usbarmory.c,382: Alignment should match open parenthesis
warning: include/configs/usbarmory.h,41: line over 80 characters

checkpatch.pl found 0 error(s), 2 warning(s), 1 checks(s)

board/inversepath/usbarmory/usbarmory.c +7 -8

index 3e60a86..573d586 100644
@@ -68,13 +68,13 @@ static void setup_iomux_sd(void)
 		NEW_PAD_CTRL(MX53_PAD_SD1_CMD__ESDHC1_CMD, SD_CMD_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_SD1_CLK__ESDHC1_CLK, MX53_SDHC_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_SD1_DATA0__ESDHC1_DAT0,
-			MX53_SDHC_PAD_CTRL),
+			     MX53_SDHC_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_SD1_DATA1__ESDHC1_DAT1,
-			MX53_SDHC_PAD_CTRL),
+			     MX53_SDHC_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_SD1_DATA2__ESDHC1_DAT2,
-			MX53_SDHC_PAD_CTRL),
+			     MX53_SDHC_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_SD1_DATA3__ESDHC1_DAT3,
-			MX53_SDHC_PAD_CTRL),
+			     MX53_SDHC_PAD_CTRL),
 		MX53_PAD_EIM_DA13__GPIO3_13,
 	};
 

@@ -85,7 +85,7 @@ static void setup_iomux_led(void)
 {
 	static const iomux_v3_cfg_t pads[] = {
 		NEW_PAD_CTRL(MX53_PAD_DISP0_DAT6__GPIO4_27,
-			PAD_CTL_PUS_100K_DOWN),
+			     PAD_CTL_PUS_100K_DOWN),
 	};
 
 	imx_iomux_v3_setup_multiple_pads(pads, ARRAY_SIZE(pads));

@@ -107,9 +107,9 @@ static void setup_iomux_pinheader(void)
 		NEW_PAD_CTRL(MX53_PAD_CSI0_DAT8__GPIO5_26, PAD_CTRL_UP),
 		NEW_PAD_CTRL(MX53_PAD_CSI0_DAT9__GPIO5_27, PAD_CTRL_UP),
 		NEW_PAD_CTRL(MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
-			MX53_UART_PAD_CTRL),
+			     MX53_UART_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
-			MX53_UART_PAD_CTRL),
+			     MX53_UART_PAD_CTRL),
 		NEW_PAD_CTRL(MX53_PAD_CSI0_DAT12__GPIO5_30, PAD_CTRL_UP),
 	};
 

@@ -119,7 +119,6 @@ static void setup_iomux_pinheader(void)
 static void setup_iomux_unused_boot(void)
 {
 	static const iomux_v3_cfg_t pads[] = {
-
 		/* Pulled-up pads */
 		NEW_PAD_CTRL(MX53_PAD_EIM_A21__GPIO2_17, PAD_CTRL_UP),
 		NEW_PAD_CTRL(MX53_PAD_EIM_DA0__GPIO3_0, PAD_CTRL_UP),

Quoted 6 lines · Stefano Babic

Hi Chris,

Quoted 2 lines · Chris Kuethe

Any chance of this being accepted into 2015.04?

checpatch reports some issues by patch 2/2. Can you please fix them and resubmit ? Thanks !

Best regards,
Stefano Babic

Signature · 9 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Hi Stefano,

Quoted 4 lines · Stefano Babic

Quoted 3 lines · Stefano Babic

Hi Chris,

On 01/04/2015 04:46, Chris Kuethe wrote:

Quoted 6 lines

Quoted 3 lines

Quoted 2 lines

Any chance of this being accepted into 2015.04?

checpatch reports some issues by patch 2/2. Can you please fix them and resubmit ? Thanks !

Just resubmitted the v5 version.