fs/common: build host-xz when xz compression is used
PATCH 1/1 fs/common: build host-xz when xz compression is used
From: Thomas De Schampheleire <[email protected]>
When a filesystem image is xz-compressed, the XZ variable is used to refer to the xz compression tool, but it is not necessarily available. Add a proper dependency to fix that.
--- fs/common.mk | 1 + 1 file changed, 1 insertion(+)
fs/common.mk +1 -0
@@ -62,6 +62,7 @@ ROOTFS_$(2)_COMPRESS_EXT = .lzo ROOTFS_$(2)_COMPRESS_CMD = $$(LZOP) -9 -c endif ifeq ($$(BR2_TARGET_ROOTFS_$(2)_XZ),y) +ROOTFS_$(2)_DEPENDENCIES += host-xz ROOTFS_$(2)_COMPRESS_EXT = .xz ROOTFS_$(2)_COMPRESS_CMD = xz -9 -C crc32 -c endif
Signature · 1 line
1.8.5.1
PATCH 1/1 fs/common: build host-xz when xz compression is used
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> When a filesystem image is xz-compressed, the XZ variable is used to refer to the xz compression tool, but it is not necessarily available. Add a proper dependency to fix that.
Isn't that already handled by support/dependencies/check-host-xzcat.mk?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 fs/common: build host-xz when xz compression is used
Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]>
Quoted 2 lines · writes:
From: Thomas De Schampheleire <[email protected]> When a filesystem image is xz-compressed, the XZ variable is used to
refer
Quoted 1 line
to the xz compression tool, but it is not necessarily available. Add
a
Quoted 1 line
proper dependency to fix that.
Isn't that already handled by
support/dependencies/check-host-xzcat.mk?
No, that file handles xzcat, the decompression tool, but in fs/ we use
compression (xz).
PATCH 1/1 fs/common: build host-xz when xz compression is used
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
Hi,
Quoted 6 lines · Peter Korsgaard
Quoted 2 lines
Isn't that already handled by
support/dependencies/check-host-xzcat.mk?No, that file handles xzcat, the decompression tool, but in
fs/we use
compression (xz).
While that is true, have you ever seen a distribution that provides one but not the other? They come from the same upstream package.
And if there would be such an (odd) distribution somewhere we could probably extend check-host-xzcat.mk to check for both with little effort.
Signature · 2 lines
Venlig hilsen, Peter Korsgaard
PATCH 1/1 fs/common: build host-xz when xz compression is used
In reply to Thomas De SchampheleireDear Thomas De Schampheleire,
Quoted 10 lines · Thomas De Schampheleire
From: Thomas De Schampheleire <[email protected]>
When a filesystem image is xz-compressed, the XZ variable is used to refer to the xz compression tool, but it is not necessarily available. Add a proper dependency to fix that.
Signed-off-by Thomas De Schampheleire <[email protected]>--- fs/common.mk | 1 + 1 file changed, 1 insertion(+)
I must say I don't quite understand why we have these options to compress the resulting filesystem image.
But since we have them, I've applied your patch :)
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com