Tuxera test suite failure for setfacl
Hello,
With commit c6ac12a6159c802ae8b757dd13563564e64333df we are modifying the ctime of the file when changing file's permission by setfacl. The commit says that is correct as per spec. But we do have a test in tuxera
http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45 which expect the ctime to be not changed across setfacl.
I haven't looked at the spec myself. Can you double check and make sure it is ok to change the ctime across setfacl ?
-aneesh
Hello,
Quoted 8 lines · Aneesh Kumar K.V
With commit
c6ac12a6159c802ae8b757dd13563564e64333dfwe are modifying the ctime of the file when changing file's permission by setfacl. The commit says that is correct as per spec. But we do have a test in tuxera
http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45 which expect the ctime to be not changed across setfacl.I haven't looked at the spec myself. Can you double check and make sure it is ok to change the ctime across setfacl ?
Well, it would be really strange if changing permissions via chmod(1)
changed ctime but via setfacl(1) did not, don't you think?
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 9 lines · Jan Kara
Hello,
Quoted 6 lines · Aneesh Kumar K.V
With commit
c6ac12a6159c802ae8b757dd13563564e64333dfwe are modifying the ctime of the file when changing file's permission by setfacl. The commit says that is correct as per spec. But we do have a test in tuxera
http://tuxera.com/sw/qa/pjd-fstest-20090130-RC.tgz test/xacl/00.t 45 which expect the ctime to be not changed across setfacl.
Quoted 5 lines
Quoted 2 lines
I haven't looked at the spec myself. Can you double check and make sure it is ok to change the ctime across setfacl ?
Well, it would be really strange if changing permissions via chmod(1)
changed ctime but via setfacl(1) did not, don't you think?
That make sense. I guess we should consider this a test case error.
-aneesh