libsndfile: Add dependency on BR2_LARGEFILE
PATCH 1/1 libsndfile: Add dependency on BR2_LARGEFILE
From: Ryan Mallon <[email protected]>
libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a typedef alias for off_t. This is not true by default for all tool-chains, which leads to a runtime assert failure in binaries compiled against libsndfile. See:
http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229
Add a dependency on BR2_LARGEFILE for libsndfile, and a comment if BR2_LARGEFILE is not selected.
[Thomas: rebased patch, added more propagation of the new BR2_LARGEFILE dependency to gst-plugins-good and mpd.]
--- package/bluez_utils/Config.in | 4 ++++ package/libsndfile/Config.in | 7 +++++++ package/multimedia/gst-plugins-bad/Config.in | 4 ++++ package/multimedia/gst-plugins-good/Config.in | 1 + package/multimedia/mpd/Config.in | 5 +++++ package/multimedia/pulseaudio/Config.in | 5 +++-- 6 files changed, 24 insertions(+), 2 deletions(-)
package/bluez_utils/Config.in +4 -0
@@ -22,9 +22,13 @@ config BR2_PACKAGE_BLUEZ_UTILS_AUDIO bool "audio support" select BR2_PACKAGE_ALSA_LIB select BR2_PACKAGE_LIBSNDFILE + depends on BR2_LARGEFILE help Audio support +comment "bluez-utils audio requires a toolchain with LARGEFILE support" + depends on !BR2_LARGEFILE + config BR2_PACKAGE_BLUEZ_UTILS_USB bool "USB support" depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
package/libsndfile/Config.in +7 -0
@@ -1,8 +1,15 @@ config BR2_PACKAGE_LIBSNDFILE bool "libsndfile" + # The absence of largefile doesn't prevent libsndfile to + # build, but at runtime the code assumes that off_t is 64 + # bits, and asserts if not. + depends on BR2_LARGEFILE help Libsndfile is a C library for reading and writing files containing sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format) through one standard library interface. http://www.mega-nerd.com/libsndfile/ + +comment "libsndfile requires a toolchain with LARGEFILE support" + depends on !BR2_LARGEFILE
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -305,6 +305,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_SDL config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_SNDFILE bool "sndfile" select BR2_PACKAGE_LIBSNDFILE + depends on BR2_LARGEFILE + +comment "gst-plugins-bad-plugin-sndfile requires a toolchain with LARGEFILE support" + depends on !BR2_LARGEFILE config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_VCD bool "vcd"
package/multimedia/gst-plugins-good/Config.in +1 -0
@@ -198,6 +198,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_OSS4 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio + depends on BR2_LARGEFILE # pulseaudio -> libsndfile select BR2_PACKAGE_PULSEAUDIO bool "pulseaudio"
package/multimedia/mpd/Config.in +5 -0
@@ -41,6 +41,7 @@ config BR2_PACKAGE_MPD_AUDIOFILE config BR2_PACKAGE_MPD_PULSEAUDIO bool "pulseaudio" depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio + depends on BR2_LARGEFILE # pulseaudio -> libsndfile select BR2_PACKAGE_PULSEAUDIO help Enable pulseaudio output support.
@@ -105,10 +106,14 @@ config BR2_PACKAGE_MPD_LIBSAMPLERATE config BR2_PACKAGE_MPD_LIBSNDFILE bool "libsndfile" select BR2_PACKAGE_LIBSNDFILE + depends on BR2_LARGEFILE help Enable libsndfile input/streaming support. Select this if you want to play back WAV files. +comment "mpd-libsndfile requires a toolchain with LARGEFILE support" + depends on !BR2_LARGEFILE + config BR2_PACKAGE_MPD_MAD bool "mad" default y
package/multimedia/pulseaudio/Config.in +3 -2
@@ -7,6 +7,7 @@ config BR2_PACKAGE_PULSEAUDIO select BR2_PACKAGE_LIBSNDFILE select BR2_PACKAGE_SPEEX select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT + depends on BR2_LARGEFILE help PulseAudio is a sound system for POSIX OSes, meaning that it is a proxy for your sound applications. It allows you to do
@@ -18,5 +19,5 @@ config BR2_PACKAGE_PULSEAUDIO http://pulseaudio.org -comment "pulseaudio requires a toolchain with WCHAR and threads support" - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS +comment "pulseaudio requires a toolchain with WCHAR, LARGEFILE and threads support" + depends on !BR2_USE_WCHAR || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.7.9.5
PATCH 1/1 libsndfile: Add dependency on BR2_LARGEFILE
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Thomas> From: Ryan Mallon <[email protected]>
Thomas> libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a Thomas> typedef alias for off_t. This is not true by default for all Thomas> tool-chains, which leads to a runtime assert failure in binaries Thomas> compiled against libsndfile. See:
Thomas> http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229
Thomas> Add a dependency on BR2_LARGEFILE for libsndfile, and a comment if Thomas> BR2_LARGEFILE is not selected.
Thomas> [Thomas: rebased patch, added more propagation of the new Thomas> BR2_LARGEFILE dependency to gst-plugins-good and mpd.]
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard