Automatic testing with locking_type = 3.
PATCH 1/1 Automatic testing with locking_type = 3.
Hi,
this patch adds the option to run our automatic testsuite with a clvmd configured for single-machine operation. There are still couple things that need to be done for this patch before checkin though:
- rename fake to (probably) singlenode
- clean up and double-check the _resource_(un)lock implementation
Currently, we only keep the locks in memory. This is wholly appropriate as long as clvmd is running and being used -- since all locking goes through this clvmd instance, there's no need for external coordination.
As things are (with the current locking implementation) the full testsuite passes. You can try with yourself with
# LVM_TEST_LOCKING=3 make check
The next step, other than above, is to integrate this into make check, so make check will run all the tests twice, once with locking_type 1 and once with locking_type 3.
I will send a revised patch later.
Yours,
Petr.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clvmd-fake.diff
Type: text/x-diff
Size: 10627 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100310/21e45f80/attachment.bin>
PATCH 1/1 Automatic testing with locking_type = 3.
Hi,
Quoted 1 line
I will send a revised patch later.
A new patch that fixes the mentioned issues is attached. This one should be ready for checkin (modulo any bugs found in further review).
Yours,
Petr.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clvmd-singlenode.diff
Type: text/x-diff
Size: 11912 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100317/c8247ae1/attachment.bin>
PATCH 1/1 Automatic testing with locking_type = 3.
Quoted 2 lines · Peter Rockai
A new patch that fixes the mentioned issues is attached. This one should be ready for checkin (modulo any bugs found in further review).
Shouldn't affect existing code, so check it in now and do any further fixes in-tree.
Alasdair