Skip to contentSkip to conversation

fix dropbear install

PATCH New Marc Gauthier 2 participants 3 messages May 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix dropbear install

Fix dropbear install

The -D option to install only works portably when the destination is a file.
Specifying the filename avoids the following build error (at least on some hosts):
"/usr/bin/install: cannot overwrite directory `/tmp/buildroot/project_build_foobar/uclibc/root/etc/init.d' with non-directory"

package/dropbear/dropbear.mk +1 -1
index e84df87..63d3daa 100644
@@ -28,7 +28,7 @@ $(DROPBEAR_TARGET_INSTALL_TARGET):
        ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/scp
        ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/ssh
        if [ ! -f $(TARGET_DIR)/etc/init.d/S50dropbear ]; then \
-               $(INSTALL) -m 0755 -D package/dropbear/S50dropbear $(TARGET_DIR)/etc/init.d; \
+               $(INSTALL) -m 0755 -D package/dropbear/S50dropbear $(TARGET_DIR)/etc/init.d/S50dropbear; \
        fi
        touch $@
 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090527/8c61ca18/attachment.htm>

#1 lore raw

PATCH 1/1 fix dropbear install

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Marc" == Marc Gauthier <[email protected]> writes:

Marc> Fix dropbear install

Marc> The -D option to install only works portably when the Marc> destination is a file. Specifying the filename avoids the Marc> following build error (at least on some hosts):
Marc> "/usr/bin/install: cannot overwrite directory `/tmp/buildroot/ Marc> project_build_foobar/uclibc/root/etc/init.d' with Marc> non-directory"

On what OS / install version? Anyway, it cannot hurt, so committed.

Your patch is writespace mangles / line wrapped, please use git send-email instead next time.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 fix dropbear install

Quoted 4 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Marc" == Marc Gauthier <[email protected]> writes:

Marc> Fix dropbear install

Quoted 8 lines

Marc> The -D option to install only works portably when the Marc> destination is a file. Specifying the filename avoids the Marc> following build error (at least on some hosts):
Marc> "/usr/bin/install: cannot overwrite directory `/tmp/buildroot/ Marc> project_build_foobar/uclibc/root/etc/init.d' with Marc> non-directory"

On what OS / install version? Anyway, it cannot hurt, so committed.

Fedora Core 3. Has install (coreutils) 5.2.1.

Quoted 2 lines

Your patch is writespace mangles / line wrapped, please use git send-email instead next time.

I'll try that. (Was hoping sending as HTML avoided that, oh well.)

Thanks!
-Marc