mt9m111: mt9m111_get_global_gain() - unsigned <= 0 is always true
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · roel kluin
unsigned <= 0 is always true
Signed-off-by Roel Kluin <[email protected]>
You're right, your patch is good, but ... there is another mistake I made which should be also fixed.
The real formula is :
gain = (data & 0x2f) * (1 << ((data >> 10) & 1)) * (1 << ((data >> 9) & 1));
That is bits 9 and 10 give a 2x gain factor.
Would you please amend your patch to fix the formula please ?
--
Robert
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
A message that is not in the archive (sent off-list or not yet received): [email protected]
Robert Jarzmik
Acked-byQuoted 11 lines · roel kluin
Quoted 7 lines
You're right, your patch is good, but ... there is another mistake I made which should be also fixed.
The real formula is :
gain = (data &0x2f) * (1 << ((data >> 10) & 1)) * (1 << ((data >> 9) & 1));That is bits 9 and 10 give a 2x gain factor.
unsigned <= 0 is always true and fix formula
Signed-off-by Roel Kluin <[email protected]>
Cheers.
--
Robert
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list