Skip to contentSkip to conversation

simplify some condition checks

PATCH New Satoru Takeuchi 1 participant 2 messages Mar 24, 2006 – Mar 27, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 simplify some condition checks

Some condition checks on iosapic_check_gsi_range() can be omitted because always `base <= end' is assured. This patch simplifies that ckecks.

---
 arch/ia64/kernel/iosapic.c |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6.16/arch/ia64/kernel/iosapic.c
=================================--- linux-2.6.16.orig/arch/ia64/kernel/iosapic.c 2006-03-24 14:42:44.000000000 +0900
+++ linux-2.6.16/arch/ia64/kernel/iosapic.c 2006-03-24 14:42:55.000000000 +0900
@@ -994,10 +994,7 @@
base = iosapic_lists[index].gsi_base; end = base + iosapic_lists[index].num_rte - 1;

- if (gsi_base < base && gsi_end < base)
- continue;/* OK */
-
- if (gsi_base > end && gsi_end > end)
+ if (gsi_end < base || end < gsi_base)
continue; /* OK */

return -EBUSY;

#1 lore raw

PATCH 2/2 simplify some condition checks

Some condition checks on iosapic_check_gsi_range() can be omitted because always `base <= end' is assured. This patch simplifies that ckecks.

---
 arch/ia64/kernel/iosapic.c |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6.16/arch/ia64/kernel/iosapic.c
=================================--- linux-2.6.16.orig/arch/ia64/kernel/iosapic.c 2006-03-27 10:37:09.000000000 +0900
+++ linux-2.6.16/arch/ia64/kernel/iosapic.c 2006-03-27 15:13:08.000000000 +0900
@@ -1057,10 +1057,7 @@
base = iosapic_lists[index].gsi_base; end = base + iosapic_lists[index].num_rte - 1;

- if (gsi_base < base && gsi_end < base)
- continue;/* OK */
-
- if (gsi_base > end && gsi_end > end)
+ if (gsi_end < base || end < gsi_base)
continue; /* OK */

return -EBUSY;