Allow disabling all native fbdev drivers and only keeping DRM emulation
Subsystems (7)
v5 cover Allow disabling all native fbdev drivers and only keeping DRM emulation
This patch series splits the fbdev core support in two different Kconfig
symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still having the the core fbdev support needed for the CONFIG_DRM_FBDEV_EMULATION to be enabled. The motivation is automatically disabling all fbdev drivers instead of having to be disabled individually.
The reason for doing this is that now with simpledrm, there's no need for the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros now disable them. But it would simplify the config a lot fo have a single Kconfig symbol to disable all fbdev drivers.
I've built tested with possible combinations of CONFIG_FB, CONFIG_FB_CORE, CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE symbols set to 'y' or 'n'.
Patch #1 moves the auxdisplay drivers to "Graphics support" Kconfig menu, patch #2 moves the core fbdev Kconfig symbols to a separate Kconfig file, patch #3 does the FB symbol split and introduces the FB_CORE symbol and finally patch #4 makes the DRM symbol to select FB_CORE if the DRM fbdev emualtion support was enabled.
Since this series touches three subsystems (auxdisplay, fbdev and DRM), I would like to merge it through DRM with the acks of these maintainers.
This is a v5 of the patch-set that addresses issues pointed out by Arnd Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4:
https://lists.freedesktop.org/archives/dri-devel/2023-July/411842.html
Changes in v5:
- Take the auxdisplay/Kconfig source out of "if HAS_IOMEM" (Geert Uytterhoeven).
- Fix ifdef guard check in drivers/video/backlight/backlight.c (Arnd Bergmann).
Changes in v4:
- Fix menuconfig hierarchy that was broken in v3 (Arnd Bergmann).
Changes in v3:
- Really make a hidden symbol by removing the prompt (Arnd Bergmann).
- Change FB_CORE to config instead of menuconfig (Arnd Bergmann).
- Keep "depends on FB" for FIRMWARE_EDID (Arnd Bergmann).
- Compile out fb_backlight.o and fbmon.o that are only needed for FB (Arnd Bergmann).
- Make FB_DEVICE to depend on FB_CORE instead of selecting it.
- Make the DRM symbol to select FB_CORE if DRM_FBDEV_EMULATION is enabled (Arnd Bergmann).
- Also make DRM select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
- Make DRM_FBDEV_EMULATION to depend on DRM instead of DRM_KMS_HELPER.
Changes in v2:
- Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann).
- Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann).
Javier Martinez Canillas (4):
video: Add auxiliary display drivers to Graphics support menu
fbdev: Move core fbdev symbols to a separate Kconfig file
fbdev: Split frame buffer support in FB and FB_CORE symbols
drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled
arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/Kconfig | 2 - drivers/gpu/drm/Kconfig | 7 +- drivers/video/Kconfig | 2 + drivers/video/backlight/backlight.c | 6 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 213 ++-------------------------- drivers/video/fbdev/core/Kconfig | 206 +++++++++++++++++++++++++++ drivers/video/fbdev/core/Makefile | 8 +- 10 files changed, 232 insertions(+), 218 deletions(-) create mode 100644 drivers/video/fbdev/core/Kconfig
Signature · 1 line
2.41.0
PATCH v5 1/4 video: Add auxiliary display drivers to Graphics support menu
The drivers in this subsystem are for character-based LCD displays, which can fall into the same category of the DRM/KMS and fbdev drivers that are located under the "Graphics support" menu. Add auxdisplay there as well.
---
Changes in v5:
- Take the auxdisplay/Kconfig source out of "if HAS_IOMEM" (Geert Uytterhoeven).
drivers/Kconfig | 2 -- drivers/video/Kconfig | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/Kconfig +0 -2
@@ -129,8 +129,6 @@ source "drivers/dma-buf/Kconfig" source "drivers/dca/Kconfig" -source "drivers/auxdisplay/Kconfig" - source "drivers/uio/Kconfig" source "drivers/vfio/Kconfig"
drivers/video/Kconfig +2 -0
@@ -25,6 +25,8 @@ config VIDEO_NOMODESET bool default n +source "drivers/auxdisplay/Kconfig" + if HAS_IOMEM config HAVE_FB_ATMEL
Signature · 1 line
2.41.0
PATCH v5 2/4 fbdev: Move core fbdev symbols to a separate Kconfig file
In reply to Javier Martinez CanillasThe drivers/video/fbdev/Kconfig defines both symbols for fbdev drivers and core fbdev symbols, that can be enabled independently of the fbdev drivers.
Split the Kconfig in two, one that only has the symbols for fbdev drivers and another one that contains the fbdev core symbols.
---
(no changes since v1)
drivers/video/fbdev/Kconfig | 203 +------------------------------ drivers/video/fbdev/core/Kconfig | 202 ++++++++++++++++++++++++++++++ 2 files changed, 204 insertions(+), 201 deletions(-) create mode 100644 drivers/video/fbdev/core/Kconfig
drivers/video/fbdev/Kconfig +2 -201
@@ -3,9 +3,6 @@ # fbdev configuration # -config FB_NOTIFY - bool - menuconfig FB tristate "Support for frame buffer devices" select FB_NOTIFY
@@ -42,204 +39,6 @@ menuconfig FB (e.g. an accelerated X server) and that are not frame buffer device-aware may cause unexpected results. If unsure, say N. -config FIRMWARE_EDID - bool "Enable firmware EDID" - depends on FB - help - This enables access to the EDID transferred from the firmware. - On the i386, this is from the Video BIOS. Enable this if DDC/I2C - transfers do not work for your driver and if you are using - nvidiafb, i810fb or savagefb. - - In general, choosing Y for this option is safe. If you - experience extremely long delays while booting before you get - something on your display, try setting this to N. Matrox cards in - combination with certain motherboards and monitors are known to - suffer from this problem. - -config FB_DEVICE - bool "Provide legacy /dev/fb* device" - depends on FB - default y - help - Say Y here if you want the legacy /dev/fb* device file and - interfaces within sysfs anc procfs. It is only required if you - have userspace programs that depend on fbdev for graphics output. - This does not affect the framebuffer console. If unsure, say N. - -config FB_DDC - tristate - depends on FB - select I2C_ALGOBIT - select I2C - -config FB_CFB_FILLRECT - tristate - depends on FB - help - Include the cfb_fillrect function for generic software rectangle - filling. This is used by drivers that don't provide their own - (accelerated) version. - -config FB_CFB_COPYAREA - tristate - depends on FB - help - Include the cfb_copyarea function for generic software area copying. - This is used by drivers that don't provide their own (accelerated) - version. - -config FB_CFB_IMAGEBLIT - tristate - depends on FB - help - Include the cfb_imageblit function for generic software image - blitting. This is used by drivers that don't provide their own - (accelerated) version. - -config FB_CFB_REV_PIXELS_IN_BYTE - bool - depends on FB - help - Allow generic frame-buffer functions to work on displays with 1, 2 - and 4 bits per pixel depths which has opposite order of pixels in - byte order to bytes in long order. - -config FB_SYS_FILLRECT - tristate - depends on FB - help - Include the sys_fillrect function for generic software rectangle - filling. This is used by drivers that don't provide their own - (accelerated) version and the framebuffer is in system RAM. - -config FB_SYS_COPYAREA - tristate - depends on FB - help - Include the sys_copyarea function for generic software area copying. - This is used by drivers that don't provide their own (accelerated) - version and the framebuffer is in system RAM. - -config FB_SYS_IMAGEBLIT - tristate - depends on FB - help - Include the sys_imageblit function for generic software image - blitting. This is used by drivers that don't provide their own - (accelerated) version and the framebuffer is in system RAM. - -config FB_PROVIDE_GET_FB_UNMAPPED_AREA - bool - depends on FB - help - Allow generic frame-buffer to provide get_fb_unmapped_area - function to provide shareable character device support on nommu. - -menuconfig FB_FOREIGN_ENDIAN - bool "Framebuffer foreign endianness support" - depends on FB - help - This menu will let you enable support for the framebuffers with - non-native endianness (e.g. Little-Endian framebuffer on a - Big-Endian machine). Most probably you don't have such hardware, - so it's safe to say "n" here. - -choice - prompt "Choice endianness support" - depends on FB_FOREIGN_ENDIAN - -config FB_BOTH_ENDIAN - bool "Support for Big- and Little-Endian framebuffers" - -config FB_BIG_ENDIAN - bool "Support for Big-Endian framebuffers only" - -config FB_LITTLE_ENDIAN - bool "Support for Little-Endian framebuffers only" - -endchoice - -config FB_SYS_FOPS - tristate - depends on FB - -config FB_DEFERRED_IO - bool - depends on FB - -config FB_IO_HELPERS - bool - depends on FB - select FB_CFB_COPYAREA - select FB_CFB_FILLRECT - select FB_CFB_IMAGEBLIT - -config FB_SYS_HELPERS - bool - depends on FB - select FB_SYS_COPYAREA - select FB_SYS_FILLRECT - select FB_SYS_FOPS - select FB_SYS_IMAGEBLIT - -config FB_SYS_HELPERS_DEFERRED - bool - depends on FB - select FB_DEFERRED_IO - select FB_SYS_HELPERS - -config FB_HECUBA - tristate - depends on FB - select FB_SYS_HELPERS_DEFERRED - -config FB_SVGALIB - tristate - depends on FB - help - Common utility functions useful to fbdev drivers of VGA-based - cards. - -config FB_MACMODES - tristate - depends on FB - -config FB_BACKLIGHT - tristate - depends on FB - select BACKLIGHT_CLASS_DEVICE - -config FB_MODE_HELPERS - bool "Enable Video Mode Handling Helpers" - depends on FB - help - This enables functions for handling video modes using the - Generalized Timing Formula and the EDID parser. A few drivers rely - on this feature such as the radeonfb, rivafb, and the i810fb. If - your driver does not take advantage of this feature, choosing Y will - just increase the kernel size by about 5K. - -config FB_TILEBLITTING - bool "Enable Tile Blitting Support" - depends on FB - help - This enables tile blitting. Tile blitting is a drawing technique - where the screen is divided into rectangular sections (tiles), whereas - the standard blitting divides the screen into pixels. Because the - default drawing element is a tile, drawing functions will be passed - parameters in terms of number of tiles instead of number of pixels. - For example, to draw a single character, instead of using bitmaps, - an index to an array of bitmaps will be used. To clear or move a - rectangular section of a screen, the rectangle will be described in - terms of number of tiles in the x- and y-axis. - - This is particularly important to one driver, matroxfb. If - unsure, say N. - -comment "Frame buffer hardware drivers" - depends on FB - config FB_GRVGA tristate "Aeroflex Gaisler framebuffer support" depends on FB && SPARC
@@ -2223,3 +2022,5 @@ config FB_SM712 source "drivers/video/fbdev/omap/Kconfig" source "drivers/video/fbdev/omap2/Kconfig" source "drivers/video/fbdev/mmp/Kconfig" + +source "drivers/video/fbdev/core/Kconfig"
drivers/video/fbdev/core/Kconfig new file +202 -0
202 lines not on this page · raw message
Signature · 1 line
2.41.0
Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file
Quoted 9 lines · Javier Martinez Canillas
The
drivers/video/fbdev/Kconfigdefines both symbols for fbdev drivers and core fbdev symbols, that can be enabled independently of the fbdev drivers.Split the
Kconfigin two, one that only has the symbols for fbdev drivers and another one that contains the fbdev core symbols.Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>---
While testing this patch series, I noticed a conflict against Thomas Zimmermann's series for FB_SYS_HELPERS_DEFERRED, so you'll have to adapt the patches in order to apply them on top.
Quoted 7 lines
drivers/video/fbdev/core/Kconfig new file +7
-0+ +config FB_HECUBA + tristate + depends on FB + depends on FB_DEFERRED_IO + +config FB_SVGALIB
drivers/video/fbdev/core/Kconfig line 171
Quoted 10 lines
drivers/video/fbdev/core/Kconfig new file +10
-0+ tristate + depends on FB + help + Common utility functions useful to fbdev drivers of VGA-based + cards. + +config FB_MACMODES + tristate + depends on FB +
The FB_HECUBA now needs 'FB_SYS_HELPERS_DEFERRED' instead of 'FB_DEFERRED_IO', which is the change done in the other patch. I think the best way of doing that would be to just not move the three symbols above to core/Kconfig but leave them in place, as they are all just helper modules for some other drivers, rather than core code.
Arnd
Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file
Quoted 7 lines · Arnd Bergmann
Quoted 6 lines · Javier Martinez Canillas
The
drivers/video/fbdev/Kconfigdefines both symbols for fbdev drivers and core fbdev symbols, that can be enabled independently of the fbdev drivers.Split the
Kconfigin two, one that only has the symbols for fbdev drivers and another one that contains the fbdev core symbols.
Quoted 8 lines
Quoted 3 lines
Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>---
While testing this patch series, I noticed a conflict against Thomas Zimmermann's series for
FB_SYS_HELPERS_DEFERRED, so you'll have to adapt the patches in order to apply them on top.
Indeed. That was my bad when doing the conflict resolution on rebase.
Quoted 16 lines
Quoted 16 lines
drivers/video/fbdev/core/Kconfig new file +16
-0+ +config FB_HECUBA + tristate + depends on FB + depends on FB_DEFERRED_IO + +config FB_SVGALIB + tristate + depends on FB + help + Common utility functions useful to fbdev drivers of VGA-based + cards. + +config FB_MACMODES + tristate + depends on FB
Quoted 9 lines
Quoted 1 line
+
The
FB_HECUBAnow needs 'FB_SYS_HELPERS_DEFERRED' instead of 'FB_DEFERRED_IO', which is the change done in the other patch. I think the best way of doing that would be to just not move the three symbols above to core/Kconfig but leave them in place, as they are all just helper modules for some other drivers, rather than core code.
Agreed. I'll change that in v6 as well.
Quoted 2 lines
Arnd
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
PATCH v5 3/4 fbdev: Split frame buffer support in FB and FB_CORE symbols
In reply to Javier Martinez CanillasCurrently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).
The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well.
That means fbdev drivers have to be explicitly disabled if users want to enable CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.
This patch introduces a non-visible CONFIG_FB_CORE symbol that could be enabled just to have core support needed for CONFIG_DRM_FBDEV_EMULATION, allowing CONFIG_FB to be disabled (and automatically disabling all the fbdev drivers).
Nothing from fb_backlight.o and fbmon.o is used by the DRM fbdev emulation layer so these two objects can be compiled out when CONFIG_FB is disabled.
---
Changes in v5:
- Fix ifdef guard check in drivers/video/backlight/backlight.c (Arnd Bergmann).
Changes in v4:
- Fix menuconfig hierarchy that was broken in v3 (Arnd Bergmann).
Changes in v3:
- Really make a hidden symbol by removing the prompt (Arnd Bergmann).
- Change FB_CORE to config instead of menuconfig (Arnd Bergmann).
- Keep "depends on FB" for FIRMWARE_EDID (Arnd Bergmann).
- Compile out fb_backlight.o and fbmon.o that are only needed for FB (Arnd Bergmann).
- Make FB_DEVICE to depend on FB_CORE instead of selecting it.
Changes in v2:
- Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann).
- Don't change the fb.o object name (Arnd Bergmann).
- Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann).
arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/backlight/backlight.c | 6 +++--- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 10 ++++++++-- drivers/video/fbdev/core/Kconfig | 30 ++++++++++++++++------------- drivers/video/fbdev/core/Makefile | 8 ++++---- 7 files changed, 35 insertions(+), 25 deletions(-)
arch/x86/Makefile +1 -1
@@ -259,7 +259,7 @@ drivers-$(CONFIG_PCI) += arch/x86/pci/ # suspend and hibernation support drivers-$(CONFIG_PM) += arch/x86/power/ -drivers-$(CONFIG_FB) += arch/x86/video/ +drivers-$(CONFIG_FB_CORE) += arch/x86/video/ #### # boot loader support. Several targets are kept for legacy purposes
arch/x86/video/Makefile +1 -1
@@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) += fbdev.o +obj-$(CONFIG_FB_CORE) += fbdev.o
drivers/video/backlight/backlight.c +3 -3
@@ -79,8 +79,8 @@ static const char *const backlight_scale_types[] = { [BACKLIGHT_SCALE_NON_LINEAR] = "non-linear", }; -#if defined(CONFIG_FB ) || (defined(CONFIG_FB_MODULE ) && \ - defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE )) +#if defined(CONFIG_FB_CORE ) || (defined(CONFIG_FB_CORE_MODULE ) && \ + defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE ))/* * fb_notifier_callback *
@@ -155,7 +155,7 @@ static inline int backlight_register_fb(struct backlight_device *bd)static inline void backlight_unregister_fb (struct backlight_device *bd) { } -#endif /* CONFIG_FB */ +#endif /* CONFIG_FB_CORE */ static void backlight_generate_event (struct backlight_device *bd,enum backlight_update_reason reason)
drivers/video/console/Kconfig +1 -1
@@ -72,7 +72,7 @@ config DUMMY_CONSOLE_ROWS config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" - depends on FB && !UML + depends on FB_CORE && !UML select VT_HW_CONSOLE_BINDING select CRC32 select FONT_SUPPORT
drivers/video/fbdev/Kconfig +8 -2
@@ -4,9 +4,9 @@ # menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers" + select FB_CORE select FB_NOTIFY - select VIDEO_CMDLINE help The frame buffer device provides an abstraction for the graphics hardware. It represents the frame buffer of some video hardware and
@@ -30,6 +30,12 @@ menuconfig FB <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more information. + This enables support for native frame buffer device (fbdev) drivers. + + The DRM subsystem provides support for emulated frame buffer devices + on top of KMS drivers, but this option allows legacy fbdev drivers to + be enabled as well. + Say Y here and to the driver for your graphics board below if you are compiling a kernel for a non-x86 architecture.
drivers/video/fbdev/core/Kconfig +17 -13
@@ -3,6 +3,10 @@ # fbdev core configuration # +config FB_CORE + select VIDEO_CMDLINE + tristate + config FB_NOTIFY bool
@@ -23,7 +27,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + depends on FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file and
@@ -39,7 +43,7 @@ config FB_DDC config FB_CFB_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the cfb_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own
@@ -47,7 +51,7 @@ config FB_CFB_FILLRECT config FB_CFB_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the cfb_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)
@@ -55,7 +59,7 @@ config FB_CFB_COPYAREA config FB_CFB_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the cfb_imageblit function for generic software image blitting. This is used by drivers that don't provide their own
@@ -63,7 +67,7 @@ config FB_CFB_IMAGEBLIT config FB_CFB_REV_PIXELS_IN_BYTE bool - depends on FB + depends on FB_CORE help Allow generic frame-buffer functions to work on displays with 1, 2 and 4 bits per pixel depths which has opposite order of pixels in
@@ -71,7 +75,7 @@ config FB_CFB_REV_PIXELS_IN_BYTE config FB_SYS_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the sys_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own
@@ -79,7 +83,7 @@ config FB_SYS_FILLRECT config FB_SYS_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the sys_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated)
@@ -87,7 +91,7 @@ config FB_SYS_COPYAREA config FB_SYS_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the sys_imageblit function for generic software image blitting. This is used by drivers that don't provide their own
@@ -126,22 +130,22 @@ endchoice config FB_SYS_FOPS tristate - depends on FB + depends on FB_CORE config FB_DEFERRED_IO bool - depends on FB + depends on FB_CORE config FB_IO_HELPERS bool - depends on FB + depends on FB_CORE select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT config FB_SYS_HELPERS bool - depends on FB + depends on FB_CORE select FB_SYS_COPYAREA select FB_SYS_FILLRECT select FB_SYS_FOPS
@@ -149,7 +153,7 @@ config FB_SYS_HELPERS config FB_SYS_HELPERS_DEFERRED bool - depends on FB + depends on FB_CORE select FB_DEFERRED_IO select FB_SYS_HELPERS
drivers/video/fbdev/core/Makefile +4 -4
@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o -fb-y := fb_backlight.o \ - fb_info.o \ - fbmem.o fbmon.o fbcmap.o \ +obj-$(CONFIG_FB_CORE) += fb.o +fb-y := fb_info.o \ + fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o fb_io_fops.o +fb-$(CONFIG_FB) += fb_backlight.o fbmon.o fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o fb-$(CONFIG_FB_DEVICE) += fb_chrdev.o \ fb_procfs.o \
Signature · 1 line
2.41.0
Re: [PATCH v5 3/4] fbdev: Split frame buffer support in FB and FB_CORE symbols
Quoted 9 lines · Javier Martinez Canillas
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.
Quoted 7 lines
This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).Nothing from fb_backlight.o and fbmon.o is used by the DRM fbdev emulation layer so these two objects can be compiled out when
CONFIG_FBis disabled.
I gave this a spin in my randconfig build setup and found one small mistake:
Quoted 16 lines
drivers/video/fbdev/core/Makefile +3
-4@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o -fb-y := fb_backlight.o \ - fb_info.o \ - fbmem.o fbmon.o fbcmap.o \ +obj-$(CONFIG_FB_CORE) += fb.o +fb-y := fb_info.o \ + fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o
Quoted 2 lines
fb_io_fops.o
+fb-$(CONFIG_FB) += fb_backlight.o fbmon.o
With CONFIG_FB_CORE=y and CONFIG_FB=m, Kbuild does not include the fb_backlight.o and fbmon.o files in fb.ko because they are not set to =y, causing link failures for fbdev drivers later:
ERROR: modpost: "of_get_fb_videomode" [drivers/video/fbdev/clps711x-fb.ko] undefined!
ERROR: modpost: "fb_videomode_from_videomode" [drivers/video/fbdev/atmel_lcdfb.ko] undefined!
ERROR: modpost: "of_get_fb_videomode" [drivers/video/fbdev/imxfb.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/udlfb.ko] undefined!
ERROR: modpost: "fb_edid_to_monspecs" [drivers/video/fbdev/udlfb.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/smscufx.ko] undefined!
ERROR: modpost: "fb_edid_to_monspecs" [drivers/video/fbdev/smscufx.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/uvesafb.ko] undefined!
ERROR: modpost: "fb_validate_mode" [drivers/video/fbdev/uvesafb.ko] undefined!
ERROR: modpost: "fb_get_mode" [drivers/video/fbdev/uvesafb.ko] undefined!
Folding this fixup into the patch makes it work:
drivers/video/fbdev/core/Makefile +3 -1
@@ -4,7 +4,9 @@ obj-$(CONFIG_FB_CORE) += fb.o fb-y := fb_info.o \ fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o fb_io_fops.o -fb-$(CONFIG_FB) += fb_backlight.o fbmon.o +ifdef CONFIG_FB +fb-y += fb_backlight.o fbmon.o +endif fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o fb-$(CONFIG_FB_DEVICE) += fb_chrdev.o \ fb_procfs.o \
Arnd
Re: [PATCH v5 3/4] fbdev: Split frame buffer support in FB and FB_CORE symbols
Quoted 15 lines · Arnd Bergmann
Quoted 14 lines · Javier Martinez Canillas
Currently the
CONFIG_FBoption has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles).The DRM subsystem has a fbdev emulation layer, but depends on
CONFIG_FBand so it can only be enabled if that dependency is enabled as well.That means fbdev drivers have to be explicitly disabled if users want to enable
CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer.This patch introduces a non-visible
CONFIG_FB_COREsymbol that could be enabled just to have core support needed forCONFIG_DRM_FBDEV_EMULATION, allowingCONFIG_FBto be disabled (and automatically disabling all the fbdev drivers).
Quoted 6 lines
Quoted 2 lines
Nothing from fb_backlight.o and fbmon.o is used by the DRM fbdev emulation layer so these two objects can be compiled out when
CONFIG_FBis disabled.I gave this a spin in my randconfig build setup and found one small mistake:
Thanks for testing!
Quoted 23 lines
Quoted 16 lines
drivers/video/fbdev/core/Makefile +3
-4@@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o -fb-y := fb_backlight.o \ - fb_info.o \ - fbmem.o fbmon.o fbcmap.o \ +obj-$(CONFIG_FB_CORE) += fb.o +fb-y := fb_info.o \ + fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.oQuoted 2 lines
fb_io_fops.o
+fb-$(CONFIG_FB) += fb_backlight.o fbmon.oWith
CONFIG_FB_CORE=yandCONFIG_FB=m,Kbuilddoes not include the fb_backlight.o and fbmon.o files in fb.ko because they are not set to =y, causing link failures for fbdev drivers later:
Quoted 11 lines
ERROR: modpost: "
of_get_fb_videomode" [drivers/video/fbdev/clps711x-fb.ko] undefined!
ERROR: modpost: "fb_videomode_from_videomode" [drivers/video/fbdev/atmel_lcdfb.ko] undefined!
ERROR: modpost: "of_get_fb_videomode" [drivers/video/fbdev/imxfb.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/udlfb.ko] undefined!
ERROR: modpost: "fb_edid_to_monspecs" [drivers/video/fbdev/udlfb.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/smscufx.ko] undefined!
ERROR: modpost: "fb_edid_to_monspecs" [drivers/video/fbdev/smscufx.ko] undefined!
ERROR: modpost: "fb_destroy_modedb" [drivers/video/fbdev/uvesafb.ko] undefined!
ERROR: modpost: "fb_validate_mode" [drivers/video/fbdev/uvesafb.ko] undefined!
ERROR: modpost: "fb_get_mode" [drivers/video/fbdev/uvesafb.ko] undefined!
Right, sorry for missing that combination.
Quoted 9 lines
Folding this fixup into the patch makes it work:
drivers/video/fbdev/core/Makefile +0
-0
drivers/video/fbdev/core/Makefile obj-$(CONFIG_FB_CORE) += fb.o · line 12
Quoted 10 lines
drivers/video/fbdev/core/Makefile +3
-1@@ -4,7 +4,9 @@ obj-$(CONFIG_FB_CORE) += fb.o fb-y := fb_info.o \ fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o fb_io_fops.o -fb-$(CONFIG_FB) += fb_backlight.o fbmon.o +ifdef CONFIG_FB +fb-y += fb_backlight.o fbmon.o +endif fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o fb-$(CONFIG_FB_DEVICE) += fb_chrdev.o \ fb_procfs.o \
Perfect, I'll squash your fix in v6. Thanks!
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
PATCH v5 4/4 drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled
In reply to Javier Martinez CanillasNow that fbdev core has been split in FB_CORE and FB, make the DRM symbol to select the FB_CORE option if the DRM fbdev emulation layer is enabled.
This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers.
---
(no changes since v3)
Changes in v3:
- Make the DRM symbol to select FB_CORE if DRM_FBDEV_EMULATION is enabled (Arnd Bergmann).
- Also make DRM select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
- Make DRM_FBDEV_EMULATION to depend on DRM instead of DRM_KMS_HELPER.
Changes in v2:
- Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann).
drivers/gpu/drm/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/Kconfig +4 -3
@@ -9,6 +9,9 @@ menuconfig DRM tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA select DRM_PANEL_ORIENTATION_QUIRKS + select DRM_KMS_HELPER if DRM_FBDEV_EMULATION + select FB_CORE if DRM_FBDEV_EMULATION + select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION select HDMI select I2C select DMA_SHARED_BUFFER
@@ -96,7 +99,6 @@ config DRM_KUNIT_TEST config DRM_KMS_HELPER tristate depends on DRM - select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION help CRTC helpers for KMS drivers.
@@ -132,8 +134,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" - depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + depends on DRM select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y
Signature · 1 line
2.41.0
Quoted 20 lines · Javier Martinez Canillas
This patch series splits the fbdev core support in two different
Kconfig
symbols: FB andFB_CORE. The motivation for this is to allowCONFIG_FBto be disabled, while still having the the core fbdev support needed for theCONFIG_DRM_FBDEV_EMULATIONto be enabled. The motivation is automatically disabling all fbdev drivers instead of having to be disabled individually.The reason for doing this is that now with simpledrm, there's no need for the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros now disable them. But it would simplify the config a lot fo have a single
Kconfigsymbol to disable all fbdev drivers.I've built tested with possible combinations of
CONFIG_FB,CONFIG_FB_CORE,CONFIG_DRM_FBDEV_EMULATIONandCONFIG_FB_DEVICEsymbols set to 'y' or 'n'.Patch #1 moves the auxdisplay drivers to "Graphics support"
Kconfigmenu, patch #2 moves the core fbdevKconfigsymbols to a separateKconfigfile, patch #3 does the FB symbol split and introduces theFB_COREsymbol and finally patch #4 makes the DRM symbol to selectFB_COREif the DRM fbdev emualtion support was enabled.
Quoted 7 lines
Since this series touches three subsystems (auxdisplay, fbdev and DRM), I would like to merge it through DRM with the acks of these maintainers.
This is a v5 of the patch-set that addresses issues pointed out by Arnd Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4:
https://lists.freedesktop.org/archives/dri-devel/2023-July/411842.html
Looks all good to me, except for two minor things I found in build testing and replied to separately. With those fixed:
Quoted 27 lines · Arnd Bergmann
Quoted 26 lines · Javier Martinez Canillas
This patch series splits the fbdev core support in two different
Kconfig
symbols: FB andFB_CORE. The motivation for this is to allowCONFIG_FBto be disabled, while still having the the core fbdev support needed for theCONFIG_DRM_FBDEV_EMULATIONto be enabled. The motivation is automatically disabling all fbdev drivers instead of having to be disabled individually.The reason for doing this is that now with simpledrm, there's no need for the legacy fbdev (e.g: efifb or vesafb) drivers anymore and many distros now disable them. But it would simplify the config a lot fo have a single
Kconfigsymbol to disable all fbdev drivers.I've built tested with possible combinations of
CONFIG_FB,CONFIG_FB_CORE,CONFIG_DRM_FBDEV_EMULATIONandCONFIG_FB_DEVICEsymbols set to 'y' or 'n'.Patch #1 moves the auxdisplay drivers to "Graphics support"
Kconfigmenu, patch #2 moves the core fbdevKconfigsymbols to a separateKconfigfile, patch #3 does the FB symbol split and introduces theFB_COREsymbol and finally patch #4 makes the DRM symbol to selectFB_COREif the DRM fbdev emualtion support was enabled.Since this series touches three subsystems (auxdisplay, fbdev and DRM), I would like to merge it through DRM with the acks of these maintainers.
This is a v5 of the patch-set that addresses issues pointed out by Arnd Bergmann, Thomas Zimmermann and Geert Uytterhoeven in the previous v4:
Quoted 8 lines
Looks all good to me, except for two minor things I found in build testing and replied to separately. With those fixed:
Reviewed-by Arnd Bergmann <[email protected]>Tested-by Arnd Bergmann <[email protected]>
Awesome, thanks a lot for your help!
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat