Skip to contentSkip to conversation

MAINTAINERS: treat Documentation/maintainer as process docs

PATCH In review Jakub Kicinski 3 participants 3 messages Jul 13, 2023 – Jul 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MAINTAINERS: treat Documentation/maintainer as process docs

A handful of people got caught out by the recent changes in git which changed the format of Message-ID and broke our recommended applyhook for adding lore links.

This was fixed in the docs by commit 2bb19e740e9b ("Documentation:
update git configuration for Link: tag") but it seems like few people have noticed. Add maintainer directory to the process entry so that workflows@ gets CCed.

---
v2:
- fix order of entries
v1: https://lore.kernel.org/all/[email protected]/

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 3be1bdfe8ecc..fff7e50948b6 100644
@@ -6206,6 +6206,7 @@ DOCUMENTATION PROCESS
 M:	Jonathan Corbet <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/maintainer/
 F:	Documentation/process/
 
 DOCUMENTATION REPORTING ISSUES
Signature · 1 line
2.41.0
reviewer Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 10 lines · Jakub Kicinski

A handful of people got caught out by the recent changes in git which changed the format of Message-ID and broke our recommended applyhook for adding lore links.

This was fixed in the docs by commit 2bb19e740e9b ("Documentation:
update git configuration for Link: tag") but it seems like few people have noticed. Add maintainer directory to the process entry so that workflows@ gets CCed.

Thanks.

Not your problem, but I find "DOCUMENTATION PROCESS" confusing. It's not about the documentation process. IMO it needs a colon at least:
DOCUMENTATION: PROCESS
or
DOCUMENTATION: DEVELOPMENT PROCESS

Quoted 20 lines

---
v2:
- fix order of entries
v1: https://lore.kernel.org/all/[email protected]/

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 3be1bdfe8ecc..fff7e50948b6 100644
@@ -6206,6 +6206,7 @@ DOCUMENTATION PROCESS
 M:	Jonathan Corbet <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/maintainer/
 F:	Documentation/process/
 
 DOCUMENTATION REPORTING ISSUES
Signature · 1 line
~Randy
maintainer
#2 lore raw
In reply to Jakub Kicinski
Quoted 23 lines · Jakub Kicinski

A handful of people got caught out by the recent changes in git which changed the format of Message-ID and broke our recommended applyhook for adding lore links.

This was fixed in the docs by commit 2bb19e740e9b ("Documentation:
update git configuration for Link: tag") but it seems like few people have noticed. Add maintainer directory to the process entry so that workflows@ gets CCed.

---
v2:
- fix order of entries
v1: https://lore.kernel.org/all/[email protected]/

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 3be1bdfe8ecc..fff7e50948b6 100644

MAINTAINERS DOCUMENTATION PROCESS · line 6210

Quoted 5 lines
MAINTAINERS +1 -0
@@ -6206,6 +6206,7 @@ DOCUMENTATION PROCESS
 M:	Jonathan Corbet <[email protected]>
 L:	[email protected]
 S:	Maintained
+F:	Documentation/maintainer/
 F:	Documentation/process/

So what this may really be telling us is that we should move the maintainer directory under Documentation/process/. But applying this patch is easier, so that's what I've done for now :)

Thanks,

jon