Skip to contentSkip to conversation

wireless/ath/ath9k: remove redundant status variable

PATCH In review [email protected] 2 participants 3 messages Jan 12, 2022 – Jan 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wireless/ath/ath9k: remove redundant status variable

From: Minghao Chi <[email protected]>

Return value directly instead of taking this in another redundant variable.

---
 drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/net/wireless/ath/ath9k/eeprom.c +1 -5
index e6b3cd49ea18..efb7889142d4 100644
@@ -670,8 +670,6 @@ void ath9k_hw_get_gain_boundaries_pdadcs(struct ath_hw *ah,
 
 int ath9k_hw_eeprom_init(struct ath_hw *ah)
 {
-	int status;
-
 	if (AR_SREV_9300_20_OR_LATER(ah))
 		ah->eep_ops = &eep_ar9300_ops;
 	else if (AR_SREV_9287(ah)) {
@@ -685,7 +683,5 @@ int ath9k_hw_eeprom_init(struct ath_hw *ah)
 	if (!ah->eep_ops->fill_eeprom(ah))
 		return -EIO;
 
-	status = ah->eep_ops->check_eeprom(ah);
-
-	return status;
+	return ah->eep_ops->check_eeprom(ah);
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 11 lines · [email protected] writes:

From: Minghao Chi <[email protected]>

Return value directly instead of taking this in another redundant variable.

---
 drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

The subject prefix should be "ath9k:", I can fix that.

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to [email protected]
Quoted 7 lines · [email protected] wrote:

Return value directly instead of taking this in another redundant variable.

Patch applied to ath-next branch of ath.git, thanks.

76d7b996aab8 ath9k: remove redundant status variable

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches