package/libkrb5: add openssl optional dependency
PATCH v2 1/2 package/libkrb5: add openssl optional dependency
openssl is an optional dependency which is enabled by default since at least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
---
Changes v1 -> v2 (after review of Yann E. Morin):
- Add openssl optional dependency
package/libkrb5/libkrb5.mk | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
package/libkrb5/libkrb5.mk +15 -0
@@ -41,6 +41,21 @@ else LIBKRB5_CONF_OPTS += --without-ldap endif +ifeq ($(BR2_PACKAGE_OPENSSL),y) +LIBKRB5_CONF_OPTS += \ + --enable-pkinit \ + --with-crypto-impl=openssl \ + --with-spake-openssl \ + --with-tls-impl=openssl +LIBKRB5_DEPENDENCIES += openssl +else +LIBKRB5_CONF_OPTS += \ + --disable-pkinit \ + --with-crypto-impl=builtin \ + --without-spake-openssl \ + --without-tls-impl +endif + ifeq ($(BR2_PACKAGE_LIBEDIT),y) LIBKRB5_CONF_OPTS += --with-libedit LIBKRB5_DEPENDENCIES += host-pkgconf libedit
Signature · 1 line
2.30.2
PATCH v2 2/2 package/libkrb5: requires DES, MD4 and RC4 support in openssl
Enable DES, MD4 and RC4 in openssl to fix build failure raised since commit a83d41867c8d69a77d5cd0a665aa216af5340359
Fixes:
- http://autobuild.buildroot.org/results/d73b477bd2064aee076f9debfd8d3346c63ba657
--- package/libkrb5/Config.in | 3 +++ 1 file changed, 3 insertions(+)
package/libkrb5/Config.in +3 -0
@@ -3,6 +3,9 @@ config BR2_PACKAGE_LIBKRB5 # needs fork() depends on BR2_USE_MMU depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_LIBOPENSSL_ENABLE_DES if BR2_PACKAGE_LIBOPENSSL + select BR2_PACKAGE_LIBOPENSSL_ENABLE_MD4 if BR2_PACKAGE_LIBOPENSSL + select BR2_PACKAGE_LIBOPENSSL_ENABLE_RC4 if BR2_PACKAGE_LIBOPENSSL help Kerberos is a system for authenticating users and services on a network. Kerberos is a trusted third-party service.
Signature · 1 line
2.30.2
Yann E. MORIN
AppliedPATCH v2 1/2 package/libkrb5: add openssl optional dependency
In reply to Fabrice FontaineFabrice, All,
On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
Quoted 5 lines
openssl is an optional dependency which is enabled by default since at least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65dSigned-off-by Fabrice Fontaine <[email protected]>
Applied to master, thanks.
I squashed the two commits together, because selecting the openssl options is really just part of fixing the openssl dependency of libkrb5.
Thank you! :-)
Regards,
Yann E. MORIN.
Quoted 40 lines
---
Changes v1 -> v2 (after review of Yann E. Morin):
- Add openssl optional dependencypackage/libkrb5/libkrb5.mk | 15 +++++++++++++++ 1 file changed, 15 insertions(+)package/libkrb5/libkrb5.mk +15
-0@@ -41,6 +41,21 @@ else LIBKRB5_CONF_OPTS += --without-ldap endif +ifeq ($(BR2_PACKAGE_OPENSSL),y) +LIBKRB5_CONF_OPTS += \ + --enable-pkinit \ + --with-crypto-impl=openssl \ + --with-spake-openssl \ + --with-tls-impl=openssl +LIBKRB5_DEPENDENCIES += openssl +else +LIBKRB5_CONF_OPTS += \ + --disable-pkinit \ + --with-crypto-impl=builtin \ + --without-spake-openssl \ + --without-tls-impl +endif + ifeq ($(BR2_PACKAGE_LIBEDIT),y) LIBKRB5_CONF_OPTS += --with-libedit LIBKRB5_DEPENDENCIES += host-pkgconf libeditSignature · 6 lines
2.30.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/2 package/libkrb5: add openssl optional dependency
Hi Yann,
Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <[email protected]> a ?crit :
Quoted 8 lines
Fabrice, All,
On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
Quoted 4 lines
openssl is an optional dependency which is enabled by default since at least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
Quoted 6 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>Applied to master, thanks.
I squashed the two commits together, because selecting the openssl options is really just part of fixing the openssl dependency of libkrb5.
Perhaps, it would have been better to keep them separate as Peter will probably only want to backport the first patch to 2020.xx and 2021.xx branches?
Quoted 49 lines
Thank you! :-)
Regards,
Yann E. MORIN.Quoted 36 lines
---
Changes v1 -> v2 (after review of Yann E. Morin):
- Add openssl optional dependencypackage/libkrb5/libkrb5.mk | 15 +++++++++++++++ 1 file changed, 15 insertions(+)package/libkrb5/libkrb5.mk +15
-1@@ -41,6 +41,21 @@ else LIBKRB5_CONF_OPTS += --without-ldap endif +ifeq ($(BR2_PACKAGE_OPENSSL),y) +LIBKRB5_CONF_OPTS += \ + --enable-pkinit \ + --with-crypto-impl=openssl \ + --with-spake-openssl \ + --with-tls-impl=openssl +LIBKRB5_DEPENDENCIES += openssl +else +LIBKRB5_CONF_OPTS += \ + --disable-pkinit \ + --with-crypto-impl=builtin \ + --without-spake-openssl \ + --without-tls-impl +endif + ifeq ($(BR2_PACKAGE_LIBEDIT),y) LIBKRB5_CONF_OPTS += --with-libedit LIBKRB5_DEPENDENCIES += host-pkgconf libedit --2.30.2
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.
Quoted 5 lines
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
Best Regards,
Fabrice
PATCH v2 1/2 package/libkrb5: add openssl optional dependency
Fabrice, All,
On 2021-06-13 18:41 +0200, Fabrice Fontaine spake thusly:
Quoted 6 lines
Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <[email protected]> a ?crit :
Quoted 5 lines
On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
Quoted 4 lines
openssl is an optional dependency which is enabled by default since at least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65d
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>I squashed the two commits together, because selecting the openssl options is really just part of fixing the openssl dependency of libkrb5.
Perhaps, it would have been better to keep them separate as Peter will probably only want to backport the first patch to 2020.xx and 2021.xx branches?
That's true.
However, semantically, I still believe the two patches should really have been one, because if we don't select the options when we explicitly add the openssl depenency, then we are still introducing a failure.
And I don't think that it is unreasonable to expect that some commits have to be adapted when backported.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/2 package/libkrb5: add openssl optional dependency
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Fabrice, All,
On 2021-06-13 18:41 +0200, Fabrice Fontaine spake thusly:Quoted 6 lines
Le dim. 13 juin 2021 ? 18:08, Yann E. MORIN <[email protected]> a ?crit :
Quoted 5 lines
On 2021-06-13 11:10 +0200, Fabrice Fontaine spake thusly:
Quoted 4 lines
openssl is an optional dependency which is enabled by default since at least 2007 and
https://github.com/krb5/krb5/commit/4c17f25c0f106ec8e3aad2cee4e7a24f66b5a65dQuoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>I squashed the two commits together, because selecting the openssl options is really just part of fixing the openssl dependency of libkrb5.
Perhaps, it would have been better to keep them separate as Peter will probably only want to backport the first patch to 2020.xx and 2021.xx branches?
Quoted 8 lines
That's true.
However, semantically, I still believe the two patches should really have been one, because if we don't select the options when we explicitly add the openssl depenency, then we are still introducing a failure.
And I don't think that it is unreasonable to expect that some commits have to be adapted when backported.
Indeed. Committed to 2021.02.x and 2021.05.x, after dropping the openssl options - thanks.
Signature · 1 line
Bye, Peter Korsgaard