Skip to contentSkip to conversation

Makefile: work around a bug in newly released make 4.3

PATCH New Yann E. MORIN 3 participants 4 messages Mar 4, 2020 – Mar 15, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Makefile: work around a bug in newly released make 4.3

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and onclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix for a previous ill-defined behaviour, or an actual regression...

In the meantime, we add a workaround, suggested in that same bug report, that fixes the issue for make 4.3, and that should not break on older make versions either (verified on all relevant versions: from 3.81, 3.82, 4.0, 4.1, and 4.2).

[0] https://savannah.gnu.org/bugs/?57676

Cc Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
- [0] points to something now (Thomas)
- repeat the bug URL in the Makefile (Thomas)
- explain where the workaround comes from (Thomas)

---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)
Makefile +3 -0
index 31624f77a2..09e769f613 100644
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
 $(error $(BR2_EXTERNAL_ERROR))
 endif
 
+# Workaround bug in make-4.3: https://savannah.gnu.org/bugs/?57676
+$(BASE_DIR)/.br2-external.mk:;
+
 # To make sure that the environment variable overrides the .config option,
 # set this before including .config.
 ifneq ($(BR2_DL_DIR),)
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 Makefile: work around a bug in newly released make 4.3

Hi,

I've tested the patch against master and using a br2-external tree and it works.

I've also tested it against buildroot-2019.02.9, but there it needs to be adjusted accordingly:

$(BASE_DIR)/.br-external.mk:;

BR
Mircea

Quoted 13 lines · Yann E. MORIN

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and onclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix for a previous ill-defined behaviour, or an actual regression...

Quoted 8 lines

In the meantime, we add a workaround, suggested in that same bug report, that fixes the issue for make 4.3, and that should not break on older make versions either (verified on all relevant versions: from 3.81, 3.82, 4.0, 4.1, and 4.2).

[0] https://savannah.gnu.org/bugs/?57676

Quoted 26 lines
Cc Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
- [0] points to something now (Thomas)
- repeat the bug URL in the Makefile (Thomas)
- explain where the workaround comes from (Thomas)

---
  Makefile | 3 +++
  1 file changed, 3 insertions(+)
Makefile +3 -0
index 31624f77a2..09e769f613 100644
@@ -188,6 +188,9 @@ ifneq ($(BR2_EXTERNAL_ERROR),)
  $(error $(BR2_EXTERNAL_ERROR))
  endif
 
+# Workaround bug in make-4.3: https://savannah.gnu.org/bugs/?57676
+$(BASE_DIR)/.br2-external.mk:;
+
  # To make sure that the environment variable overrides the .config option,
  # set this before including .config.
  ifneq ($(BR2_DL_DIR),)
#2 lore raw

PATCH v2 1/1 Makefile: work around a bug in newly released make 4.3

In reply to Yann E. MORIN
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and onclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix for a previous ill-defined behaviour, or an actual regression...

In the meantime, we add a workaround, suggested in that same bug report, that fixes the issue for make 4.3, and that should not break on older make versions either (verified on all relevant versions: from 3.81, 3.82, 4.0, 4.1, and 4.2).

[0] https://savannah.gnu.org/bugs/?57676

Quoted 8 lines
Cc Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
- [0] points to something now (Thomas)
- repeat the bug URL in the Makefile (Thomas)
- explain where the workaround comes from (Thomas)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 Makefile: work around a bug in newly released make 4.3

In reply to Yann E. MORIN
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Several users of rolling-release distributions have been reporting on IRC that Buildroot is broken now that they have switched to the newly released make 4.3.

It turns out that the constructs we use to generated and onclude the internal br2-external related fragments is no longer working with make-4.3.

Indeed, an upstream bug report [0] seems to imply that it so far was working by chance. There has been no further feedback, whether this is really considered a fix for a previous ill-defined behaviour, or an actual regression...

In the meantime, we add a workaround, suggested in that same bug report, that fixes the issue for make 4.3, and that should not break on older make versions either (verified on all relevant versions: from 3.81, 3.82, 4.0, 4.1, and 4.2).

[0] https://savannah.gnu.org/bugs/?57676

Quoted 8 lines
Cc Thomas Petazzoni <[email protected]>

---
Changes v1 -> v2:
- [0] points to something now (Thomas)
- repeat the bug URL in the Makefile (Thomas)
- explain where the workaround comes from (Thomas)

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard