Skip to contentSkip to conversation

package/python-kiwisolver: new package

PATCH New Esben Haabendal 4 participants 8 messages Sep 17, 2019 – Sep 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 package/python-kiwisolver: new package

---
 DEVELOPERS                                      |  1 +
 package/Config.in                               |  1 +
 package/python-kiwisolver/Config.in             | 17 +++++++++++++++++
 .../python-kiwisolver/python-kiwisolver.hash    |  3 +++
 package/python-kiwisolver/python-kiwisolver.mk  |  7 +++++++
 5 files changed, 29 insertions(+)
 create mode 100644 package/python-kiwisolver/Config.in
 create mode 100644 package/python-kiwisolver/python-kiwisolver.hash
 create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
DEVELOPERS +1 -0
index 3b1d03c82684..583a65b14ba9 100644
@@ -719,6 +719,7 @@ F:	package/szip/
 
 N:	Esben Haabendal <[email protected]>
 F:	boot/gummiboot/
+F:	package/python-kiwisolver/
 
 N:	Etienne Carriere <[email protected]>
 F:	boot/optee-os/
package/Config.in +1 -0
index 9336261c5d9e..dddce6636168 100644
@@ -933,6 +933,7 @@ menu "External python modules"
 	source "package/python-jsonmodels/Config.in"
 	source "package/python-jsonschema/Config.in"
 	source "package/python-keyring/Config.in"
+	source "package/python-kiwisolver/Config.in"
 	source "package/python-libconfig/Config.in"
 	source "package/python-libusb1/Config.in"
 	source "package/python-lmdb/Config.in"
package/python-kiwisolver/Config.in new file +17 -0
new file mode 100644
index 000000000000..6d31fdc35787
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+	bool "python-kiwisolver"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON
+	help
+	  Kiwi is an efficient C++ implementation of the Cassowary constraint
+	  solving algorithm. Kiwi is an implementation of the algorithm based
+	  on the seminal Cassowary paper. It is not a refactoring of the
+	  original C++ solver. Kiwi has been designed from the ground up to be
+	  lightweight and fast. Kiwi ranges from 10x to 500x faster than the
+	  original Cassowary solver with typical use cases gaining a 40x
+	  improvement. Memory savings are consistently > 5x.
+
+	  https://github.com/nucleic/kiwi
+
+comment "python-kiwisolver needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/python-kiwisolver/python-kiwisolver.hash new file +3 -0
new file mode 100644
index 000000000000..9cdb27002cf2
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 48168c0ace18319c649e31907f6d8586f648e503560f506f128798b99393bcdb  python-kiwisolver-1.1.0.tar.gz
+sha256 95c32f73d43fa54d8146badbcbd73b83acb7fa2cc81a7cef7784b3cd33b146a0  LICENSE
package/python-kiwisolver/python-kiwisolver.mk new file +7 -0
new file mode 100644
index 000000000000..96019fc29328
@@ -0,0 +1,7 @@
+PYTHON_KIWISOLVER_VERSION = 1.1.0
+PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
+PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
+PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
+PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
Signature · 1 line
2.23.0
#1 lore raw

PATCH v3 2/2 package/python-matplotlib: add kiwisolver dependency

This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

---
 package/python-matplotlib/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-matplotlib/Config.in +1 -0
index 07160affd043..e6ed8cda2f28 100644
@@ -9,6 +9,7 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
 	select BR2_PACKAGE_PYTHON_CYCLER
 	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
 	select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
+	select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
 	select BR2_PACKAGE_PYTHON_NUMPY # runtime
 	select BR2_PACKAGE_PYTHON_PYPARSING # runtime
 	select BR2_PACKAGE_PYTHON3_ZLIB # runtime
Signature · 1 line
2.23.0
#2 lore raw

PATCH v3 2/2 package/python-matplotlib: add kiwisolver dependency

Quoted 8 lines · On Tue, 17 Sep 2019 10:50:34 +0200 Esben Haabendal <[email protected]> wrote:

This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

---
 package/python-matplotlib/Config.in | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v3 1/2 package/python-kiwisolver: new package

In reply to Esben Haabendal

Hi Esben,

Quoted 84 lines · Esben Haabendal
---
 DEVELOPERS                                      |  1 +
 package/Config.in                               |  1 +
 package/python-kiwisolver/Config.in             | 17 +++++++++++++++++
 .../python-kiwisolver/python-kiwisolver.hash    |  3 +++
 package/python-kiwisolver/python-kiwisolver.mk  |  7 +++++++
 5 files changed, 29 insertions(+)
 create mode 100644 package/python-kiwisolver/Config.in
 create mode 100644 package/python-kiwisolver/python-kiwisolver.hash
 create mode 100644 package/python-kiwisolver/python-kiwisolver.mk
DEVELOPERS +1 -0
index 3b1d03c82684..583a65b14ba9 100644
@@ -719,6 +719,7 @@ F:  package/szip/
 
 N:     Esben Haabendal <[email protected]>
 F:     boot/gummiboot/
+F:     package/python-kiwisolver/
 
 N:     Etienne Carriere <[email protected]>
 F:     boot/optee-os/
package/Config.in +1 -0
index 9336261c5d9e..dddce6636168 100644
@@ -933,6 +933,7 @@ menu "External python modules"
        source "package/python-jsonmodels/Config.in"
        source "package/python-jsonschema/Config.in"
        source "package/python-keyring/Config.in"
+       source "package/python-kiwisolver/Config.in"
        source "package/python-libconfig/Config.in"
        source "package/python-libusb1/Config.in"
        source "package/python-lmdb/Config.in"
package/python-kiwisolver/Config.in new file +17 -0
new file mode 100644
index 000000000000..6d31fdc35787
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+       bool "python-kiwisolver"
+       depends on BR2_INSTALL_LIBSTDCPP
+       depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON
+       help
+         Kiwi is an efficient C++ implementation of the Cassowary constraint
+         solving algorithm. Kiwi is an implementation of the algorithm based
+         on the seminal Cassowary paper. It is not a refactoring of the
+         original C++ solver. Kiwi has been designed from the ground up to be
+         lightweight and fast. Kiwi ranges from 10x to 500x faster than the
+         original Cassowary solver with typical use cases gaining a 40x
+         improvement. Memory savings are consistently > 5x.
+
+         https://github.com/nucleic/kiwi
+
+comment "python-kiwisolver needs a toolchain w/ C++"
+       depends on !BR2_INSTALL_LIBSTDCPP
package/python-kiwisolver/python-kiwisolver.hash new file +3 -0
new file mode 100644
index 000000000000..9cdb27002cf2
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 48168c0ace18319c649e31907f6d8586f648e503560f506f128798b99393bcdb  python-kiwisolver-1.1.0.tar.gz
+sha256 95c32f73d43fa54d8146badbcbd73b83acb7fa2cc81a7cef7784b3cd33b146a0  LICENSE
package/python-kiwisolver/python-kiwisolver.mk new file +7 -1
new file mode 100644
index 000000000000..96019fc29328
@@ -0,0 +1,7 @@
+PYTHON_KIWISOLVER_VERSION = 1.1.0
+PYTHON_KIWISOLVER_SITE = $(call github,nucleic,kiwi,$(PYTHON_KIWISOLVER_VERSION))
+PYTHON_KIWISOLVER_LICENSE = BSD-3-Clause
+PYTHON_KIWISOLVER_LICENSE_FILES = LICENSE
+PYTHON_KIWISOLVER_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
--
Quoted 1 line

2.23.0

Could you also mark the previous patch versions as "Superceded" in [1]. Thanks.

[1] https://patchwork.ozlabs.org/project/buildroot/list/?submitter=76514

Yegor

#5 lore raw

PATCH v3 1/2 package/python-kiwisolver: new package

In reply to Esben Haabendal

Hello,

package/python-kiwisolver/Config.in line 4

Quoted 4 lines · On Tue, 17 Sep 2019 10:50:33 +0200 Esben Haabendal <[email protected]> wrote:
package/python-kiwisolver/Config.in new file +4 -0
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+	bool "python-kiwisolver"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON

a dependency on python || python is not very useful, especially since anyway this Config.in is already included in a python || python3 condition.

package/python-kiwisolver/python-kiwisolver.mk

Quoted 6 lines
package/python-kiwisolver/python-kiwisolver.mk new file +0 -0
new file mode 100644
index 000000000000..96019fc29328
@@ -0,0 +1,7 @@

You forgot our completely useless, but absolutely mandatory and lovely comment header that we have in all packages.

I fixed both issues and applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH v3 1/2 package/python-kiwisolver: new package

Quoted 5 lines · Thomas Petazzoni

Hello,

On Tue, 17 Sep 2019 10:50:33 +0200
Esben Haabendal <[email protected]> wrote:

Quoted 8 lines

package/python-kiwisolver/Config.in line 4

Quoted 4 lines
package/python-kiwisolver/Config.in new file +4 -0
+config BR2_PACKAGE_PYTHON_KIWISOLVER
+	bool "python-kiwisolver"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON

a dependency on python || python is not very useful, especially since anyway this Config.in is already included in a python || python3 condition.

Ah. Both did I make a typo in v3, and what I wanted to do did not make any difference. The first lesson of today :)

Quoted 10 lines

package/python-kiwisolver/python-kiwisolver.mk

Quoted 7 lines
package/python-kiwisolver/python-kiwisolver.mk new file +0 -0
new file mode 100644
index 000000000000..96019fc29328
@@ -0,0 +1,7 @@

You forgot our completely useless, but absolutely mandatory and lovely comment header that we have in all packages.

I will try to remember next time :)

Quoted 1 line

I fixed both issues and applied to master. Thanks!

Thanks.

/Esben

#7 lore raw

PATCH v3 1/2 package/python-kiwisolver: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Esben" == Esben Haabendal <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 2 lines

You forgot our completely useless, but absolutely mandatory and lovely comment header that we have in all packages.

I will try to remember next time :)

Hint: We have ./utils/check-package which warns about all these kind of things.

Signature · 1 line
Bye, Peter Korsgaard