Skip to contentSkip to conversation

package/lynx: fix build with latomic

PATCH New Fabrice Fontaine 3 participants 3 messages Apr 22, 2019 – Apr 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lynx: fix build with latomic

Help lynx finding openssl dependencies by giving it a path in --with-ssl and using pkg-config to directly pass the correct libraries in LIBS.

This will disable the call to pkg-config and CF_ADD_LIBS which has the sad behavior of removing duplicates ...
As a result, build fails because, the following correct dependencies:

configure:14170: testing adding -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...

is replaced by:

-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -lz -pthread -latomic -lcrypto

As a result, static linking fails on crypto because the second -latomic has been removed ...

Fixes:
- http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19

---
 package/lynx/lynx.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/lynx/lynx.mk +3 -2
index 174d741dd9..3ac5b4cabf 100644
@@ -21,8 +21,9 @@ LYNX_CONF_OPTS += --with-screen=slang
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-LYNX_DEPENDENCIES += openssl
-LYNX_CONF_OPTS += --with-ssl
+LYNX_DEPENDENCIES += host-pkgconf openssl
+LYNX_CONF_OPTS += --with-ssl=$(STAGING_DIR)/usr
+LYNX_CONF_ENV = LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
 else ifeq ($(BR2_PACKAGE_GNUTLS),y)
 LYNX_DEPENDENCIES += gnutls
 LYNX_CONF_OPTS += --with-gnutls
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/lynx: fix build with latomic

Hello Fabrice,

Quoted 5 lines · On Mon, 22 Apr 2019 12:48:21 +0200 Fabrice Fontaine…

Help lynx finding openssl dependencies by giving it a path in --with-ssl and using pkg-config to directly pass the correct libraries in LIBS.

This will disable the call to pkg-config and CF_ADD_LIBS which has the sad behavior of removing duplicates ...

Could this issue be reported upstream ?

Quoted 11 lines

As a result, build fails because, the following correct dependencies:

configure:14170: testing adding -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...

is replaced by:

-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib -lssl -lz -pthread -latomic -lcrypto

As a result, static linking fails on crypto because the second -latomic has been removed ...

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19

---
 package/lynx/lynx.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/lynx: fix build with latomic

In reply to Fabrice Fontaine
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Help lynx finding openssl dependencies by giving it a path in --with-ssl and using pkg-config to directly pass the correct libraries in LIBS.

This will disable the call to pkg-config and CF_ADD_LIBS which has the sad behavior of removing duplicates ...
As a result, build fails because, the following correct dependencies:

configure:14170: testing adding

(quoted diff) +0 -4
-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
-lssl
-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
-lz -pthread -latomic -lcrypto -lz -pthread -latomic to LIBS ...

is replaced by:

(quoted diff) +0 -2
-L/accts/mlweber1/rclinux/rc-buildroot-test/scripts/instance-0/output/host/bin/../sparc-buildroot-linux-uclibc/sysroot/usr/lib
-lssl -lz -pthread -latomic -lcrypto
Quoted 7 lines

As a result, static linking fails on crypto because the second -latomic has been removed ...

Fixes:
- http://autobuild.buildroot.org/results/2c28426253014d93e86e3ba6ed578e84317a9f19

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard