Skip to contentSkip to conversation

usb: dwc3: gadget: combine unaligned and zero flags

PATCH New Felipe Balbi 1 participant 1 message Nov 6, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 2/8 usb: dwc3: gadget: combine unaligned and zero flags

Hi,

Quoted 8 lines · Thinh Nguyen
(quoted diff) +0 -0
@@ -2250,7 +2250,7 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,

Review

Quoted 5 lines
(quoted diff) +1 -1
 	 * with one TRB pending in the ring. We need to manually clear HWO bit
 	 * from that TRB.
 	 */
-	if ((req->zero || req->unaligned) && !(trb->ctrl & DWC3_TRB_CTRL_CHN)) {
+	if (req->needs_extra_trb && !(trb->ctrl & DWC3_TRB_CTRL_CNH)) {

DWC3_TRB_CTRL_CNH -> DWC3_TRB_CTRL_CHN

right, fixed locally.