Skip to contentSkip to conversation

riemann-c-client: disable parallel make

PATCH New Peter Korsgaard 1 participant 2 messages Feb 13, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riemann-c-client: disable parallel make

Fixes:
http://autobuild.buildroot.net/results/2f8/2f85a2d19232365f7e5fddde6092af9dd74d4518/
http://autobuild.buildroot.net/results/80d/80d83c650c668ee1e87c288bd7a0ce63eab95631/

The build system doesn't specify any dependencies between the generated header files and the source files including them, causing a race condition:

  GEN      lib/riemann/proto/riemann.pb-c.c
  GEN      lib/riemann/proto/riemann.pb-c.h
  CC       src/src_riemann_client-riemann-client.o

In file included from ./lib/riemann/riemann-client.h:23:0,
from src/riemann-client.c:18:
./lib/riemann/attribute.h:21:40: fatal error: riemann/proto/riemann.pb-c.h: No such file or directory

Work around it by forcing non-parallel make.

---
 package/riemann-c-client/riemann-c-client.mk | 1 +
 1 file changed, 1 insertion(+)
package/riemann-c-client/riemann-c-client.mk +1 -0
index 559351998..c8a411c32 100644
@@ -10,6 +10,7 @@ RIEMANN_C_CLIENT_SITE = https://github.com/algernon/riemann-c-client/releases/do
 RIEMANN_C_CLIENT_LICENSE = LGPLv3+
 RIEMANN_C_CLIENT_LICENSE_FILES = LICENSE
 RIEMANN_C_CLIENT_INSTALL_STAGING = YES
+RIEMANN_C_CLIENT_MAKE = $(MAKE1)
 RIEMANN_C_CLIENT_DEPENDENCIES = \
 	host-pkgconf protobuf-c \
 	$(if $(BR2_PACKAGE_GNUTLS),gnutls) \
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 riemann-c-client: disable parallel make

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/2f8/2f85a2d19232365f7e5fddde6092af9dd74d4518/
http://autobuild.buildroot.net/results/80d/80d83c650c668ee1e87c288bd7a0ce63eab95631/

The build system doesn't specify any dependencies between the generated header files and the source files including them, causing a race condition:

  GEN      lib/riemann/proto/riemann.pb-c.c
  GEN      lib/riemann/proto/riemann.pb-c.h
  CC       src/src_riemann_client-riemann-client.o
Quoted 7 lines

In file included from ./lib/riemann/riemann-client.h:23:0,
from src/riemann-client.c:18:
./lib/riemann/attribute.h:21:40: fatal error: riemann/proto/riemann.pb-c.h: No such file or directory

Work around it by forcing non-parallel make.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard