net: wireless: rt2x00: Fixed Spacing issues

PATCH Applied Paul McQuade 4 participants 6 messages Oct 17, 2015 – Feb 7, 2016

Subsystems (3)

Networking Network drivers Networking drivers (wireless)

lore

Share & tools

lore

Paul McQuade

author

2015-10-17 20:04 UTC #0 lore raw

PATCH 1/1 net: wireless: rt2x00: Fixed Spacing issues

Removed empty spaces before/after parenthesis

Signed-off-by Paul McQuade <[email protected]>

---
 drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

drivers/net/wireless/rt2x00/rt61pci.h +10 ~~-10~~

index 1442075..ab86415 100644
@@ -138,14 +138,14 @@
 #define PAIRWISE_TA_TABLE_BASE		0x1a00
 
 #define SHARED_KEY_ENTRY(__idx) \
-	( SHARED_KEY_TABLE_BASE + \
-		((__idx) * sizeof(struct hw_key_entry)) )
+	(SHARED_KEY_TABLE_BASE + \
+		((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_KEY_ENTRY(__idx) \
-	( PAIRWISE_KEY_TABLE_BASE + \
-		((__idx) * sizeof(struct hw_key_entry)) )
+	(PAIRWISE_KEY_TABLE_BASE + \
+		((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_TA_ENTRY(__idx) \
-	( PAIRWISE_TA_TABLE_BASE + \
-		((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
+	(PAIRWISE_TA_TABLE_BASE + \
+		((__idx) * sizeof(struct hw_pairwise_ta_entry)))
 
 struct hw_key_entry {
 	u8 key[16];

@@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
 #define HW_BEACON_BASE3			0x2f00
 
 #define HW_BEACON_OFFSET(__index) \
-	( HW_BEACON_BASE0 + (__index * 0x0100) )
+	(HW_BEACON_BASE0 + (__index * 0x0100))
 
 /*
  * HOST-MCU shared memory.

@@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
 /*
  * DMA descriptor defines.
  */
-#define TXD_DESC_SIZE			( 16 * sizeof(__le32) )
-#define TXINFO_SIZE			( 6 * sizeof(__le32) )
-#define RXD_DESC_SIZE			( 16 * sizeof(__le32) )
+#define TXD_DESC_SIZE			(16 * sizeof(__le32))
+#define TXINFO_SIZE			(6 * sizeof(__le32))
+#define RXD_DESC_SIZE			(16 * sizeof(__le32))
 
 /*
  * TX descriptor format for TX, PRIO and Beacon Ring.

Signature · 1 line

2.6.1

Helmut Schaa

Acked-by on v1 1/1

2016-01-21 16:56 UTC #1 lore raw

Quoted 3 lines · Paul McQuade

Removed empty spaces before/after parenthesis
Signed-off-by Paul McQuade <[email protected]>

Just noticed these did not get applied by Kalle yet.

Looks good to me.

Acked-by Helmut Schaa <[email protected]>

Quoted 58 lines

---
 drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

drivers/net/wireless/rt2x00/rt61pci.h +10 ~~-11~~

index 1442075..ab86415 100644
@@ -138,14 +138,14 @@
 #define PAIRWISE_TA_TABLE_BASE         0x1a00
 
 #define SHARED_KEY_ENTRY(__idx) \
-       ( SHARED_KEY_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_key_entry)) )
+       (SHARED_KEY_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_KEY_ENTRY(__idx) \
-       ( PAIRWISE_KEY_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_key_entry)) )
+       (PAIRWISE_KEY_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_TA_ENTRY(__idx) \
-       ( PAIRWISE_TA_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
+       (PAIRWISE_TA_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
 
 struct hw_key_entry {
        u8 key[16];

@@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
 #define HW_BEACON_BASE3                        0x2f00
 
 #define HW_BEACON_OFFSET(__index) \
-       ( HW_BEACON_BASE0 + (__index * 0x0100) )
+       (HW_BEACON_BASE0 + (__index * 0x0100))
 
 /*
  * HOST-MCU shared memory.

@@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
 /*
  * DMA descriptor defines.
  */
-#define TXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
-#define TXINFO_SIZE                    ( 6 * sizeof(__le32) )
-#define RXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
+#define TXD_DESC_SIZE                  (16 * sizeof(__le32))
+#define TXINFO_SIZE                    (6 * sizeof(__le32))
+#define RXD_DESC_SIZE                  (16 * sizeof(__le32))
 
 /*
  * TX descriptor format for TX, PRIO and Beacon Ring.
--

2.6.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Helmut Schaa

2016-01-21 17:02 UTC #2 lore raw

Quoted 6 lines · Helmut Schaa

Quoted 3 lines · Paul McQuade
Removed empty spaces before/after parenthesis
Signed-off-by Paul McQuade <[email protected]>
Just noticed these did not get applied by Kalle yet.

Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying? Or would you prefer Paul to respin the whole code style cleanup series?

Thanks,
Helmut

Quoted 62 lines

Looks good to me.

Acked-by Helmut Schaa <[email protected]>

Quoted 58 lines

---
 drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

drivers/net/wireless/rt2x00/rt61pci.h +10 ~~-11~~

index 1442075..ab86415 100644
@@ -138,14 +138,14 @@
 #define PAIRWISE_TA_TABLE_BASE         0x1a00
 
 #define SHARED_KEY_ENTRY(__idx) \
-       ( SHARED_KEY_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_key_entry)) )
+       (SHARED_KEY_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_KEY_ENTRY(__idx) \
-       ( PAIRWISE_KEY_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_key_entry)) )
+       (PAIRWISE_KEY_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_key_entry)))
 #define PAIRWISE_TA_ENTRY(__idx) \
-       ( PAIRWISE_TA_TABLE_BASE + \
-               ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
+       (PAIRWISE_TA_TABLE_BASE + \
+               ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
 
 struct hw_key_entry {
        u8 key[16];

@@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
 #define HW_BEACON_BASE3                        0x2f00
 
 #define HW_BEACON_OFFSET(__index) \
-       ( HW_BEACON_BASE0 + (__index * 0x0100) )
+       (HW_BEACON_BASE0 + (__index * 0x0100))
 
 /*
  * HOST-MCU shared memory.

@@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
 /*
  * DMA descriptor defines.
  */
-#define TXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
-#define TXINFO_SIZE                    ( 6 * sizeof(__le32) )
-#define RXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
+#define TXD_DESC_SIZE                  (16 * sizeof(__le32))
+#define TXINFO_SIZE                    (6 * sizeof(__le32))
+#define RXD_DESC_SIZE                  (16 * sizeof(__le32))
 
 /*
  * TX descriptor format for TX, PRIO and Beacon Ring.
--

2.6.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Kalle Valo

2016-01-21 17:12 UTC #3 lore raw

Quoted 11 lines · Helmut Schaa

Quoted 6 lines · Helmut Schaa
Quoted 3 lines · Paul McQuade
Removed empty spaces before/after parenthesis
Signed-off-by Paul McQuade <[email protected]>
Just noticed these did not get applied by Kalle yet.
Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying? Or would you prefer Paul to respin the whole code style cleanup series?

Actually git should be manage that automatically, it's so awesome :)

I can also fix the title and remove the unnecessary "net: wireless:" prefix.

Signature · 5 lines

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sudip Mukherjee

2016-02-02 15:59 UTC #4 lore raw

In reply to Paul McQuade

Quoted 8 lines · Paul Mcquade

Removed empty spaces before/after parenthesis
Signed-off-by Paul McQuade <[email protected]>
Acked-by Helmut Schaa <[email protected]>
---
drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

This patch and your other patches related to rt2x00 will not apply anymore as the driver has moved to drivers/net/wireless/ralink/rt2x00

can you please send them again after rebasing against current tree..

regards
sudip

Kalle Valo

Applied

2016-02-07 07:10 UTC #5 lore raw

In reply to Paul McQuade

Quoted 5 lines

Removed empty spaces before/after parenthesis
Signed-off-by Paul McQuade <[email protected]>
Acked-by Helmut Schaa <helmut.schaa-gM/[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html