Skip to contentSkip to conversation

freerdp: pass appropriate ARM ABI flags

PATCH New Thomas Petazzoni 2 participants 2 messages Dec 29, 2014

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 freerdp: pass appropriate ARM ABI flags

In the line of commit 530693787b3 ("package/freerdp: do not use Neon extensions when not available") done by Yann E. Morin, freerdp also passes an explicit -mfloat-abi= flag, and defaults to softfp. This obviously breaks badly when building an EABIhf system.

This commit therefore fixes freerdp.mk to pass the appropriate ARM_FP_ABI value to freerdp's build system.

Fixes:

http://autobuild.buildroot.org/results/6ca/6ca9de1a11c675533baa68f7a6bf7b6af7cb4345/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/freerdp/freerdp.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/freerdp/freerdp.mk +4 -0
index a703500..57cd7a8 100644
@@ -75,4 +75,8 @@ else
 FREERDP_CONF_OPTS += -DWITH_SSE2=OFF
 endif
 
+ifeq ($(BR2_arm)$(BR2_armeb),y)
+FREERDP_CONF_OPTS += -DARM_FP_ABI=$(call qstrip,$(BR2_GCC_TARGET_FLOAT_ABI))
+endif
+
 $(eval $(cmake-package))
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 freerdp: pass appropriate ARM ABI flags

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In the line of commit 530693787b3 ("package/freerdp: do not use Neon extensions when not available") done by Yann E. Morin, freerdp also passes an explicit -mfloat-abi= flag, and defaults to softfp. This obviously breaks badly when building an EABIhf system.

Quoted 8 lines

This commit therefore fixes freerdp.mk to pass the appropriate ARM_FP_ABI value to freerdp's build system.

Fixes:

http://autobuild.buildroot.org/results/6ca/6ca9de1a11c675533baa68f7a6bf7b6af7cb4345/

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard