aarch64: filter $x from kallsyms
PATCH 1/1 aarch64: filter $x from kallsyms
Similar to ARM, AArch64 is generating $x and $d syms... which isn't terribly helpful when looking at %pF output and the like. Filter those out in kallsyms, modpost and when looking at module symbols.
Seems simplest since none of these check EM_ARM anyway, to just add it to the strchr used, rather than trying to make things overly complicated.
initcall_debug improves:
dmesg_before.txt: initcall $x+0x0/0x154 [sg] returned 0 after 26331 usecs dmesg_after.txt: initcall init_sg+0x0/0x154 [sg] returned 0 after 15461 usecs
kernel/module.c +1 -1
@@ -3388,7 +3388,7 @@ static inline int is_arm_mapping_symbol(const char *str) {if (str[0 ] =='.' && str[1 ] =='L' )return true; -return str[0 ] =='$' &&strchr ("atd" , str[1 ]) +return str[0 ] =='$' &&strchr ("axtd" , str[1 ]) && (str[2 ] =='\0' || str[2 ] =='.' ); }
scripts/kallsyms.c +1 -1
@@ -84,7 +84,7 @@ static void usage(void)*/ static inline int is_arm_mapping_symbol (const char *str) { -return str[0 ] =='$' &&strchr ("atd" , str[1 ]) +return str[0 ] =='$' &&strchr ("axtd" , str[1 ]) && (str[2 ] =='\0' || str[2 ] =='.' ); }
scripts/mod/modpost.c +1 -1
@@ -1146,7 +1146,7 @@ static Elf_Sym *find_elf_symbol(struct elf_info *elf, Elf64_Sword addr,static inline int is_arm_mapping_symbol (const char *str) { -return str[0 ] =='$' &&strchr ("atd" , str[1 ]) +return str[0 ] =='$' &&strchr ("axtd" , str[1 ]) && (str[2 ] =='\0' || str[2 ] =='.' ); }
Quoted 8 lines · Kyle McMartin
Similar to ARM, AArch64 is generating $x and $d syms... which isn't terribly helpful when looking at %pF output and the like. Filter those out in kallsyms, modpost and when looking at module symbols.
Seems simplest since none of these check
EM_ARManyway, to just add it to the strchr used, rather than trying to make things overly complicated.
Quoted 5 lines
initcall_debugimproves:
dmesg_before.txt: initcall $x+0x0/0x154 [sg] returned 0 after 26331 usecs dmesg_after.txt: initcallinit_sg+0x0/0x154[sg] returned 0 after 15461 usecsSigned-off-by Kyle McMartin <[email protected]>
Thanks,
Rusty.
Quoted 9 lines · Rusty Russell
Quoted 8 lines · Kyle McMartin
Similar to ARM, AArch64 is generating $x and $d syms... which isn't terribly helpful when looking at %pF output and the like. Filter those out in kallsyms, modpost and when looking at module symbols.
Seems simplest since none of these check
EM_ARManyway, to just add it to the strchr used, rather than trying to make things overly complicated.
Quoted 7 lines
Quoted 5 lines
initcall_debugimproves:
dmesg_before.txt: initcall $x+0x0/0x154 [sg] returned 0 after 26331 usecs dmesg_after.txt: initcallinit_sg+0x0/0x154[sg] returned 0 after 15461 usecsSigned-off-by Kyle McMartin <[email protected]>Acked-by Rusty Russell <[email protected]>
Thanks. Shall I understand that you are ok for me to take it via the arm64 tree (or you'd prefer to merge it via your tree)?
Signature · 1 line
Catalin
Quoted 14 lines · Catalin Marinas
Quoted 13 lines · Rusty Russell
Quoted 12 lines · Kyle McMartin
Similar to ARM, AArch64 is generating $x and $d syms... which isn't terribly helpful when looking at %pF output and the like. Filter those out in kallsyms, modpost and when looking at module symbols.
Seems simplest since none of these check
EM_ARManyway, to just add it to the strchr used, rather than trying to make things overly complicated.
initcall_debugimproves:
dmesg_before.txt: initcall $x+0x0/0x154 [sg] returned 0 after 26331 usecs dmesg_after.txt: initcallinit_sg+0x0/0x154[sg] returned 0 after 15461 usecs
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Kyle McMartin <[email protected]>Acked-by Rusty Russell <[email protected]>Thanks. Shall I understand that you are ok for me to take it via the arm64 tree (or you'd prefer to merge it via your tree)?
Sorry, vacation. Yes, it was all yours, and I see it in Linus' tree now.
Thanks,
Rusty.