Skip to contentSkip to conversation

perl: bump to version 5.20.1

PATCH New Francois Perrad 4 participants 12 messages Oct 1, 2014 – Oct 4, 2014

lore
Share & tools
lore

Francois Perrad

author
#0 lore raw

PATCH 1/3 perl: bump to version 5.20.1

Signed-off-by Francois Perrad <[email protected]>
---
 package/perl/perl-uClibc-IPv6.patch | 10 +++++-----
 package/perl/perl.mk                | 11 +++++++----
 support/scripts/scancpan            |  2 +-
 3 files changed, 13 insertions(+), 10 deletions(-)
package/perl/perl-uClibc-IPv6.patch +5 -5
index 8ace75e..b29d373 100644
@@ -6,7 +6,7 @@ Index: b/cpan/Socket/Socket.xs
 ===================================================================
 --- a/cpan/Socket/Socket.xs
 +++ b/cpan/Socket/Socket.xs
-@@ -896,7 +896,7 @@
+@@ -920,7 +920,7 @@
  	CODE:
  #ifdef HAS_INETNTOP
  	STRLEN addrlen;

@@ -15,7 +15,7 @@ Index: b/cpan/Socket/Socket.xs
  	struct in6_addr addr;
  	char str[INET6_ADDRSTRLEN];
  #else
-@@ -916,7 +916,7 @@
+@@ -940,7 +940,7 @@
  		croak("Bad address length for Socket::inet_ntop on AF_INET;"
  		      " got %"UVuf", should be 4", (UV)addrlen);
  	    break;

@@ -24,7 +24,7 @@ Index: b/cpan/Socket/Socket.xs
  	  case AF_INET6:
  	    if(addrlen != 16)
  		croak("Bad address length for Socket::inet_ntop on AF_INET6;"
-@@ -925,7 +925,7 @@
+@@ -949,7 +949,7 @@
  #endif
  	  default:
  		croak("Bad address family for %s, got %d, should be"

@@ -33,7 +33,7 @@ Index: b/cpan/Socket/Socket.xs
  		      " either AF_INET or AF_INET6",
  #else
  		      " AF_INET",
-@@ -955,7 +955,7 @@
+@@ -979,7 +979,7 @@
  #ifdef HAS_INETPTON
  	int ok;
  	int addrlen = 0;

@@ -42,7 +42,7 @@ Index: b/cpan/Socket/Socket.xs
  	struct in6_addr ip_address;
  #else
  	struct in_addr ip_address;
-@@ -965,14 +965,14 @@
+@@ -989,14 +989,14 @@
  	  case AF_INET:
  	    addrlen = 4;
  	    break;
package/perl/perl.mk +7 -4
index 65c0a7d..c355dc0 100644
@@ -4,16 +4,16 @@
 #
 ################################################################################
 
-PERL_VERSION_MAJOR = 18
-PERL_VERSION = 5.$(PERL_VERSION_MAJOR).2
+PERL_VERSION_MAJOR = 20
+PERL_VERSION = 5.$(PERL_VERSION_MAJOR).1
 PERL_SITE = http://www.cpan.org/src/5.0
 PERL_SOURCE = perl-$(PERL_VERSION).tar.bz2
 PERL_LICENSE = Artistic or GPLv1+
 PERL_LICENSE_FILES = Artistic Copying README
 PERL_INSTALL_STAGING = YES
 
-PERL_CROSS_VERSION = 0.8.5
-PERL_CROSS_BASE_VERSION = 5.$(PERL_VERSION_MAJOR).2
+PERL_CROSS_VERSION = 0.9.2
+PERL_CROSS_BASE_VERSION = 5.$(PERL_VERSION_MAJOR).0
 # DO NOT refactor with the github helper (the result is not the same)
 PERL_CROSS_SITE    = http://raw.github.com/arsv/perl-cross/releases
 PERL_CROSS_SOURCE  = perl-$(PERL_CROSS_BASE_VERSION)-cross-$(PERL_CROSS_VERSION).tar.gz

@@ -116,7 +116,10 @@ endef
 #
 define PERL_ADD_CORE_H
 	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/patchlevel-debian.h
+	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/patchlevel-gentoo.h
 	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/cc_runtime.h
+	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/fakethr.h
+	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/perlsfio.h
 	touch $(STAGING_DIR)/usr/lib/perl5/$(PERL_VERSION)/$(PERL_ARCHNAME)/CORE/vutil.h
 endef
support/scripts/scancpan +1 -1
index e738a83..f5612e3 100755
@@ -471,7 +471,7 @@ unshift @INC, sub {
 } # END OF FATPACK CODE
 
 
-use 5.018;      # same major version as target perl
+use 5.020;      # same major version as target perl
 use strict;
 use warnings;
 use Fatal qw(open close);
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/3 perl: add hash

Signed-off-by Francois Perrad <[email protected]>
---
 package/perl/perl.hash | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 package/perl/perl.hash
package/perl/perl.hash new file +4 -0
new file mode 100644
index 0000000..57fefd7
@@ -0,0 +1,4 @@
+# Hashes from: http://www.cpan.org/src/5.0/perl-5.20.1.tar.bz2.{md5,sha1,sha256}.txt
+md5    ede5166f949d9a07163bc5b086be9759                                 perl-5.20.1.tar.bz2
+sha1   cd424d1520ba2686fe5d4422565aaf880e9467f6                         perl-5.20.1.tar.bz2
+sha256 ede5ded37e7fb6139b04728cfca826f17076f9888dbfd100a56834dbeb04657c perl-5.20.1.tar.bz2
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH 3/3 support/script/scancpan: add option test

In reply to Francois Perrad

test modules are usually useless on BR

Signed-off-by Francois Perrad <[email protected]>
---
 support/scripts/scancpan | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)
support/scripts/scancpan +10 -3
index f5612e3..a049e2c 100755
@@ -483,7 +483,7 @@ use Module::CoreList;
 use HTTP::Tiny;
 use MetaCPAN::API::Tiny;
 
-my ($help, $man, $quiet, $force, $recommend, $host);
+my ($help, $man, $quiet, $force, $recommend, $test, $host);
 my $target = 1;
 GetOptions( 'help|?' => \$help,
             'man' => \$man,

@@ -491,7 +491,8 @@ GetOptions( 'help|?' => \$help,
             'force|f' => \$force,
             'host!' => \$host,
             'target!' => \$target,
-            'recommend' => \$recommend
+            'recommend' => \$recommend,
+            'test' => \$test
 ) or pod2usage(-exitval => 1);
 pod2usage(-exitval => 0) if $help;
 pod2usage(-exitval => 0, -verbose => 2) if $man;

@@ -554,11 +555,12 @@ sub fetch {
             next if $modname eq q{perl};
             next if $modname =~ m|^Alien|;
             next if $modname =~ m|^Win32|;
+            next if !$test && $modname =~ m|^Test|; 
             next if Module::CoreList::first_release( $modname );
             # we could use the host Module::CoreList data, because host perl and
             # target perl have the same major version
             next if ${$dep}{phase} eq q{develop};
-            next if ${$dep}{phase} eq q{test};
+            next if !$test && ${$dep}{phase} eq q{test};
             next if !$recommend && ${$dep}{relationship} ne q{requires};
             my $distname = $mcpan->module( $modname )->{distribution};
             if (${$dep}{phase} eq q{runtime}) {

@@ -716,6 +718,7 @@ supports/scripts/scancpan [options] [distname ...]
    -target/-notarget
    -host/-nohost
    -recommend
+   -test
 
 =head1 OPTIONS
 

@@ -749,6 +752,10 @@ Switches package generation for the host variant (the default is C<-nohost>).
 
 Adds I<recommended> dependencies.
 
+=item B<-test>
+
+Adds dependencies for test.
+
 =back
 
 =head1 DESCRIPTION
Signature · 1 line
1.9.1
#4 lore raw

PATCH 3/3 support/script/scancpan: add option test

Dear Francois Perrad,

Quoted 3 lines · Francois Perrad

test modules are usually useless on BR

Signed-off-by Francois Perrad <[email protected]>

Sorry for asking only now, but can we have a real commit message that explains what's going on?

Something like:

"""
This commit adds a new -test option to the scancpan script, which allows to ...
"""

With your current message "test modules are usually useless on BR", I don't understand what this option does: does it disables test modules? does it enables it? what does it change compared to the previous situation?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 3/3 support/script/scancpan: add option test

2014-10-01 21:34 GMT+02:00 Thomas Petazzoni
<[email protected]>:

Quoted 17 lines

Dear Francois Perrad,

Quoted 3 lines · Francois Perrad

test modules are usually useless on BR

Signed-off-by Francois Perrad <[email protected]>

Sorry for asking only now, but can we have a real commit message that explains what's going on?

Something like:

"""
This commit adds a new -test option to the scancpan script, which allows to ...
"""

Quoted 7 lines

With your current message "test modules are usually useless on BR", I don't understand what this option does: does it disables test modules? does it enables it? what does it change compared to the previous situation?

Best regards,

find below an improved message for this patch

"""
Between Perl modules, there are 3 kinds of dependency:
- configure/build time dependency which becomes host dependency
- runtime dependency which becomes target dependency
- test time dependency which is useless in a cross-compiling context like BR

Before this patch, test time dependencies are handled like runtime dependencies.

After this patch, test time dependencies are ignored by default. The new option -test allows to add them anyway.
"""

Fran?ois.

Quoted 9 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#6 lore raw

PATCH 3/3 support/script/scancpan: add option test

Dear Fran?ois Perrad,

Quoted 8 lines · Fran?ois Perrad

find below an improved message for this patch

"""
Between Perl modules, there are 3 kinds of dependency:
- configure/build time dependency which becomes host dependency
- runtime dependency which becomes target dependency
- test time dependency which is useless in a cross-compiling context like BR

Quoted 5 lines

Before this patch, test time dependencies are handled like runtime dependencies.

After this patch, test time dependencies are ignored by default. The new option -test allows to add them anyway.
"""

Looks, much, much better. I understand now.

Thanks for the better commit message!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Applied
#7 lore raw

PATCH 3/3 support/script/scancpan: add option test

In reply to Francois Perrad

Dear Francois Perrad,

Quoted 6 lines · Francois Perrad

test modules are usually useless on BR

Signed-off-by Francois Perrad <[email protected]>
---
 support/scripts/scancpan | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Thanks, applied, after adding your new commit message.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#9 lore raw

PATCH 1/3 perl: bump to version 5.20.1

In reply to Francois Perrad

Dear Francois Perrad,

Quoted 6 lines · Francois Perrad
Signed-off-by Francois Perrad <[email protected]>
---
 package/perl/perl-uClibc-IPv6.patch | 10 +++++-----
 package/perl/perl.mk                | 11 +++++++----
 support/scripts/scancpan            |  2 +-
 3 files changed, 13 insertions(+), 10 deletions(-)

Don't know if it's related to the version bump, but perl now fails to build on PowerPC:

http://autobuild.buildroot.org/results/8ad/8ade6c432ffa725a324f9e7cfb18f6453687b129/build-end.log

Could you have a look?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#10 lore raw

PATCH 1/3 perl: bump to version 5.20.1

2014-10-04 14:26 GMT+02:00 Thomas Petazzoni
<[email protected]>:

Quoted 10 lines

Dear Francois Perrad,

Quoted 6 lines · Francois Perrad
Signed-off-by Francois Perrad <[email protected]>
---
 package/perl/perl-uClibc-IPv6.patch | 10 +++++-----
 package/perl/perl.mk                | 11 +++++++----
 support/scripts/scancpan            |  2 +-
 3 files changed, 13 insertions(+), 10 deletions(-)
Quoted 7 lines

Don't know if it's related to the version bump, but perl now fails to build on PowerPC:

http://autobuild.buildroot.org/results/8ad/8ade6c432ffa725a324f9e7cfb18f6453687b129/build-end.log

Could you have a look?

I've already filled an issue, see https://github.com/arsv/perl-cross/issues/10

Fran?ois

Quoted 11 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#11 lore raw

PATCH 1/3 perl: bump to version 5.20.1

Dear Fran?ois Perrad,

Quoted 9 lines · Fran?ois Perrad
Quoted 7 lines

Don't know if it's related to the version bump, but perl now fails to build on PowerPC:

http://autobuild.buildroot.org/results/8ad/8ade6c432ffa725a324f9e7cfb18f6453687b129/build-end.log

Could you have a look?

I've already filled an issue, see https://github.com/arsv/perl-cross/issues/10

Ok, thanks. Do you think the perl-cross people will be reactive? If not, what do we do in the mean time: revert the bump? Disable perl on big-endian architectures?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com