Skip to contentSkip to conversation

Initial support for Panda and PandaES

PATCH New Nicolas Dechesne 5 participants 13 messages Mar 18, 2012 – May 5, 2012

lore
Share & tools
lore
#0 lore raw

v4 cover Initial support for Panda and PandaES

Here is a new attempt to add support for TI PandaBoard and PandaBoard ES.

Many thanks for Arnout for his time reviewing all these versions!

v4:
- add a config variable for SPL name since MLO is used on OMAP only
- changed the default SPL NAME to MLO in pandaboard config
- rebased on master branch as of 2012/03/18

v3:
- added more documentation in uboot/Config.in regarding SPL
- added 'acked-by' as per review
- rebased on master branch as of 2012/03/12

v2:

- typo cleanup as per reviews
- introduce BR2_TARGET_UBOOT_FORMAT_IMG to allow use of u-boot.img on platforms that need it, like OMAP. This is better than v1 since u-boot.img is not stricly dependent on SPL, so making 2 parameters makes more sense.

v1:

Because we want to deprecate x-loader in favor of u-boot SPL:
- my first patch adds support for SPL in BR
- SPL is enabled by default in my panda config.

Both Panda and PandaES have been tested, detection is done at run time in uboot and kernel, so we can have 1 configuration only.

I've used DEVTMPFS by default, as 1) I generally prefer this, and 2) ttyO was missing from the generic dev table...

*** BLURB HERE ***

Nicolas Dechesne (3):
uboot: Add support for U-Boot SPL
uboot: add a new binary format for u-boot.img
configs: add support for PandaBoard and PandaBoard ES

 boot/uboot/Config.in         |   21 +++++++++++++++++++++
 boot/uboot/uboot.mk          |    4 ++++
 configs/pandaboard_defconfig |   26 ++++++++++++++++++++++++++
 3 files changed, 51 insertions(+), 0 deletions(-)
 create mode 100644 configs/pandaboard_defconfig
Signature · 1 line
1.7.9.1
#1 lore raw

PATCH v4 1/3 uboot: Add support for U-Boot SPL

SPL is a first stage bootloader. On pandaboard it supercedes x-loader, and should now be used.

This patch ensures that either SPL or xloader can be selected.

A config variable has been added for the name of the SPL binary generated during u-boot build. For most platform it is u-boot-spl.bin but not always. It is MLO on OMAP for example.

---
 boot/uboot/Config.in |   18 ++++++++++++++++++
 boot/uboot/uboot.mk  |    2 ++
 2 files changed, 20 insertions(+), 0 deletions(-)
boot/uboot/Config.in +18 -0
index c8db9fb..4873e62 100644
@@ -137,4 +137,22 @@ config BR2_TARGET_UBOOT_ETH1ADDR
 
 endif # BR2_TARGET_UBOOT_NETWORK
 
+config BR2_TARGET_UBOOT_SPL
+	bool "U-Boot SPL support"
+	depends on !BR2_TARGET_XLOADER
+	help
+	  Enable the U-Boot SPL support. SPL is a first stage
+	  bootloader loaded into internal memory in charge of 
+	  enabling and configuring the external memory (DDR), 
+	  and load the u-boot program into DDR.
+
+config BR2_TARGET_UBOOT_SPL_NAME
+	string "U-Boot SPL target name"
+	default "u-boot-spl.bin"
+	depends on BR2_TARGET_UBOOT_SPL
+	help
+	  This is the name of the SPL binary, generated during
+	  u-boot build. For most platform it is u-boot-spl.bin
+	  but not always. It is MLO on OMAP for example.
+
 endif # BR2_TARGET_UBOOT
boot/uboot/uboot.mk +2 -0
index db9de8d..f64964c 100644
@@ -88,6 +88,8 @@ endef
 
 define UBOOT_INSTALL_IMAGES_CMDS
 	cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
+	$(if $(BR2_TARGET_UBOOT_SPL),
+		cp -dpf $(@D)/$(BR2_TARGET_UBOOT_SPL_NAME) $(BINARIES_DIR)/)
 endef
 
 $(eval $(call GENTARGETS))
Signature · 1 line
1.7.9.1
#2 lore raw

PATCH v4 1/3 uboot: Add support for U-Boot SPL

Quoted 6 lines · Nicolas Dechesne

SPL is a first stage bootloader. On pandaboard it supercedes x-loader, and should now be used.

This patch ensures that either SPL or xloader can be selected.

Quoted 7 lines

A config variable has been added for the name of the SPL binary generated during u-boot build. For most platform it is u-boot-spl.bin but not always.
It is MLO on OMAP for example.

I started following the pandaboard patches, since parts are also useful for the beaglebone. I'm not sure what their status is, but if it helps, this particular patch is:

Supposing these get included, I'll need to send an updated beaglebone patch.

Frank

#3 lore raw

PATCH v4 1/3 uboot: Add support for U-Boot SPL

On Sun, Apr 1, 2012 at 8:50 PM, Frank Hunleth <[email protected]

Quoted 11 lines

wrote:

I started following the pandaboard patches, since parts are also useful for the beaglebone. I'm not sure what their status is, but if it helps, this particular patch is:

Supposing these get included, I'll need to send an updated beaglebone patch.

ping.

any interest to merge these pandaboard support patches?

let me know if you need anything from me.

thx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120503/41c85375/attachment.html>

#5 lore raw

PATCH v4 1/3 uboot: Add support for U-Boot SPL

In reply to Nicolas Dechesne
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Nicolas" == Nicolas Dechesne <[email protected]> writes:

Nicolas> SPL is a first stage bootloader. On pandaboard it supercedes x-loader, Nicolas> and should now be used.

Nicolas> This patch ensures that either SPL or xloader can be selected.

Nicolas> A config variable has been added for the name of the SPL Nicolas> binary generated during u-boot build. For most platform it is Nicolas> u-boot-spl.bin but not always. It is MLO on OMAP for example.

Committed, thanks - And sorry for the slow response.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH v4 2/3 uboot: add a new binary format for u-boot.img

In reply to Nicolas Dechesne

For some platforms like OMAP, a new binary format is now being used for u-boot: u-boot.img. It is basically u-boot.bin which has been processed with mkimage.

---
 boot/uboot/Config.in |    3 +++
 boot/uboot/uboot.mk  |    2 ++
 2 files changed, 5 insertions(+), 0 deletions(-)
boot/uboot/Config.in +3 -0
index 4873e62..d5669e1 100644
@@ -79,6 +79,9 @@ choice
 config BR2_TARGET_UBOOT_FORMAT_BIN
 	bool "u-boot.bin"
 
+config BR2_TARGET_UBOOT_FORMAT_IMG
+	bool "u-boot.img"
+
 config BR2_TARGET_UBOOT_FORMAT_NAND_BIN
 	bool "u-boot-nand.bin"
 
boot/uboot/uboot.mk +2 -0
index f64964c..3119092 100644
@@ -29,6 +29,8 @@ else ifeq ($(BR2_TARGET_UBOOT_FORMAT_LDR),y)
 UBOOT_BIN          = u-boot.ldr
 else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND_BIN),y)
 UBOOT_BIN          = u-boot-nand.bin
+else ifeq ($(BR2_TARGET_UBOOT_FORMAT_IMG),y)
+UBOOT_BIN          = u-boot.img
 else
 UBOOT_BIN          = u-boot.bin
 endif
Signature · 1 line
1.7.9.1
#8 lore raw

PATCH v4 2/3 uboot: add a new binary format for u-boot.img

In reply to Nicolas Dechesne
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Nicolas" == Nicolas Dechesne <[email protected]> writes:

Nicolas> For some platforms like OMAP, a new binary format is now being used Nicolas> for u-boot: u-boot.img. It is basically u-boot.bin which has been Nicolas> processed with mkimage.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#9 lore raw

PATCH v4 3/3 configs: add support for PandaBoard and PandaBoard ES

In reply to Nicolas Dechesne

This is a default configuration for Panda and PandaES, tested on both platforms.

DEVTMPFS is enabled, to use static dev configuration one would need to update the generic dev table for ttyO driver.

Panda is well supported in mainline kernel with omap2plus_defconfig, so this should be safe.

U-boot SPL support is enabled by default as x-loader is now deprecated.

With OMAP platforms u-boot,img format is prefered now, so it's enabled by default as well. Also, on PandaBoard, the name of SPL target file is MLO.

---
 configs/pandaboard_defconfig |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 configs/pandaboard_defconfig
configs/pandaboard_defconfig new file +26 -0
new file mode 100644
index 0000000..9496b7f
@@ -0,0 +1,26 @@
+# Architecture
+BR2_arm=y
+BR2_cortex_a9=y
+
+# system
+BR2_TARGET_GENERIC_GETTY=y
+BR2_TARGET_GENERIC_GETTY_PORT="ttyO2"
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS=y
+
+# filesystem
+BR2_TARGET_ROOTFS_EXT2=y
+# BR2_TARGET_ROOTFS_TAR is not set
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_DEFCONFIG="omap2plus"
+
+# GCC
+BR2_GCC_VERSION_4_6_X=y
+
+# Bootloaders
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_FORMAT_IMG=y
+BR2_TARGET_UBOOT_BOARDNAME="omap4_panda"
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="MLO"
Signature · 1 line
1.7.9.1
#11 lore raw

PATCH v4 3/3 configs: add support for PandaBoard and PandaBoard ES

In reply to Nicolas Dechesne
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Nicolas" == Nicolas Dechesne <[email protected]> writes:

Nicolas> This is a default configuration for Panda and PandaES, tested on both Nicolas> platforms.

Nicolas> DEVTMPFS is enabled, to use static dev configuration one would need Nicolas> to update the generic dev table for ttyO driver.

Nicolas> Panda is well supported in mainline kernel with omap2plus_defconfig, Nicolas> so this should be safe.

Nicolas> U-boot SPL support is enabled by default as x-loader is now Nicolas> deprecated.

Nicolas> With OMAP platforms u-boot,img format is prefered now, so it's enabled Nicolas> by default as well. Also, on PandaBoard, the name of SPL target file Nicolas> is MLO.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#12 lore raw

v4 cover Initial support for Panda and PandaES

In reply to Nicolas Dechesne

Peter, Arnoud, Thomas,

Quoted 9 lines · Nicolas Dechesne

Here is a new attempt to add support for TI PandaBoard and PandaBoard ES.

Many thanks for Arnout for his time reviewing all these versions!

v4:
- add a config variable for SPL name since MLO is used on OMAP only
- changed the default SPL NAME to MLO in pandaboard config
- rebased on master branch as of 2012/03/18

can you please tell me if anything else is needed on my side to get this series merged? Arnoud did several rounds of review, and we came up with this v4. If there is any more updates , i can make them of course, but I really wish this can get merged at some point.

cheers

nico
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120326/6fec9938/attachment.html>