Skip to contentSkip to conversation

add libfcgi to buildroot

PATCH New Rico Bachmann 4 participants 21 messages Sep 29, 2011 – May 1, 2012

lore
Share & tools
lore

Rico Bachmann

author
#0 lore raw

PATCH 2/2 add libfcgi to buildroot

added the patches, still not working
could be a problem with the filepath in the patch?

Signed-off-by Rico Bachmann <[email protected]>
---
 package/libfcgi/Config.in               |    3 ++-
 package/libfcgi/libfcgi.mk              |    2 --
 package/libfcgi/link_math_cgifcgi.patch |   11 +++++++++++
 package/libfcgi/link_math_example.patch |   11 +++++++++++
 4 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100755 package/libfcgi/link_math_cgifcgi.patch
 create mode 100755 package/libfcgi/link_math_example.patch
package/libfcgi/Config.in +2 -1
index 169c6f2..a2f448b 100755
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFCGI
     bool "libfcgi"
     help
-        fastcgi developerslibrary
+        This is a fastcgi developer library for C/C++
         http://www.fastcgi.com/
+
package/libfcgi/libfcgi.mk +0 -2
index e338f29..04c9996 100755
@@ -7,7 +7,5 @@ LIBFCGI_VERSION = 2.4.0
 LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
 LIBFCGI_SITE = http://www.fastcgi.com/dist
 LIBFCGI_INSTALL_STAGING = YES
-LIBFCGI_INSTALL_TARGET = YES
-LIBFCGI_CONF_OPT = --enable-shared
 
 $(eval $(call AUTOTARGETS,package,libfcgi))
package/libfcgi/link_math_cgifcgi.patch new file +11 -0
new file mode 100755
index 0000000..add425a
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:05:06.000000000 +0200
+@@ -119,7 +119,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/cgi-fcgi.Po
package/libfcgi/link_math_example.patch new file +11 -0
new file mode 100755
index 0000000..fff2595
@@ -0,0 +1,11 @@
+--- ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:03:22.000000000 +0200
++++ ../../output/build/fcgi-2.4.0/Makefile	2011-09-29 09:04:37.000000000 +0200
+@@ -171,7 +171,7 @@
+ 
+ DEFS = -DHAVE_CONFIG_H
+ DEFAULT_INCLUDES =  -I. -I$(srcdir) -I$(top_builddir)
+-LDFLAGS = 
++LDFLAGS = -lm
+ LIBS = -lnsl 
+ depcomp = $(SHELL) $(top_srcdir)/depcomp
+ DEP_FILES = $(DEPDIR)/authorizer.Po $(DEPDIR)/echo-cpp.Po \
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH 2/2 add libfcgi to buildroot

Le Thu, 29 Sep 2011 10:45:17 +0200,
Rico Bachmann <[email protected]> a ?crit :

Quoted 2 lines

added the patches, still not working
could be a problem with the filepath in the patch?

I'm sorry to say so, but: please read my e-mails. I said:

"""
Simply add them in package/fcgi/, under a name like fcgi-2.4.0-some-useful-description.patch. """

So link_math_cgifcgi.patch should be fcgi-2.0.4-link_math_cgifcgi.patch if you want the patch to be applied.

Also, here you have only sent PATCH 2/2, and this patch should be merged into the previous one to create a single patch that adds the package and its associated patches. To do so, you can do:

git rebase -i master

When the editor pops up, on the second line that corresponds to the second commit, replace "pick" by "fixup", and exit your editor. This will instruct git to merge your second commit into your first commit.

Also:

* Your two patches link_math_cgifcgi.patch and link_math_example.patch should be just one patch.

* This patch should have a description and a Signed-off-by line.

* Patching the Makefiles in an autotools-based package is really wrong, it's the Makefile.am that should be patched. I think your LDFLAGS = -lm is more a workaround than a correct fix.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 2/2 add libfcgi to buildroot

[I put Rico back in CC]

Quoted 5 lines · Thomas Petazzoni

Le Thu, 29 Sep 2011 10:45:17 +0200,

Rico Bachmann <[email protected]> a ?crit :

Quoted 2 lines

added the patches, still not working
could be a problem with the filepath in the patch?

[snip]

Quoted 4 lines

Also:

* Your two patches link_math_cgifcgi.patch and link_math_example.patch should be just one patch.

You typically generate the patch like this:

1. Make a copy of the unmodified source tree:
cp -a output/build/fcgi-2.4.0 output/build/fcgi-2.4.0.orig

2. Hack away in output/build/fcgi-2.4.0 until it works.

3. Create the patch relative to the build directory:
cd output/build
diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
../../package/fcgi/fcgi-2.4.0-add-lm.patch

4. Verify that it works by doing a clean build:
make fcgi-dirclean; make fcgi

5.

Quoted 1 line

* This patch should have a description and a Signed-off-by line.

Edit package/fcgi/fcgi-2.4.0-add-lm.patch to add these things.

The description goes in the beginning of the patch, before the first 'diff',
and explains why the patch is necessary.

The Signed-off-by line comes at the end of this patch comment. It shows that
you are the author of the patch and that you agree to distribute it under GPL. See http://kerneltrap.org/files/Jeremy/DCO.txt

Terminate the description with a line containing three dashes: ---

And look at some of the existing patches for inspiration :-)

Quoted 3 lines

* Patching the Makefiles in an autotools-based package is really wrong, it's the Makefile.am that should be patched. I think your LDFLAGS = -lm is more a workaround than a correct fix.

The Makefile will be overwritten next time you configure the package. You'll
notice that in step 4 :-). Instead, you have to modify Makefile.am. Autotools uses Makefile.am to generate Makefile.in, and configure uses Makefile.in to generate Makefile. However, buildroot normally doesn't run autotools but uses the distributed Makefile.in instead. So, you should patch both Makefile.am and Makefile.in.

6. Send your patch to the upstream project. And be prepared to get
completely different feedback from them than what you got here :-)

Good luck!

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
author
#3 lore raw

PATCH 2/2 add libfcgi to buildroot

Quoted 79 lines

-----Urspr?ngliche Nachricht-----
Von: Arnout Vandecappelle [mailto:arnout at mind.be]
Gesendet: Samstag, 1. Oktober 2011 22:59
An: buildroot at busybox.net
Cc: Thomas Petazzoni; Rico Bachmann
Betreff: Re: [Buildroot] [PATCH 2/2] add libfcgi to buildroot

[I put Rico back in CC]

Quoted 5 lines · Thomas Petazzoni

Le Thu, 29 Sep 2011 10:45:17 +0200,

Rico Bachmann <[email protected]> a ?crit :

Quoted 2 lines

added the patches, still not working
could be a problem with the filepath in the patch?

[snip]

Quoted 3 lines

Also:

* Your two patches link_math_cgifcgi.patch and

link_math_example.patch

Quoted 1 line

should be just one patch.

You typically generate the patch like this:

1. Make a copy of the unmodified source tree:
cp -a output/build/fcgi-2.4.0 output/build/fcgi-2.4.0.orig

2. Hack away in output/build/fcgi-2.4.0 until it works.

3. Create the patch relative to the build directory:
cd output/build
diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
../../package/fcgi/fcgi-2.4.0-add-lm.patch

4. Verify that it works by doing a clean build:
make fcgi-dirclean; make fcgi

5.

Quoted 1 line

* This patch should have a description and a Signed-off-by line.

Edit package/fcgi/fcgi-2.4.0-add-lm.patch to add these things.

The description goes in the beginning of the patch, before the first
'diff',
and explains why the patch is necessary.

The Signed-off-by line comes at the end of this patch comment. It
shows that
you are the author of the patch and that you agree to distribute it under GPL.
See http://kerneltrap.org/files/Jeremy/DCO.txt

Terminate the description with a line containing three dashes: ---

And look at some of the existing patches for inspiration :-)

Quoted 3 lines

* Patching the Makefiles in an autotools-based package is really wrong, it's the Makefile.am that should be patched. I think your LDFLAGS = -lm is more a workaround than a correct fix.

The Makefile will be overwritten next time you configure the package.
You'll
notice that in step 4 :-). Instead, you have to modify Makefile.am. Autotools uses Makefile.am to generate Makefile.in, and configure uses Makefile.in to generate Makefile. However, buildroot normally doesn't run
autotools but uses the distributed Makefile.in instead. So, you should patch
both Makefile.am and Makefile.in.

6. Send your patch to the upstream project. And be prepared to get
completely different feedback from them than what you got here :-)

Good luck!

Regards,
Arnout
--

Quoted 7 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR
Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

Thanks for this nice explanation.
I will fix the package in the Makefile.in and in the Makefile.am And add i nice patch with all necessary comments and signed-off-by line etc.

author
#4 lore raw

PATCH 2/2 add libfcgi to buildroot

In reply to Arnout Vandecappelle

Am 01.10.2011, 22:59 Uhr, schrieb Arnout Vandecappelle <[email protected]>:

Quoted 5 lines

3. Create the patch relative to the build directory:
cd output/build
diff -rup fcgi-2.4.0.orig fcgi-2.4.0 > \
../../package/fcgi/fcgi-2.4.0-add-lm.patch

When I try to create my patch with this command I got a fault, file or folder not found, when I
delete the backslash after the '>' it works fine. But my patch still have no effect if i try to build the
package with buildroot and use the patch automatically.

If I use my patch manual it works fine:

commands:
cd /buildroot/output/build
patch -p0 < ../../package/fcgi/fcgi-2.4.0-add-lm.patch

output:
patching file fcgi-2.4.0/cgi-fcgi/Makefile.in patching file fcgi-2.4.0/examples/Makefile.in

After that I can build the package (of course only without a make fcgi-dirclean)

Here is the output form buildroot while using the patch:

>>> fcgi 2.4.0 Patching packages/fcgi
for file in config.guess config.cub; do for i $(find

/buildroot/output/build/fcgi-2.4.0 -name $file);
       do cp package/gnuconfig/$file $i;
       done; done

After that, the build still failed.

#5 lore raw

PATCH 2/2 add libfcgi to buildroot

Quoted 7 lines · Rico Bachmann

Here is the output form buildroot while using the patch:

>>> fcgi 2.4.0 Patching packages/fcgi
for file in config.guess config.cub; do for i $(find

/buildroot/output/build/fcgi-2.4.0 -name $file);
       do cp package/gnuconfig/$file $i;
       done; done

Weird, you should get

Quoted 1 line
Quoted 1 line
Quoted 1 line

fcgi 2.4.0 Updating config.sub and config.guess

before the 'for'.

And of course, you should get
Applying fcgi-2.4.0-add-lm.patch using plaintext:
before that one.

That file does exist in the package/fcgi directory, right? It's not that the
patch ended up in a completely different place?

Regards,
Arnout

Signature · 9 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111011/f2cde576/attachment.html>
author
#6 lore raw

PATCH 2/2 add libfcgi to buildroot

Am 11.10.2011, 18:06 Uhr, schrieb Arnout Vandecappelle <[email protected]>:

Quoted 14 lines · Rico Bachmann
Quoted 7 lines

Here is the output form buildroot while using the patch:

>>> fcgi 2.4.0 Patching packages/fcgi
for file in config.guess config.cub; do for i $(find

/buildroot/output/build/fcgi-2.4.0 -name $file);
       do cp package/gnuconfig/$file $i;
       done; done

Weird, you should get

Quoted 1 line
Quoted 1 line
Quoted 1 line

fcgi 2.4.0 Updating config.sub and config.guess

before the 'for'.

Quoted 7 lines

And of course, you should get
Applying fcgi-2.4.0-add-lm.patch using plaintext:
before that one.

That file does exist in the package/fcgi directory, right? It's not
that the
patch ended up in a completely different place?

yes the file exists in package/fcgi and has 777 rights

Quoted 4 lines

Regards,
Arnout

#7 lore raw

PATCH 2/2 add libfcgi to buildroot

Quoted 1 line · Rico Bachmann

yes the file exists in package/fcgi and has 777 rights

Silly me, I just now saw that the package is called libfcgi, not fcgi. So it should of course be in the package/libfcgi directory and it should be called libfcgi-....patch.

Anyway, there's a better solution: add -lm in the LDFLAGS of the configure environment.

I'll just send a patch with the complete libfcgi support as a follow-up of this mail.

Regards,
Arnout

Signature · 9 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/608b7d0d/attachment.html>
#8 lore raw

PATCH 1/1 package: add libfcgi fast cgi library.

From: Rico Bachmann <[email protected]>

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signed-off-by Rico Bachmann <[email protected]>
---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    6 ++++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk
package/Config.in +1 -0
index 7dc8887..76c89c7 100644
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
package/libfcgi/Config.in new file +6 -0
new file mode 100644
index 0000000..a2f448b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBFCGI
+    bool "libfcgi"
+    help
+        This is a fastcgi developer library for C/C++
+        http://www.fastcgi.com/
+
package/libfcgi/libfcgi.mk new file +12 -0
new file mode 100644
index 0000000..72bbf9a
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS,package,libfcgi))
Signature · 1 line
1.7.7
#9 lore raw

PATCH 1/1 package: add libfcgi fast cgi library.

Le Fri, 14 Oct 2011 00:46:59 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> a ?crit :

package/libfcgi/Config.in line 3

Quoted 3 lines
package/libfcgi/Config.in new file +3 -0
+config BR2_PACKAGE_LIBFCGI
+    bool "libfcgi"
+    help

One tab.

package/libfcgi/Config.in line 5

Quoted 2 lines
package/libfcgi/Config.in new file +2 -0
+        This is a fastcgi developer library for C/C++
+        http://www.fastcgi.com/

One tab + two spaces.

Quoted 8 lines
package/libfcgi/libfcgi.mk new file +2 -0
new file mode 100644
index 0000000..72bbf9a
@@ -0,0 +1,12 @@
+##############################################################################
+#

package/libfcgi/libfcgi.mk line 12

Quoted 10 lines
package/libfcgi/libfcgi.mk new file +10 -0
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS,package,libfcgi))

$(eval $(call AUTOTARGETS))

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#10 lore raw

PATCH v2 1/1 package: add libfcgi fast cgi library.

From: Rico Bachmann <[email protected]>

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signed-off-by Rico Bachmann <[email protected]>

---
Changes v2: corrected indentation of Config.in, removed redundant arguments of AUTOTARGETS.

---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    6 ++++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk
package/Config.in +1 -0
index 7dc8887..76c89c7 100644
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
package/libfcgi/Config.in new file +6 -0
new file mode 100644
index 0000000..a2f448b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBFCGI
+    bool "libfcgi"
+    help
+        This is a fastcgi developer library for C/C++
+        http://www.fastcgi.com/
+
package/libfcgi/libfcgi.mk new file +12 -0
new file mode 100644
index 0000000..72bbf9a
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS,package,libfcgi))
Signature · 1 line
1.7.7
#11 lore raw

PATCH v2 1/1 package: add libfcgi fast cgi library.

Hello,

Le Fri, 14 Oct 2011 09:59:51 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> a ?crit :

Quoted 7 lines

From: Rico Bachmann <[email protected]>

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signed-off-by Rico Bachmann <[email protected]>

---
Changes v2: corrected indentation of Config.in, removed redundant arguments of AUTOTARGETS.

I guess you did something wrong, because none of these things are part of this new patch :-)

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#12 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

From: Rico Bachmann <[email protected]>

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signed-off-by Rico Bachmann <[email protected]>

---
Changes v3: now actually included the changes v2 (forgot the -a to git commit :-)

Changes v2: corrected indentation of Config.in, removed redundant arguments of AUTOTARGETS.

---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    5 +++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk
package/Config.in +1 -0
index 7dc8887..76c89c7 100644
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
package/libfcgi/Config.in new file +5 -0
new file mode 100644
index 0000000..b31f06b
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBFCGI
+	bool "libfcgi"
+	help
+	  FCGI, a fastcgi developer library for C/C++
+	  http://www.fastcgi.com/
package/libfcgi/libfcgi.mk new file +12 -0
new file mode 100644
index 0000000..4625165
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.7
author
#13 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Ping

Can this patch be commited?
Or is there something to do first?

e.g. rename to fcgi to avoid the LIBFCGI_SOURCE makro?

Am 14.10.2011, 11:16 Uhr, schrieb Arnout Vandecappelle (Essensium/Mind) <[email protected]>:

Quoted 61 lines

From: Rico Bachmann <[email protected]>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signed-off-by: Rico Bachmann <[email protected]>
---
Changes v3: now actually included the changes v2 (forgot the -a to git commit :-)

Changes v2: corrected indentation of Config.in, removed redundant arguments of AUTOTARGETS.

---
 package/Config.in          |    1 +
 package/libfcgi/Config.in  |    5 +++++
 package/libfcgi/libfcgi.mk |   12 ++++++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/libfcgi/Config.in
 create mode 100644 package/libfcgi/libfcgi.mk
package/Config.in +1 -0
index 7dc8887..76c89c7 100644
@@ -327,6 +327,7 @@ source "package/libcgicc/Config.in"
 source "package/libcurl/Config.in"
 source "package/libdnet/Config.in"
 source "package/libeXosip2/Config.in"
+source "package/libfcgi/Config.in"
 source "package/libidn/Config.in"
 source "package/libmicrohttpd/Config.in"
 source "package/neon/Config.in"
package/libfcgi/Config.in new file +5 -0
new file mode 100644
index 0000000..b31f06b
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBFCGI
+	bool "libfcgi"
+	help
+	  FCGI, a fastcgi developer library for C/C++
+	  http://www.fastcgi.com/
package/libfcgi/libfcgi.mk new file +12 -0
new file mode 100644
index 0000000..4625165
@@ -0,0 +1,12 @@
+##############################################################################
+#
+# libfcgi
+#
+##############################################################################
+LIBFCGI_VERSION = 2.4.0
+LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
+LIBFCGI_SITE = http://www.fastcgi.com/dist
+LIBFCGI_INSTALL_STAGING = YES
+LIBFCGI_CONF_ENV = LDFLAGS="$(TARGET_LDFLAGS) -lm"
+
+$(eval $(call AUTOTARGETS))
#14 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Quoted 8 lines · On Wednesday 25 April 2012 12:24:04 Rico Bachmann wrote:

Ping

Can this patch be commited?
Or is there something to do first?

e.g. rename to fcgi to avoid the LIBFCGI_SOURCE makro?

Am 14.10.2011, 11:16 Uhr, schrieb Arnout Vandecappelle (Essensium/Mind)

Since this is so long ago, it's better to repost the patch.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#15 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Arnout> From: Rico Bachmann <[email protected]>
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> Signed-off-by: Rico Bachmann <[email protected]>

Committed, thanks both.

Signature · 1 line
Bye, Peter Korsgaard
author
#16 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Hi together

I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3 I had some problems while building libfcgi with gcc 4.5.3! There was an error: EOF is undefined.

This issue is already known on the libfcgi mailinglist:
http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

I will add this patch to buildroot asap.

Is there in BR a nice possibility to use a patch from a package only when gcc >=4.4.X?

And how do I have to handle the patch because its written by Markus from the libfcgi mailing list and not by myself?

Regards Rico

Quoted 11 lines

-----Urspr?ngliche Nachricht-----
Von: Peter Korsgaard [mailto:jacmet at gmail.com] Im Auftrag von Peter Korsgaard
Gesendet: Sonntag, 29. April 2012 20:38
An: Arnout Vandecappelle (Essensium/Mind)
Cc: buildroot at busybox.net; Rico Bachmann
Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind)

<[email protected]> writes:

Quoted 8 lines

Arnout> From: Rico Bachmann <[email protected]> Arnout> Signed-

off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout>
Signed-off-by Rico Bachmann <[email protected]>

Committed, thanks both.

--
Bye, Peter Korsgaard

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

author
#17 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Am 30.04.2012, 16:13 Uhr, schrieb Rico Bachmann
<[email protected]>:

Quoted 6 lines

Hi together

I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3 I had some problems while building libfcgi with gcc 4.5.3! There was an error: EOF is undefined.

Quoted 7 lines

This issue is already known on the libfcgi mailinglist:
http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

I will add this patch to buildroot asap.

Is there in BR a nice possibility to use a patch from a package only when gcc >=4.4.X?

if BR2_GCC_VERSION_4_4_X | BR2_GCC_VERSION_4_3_X
LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
endif

maybe something like that?

Quoted 33 lines

And how do I have to handle the patch because its written by Markus from the libfcgi mailing list and not by myself?

Regards Rico

Quoted 20 lines

-----Urspr?ngliche Nachricht-----
Von: Peter Korsgaard
[mailto:jacmet at gmail.com] Im Auftrag von
Peter
Korsgaard
Gesendet: Sonntag, 29. April 2012 20:38
An: Arnout Vandecappelle (Essensium/Mind)
Cc: buildroot at busybox.net; Rico Bachmann
Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind)

<[email protected]> writes:

Arnout> From: Rico Bachmann
<[email protected]> Arnout> Signed-
off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout>
Signed-off-by: Rico Bachmann <[email protected]>

Quoted 4 lines

Committed, thanks both.

--
Bye, Peter Korsgaard

Mit freundlichen Gr?ssen

Quoted 7 lines

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

author
#18 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Am 30.04.2012, 16:23 Uhr, schrieb Rico Bachmann
<[email protected]>:

Quoted 12 lines

Am 30.04.2012, 16:13 Uhr, schrieb Rico Bachmann
<[email protected]>:

Quoted 9 lines

Hi together

I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3 I had some problems while building libfcgi with gcc 4.5.3! There was an error: EOF is undefined.

This issue is already known on the libfcgi mailinglist:
http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

Quoted 8 lines
Quoted 4 lines

I will add this patch to buildroot asap.

Is there in BR a nice possibility to use a patch from a package only when gcc >=4.4.X?

if BR2_GCC_VERSION_4_4_X | BR2_GCC_VERSION_4_3_X
LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
endif

I made some mistakes while thinking about this problem... if it is possible that way then it should be something like this:

if !BR2_GCC_VERSION_4_3_X
LIBFCGI_POST_BUILD_HOOKS="mypatch.patch"
endif

Quoted 46 lines

maybe something like that?

Quoted 33 lines

And how do I have to handle the patch because its written by Markus from the libfcgi mailing list and not by myself?

Regards Rico

Quoted 20 lines

-----Urspr?ngliche Nachricht-----
Von: Peter Korsgaard
[mailto:jacmet at gmail.com] Im Auftrag von
Peter
Korsgaard
Gesendet: Sonntag, 29. April 2012 20:38
An: Arnout Vandecappelle (Essensium/Mind)
Cc: buildroot at busybox.net; Rico Bachmann
Betreff: Re: [PATCH v3] package: add libfcgi fast cgi library.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind)

<[email protected]> writes:

Arnout> From: Rico Bachmann
<[email protected]> Arnout> Signed-
off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout>
Signed-off-by: Rico Bachmann <[email protected]>

Quoted 4 lines

Committed, thanks both.

--
Bye, Peter Korsgaard

Mit freundlichen Gr?ssen

Quoted 7 lines

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

Mit freundlichen Gr?ssen

Quoted 7 lines

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

Mit freundlichen Gr?ssen

Tofwerk AG, Rico Bachmann

+41 33 511 11 69
bachmann at tofwerk.com
http://www.tofwerk.com
Uttigenstrasse 22
CH - 3600 Thun

#19 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

In reply to Rico Bachmann
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Rico" == Rico Bachmann <[email protected]> writes:

Rico> Hi together
Rico> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3 Rico> I had some problems while building libfcgi with gcc 4.5.3! Rico> There was an error: EOF is undefined.

Ahh, yes - I only tested with a precompiled 4.3.x toolchain.

Rico> This issue is already known on the libfcgi mailinglist:
Rico> http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

Rico> I will add this patch to buildroot asap.

Rico> Is there in BR a nice possibility to use a patch from a package only Rico> when gcc >=4.4.X?

No, but there's no reason to not add it for older toolchains as well.

Rico> And how do I have to handle the patch because its written by Rico> Markus from the libfcgi mailing list and not by myself?

Keep his authorship (git-style patch has this in the header), but with your signed-off-by.

Signature · 1 line
Bye, Peter Korsgaard
author
#20 lore raw

PATCH v3 1/1 package: add libfcgi fast cgi library.

Am 30.04.2012, 19:11 Uhr, schrieb Peter Korsgaard
<[email protected]>:

Quoted 9 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Rico" == Rico Bachmann
<[email protected]> writes:

Rico> Hi together
Rico> I was using gcc 4.3.X until now... Today I changed to gcc 4.5.3 Rico> I had some problems while building libfcgi with gcc 4.5.3! Rico> There was an error: EOF is undefined.

Ahh, yes - I only tested with a precompiled 4.3.x toolchain.

I've got the same situation, first I've just tested with the precompiled toolchain.

Quoted 11 lines

Rico> This issue is already known on the libfcgi mailinglist:
Rico>
http://article.gmane.org/gmane.comp.web.fastcgi.devel/3205/match=eof

Rico> I will add this patch to buildroot asap.

Rico> Is there in BR a nice possibility to use a patch from a package
only
Rico> when gcc >=4.4.X?

Quoted 8 lines

No, but there's no reason to not add it for older toolchains as well.

Rico> And how do I have to handle the patch because its written by Rico> Markus from the libfcgi mailing list and not by myself?

Keep his authorship (git-style patch has this in the header), but with your signed-off-by.

Thanks for the information.
I will add the patch this way.

Regards
Rico