ALSA: usb-audio: Initialize status1 to fix uninitialized symbol errors
PATCH v2 1/1 ALSA: usb-audio: Initialize status1 to fix uninitialized symbol errors
From: HariKrishna Sagala <[email protected]>
Initialize 'status1' with a default value to resolve the static analysis smatch reported error "uninitialized symbol 'status1'".
The 'status1' variable is used to create a buff using "kmemdup". So, ensure to initialize the value before it is read.
---
This patch fixes the below smatch reported errors.sound/usb/mixer_quirks.c:2462 snd_rme_rate_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2467 snd_rme_rate_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2472 snd_rme_rate_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2495 snd_rme_sync_state_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2501 snd_rme_sync_state_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2522 snd_rme_spdif_if_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2535 snd_rme_spdif_format_get() error: uninitialized symbol 'status1'. sound/usb/mixer_quirks.c:2548 snd_rme_sync_source_get() error: uninitialized symbol 'status1'.
The below is the flow of 'status1' it is used before initialization.
snd_rme_rate_get -> status1 is uninitialized and passed
snd_rme_get_status1 -> passed as is
snd_rme_read_value -> passed as is
snd_usb_ctl_msg -> created buf from status1 using kmemdup
usb_control_msg -> sent buf for reading/writingDescription of "usb_control_msg", states as
" * @data: pointer to the data to send"
Later from Usb control request, dst buf is copied to src buf but usb control msg request is made before initialization.
All the above warning reported functions, call snd_rme_get_status1().
v2:
Corrected as suggested by Takashi Iwai to silence the warnings from callee side as it can reduce number of changes.
v1:
https://lore.kernel.org/all/[email protected]/
Thank you.
sound/usb/mixer_quirks.c | 1 + 1 file changed, 1 insertion(+)
sound/usb/mixer_quirks.c +1 -0
@@ -2440,6 +2440,7 @@ static int snd_rme_get_status1(struct snd_kcontrol *kcontrol,struct usb_mixer_elem_list *list =snd_kcontrol_chip (kcontrol);struct snd_usb_audio *chip = list->mixer->chip; + *status1 =0 ;CLASS (snd_usb_lock, pm)(chip);if (pm.err <0 )return pm.err;
base-commit: 4a26e7032d7d57c998598c08a034872d6f0d3945
Signature · 1 line
2.43.0
Quoted 10 lines · On Thu, 04 Dec 2025 06:22:03 +0100, [email protected] wrote:
From: HariKrishna Sagala <[email protected]>
Initialize 'status1' with a default value to resolve the static analysis smatch reported error "uninitialized symbol 'status1'".
The 'status1' variable is used to create a buff using "kmemdup". So, ensure to initialize the value before it is read.Suggested-by Takashi Iwai <[email protected]>Signed-off-by HariKrishna Sagala <[email protected]>
Applied now. Thanks.
Takashi