Skip to contentSkip to conversation

ALSA/hda: intel-sdw-acpi: Correct sdw_intel_acpi_scan() function parameter

PATCH Applied Peter Ujfalusi 2 participants 2 messages May 8, 2025 – May 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA/hda: intel-sdw-acpi: Correct sdw_intel_acpi_scan() function parameter

The acpi_handle should be just a handle and not a pointer in sdw_intel_acpi_scan() parameter list.
It is called with 'acpi_handle handle' as parameter and it is passing it to acpi_walk_namespace, which also expects acpi_handle and not acpi_handle*

---
 include/linux/soundwire/sdw_intel.h | 2 +-
 sound/hda/intel-sdw-acpi.c          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/soundwire/sdw_intel.h +1 -1
index 493d9de4e472..dc6ebaee3d18 100644
@@ -365,7 +365,7 @@ struct sdw_intel_res {
  * on e.g. which machine driver to select (I2S mode, HDaudio or
  * SoundWire).
  */
-int sdw_intel_acpi_scan(acpi_handle *parent_handle,
+int sdw_intel_acpi_scan(acpi_handle parent_handle,
 			struct sdw_intel_acpi_info *info);
 
 void sdw_intel_process_wakeen_event(struct sdw_intel_ctx *ctx);
sound/hda/intel-sdw-acpi.c +1 -1
index 8686adaf4531..d3511135f7d3 100644
@@ -177,7 +177,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
  * sdw_intel_startup() is required for creation of devices and bus
  * startup
  */
-int sdw_intel_acpi_scan(acpi_handle *parent_handle,
+int sdw_intel_acpi_scan(acpi_handle parent_handle,
 			struct sdw_intel_acpi_info *info)
 {
 	acpi_status status;
Signature · 1 line
2.49.0
Applied
#1 lore raw
Quoted 10 lines · Peter Ujfalusi

The acpi_handle should be just a handle and not a pointer in sdw_intel_acpi_scan() parameter list.
It is called with 'acpi_handle handle' as parameter and it is passing it to acpi_walk_namespace, which also expects acpi_handle and not acpi_handle*

Thanks, applied now.

Takashi