drm/xe: Reduce flickering when inheriting BIOS fb.
v3 cover drm/xe: Reduce flickering when inheriting BIOS fb.
It turns out that xe is performing all kinds of allocations before inheriting the BIOS fb. This is problematic as it completely overwrites the initial FB on discrete, and on integrated causes flickering until the original FB is restored (preserved in stolen memory).
The complete fix requires reshuffling the entire init sequence. I want to do that, but first add some preparations. This way I don't need to resubmit all these patches that are ready to commit each time.
Maarten Lankhorst (12):
drm/xe/display: Handle stolen bar readout in the same way as lmem drm/xe: Remove double pageflip
drm/i915/display: Use async flip when available for initial plane
config
drm/xe/display: Remove single wait for vblank
drm/xe: Move suballocator init to after display init drm/xe: Use xe_ggtt_map_bo_unlocked for resume
drm/xe: Add xe_ggtt_might_lock
drm/xe: Add xe_ggtt_alloc
drm/xe: Abstract read/write functions for GGTT PTEs drm/xe: Make xe_ggtt_pt_ops private
drm/xe/display: Stop dereferencing ggtt in xe_fb_pin drm/xe: Move struct xe_ggtt to xe_ggtt.c
.../drm/i915/display/skl_universal_plane.c | 13 +- drivers/gpu/drm/xe/display/xe_fb_pin.c | 36 ++--- drivers/gpu/drm/xe/display/xe_plane_initial.c | 27 +--- drivers/gpu/drm/xe/xe_bo.c | 2 +- drivers/gpu/drm/xe/xe_bo_evict.c | 9 +- drivers/gpu/drm/xe/xe_device.c | 6 + drivers/gpu/drm/xe/xe_ggtt.c | 141 +++++++++++++++++- drivers/gpu/drm/xe/xe_ggtt.h | 22 ++- drivers/gpu/drm/xe/xe_ggtt_types.h | 50 +------ drivers/gpu/drm/xe/xe_tile.c | 16 +- drivers/gpu/drm/xe/xe_tile.h | 1 + 11 files changed, 218 insertions(+), 105 deletions(-)
Signature · 1 line
2.45.2
PATCH v3 1/12 drm/xe/display: Handle stolen bar readout in the same way as lmem
i915 already does this, we should do the same for Xe.
--- drivers/gpu/drm/xe/display/xe_plane_initial.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/display/xe_plane_initial.c +6 -3
@@ -69,7 +69,7 @@ initial_plane_bo(struct xe_device *xe, flags =XE_BO_FLAG_PINNED |XE_BO_FLAG_SCANOUT |XE_BO_FLAG_GGTT ; base =round_down (plane_config->base, page_size); -if (IS_DGFX (xe)) { +if (IS_DGFX (xe) ||GRAPHICS_VERx100 (xe) >=1270 ) {u64 __iomem *gte = tile0->mem.ggtt->gsm;u64 pte;
@@ -83,7 +83,6 @@ initial_plane_bo(struct xe_device *xe, } phys_base = pte & ~(page_size -1 ); - flags |=XE_BO_FLAG_VRAM0 ;/* * We don't currently expect this to ever be placed in the
@@ -105,7 +104,6 @@ initial_plane_bo(struct xe_device *xe,if (!stolen)return NULL ; phys_base = base; - flags |=XE_BO_FLAG_STOLEN ; if (XE_WA(xe_root_mmio_gt(xe), 22019338487_display))return NULL ;
@@ -120,6 +118,11 @@ initial_plane_bo(struct xe_device *xe,return NULL ; } +if (IS_DGFX (xe)) + flags |=XE_BO_FLAG_VRAM0 ; +else + flags |=XE_BO_FLAG_STOLEN ; + size =round_up (plane_config->base + plane_config->size, page_size); size -= base;
Signature · 1 line
2.45.2
Re: [PATCH v3 01/12] drm/xe/display: Handle stolen bar readout in the same way as lmem
Quoted 12 lines · Maarten Lankhorst
i915 already does this, we should do the same for Xe.
Signed-off-by Maarten Lankhorst <[email protected]>---
drivers/gpu/drm/xe/display/xe_plane_initial.c| 9 ++++++---1 file changed, 6 insertions(+), 3 deletions(-)drivers/gpu/drm/xe/display/xe_plane_initial.c +0
-0
drivers/gpu/drm/xe/display/xe_plane_initial.c initial_plane_bo(struct xe_device *xe, · line 72
Quoted 5 lines
drivers/gpu/drm/xe/display/xe_plane_initial.c +1
-1@@ -69,7 +69,7 @@ initial_plane_bo(struct xe_device *xe, flags =XE_BO_FLAG_PINNED |XE_BO_FLAG_SCANOUT |XE_BO_FLAG_GGTT ; base =round_down (plane_config->base, page_size); -if (IS_DGFX (xe)) { +if (IS_DGFX (xe) ||GRAPHICS_VERx100 (xe) >=1270 ) {
and with this you just dropped Wa 22019338487 from e.g. LNL.
Also, making igfx going through this path is very odd when it has checks like phys_base >= mem.vram.usable_size
Lucas De Marchi
Quoted 34 lines
drivers/gpu/drm/xe/display/xe_plane_initial.c +5
-2u64 __iomem *gte = tile0->mem.ggtt->gsm;u64 pte;@@ -83,7 +83,6 @@ initial_plane_bo(struct xe_device *xe, } phys_base = pte & ~(page_size -1 ); - flags |=XE_BO_FLAG_VRAM0 ;/* * We don't currently expect this to ever be placed in the @@ -105,7 +104,6 @@ initial_plane_bo(struct xe_device *xe,if (!stolen)return NULL ; phys_base = base; - flags |=XE_BO_FLAG_STOLEN ; if (XE_WA(xe_root_mmio_gt(xe), 22019338487_display))return NULL ;@@ -120,6 +118,11 @@ initial_plane_bo(struct xe_device *xe,return NULL ; } +if (IS_DGFX (xe)) + flags |=XE_BO_FLAG_VRAM0 ; +else + flags |=XE_BO_FLAG_STOLEN ; + size =round_up (plane_config->base + plane_config->size, page_size); size -= base;Signature · 1 line
2.45.2
PATCH v3 2/12 drm/xe: Remove double pageflip
In reply to Maarten LankhorstThis is already handled below by fixup_initial_plane_config.
--- drivers/gpu/drm/xe/display/xe_plane_initial.c | 9 --------- 1 file changed, 9 deletions(-)
drivers/gpu/drm/xe/display/xe_plane_initial.c +0 -9
@@ -197,8 +197,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,to_intel_plane (crtc->base.primary);struct intel_plane_state *plane_state =to_intel_plane_state (plane->base.state); -struct intel_crtc_state *crtc_state = -to_intel_crtc_state (crtc->base.state);struct drm_framebuffer *fb;struct i915_vma *vma;
@@ -245,13 +243,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc, plane_config->vma = vma; -/* -* Flip to the newly created mapping ASAP, so we can re-use the -* first part of GGTT for WOPCM, prevent flickering, and prevent -* the lookup of sysmem scratch pages. -*/ - plane->check_plane (crtc_state, plane_state); - plane->async_flip (plane, crtc_state, plane_state, true);return ; nofb:
Signature · 1 line
2.45.2
Re: [PATCH v3 02/12] drm/xe: Remove double pageflip
Quoted 8 lines · Maarten Lankhorst
This is already handled below by
fixup_initial_plane_config.Signed-off-by Maarten Lankhorst <[email protected]>Fixes a8153627520a ("drm/i915: Try to relocate the BIOS fb to the start of ggtt")Cc Ville Syrjälä <[email protected]>---
drivers/gpu/drm/xe/display/xe_plane_initial.c | 9 ---------1 file changed, 9 deletions(-)
I had the same change as part of some other BMG bug analysis. But was never merged upstream!
(https://patchwork.freedesktop.org/patch/590387/?series=132649&rev=2)
Anyway, I think this change as part of this series could go instead.
Quoted 29 lines
drivers/gpu/drm/xe/display/xe_plane_initial.c +0
-0@@ -197,8 +197,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc, to_intel_plane(crtc->base.primary);struct
intel_plane_state*plane_state=to_intel_plane_state(plane->base.state); - structintel_crtc_state*crtc_state=
- to_intel_crtc_state(crtc->base.state); structdrm_framebuffer*fb;
structi915_vma*vma;drivers/gpu/drm/xe/display/xe_plane_initial.c +0
-0@@ -245,13 +243,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
plane_config->vma = vma;
- /*
- * Flip to the newly created mapping ASAP, so we can re-use the - * first part of GGTT for WOPCM, prevent flickering, and prevent - * the lookup of sysmem scratch pages.
- */
- plane->check_plane(crtc_state,plane_state);
- plane->async_flip(plane,crtc_state,plane_state, true); return;
nofb:
PATCH v3 3/12 drm/i915/display: Use async flip when available for initial plane config
In reply to Maarten LankhorstI'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/skl_universal_plane.c +11 -2
@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;
@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false; +/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; + +intel_de_write (i915,PLANE_CTL (pipe, plane_id), plane_ctl);intel_de_write (i915,PLANE_SURF (pipe, plane_id), base); -return true; +if (intel_de_wait_custom (i915,PLANE_SURFLIVE (pipe, plane_id), ~0U , base,0 ,40 ,NULL ) <0 ) +drm_warn (&i915->drm,"async flip timed out\n" ); + +/* No need to vblank wait either */ +return false; }
Signature · 1 line
2.45.2
Jani Nikula
maintainerRe: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
Quoted 27 lines · Maarten Lankhorst
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
Signed-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +1
-1@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false;
drivers/gpu/drm/i915/display/skl_universal_plane.c bool skl_fixup_initial_plane_config(struct intel_crtc *crtc, · line 2824
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +6
-1+/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; + +intel_de_write (i915,PLANE_CTL (pipe, plane_id), plane_ctl);intel_de_write (i915,PLANE_SURF (pipe, plane_id), base); -return true; +if (intel_de_wait_custom (i915,PLANE_SURFLIVE (pipe, plane_id), ~0U , base,0 ,40 ,NULL ) <0 )
Why not just intel_de_wait()?
BR,
Jani.
Quoted 5 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +4
-0+drm_warn (&i915->drm,"async flip timed out\n" ); + +/* No need to vblank wait either */ +return false; }
Signature · 1 line
Jani Nikula, Intel
Re: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
Den 2024-10-03 kl. 17:58, skrev Jani Nikula:
Quoted 36 lines · Maarten Lankhorst
Quoted 35 lines
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
Signed-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +6
-1@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false; +/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; + +intel_de_write (i915,PLANE_CTL (pipe, plane_id), plane_ctl);intel_de_write (i915,PLANE_SURF (pipe, plane_id), base);
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c bool skl_fixup_initial_plane_config(struct intel_crtc *crtc, · line 2824
Quoted 2 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +1
-1-return true; +if (intel_de_wait_custom (i915,PLANE_SURFLIVE (pipe, plane_id), ~0U , base,0 ,40 ,NULL ) <0 )Why not just
intel_de_wait()?BR,
Jani.
Yes, I overlooked that when I was browsing through intel_de.h :-)
Can respin if we agree on the direction.
Cheers,
~Maarten
Re: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
In reply to Maarten LankhorstQuoted 25 lines · Maarten Lankhorst
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
Signed-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +1
-1@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;
drivers/gpu/drm/i915/display/skl_universal_plane.c bool skl_fixup_initial_plane_config(struct intel_crtc *crtc, · line 2820
Quoted 7 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +4
-0@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false; +/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; +
No async flips!
Quoted 12 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +6
-1+intel_de_write (i915,PLANE_CTL (pipe, plane_id), plane_ctl);intel_de_write (i915,PLANE_SURF (pipe, plane_id), base); -return true; +if (intel_de_wait_custom (i915,PLANE_SURFLIVE (pipe, plane_id), ~0U , base,0 ,40 ,NULL ) <0 ) +drm_warn (&i915->drm,"async flip timed out\n" ); + +/* No need to vblank wait either */ +return false; }Signature · 1 line
2.45.2
Signature · 2 lines
Ville Syrjälä Intel
Re: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
Hello,
Den 2024-10-03 kl. 18:14, skrev Ville Syrjälä:
Quoted 29 lines · Maarten Lankhorst
Quoted 28 lines
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
Signed-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +1
-1@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false;
Quoted 6 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c bool skl_fixup_initial_plane_config(struct intel_crtc *crtc, · line 2820
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +4
-0+/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; +No async flips!
Can you please explain your reasoning? I think async flip would fit perfectly here. We cannot perform a wait_for_vblank as we will not have interrupts enabled yet. Additionally an async flip would cause a faster driver loading. Since the FB is exactly the same except set to a different address, no tearing will occur.
Cheers,
~Maarten
Re: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
Quoted 32 lines · Maarten Lankhorst
Hello,
Den 2024-10-03 kl. 18:14, skrev Ville Syrjälä:
Quoted 29 lines · Maarten Lankhorst
Quoted 28 lines
I'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
Signed-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/skl_universal_plane.c +1
-1@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false;
Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c bool skl_fixup_initial_plane_config(struct intel_crtc *crtc, · line 2820
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_universal_plane.c +4
-0+/* Perform an async flip to the new surface. */ + plane_ctl =intel_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; +No async flips!
Can you please explain your reasoning?
Async flips are special. They have all kinds of random hardware limitations.
Quoted 3 lines
I think async flip would fit
perfectly here. We cannot perform await_for_vblankas we will not have interrupts enabled yet.
The type of flip is irrelevant when you just poll until it's done.
Quoted 3 lines
Additionally an async flip would cause a faster
driver loading. Since the FB is exactly the same except set to a different address, no tearing will occur.
Until we violate some hardware requirement and you get a fault.
Signature · 2 lines
Ville Syrjälä Intel
kernel test robot
build botRe: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config
In reply to Maarten Lankhorstkernel test robot noticed the following build errors:
Hi Maarten,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.12-rc1] [cannot apply to next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-xe-display-Handle-stolen-bar-readout-in-the-same-way-as-lmem/20241004-000534 base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next patch link: https://lore.kernel.org/r/20241003154421.33805-4-maarten.lankhorst%40linux.intel.com patch subject: [PATCH v3 03/12] drm/i915/display: Use async flip when available for initial plane config config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20241004/[email protected]/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/skl_universal_plane.c:2814:14: error: call to undeclared function 'intel_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2814 | plane_ctl = intel_read(i915, PLANE_CTL(pipe, plane_id));
| ^1 error generated.
vim +/intel_read +2814 drivers/gpu/drm/i915/display/skl_universal_plane.c
2789
2790 bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,
2791 const struct intel_initial_plane_config *plane_config)
2792 {
2793 struct drm_i915_private *i915 = to_i915(crtc->base.dev);
2794 struct intel_plane *plane = to_intel_plane(crtc->base.primary);
2795 const struct intel_plane_state *plane_state =
2796 to_intel_plane_state(plane->base.state);
2797 enum plane_id plane_id = plane->id;
2798 enum pipe pipe = crtc->pipe;
2799 u32 base, plane_ctl;
2800
2801 if (!plane_state->uapi.visible)
2802 return false;
2803
2804 base = intel_plane_ggtt_offset(plane_state);
2805
2806 /*
2807 * We may have moved the surface to a different
2808 * part of ggtt, make the plane aware of that.
2809 */
2810 if (plane_config->base == base)
2811 return false;
2812
2813 /* Perform an async flip to the new surface. */
> 2814 plane_ctl = intel_read(i915, PLANE_CTL(pipe, plane_id));
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v3 3/12 drm/i915/display: Use async flip when available for initial plane config
In reply to Maarten LankhorstI'm planning to reorder readout in the Xe sequence in such a way that interrupts will not be available, so just use an async flip.
Since the new FB points to the same pages, it will not tear. It also has the benefit of perhaps being slightly faster.
---
Fix compiler fails..
Change intel_de_wait_custom to normal variant.
I still believe we should be fine with async flips. The buffer will not be a standard RGBX8888 on the first plane. If we violate a constraint, it will be from alignment, and for that it would be interesting to find any border cases we missed.
drivers/gpu/drm/i915/display/skl_universal_plane.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/skl_universal_plane.c +11 -2
@@ -2800,7 +2800,7 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,to_intel_plane_state (plane->base.state);enum plane_id plane_id = plane->id;enum pipe pipe = crtc->pipe; -u32 base; +u32 base, plane_ctl;if (!plane_state->uapi.visible)return false;
@@ -2814,7 +2814,16 @@ bool skl_fixup_initial_plane_config(struct intel_crtc *crtc,if (plane_config->base == base)return false; +/* Perform an async flip to the new surface. */ + plane_ctl =intel_de_read (i915,PLANE_CTL (pipe, plane_id)); + plane_ctl |=PLANE_CTL_ASYNC_FLIP ; + +intel_de_write (i915,PLANE_CTL (pipe, plane_id), plane_ctl);intel_de_write (i915,PLANE_SURF (pipe, plane_id), base); -return true; +if (intel_de_wait (i915,PLANE_SURFLIVE (pipe, plane_id), ~0U , base,40 ) <0 ) +drm_warn (&i915->drm,"async flip timed out\n" ); + +/* No need to vblank wait either */ +return false; }
Signature · 1 line
2.45.2
PATCH v3 4/12 drm/xe/display: Remove single wait for vblank
In reply to Maarten LankhorstNow that i915/display is using async flip waits, we can remove the vblank handling from xe. This makes the initial allocation code no longer require interrupts.
--- drivers/gpu/drm/xe/display/xe_plane_initial.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/xe/display/xe_plane_initial.c +1 -2
@@ -296,8 +296,7 @@ void intel_initial_plane_config(struct drm_i915_private *i915)*/ intel_find_initial_plane_obj (crtc, plane_configs); -if (i915->display.funcs.display->fixup_initial_plane_config (crtc, plane_config)) -intel_crtc_wait_for_next_vblank (crtc); + i915->display.funcs.display->fixup_initial_plane_config (crtc, plane_config);plane_config_fini (plane_config); }
Signature · 1 line
2.45.2
PATCH v3 5/12 drm/xe: Move suballocator init to after display init
In reply to Maarten LankhorstNo allocations should be done before we have had a chance to preserve the display fb.
--- drivers/gpu/drm/xe/xe_device.c | 6 ++++++ drivers/gpu/drm/xe/xe_tile.c | 12 ++++++++---- drivers/gpu/drm/xe/xe_tile.h | 1 + 3 files changed, 15 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_device.c +6 -0
@@ -732,6 +732,12 @@ int xe_device_probe(struct xe_device *xe)if (err) goto err; +for_each_tile (tile, xe, id) { + err =xe_tile_init (tile); +if (err) + goto err; + } +for_each_gt (gt, xe, id) { last_gt = id;
drivers/gpu/drm/xe/xe_tile.c +8 -4
@@ -167,10 +167,6 @@ int xe_tile_init_noalloc(struct xe_tile *tile)if (err)return err; - tile->mem.kernel_bb_pool =xe_sa_bo_manager_init (tile,SZ_1M ,16 ); -if (IS_ERR (tile->mem.kernel_bb_pool)) -return PTR_ERR (tile->mem.kernel_bb_pool); -xe_wa_apply_tile_workarounds (tile); err =xe_tile_sysfs_init (tile);
@@ -178,6 +174,14 @@ int xe_tile_init_noalloc(struct xe_tile *tile)return 0 ; } +int xe_tile_init (struct xe_tile *tile) +{ + tile->mem.kernel_bb_pool =xe_sa_bo_manager_init (tile,SZ_1M ,16 ); +if (IS_ERR (tile->mem.kernel_bb_pool)) +return PTR_ERR (tile->mem.kernel_bb_pool); + +return 0 ; +}void xe_tile_migrate_wait (struct xe_tile *tile) {xe_migrate_wait (tile->migrate);
drivers/gpu/drm/xe/xe_tile.h +1 -0
@@ -12,6 +12,7 @@ struct xe_tile;int xe_tile_init_early (struct xe_tile *tile,struct xe_device *xe,u8 id);int xe_tile_init_noalloc (struct xe_tile *tile); +int xe_tile_init (struct xe_tile *tile);void xe_tile_migrate_wait (struct xe_tile *tile);
Signature · 1 line
2.45.2
PATCH v3 6/12 drm/xe: Use xe_ggtt_map_bo_unlocked for resume
In reply to Maarten LankhorstThis is the first step to hide the details of struct xe_ggtt.
--- drivers/gpu/drm/xe/xe_bo_evict.c | 9 ++------- drivers/gpu/drm/xe/xe_ggtt.c | 16 +++++++++++++++- drivers/gpu/drm/xe/xe_ggtt.h | 2 +- 3 files changed, 18 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_bo_evict.c +2 -7
@@ -146,13 +146,8 @@ int xe_bo_restore_kernel(struct xe_device *xe)return ret; } -if (bo->flags &XE_BO_FLAG_GGTT ) { -struct xe_tile *tile = bo->tile; - -mutex_lock (&tile->mem.ggtt->lock); -xe_ggtt_map_bo (tile->mem.ggtt, bo); -mutex_unlock (&tile->mem.ggtt->lock); - } +if (bo->flags &XE_BO_FLAG_GGTT ) +xe_ggtt_map_bo_unlocked (bo->tile->mem.ggtt, bo);/* * We expect validate to trigger a move VRAM and our move code
drivers/gpu/drm/xe/xe_ggtt.c +15 -1
@@ -579,7 +579,7 @@ bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node)* @ggtt: the &xe_ggtt where node will be mapped * @bo: the &xe_bo to be mapped */ -void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo) +static void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo) {u16 cache_mode = bo->flags &XE_BO_FLAG_NEEDS_UC ?XE_CACHE_NONE :XE_CACHE_WB ;u16 pat_index =tile_to_xe (ggtt->tile)->pat.idx[cache_mode];
@@ -597,6 +597,20 @@ void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo) } } +/** +* xe_ggtt_map_bo_unlocked - Restore a mapping of a BO into GGTT +* @ggtt: the &xe_ggtt where node will be mapped +* @bo: the &xe_bo to be mapped +* +* This is used to restore a GGTT mapping after suspend. +*/ +void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo) +{ +mutex_lock (&ggtt->lock); +xe_ggtt_map_bo (ggtt, bo); +mutex_unlock (&ggtt->lock); +} +static int __xe_ggtt_insert_bo_at (struct xe_ggtt *ggtt,struct xe_bo *bo,u64 start,u64 end) {
drivers/gpu/drm/xe/xe_ggtt.h +1 -1
@@ -24,7 +24,7 @@ int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node, u32 size, u32 align, u32 mm_flags);void xe_ggtt_node_remove (struct xe_ggtt_node *node,bool invalidate);bool xe_ggtt_node_allocated (const struct xe_ggtt_node *node); -void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo); +void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo);int xe_ggtt_insert_bo (struct xe_ggtt *ggtt,struct xe_bo *bo);int xe_ggtt_insert_bo_at (struct xe_ggtt *ggtt,struct xe_bo *bo,u64 start,u64 end);
Signature · 1 line
2.45.2
Re: [PATCH v3 06/12] drm/xe: Use xe_ggtt_map_bo_unlocked for resume
Quoted 3 lines · Maarten Lankhorst
This is the first step to hide the details of struct
xe_ggtt.Signed-off-by Maarten Lankhorst <[email protected]>
Quoted 76 lines
--- drivers/gpu/drm/xe/xe_bo_evict.c | 9 ++------- drivers/gpu/drm/xe/xe_ggtt.c | 16 +++++++++++++++- drivers/gpu/drm/xe/xe_ggtt.h | 2 +- 3 files changed, 18 insertions(+), 9 deletions(-)drivers/gpu/drm/xe/xe_bo_evict.c +2
-7@@ -146,13 +146,8 @@ int xe_bo_restore_kernel(struct xe_device *xe)return ret; } -if (bo->flags &XE_BO_FLAG_GGTT ) { -struct xe_tile *tile = bo->tile; - -mutex_lock (&tile->mem.ggtt->lock); -xe_ggtt_map_bo (tile->mem.ggtt, bo); -mutex_unlock (&tile->mem.ggtt->lock); - } +if (bo->flags &XE_BO_FLAG_GGTT ) +xe_ggtt_map_bo_unlocked (bo->tile->mem.ggtt, bo);/* * We expect validate to trigger a move VRAM and our move code drivers/gpu/drm/xe/xe_ggtt.c +15
-1@@ -579,7 +579,7 @@ bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node)* @ggtt: the &xe_ggtt where node will be mapped * @bo: the &xe_bo to be mapped */ -void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo) +static void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo) {u16 cache_mode = bo->flags &XE_BO_FLAG_NEEDS_UC ?XE_CACHE_NONE :XE_CACHE_WB ;u16 pat_index =tile_to_xe (ggtt->tile)->pat.idx[cache_mode];@@ -597,6 +597,20 @@ void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_bo *bo) } } +/** +* xe_ggtt_map_bo_unlocked - Restore a mapping of a BO into GGTT +* @ggtt: the &xe_ggtt where node will be mapped +* @bo: the &xe_bo to be mapped +* +* This is used to restore a GGTT mapping after suspend. +*/ +void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo) +{ +mutex_lock (&ggtt->lock); +xe_ggtt_map_bo (ggtt, bo); +mutex_unlock (&ggtt->lock); +} +static int __xe_ggtt_insert_bo_at (struct xe_ggtt *ggtt,struct xe_bo *bo,u64 start,u64 end) {drivers/gpu/drm/xe/xe_ggtt.h +1
-1@@ -24,7 +24,7 @@ int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node, u32 size, u32 align, u32 mm_flags);void xe_ggtt_node_remove (struct xe_ggtt_node *node,bool invalidate);bool xe_ggtt_node_allocated (const struct xe_ggtt_node *node); -void xe_ggtt_map_bo (struct xe_ggtt *ggtt,struct xe_bo *bo); +void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo);int xe_ggtt_insert_bo (struct xe_ggtt *ggtt,struct xe_bo *bo);int xe_ggtt_insert_bo_at (struct xe_ggtt *ggtt,struct xe_bo *bo,u64 start,u64 end);Signature · 1 line
2.45.2
PATCH v3 7/12 drm/xe: Add xe_ggtt_might_lock
In reply to Maarten LankhorstAnother requirement of hiding more of struct xe_ggtt.
--- drivers/gpu/drm/xe/xe_bo.c | 2 +- drivers/gpu/drm/xe/xe_ggtt.c | 7 +++++++ drivers/gpu/drm/xe/xe_ggtt.h | 7 +++++++ 3 files changed, 15 insertions(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_bo.c +1 -1
@@ -2359,7 +2359,7 @@ void xe_bo_put(struct xe_bo *bo)might_lock (&bo->client->bos_lock);#endif if (bo->ggtt_node && bo->ggtt_node->ggtt) -might_lock (&bo->ggtt_node->ggtt->lock); +xe_ggtt_might_lock (bo->ggtt_node->ggtt);drm_gem_object_put (&bo->ttm.base); } }
drivers/gpu/drm/xe/xe_ggtt.c +7 -0
@@ -175,6 +175,13 @@ static void ggtt_fini(void *arg) ggtt->scratch =NULL ; } +#ifdef CONFIG_LOCKDEP +void xe_ggtt_might_lock (struct xe_ggtt *ggtt) +{ +might_lock (&ggtt->lock); +} +#endif +static void primelockdep (struct xe_ggtt *ggtt) {if (!IS_ENABLED (CONFIG_LOCKDEP ))
drivers/gpu/drm/xe/xe_ggtt.h +7 -0
@@ -38,4 +38,11 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printervoid xe_ggtt_assign (const struct xe_ggtt_node *node,u16 vfid);#endif +#ifndef CONFIG_LOCKDEP +static inline void xe_ggtt_might_lock (struct xe_ggtt *ggtt) +{ } +#else +void xe_ggtt_might_lock (struct xe_ggtt *ggtt); +#endif +#endif
Signature · 1 line
2.45.2
Re: [PATCH v3 07/12] drm/xe: Add xe_ggtt_might_lock
Quoted 3 lines · Maarten Lankhorst
Another requirement of hiding more of struct
xe_ggtt.Signed-off-by Maarten Lankhorst <[email protected]>
Quoted 56 lines
--- drivers/gpu/drm/xe/xe_bo.c | 2 +- drivers/gpu/drm/xe/xe_ggtt.c | 7 +++++++ drivers/gpu/drm/xe/xe_ggtt.h | 7 +++++++ 3 files changed, 15 insertions(+), 1 deletion(-)drivers/gpu/drm/xe/xe_bo.c +1
-1@@ -2359,7 +2359,7 @@ void xe_bo_put(struct xe_bo *bo)might_lock (&bo->client->bos_lock);#endif if (bo->ggtt_node && bo->ggtt_node->ggtt) -might_lock (&bo->ggtt_node->ggtt->lock); +xe_ggtt_might_lock (bo->ggtt_node->ggtt);drm_gem_object_put (&bo->ttm.base); } }drivers/gpu/drm/xe/xe_ggtt.c +7
-0@@ -175,6 +175,13 @@ static void ggtt_fini(void *arg) ggtt->scratch =NULL ; } +#ifdef CONFIG_LOCKDEP +void xe_ggtt_might_lock (struct xe_ggtt *ggtt) +{ +might_lock (&ggtt->lock); +} +#endif +static void primelockdep (struct xe_ggtt *ggtt) {if (!IS_ENABLED (CONFIG_LOCKDEP ))drivers/gpu/drm/xe/xe_ggtt.h +7
-0@@ -38,4 +38,11 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printervoid xe_ggtt_assign (const struct xe_ggtt_node *node,u16 vfid);#endif +#ifndef CONFIG_LOCKDEP +static inline void xe_ggtt_might_lock (struct xe_ggtt *ggtt) +{ } +#else +void xe_ggtt_might_lock (struct xe_ggtt *ggtt); +#endif +#endif Signature · 1 line
2.45.2
PATCH v3 8/12 drm/xe: Add xe_ggtt_alloc
In reply to Maarten LankhorstInstead of allocating inside xe_tile, create a new function that returns an allocated struct xe_ggtt from xe_ggtt.c
--- drivers/gpu/drm/xe/xe_ggtt.c | 8 ++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 2 ++ drivers/gpu/drm/xe/xe_tile.c | 4 +--- 3 files changed, 11 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +8 -0
@@ -159,6 +159,14 @@ static void xe_ggtt_clear(struct xe_ggtt *ggtt, u64 start, u64 size) } } +struct xe_ggtt *xe_ggtt_alloc (struct xe_tile *tile) +{ +struct xe_ggtt *ggtt =drmm_kzalloc (&tile_to_xe (tile)->drm,sizeof (*ggtt),GFP_KERNEL ); +if (ggtt) + ggtt->tile = tile; +return ggtt; +} +static void ggtt_fini_early (struct drm_device *drm,void *arg) {struct xe_ggtt *ggtt = arg;
drivers/gpu/drm/xe/xe_ggtt.h +2 -0
@@ -9,7 +9,9 @@#include "xe_ggtt_types.h" struct drm_printer ; +struct xe_tile ; +struct xe_ggtt *xe_ggtt_alloc (struct xe_tile *tile);int xe_ggtt_init_early (struct xe_ggtt *ggtt);int xe_ggtt_init (struct xe_ggtt *ggtt);
drivers/gpu/drm/xe/xe_tile.c +1 -3
@@ -86,11 +86,9 @@ static int xe_tile_alloc(struct xe_tile *tile) {struct drm_device *drm = &tile_to_xe (tile)->drm; - tile->mem.ggtt =drmm_kzalloc (drm,sizeof (*tile->mem.ggtt), -GFP_KERNEL ); + tile->mem.ggtt =xe_ggtt_alloc (tile);if (!tile->mem.ggtt)return -ENOMEM ; - tile->mem.ggtt->tile = tile; tile->mem.vram_mgr =drmm_kzalloc (drm,sizeof (*tile->mem.vram_mgr),GFP_KERNEL );if (!tile->mem.vram_mgr)
Signature · 1 line
2.45.2
Re: [PATCH v3 08/12] drm/xe: Add xe_ggtt_alloc
Quoted 15 lines · Maarten Lankhorst
Instead of allocating inside
xe_tile, create a new function that returns an allocated structxe_ggttfromxe_ggtt.cSigned-off-by Maarten Lankhorst <[email protected]>--- drivers/gpu/drm/xe/xe_ggtt.c | 8 ++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 2 ++ drivers/gpu/drm/xe/xe_tile.c | 4 +--- 3 files changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/xe/xe_ggtt.c +0
-0
drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_clear(struct xe_ggtt *ggtt, u64 start, u64 size) · line 161
Quoted 3 lines
drivers/gpu/drm/xe/xe_ggtt.c +0
-0@@ -159,6 +159,14 @@ static void xe_ggtt_clear(struct xe_ggtt *ggtt, u64 start, u64 size) } }
Probably kernel doc as we shouldn't add more undocumented public functions.
With kernel doc:
Quoted 45 lines
drivers/gpu/drm/xe/xe_ggtt.c +8
-0+struct xe_ggtt *xe_ggtt_alloc (struct xe_tile *tile) +{ +struct xe_ggtt *ggtt =drmm_kzalloc (&tile_to_xe (tile)->drm,sizeof (*ggtt),GFP_KERNEL ); +if (ggtt) + ggtt->tile = tile; +return ggtt; +} +static void ggtt_fini_early (struct drm_device *drm,void *arg) {struct xe_ggtt *ggtt = arg;drivers/gpu/drm/xe/xe_ggtt.h +2
-0@@ -9,7 +9,9 @@#include "xe_ggtt_types.h" struct drm_printer ; +struct xe_tile ; +struct xe_ggtt *xe_ggtt_alloc (struct xe_tile *tile);int xe_ggtt_init_early (struct xe_ggtt *ggtt);int xe_ggtt_init (struct xe_ggtt *ggtt);drivers/gpu/drm/xe/xe_tile.c +1
-3@@ -86,11 +86,9 @@ static int xe_tile_alloc(struct xe_tile *tile) {struct drm_device *drm = &tile_to_xe (tile)->drm; - tile->mem.ggtt =drmm_kzalloc (drm,sizeof (*tile->mem.ggtt), -GFP_KERNEL ); + tile->mem.ggtt =xe_ggtt_alloc (tile);if (!tile->mem.ggtt)return -ENOMEM ; - tile->mem.ggtt->tile = tile; tile->mem.vram_mgr =drmm_kzalloc (drm,sizeof (*tile->mem.vram_mgr),GFP_KERNEL );if (!tile->mem.vram_mgr)Signature · 1 line
2.45.2
PATCH v3 9/12 drm/xe: Abstract read/write functions for GGTT PTEs
In reply to Maarten LankhorstInstead of writing directly, use GGTT functions. This allows us to hide away more GGTT details.
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 4 +-- drivers/gpu/drm/xe/display/xe_plane_initial.c | 6 +---- drivers/gpu/drm/xe/xe_ggtt.c | 25 +++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 3 +++ 4 files changed, 31 insertions(+), 7 deletions(-)
drivers/gpu/drm/xe/display/xe_fb_pin.c +2 -2
@@ -172,7 +172,7 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bou64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , xe->pat.idx[XE_CACHE_NONE ]); - ggtt->pt_ops->ggtt_set_pte (ggtt, *ggtt_ofs, pte); +xe_ggtt_write_pte (ggtt, *ggtt_ofs, pte); *ggtt_ofs +=XE_PAGE_SIZE ; src_idx -= src_stride; }
@@ -226,7 +226,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x, xe->pat.idx[XE_CACHE_NONE ]); - ggtt->pt_ops->ggtt_set_pte (ggtt, vma->node->base.start + x, pte); +xe_ggtt_write_pte (ggtt, vma->node->base.start + x, pte); } }else {u32 i, ggtt_ofs;
drivers/gpu/drm/xe/display/xe_plane_initial.c +1 -5
@@ -70,12 +70,8 @@ initial_plane_bo(struct xe_device *xe, base =round_down (plane_config->base, page_size);if (IS_DGFX (xe) ||GRAPHICS_VERx100 (xe) >=1270 ) { -u64 __iomem *gte = tile0->mem.ggtt->gsm; -u64 pte; +u64 pte =xe_ggtt_read_pte (tile0->mem.ggtt, base); - gte += base /XE_PAGE_SIZE ; - - pte =ioread64 (gte);if (!(pte &XE_GGTT_PTE_DM )) {drm_err (&xe->drm,"Initial plane programming missing DM bit\n" );
drivers/gpu/drm/xe/xe_ggtt.c +25 -0
@@ -855,3 +855,28 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printerreturn total; } + +/** +* xe_ggtt_read_pte - Read a PTE from the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be read. +* +* Used by display for inheriting a bios set FB. +*/ +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset) +{ +return ioread64 (ggtt->gsm + (offset /XE_PAGE_SIZE )); +} + +/** +* xe_ggtt_write_pte - Write a PTE to the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be written. +* @pte: The page table entry to write +* +* Used by display for writing normal and rotated GGTT entries for temporary pinned FB's. +*/ +void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte) +{ +return ggtt->pt_ops->ggtt_set_pte (ggtt, offset, pte); +}
drivers/gpu/drm/xe/xe_ggtt.h +3 -0
@@ -47,4 +47,7 @@ static inline void xe_ggtt_might_lock(struct xe_ggtt *ggtt)void xe_ggtt_might_lock (struct xe_ggtt *ggtt);#endif +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); +void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte); +#endif
Signature · 1 line
2.45.2
Re: [PATCH v3 09/12] drm/xe: Abstract read/write functions for GGTT PTEs
Quoted 4 lines · Maarten Lankhorst
Instead of writing directly, use GGTT functions. This allows us to hide away more GGTT details.
Signed-off-by Maarten Lankhorst <[email protected]>
Quoted 95 lines
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 4 +-- drivers/gpu/drm/xe/display/xe_plane_initial.c | 6 +---- drivers/gpu/drm/xe/xe_ggtt.c | 25 +++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 3 +++ 4 files changed, 31 insertions(+), 7 deletions(-)drivers/gpu/drm/xe/display/xe_fb_pin.c +2
-2@@ -172,7 +172,7 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bou64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , xe->pat.idx[XE_CACHE_NONE ]); - ggtt->pt_ops->ggtt_set_pte (ggtt, *ggtt_ofs, pte); +xe_ggtt_write_pte (ggtt, *ggtt_ofs, pte); *ggtt_ofs +=XE_PAGE_SIZE ; src_idx -= src_stride; }@@ -226,7 +226,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x, xe->pat.idx[XE_CACHE_NONE ]); - ggtt->pt_ops->ggtt_set_pte (ggtt, vma->node->base.start + x, pte); +xe_ggtt_write_pte (ggtt, vma->node->base.start + x, pte); } }else {u32 i, ggtt_ofs;drivers/gpu/drm/xe/display/xe_plane_initial.c +1
-5@@ -70,12 +70,8 @@ initial_plane_bo(struct xe_device *xe, base =round_down (plane_config->base, page_size);if (IS_DGFX (xe) ||GRAPHICS_VERx100 (xe) >=1270 ) { -u64 __iomem *gte = tile0->mem.ggtt->gsm; -u64 pte; +u64 pte =xe_ggtt_read_pte (tile0->mem.ggtt, base); - gte += base /XE_PAGE_SIZE ; - - pte =ioread64 (gte);if (!(pte &XE_GGTT_PTE_DM )) {drm_err (&xe->drm,"Initial plane programming missing DM bit\n" );drivers/gpu/drm/xe/xe_ggtt.c +25
-0@@ -855,3 +855,28 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printerreturn total; } + +/** +* xe_ggtt_read_pte - Read a PTE from the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be read. +* +* Used by display for inheriting a bios set FB. +*/ +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset) +{ +return ioread64 (ggtt->gsm + (offset /XE_PAGE_SIZE )); +} + +/** +* xe_ggtt_write_pte - Write a PTE to the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be written. +* @pte: The page table entry to write +* +* Used by display for writing normal and rotated GGTT entries for temporary pinned FB's. +*/ +void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte) +{ +return ggtt->pt_ops->ggtt_set_pte (ggtt, offset, pte); +}drivers/gpu/drm/xe/xe_ggtt.h +3
-0@@ -47,4 +47,7 @@ static inline void xe_ggtt_might_lock(struct xe_ggtt *ggtt)void xe_ggtt_might_lock (struct xe_ggtt *ggtt);#endif +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); +void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte); +#endif Signature · 1 line
2.45.2
PATCH v3 10/12 drm/xe: Make xe_ggtt_pt_ops private
In reply to Maarten LankhorstThe only user outside xe_ggtt.c is fb pinning, which makes sense as all the operations it performs can be considered part of GGTT.
We could move this to xe_ggtt.c, but lets keep it inside display for now.
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 22 ++++++++++++---------- drivers/gpu/drm/xe/xe_ggtt.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 2 ++ drivers/gpu/drm/xe/xe_ggtt_types.h | 13 ++----------- 4 files changed, 40 insertions(+), 21 deletions(-)
drivers/gpu/drm/xe/display/xe_fb_pin.c +12 -10
@@ -20,6 +20,7 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_ {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;/* TODO: Maybe rewrite so we can traverse the bo addresses sequentially,
@@ -30,8 +31,8 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (map, *dpt_ofs, u64, pte); *dpt_ofs +=8 ;
@@ -53,8 +54,7 @@ write_dpt_remapped(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index) - = ggtt->pt_ops->pte_encode_bo; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (row =0 ; row < height; row++) {
@@ -120,11 +120,12 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,return PTR_ERR (dpt);if (view->type ==I915_GTT_VIEW_NORMAL ) { +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 x;for (x =0 ; x < size /XE_PAGE_SIZE ; x++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (&dpt->vmap, x *8 , u64, pte); }
@@ -163,14 +164,15 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bo u32 width, u32 height, u32 src_stride, u32 dst_stride) { struct xe_device *xe = xe_bo_device(bo); +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (column =0 ; column < width; column++) {u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, *ggtt_ofs, pte); *ggtt_ofs +=XE_PAGE_SIZE ;
@@ -209,6 +211,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, vma->node = bo->ggtt_node; }else if (view->type ==I915_GTT_VIEW_NORMAL ) {u32 x, size = bo->ttm.base.size; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt); vma->node =xe_ggtt_node_init (ggtt);if (IS_ERR (vma->node)) {
@@ -223,8 +226,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, }for (x =0 ; x < size; x +=XE_PAGE_SIZE ) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x, - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x, xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, vma->node->base.start + x, pte); }
drivers/gpu/drm/xe/xe_ggtt.c +24 -0
@@ -63,6 +63,18 @@* give us the correct placement for free. */ +/** +* struct xe_ggtt_pt_ops - GGTT Page table operations +* Which can vary from platform to platform. +*/ +struct xe_ggtt_pt_ops { +/** @pte_encode_bo: Encode PTE address for a given BO */ +xe_ggtt_pte_encode_bo_fn pte_encode_bo; +/** @ggtt_set_pte: Directly write into GGTT's PTE */ +void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); +}; + +static u64 xelp_ggtt_pte_encode_bo (struct xe_bo *bo,u64 bo_offset,u16 pat_index) {
@@ -880,3 +892,15 @@ void xe_ggtt_write_pte(struct xe_ggtt *ggtt, u64 offset, u64 pte) {return ggtt->pt_ops->ggtt_set_pte (ggtt, offset, pte); } + +/** +* xe_ggtt_write_pte - Write a PTE to the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be written. +* +* Used by display for DPT and GGTT paths to enccode BO's. +*/ +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt) +{ +return ggtt->pt_ops->pte_encode_bo; +}
drivers/gpu/drm/xe/xe_ggtt.h +2 -0
@@ -48,6 +48,8 @@ void xe_ggtt_might_lock(struct xe_ggtt *ggtt);#endif u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); + +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt);void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte);#endif
drivers/gpu/drm/xe/xe_ggtt_types.h +2 -11
@@ -13,6 +13,8 @@struct xe_bo ;struct xe_gt ; +typedef u64 (*xe_ggtt_pte_encode_bo_fn )(struct xe_bo *bo,u64 bo_offset,u16 pat_index); +/** * struct xe_ggtt - Main GGTT struct *
@@ -69,15 +71,4 @@ struct xe_ggtt_node { bool invalidate_on_remove; }; -/** -* struct xe_ggtt_pt_ops - GGTT Page table operations -* Which can vary from platform to platform. -*/ -struct xe_ggtt_pt_ops { -/** @pte_encode_bo: Encode PTE address for a given BO */ -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index); -/** @ggtt_set_pte: Directly write into GGTT's PTE */ -void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); -}; -#endif
Signature · 1 line
2.45.2
Re: [PATCH v3 10/12] drm/xe: Make xe_ggtt_pt_ops private
Quoted 7 lines · Maarten Lankhorst
The only user outside
xe_ggtt.cis fb pinning, which makes sense as all the operations it performs can be considered part of GGTT.We could move this to
xe_ggtt.c, but lets keep it inside display for now.Signed-off-by Maarten Lankhorst <[email protected]>
Quoted 175 lines
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 22 ++++++++++++---------- drivers/gpu/drm/xe/xe_ggtt.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 2 ++ drivers/gpu/drm/xe/xe_ggtt_types.h | 13 ++----------- 4 files changed, 40 insertions(+), 21 deletions(-)drivers/gpu/drm/xe/display/xe_fb_pin.c +12
-10@@ -20,6 +20,7 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_ {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;/* TODO: Maybe rewrite so we can traverse the bo addresses sequentially, @@ -30,8 +31,8 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (map, *dpt_ofs, u64, pte); *dpt_ofs +=8 ;@@ -53,8 +54,7 @@ write_dpt_remapped(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index) - = ggtt->pt_ops->pte_encode_bo; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (row =0 ; row < height; row++) {@@ -120,11 +120,12 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,return PTR_ERR (dpt);if (view->type ==I915_GTT_VIEW_NORMAL ) { +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 x;for (x =0 ; x < size /XE_PAGE_SIZE ; x++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (&dpt->vmap, x *8 , u64, pte); }@@ -163,14 +164,15 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bo u32 width, u32 height, u32 src_stride, u32 dst_stride) { struct xe_device *xe = xe_bo_device(bo); +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (column =0 ; column < width; column++) {u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, *ggtt_ofs, pte); *ggtt_ofs +=XE_PAGE_SIZE ;@@ -209,6 +211,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, vma->node = bo->ggtt_node; }else if (view->type ==I915_GTT_VIEW_NORMAL ) {u32 x, size = bo->ttm.base.size; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt); vma->node =xe_ggtt_node_init (ggtt);if (IS_ERR (vma->node)) {@@ -223,8 +226,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, }for (x =0 ; x < size; x +=XE_PAGE_SIZE ) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x, - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x, xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, vma->node->base.start + x, pte); }drivers/gpu/drm/xe/xe_ggtt.c +24
-0@@ -63,6 +63,18 @@* give us the correct placement for free. */ +/** +* struct xe_ggtt_pt_ops - GGTT Page table operations +* Which can vary from platform to platform. +*/ +struct xe_ggtt_pt_ops { +/** @pte_encode_bo: Encode PTE address for a given BO */ +xe_ggtt_pte_encode_bo_fn pte_encode_bo; +/** @ggtt_set_pte: Directly write into GGTT's PTE */ +void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); +}; + +static u64 xelp_ggtt_pte_encode_bo (struct xe_bo *bo,u64 bo_offset,u16 pat_index) {@@ -880,3 +892,15 @@ void xe_ggtt_write_pte(struct xe_ggtt *ggtt, u64 offset, u64 pte) {return ggtt->pt_ops->ggtt_set_pte (ggtt, offset, pte); } + +/** +* xe_ggtt_write_pte - Write a PTE to the GGTT +* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be written. +* +* Used by display for DPT and GGTT paths to enccode BO's. +*/ +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt) +{ +return ggtt->pt_ops->pte_encode_bo; +}drivers/gpu/drm/xe/xe_ggtt.h +2
-0@@ -48,6 +48,8 @@ void xe_ggtt_might_lock(struct xe_ggtt *ggtt);#endif u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); + +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt);void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte);#endif drivers/gpu/drm/xe/xe_ggtt_types.h +2
-11@@ -13,6 +13,8 @@struct xe_bo ;struct xe_gt ; +typedef u64 (*xe_ggtt_pte_encode_bo_fn )(struct xe_bo *bo,u64 bo_offset,u16 pat_index); +/** * struct xe_ggtt - Main GGTT struct * @@ -69,15 +71,4 @@ struct xe_ggtt_node { bool invalidate_on_remove; }; -/** -* struct xe_ggtt_pt_ops - GGTT Page table operations -* Which can vary from platform to platform. -*/ -struct xe_ggtt_pt_ops { -/** @pte_encode_bo: Encode PTE address for a given BO */ -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index); -/** @ggtt_set_pte: Directly write into GGTT's PTE */ -void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); -}; -#endif Signature · 1 line
2.45.2
kernel test robot
build botRe: [PATCH v3 10/12] drm/xe: Make xe_ggtt_pt_ops private
In reply to Maarten Lankhorstkernel test robot noticed the following build warnings:
Hi Maarten,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on linus/master v6.12-rc1]
[cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maarten-Lankhorst/drm-xe-display-Handle-stolen-bar-readout-in-the-same-way-as-lmem/20241004-000534 base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next patch link: https://lore.kernel.org/r/20241003154421.33805-11-maarten.lankhorst%40linux.intel.com patch subject: [PATCH v3 10/12] drm/xe: Make xe_ggtt_pt_ops private config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241004/[email protected]/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/xe/xe_ggtt.c:906: warning: expecting prototype for xe_ggtt_write_pte(). Prototype was for xe_ggtt_get_encode_pte_bo_fn() instead
vim +906 drivers/gpu/drm/xe/xe_ggtt.c
897
898 /**
899 * xe_ggtt_write_pte - Write a PTE to the GGTT
900 * @ggtt: &xe_ggtt
901 * @offset: the offset for which the mapping should be written.
902 *
903 * Used by display for DPT and GGTT paths to enccode BO's.
904 */
905 xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn(struct xe_ggtt *ggtt)
> 906 {Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Re: [PATCH v3 10/12] drm/xe: Make xe_ggtt_pt_ops private
In reply to Maarten LankhorstQuoted 19 lines · Maarten Lankhorst
The only user outside
xe_ggtt.cis fb pinning, which makes sense as all the operations it performs can be considered part of GGTT.We could move this to
xe_ggtt.c, but lets keep it inside display for now.Signed-off-by Maarten Lankhorst <[email protected]>---
drivers/gpu/drm/xe/display/xe_fb_pin.c | 22 ++++++++++++---------- drivers/gpu/drm/xe/xe_ggtt.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 2 ++ drivers/gpu/drm/xe/xe_ggtt_types.h | 13 ++----------- 4 files changed, 40 insertions(+), 21 deletions(-)drivers/gpu/drm/xe/display/xe_fb_pin.c +0
-0
drivers/gpu/drm/xe/display/xe_fb_pin.c write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_ · line 23
Quoted 4 lines
drivers/gpu/drm/xe/display/xe_fb_pin.c +1
-0@@ -20,6 +20,7 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_ {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);
ugh... that's awful. It's not private at all. You are just trading the direct access ggtt->pt_ops->pte_encode_bo with a function that returns a function pointer and you all it later.
Lucas De Marchi
Quoted 99 lines
drivers/gpu/drm/xe/display/xe_fb_pin.c +11
-10u32 column, row;/* TODO: Maybe rewrite so we can traverse the bo addresses sequentially, @@ -30,8 +31,8 @@ write_dpt_rotated(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, u32 bo_u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (map, *dpt_ofs, u64, pte); *dpt_ofs +=8 ;@@ -53,8 +54,7 @@ write_dpt_remapped(struct xe_bo *bo, struct iosys_map *map, u32 *dpt_ofs, {struct xe_device *xe =xe_bo_device (bo);struct xe_ggtt *ggtt =xe_device_get_root_tile (xe)->mem.ggtt; -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index) - = ggtt->pt_ops->pte_encode_bo; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (row =0 ; row < height; row++) {@@ -120,11 +120,12 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,return PTR_ERR (dpt);if (view->type ==I915_GTT_VIEW_NORMAL ) { +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 x;for (x =0 ; x < size /XE_PAGE_SIZE ; x++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);iosys_map_wr (&dpt->vmap, x *8 , u64, pte); }@@ -163,14 +164,15 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bo u32 width, u32 height, u32 src_stride, u32 dst_stride) { struct xe_device *xe = xe_bo_device(bo); +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt);u32 column, row;for (column =0 ; column < width; column++) {u32 src_idx = src_stride * (height -1 ) + column + bo_ofs;for (row =0 ; row < height; row++) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, src_idx *XE_PAGE_SIZE , + xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, *ggtt_ofs, pte); *ggtt_ofs +=XE_PAGE_SIZE ;@@ -209,6 +211,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, vma->node = bo->ggtt_node; }else if (view->type ==I915_GTT_VIEW_NORMAL ) {u32 x, size = bo->ttm.base.size; +xe_ggtt_pte_encode_bo_fn pte_encode_bo =xe_ggtt_get_encode_pte_bo_fn (ggtt); vma->node =xe_ggtt_node_init (ggtt);if (IS_ERR (vma->node)) {@@ -223,8 +226,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, }for (x =0 ; x < size; x +=XE_PAGE_SIZE ) { -u64 pte = ggtt->pt_ops->pte_encode_bo (bo, x, - xe->pat.idx[XE_CACHE_NONE ]); +u64 pte =pte_encode_bo (bo, x, xe->pat.idx[XE_CACHE_NONE ]);xe_ggtt_write_pte (ggtt, vma->node->base.start + x, pte); }drivers/gpu/drm/xe/xe_ggtt.c +12
-0@@ -63,6 +63,18 @@* give us the correct placement for free. */ +/** +* struct xe_ggtt_pt_ops - GGTT Page table operations +* Which can vary from platform to platform. +*/ +struct xe_ggtt_pt_ops { +/** @pte_encode_bo: Encode PTE address for a given BO */ +xe_ggtt_pte_encode_bo_fn pte_encode_bo; +/** @ggtt_set_pte: Directly write into GGTT's PTE */ +void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); +}; + +static u64 xelp_ggtt_pte_encode_bo (struct xe_bo *bo,u64 bo_offset,u16 pat_index) {
drivers/gpu/drm/xe/xe_ggtt.c void xe_ggtt_write_pte(struct xe_ggtt *ggtt, u64 offset, u64 pte) · line 897
Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +3
-0@@ -880,3 +892,15 @@ void xe_ggtt_write_pte(struct xe_ggtt *ggtt, u64 offset, u64 pte) {return ggtt->pt_ops->ggtt_set_pte (ggtt, offset, pte); } + +/** +* xe_ggtt_write_pte - Write a PTE to the GGTT
copy & pasta
I don't think we should have this partial transition. If we want to hide the pointer indirection we should provide functions like xe_ggtt_pte_encode_bo() and xe_ggtt_set_pte() instead of adding a getter to return the function pointer.
Lucas De Marchi
Quoted 54 lines
drivers/gpu/drm/xe/xe_ggtt.c +9
-0+* @ggtt: &xe_ggtt +* @offset: the offset for which the mapping should be written. +* +* Used by display for DPT and GGTT paths to enccode BO's. +*/ +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt) +{ +return ggtt->pt_ops->pte_encode_bo; +}drivers/gpu/drm/xe/xe_ggtt.h +2
-0@@ -48,6 +48,8 @@ void xe_ggtt_might_lock(struct xe_ggtt *ggtt);#endif u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); + +xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt);void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte);#endif drivers/gpu/drm/xe/xe_ggtt_types.h +2
-11@@ -13,6 +13,8 @@struct xe_bo ;struct xe_gt ; +typedef u64 (*xe_ggtt_pte_encode_bo_fn )(struct xe_bo *bo,u64 bo_offset,u16 pat_index); +/** * struct xe_ggtt - Main GGTT struct * @@ -69,15 +71,4 @@ struct xe_ggtt_node { bool invalidate_on_remove; }; -/** -* struct xe_ggtt_pt_ops - GGTT Page table operations -* Which can vary from platform to platform. -*/ -struct xe_ggtt_pt_ops { -/** @pte_encode_bo: Encode PTE address for a given BO */ -u64 (*pte_encode_bo)(struct xe_bo *bo,u64 bo_offset,u16 pat_index); -/** @ggtt_set_pte: Directly write into GGTT's PTE */ -void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); -}; -#endif Signature · 1 line
2.45.2
PATCH v3 11/12 drm/xe/display: Stop dereferencing ggtt in xe_fb_pin
In reply to Maarten LankhorstThis is the only user of the ggtt struct still there, add some calls to lock/unlock ggtt and remove other dereferencing.
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 +++++----- drivers/gpu/drm/xe/xe_ggtt.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 10 ++++++---- 3 files changed, 35 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/display/xe_fb_pin.c +5 -5
@@ -198,13 +198,13 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,/* TODO: Consider sharing framebuffer mapping? * embed i915_vma inside intel_framebuffer */ -xe_pm_runtime_get_noresume (tile_to_xe (ggtt->tile)); - ret =mutex_lock_interruptible (&ggtt->lock); +xe_pm_runtime_get_noresume (xe); + ret =xe_ggtt_lock_interruptible (ggtt);if (ret) goto out; align =XE_PAGE_SIZE ; -if (xe_bo_is_vram (bo) && ggtt->flags &XE_GGTT_FLAGS_64K ) +if (xe_bo_is_vram (bo) && xe->info.vram_flags &XE_VRAM_FLAGS_NEED64K ) align =max_t (u32, align,SZ_64K );if (bo->ggtt_node && view->type ==I915_GTT_VIEW_NORMAL ) {
@@ -261,9 +261,9 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, } out_unlock: -mutex_unlock (&ggtt->lock); +xe_ggtt_unlock (ggtt); out: -xe_pm_runtime_put (tile_to_xe (ggtt->tile)); +xe_pm_runtime_put (xe);return ret; }
drivers/gpu/drm/xe/xe_ggtt.c +24 -0
@@ -868,6 +868,30 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printerreturn total; } +/** +* xe_ggtt_lock_interruptible - Lock GGTT for display updates +* @ggtt: &xe_ggtt +* +* There's no reason to want this outside of display, and that is only +* there because moving to here would be a layering violation. +*/ +int xe_ggtt_lock_interruptible (struct xe_ggtt *ggtt) +{ +return mutex_lock_interruptible (&ggtt->lock); +} + +/** +* xe_ggtt_unlock - Unlock GGTT after display updates +* @ggtt: &xe_ggtt +* +* There's no reason to want this outside of display, and that is only +* there because moving to here would be a layering violation. +*/ +void xe_ggtt_unlock (struct xe_ggtt *ggtt) +{ +mutex_unlock (&ggtt->lock); +} +/** * xe_ggtt_read_pte - Read a PTE from the GGTT * @ggtt: &xe_ggtt
drivers/gpu/drm/xe/xe_ggtt.h +6 -4
@@ -22,8 +22,6 @@ int xe_ggtt_node_insert_balloon(struct xe_ggtt_node *node,void xe_ggtt_node_remove_balloon (struct xe_ggtt_node *node);int xe_ggtt_node_insert (struct xe_ggtt_node *node,u32 size,u32 align); -int xe_ggtt_node_insert_locked (struct xe_ggtt_node *node, -u32 size,u32 align,u32 mm_flags);void xe_ggtt_node_remove (struct xe_ggtt_node *node,bool invalidate);bool xe_ggtt_node_allocated (const struct xe_ggtt_node *node);void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo);
@@ -47,9 +45,13 @@ static inline void xe_ggtt_might_lock(struct xe_ggtt *ggtt)void xe_ggtt_might_lock (struct xe_ggtt *ggtt);#endif -u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); - +/* Display specific function calls, don't use outside of xe/display */ +int xe_ggtt_lock_interruptible (struct xe_ggtt *ggtt); +void xe_ggtt_unlock (struct xe_ggtt *ggtt); +int xe_ggtt_node_insert_locked (struct xe_ggtt_node *node, +u32 size,u32 align,u32 mm_flags);xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt); +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset);void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte);#endif
Signature · 1 line
2.45.2
Re: [PATCH v3 11/12] drm/xe/display: Stop dereferencing ggtt in xe_fb_pin
Quoted 4 lines · Maarten Lankhorst
This is the only user of the ggtt struct still there, add some calls to lock/unlock ggtt and remove other dereferencing.
Signed-off-by Maarten Lankhorst <[email protected]>
Quoted 106 lines
--- drivers/gpu/drm/xe/display/xe_fb_pin.c | 10 +++++----- drivers/gpu/drm/xe/xe_ggtt.c | 24 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt.h | 10 ++++++---- 3 files changed, 35 insertions(+), 9 deletions(-)drivers/gpu/drm/xe/display/xe_fb_pin.c +5
-5@@ -198,13 +198,13 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,/* TODO: Consider sharing framebuffer mapping? * embed i915_vma inside intel_framebuffer */ -xe_pm_runtime_get_noresume (tile_to_xe (ggtt->tile)); - ret =mutex_lock_interruptible (&ggtt->lock); +xe_pm_runtime_get_noresume (xe); + ret =xe_ggtt_lock_interruptible (ggtt);if (ret) goto out; align =XE_PAGE_SIZE ; -if (xe_bo_is_vram (bo) && ggtt->flags &XE_GGTT_FLAGS_64K ) +if (xe_bo_is_vram (bo) && xe->info.vram_flags &XE_VRAM_FLAGS_NEED64K ) align =max_t (u32, align,SZ_64K );if (bo->ggtt_node && view->type ==I915_GTT_VIEW_NORMAL ) {@@ -261,9 +261,9 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb, } out_unlock: -mutex_unlock (&ggtt->lock); +xe_ggtt_unlock (ggtt); out: -xe_pm_runtime_put (tile_to_xe (ggtt->tile)); +xe_pm_runtime_put (xe);return ret; }drivers/gpu/drm/xe/xe_ggtt.c +24
-0@@ -868,6 +868,30 @@ u64 xe_ggtt_print_holes(struct xe_ggtt *ggtt, u64 alignment, struct drm_printerreturn total; } +/** +* xe_ggtt_lock_interruptible - Lock GGTT for display updates +* @ggtt: &xe_ggtt +* +* There's no reason to want this outside of display, and that is only +* there because moving to here would be a layering violation. +*/ +int xe_ggtt_lock_interruptible (struct xe_ggtt *ggtt) +{ +return mutex_lock_interruptible (&ggtt->lock); +} + +/** +* xe_ggtt_unlock - Unlock GGTT after display updates +* @ggtt: &xe_ggtt +* +* There's no reason to want this outside of display, and that is only +* there because moving to here would be a layering violation. +*/ +void xe_ggtt_unlock (struct xe_ggtt *ggtt) +{ +mutex_unlock (&ggtt->lock); +} +/** * xe_ggtt_read_pte - Read a PTE from the GGTT * @ggtt: &xe_ggtt drivers/gpu/drm/xe/xe_ggtt.h +6
-4@@ -22,8 +22,6 @@ int xe_ggtt_node_insert_balloon(struct xe_ggtt_node *node,void xe_ggtt_node_remove_balloon (struct xe_ggtt_node *node);int xe_ggtt_node_insert (struct xe_ggtt_node *node,u32 size,u32 align); -int xe_ggtt_node_insert_locked (struct xe_ggtt_node *node, -u32 size,u32 align,u32 mm_flags);void xe_ggtt_node_remove (struct xe_ggtt_node *node,bool invalidate);bool xe_ggtt_node_allocated (const struct xe_ggtt_node *node);void xe_ggtt_map_bo_unlocked (struct xe_ggtt *ggtt,struct xe_bo *bo);@@ -47,9 +45,13 @@ static inline void xe_ggtt_might_lock(struct xe_ggtt *ggtt)void xe_ggtt_might_lock (struct xe_ggtt *ggtt);#endif -u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset); - +/* Display specific function calls, don't use outside of xe/display */ +int xe_ggtt_lock_interruptible (struct xe_ggtt *ggtt); +void xe_ggtt_unlock (struct xe_ggtt *ggtt); +int xe_ggtt_node_insert_locked (struct xe_ggtt_node *node, +u32 size,u32 align,u32 mm_flags);xe_ggtt_pte_encode_bo_fn xe_ggtt_get_encode_pte_bo_fn (struct xe_ggtt *ggtt); +u64 xe_ggtt_read_pte (struct xe_ggtt *ggtt,u64 offset);void xe_ggtt_write_pte (struct xe_ggtt *ggtt,u64 offset,u64 pte);#endif Signature · 1 line
2.45.2
PATCH v3 12/12 drm/xe: Move struct xe_ggtt to xe_ggtt.c
In reply to Maarten LankhorstNo users left outside of xe_ggtt.c, so we can make the struct private.
This prevents us from accidentally touching it before init.
--- drivers/gpu/drm/xe/xe_ggtt.c | 37 ++++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt_types.h | 39 +----------------------------- 2 files changed, 38 insertions(+), 38 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +37 -0
@@ -74,6 +74,43 @@ struct xe_ggtt_pt_ops {void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); }; +/** +* struct xe_ggtt - Main GGTT struct +* +* In general, each tile can contains its own Global Graphics Translation Table +* (GGTT) instance. +*/ +struct xe_ggtt { +/** @tile: Back pointer to tile where this GGTT belongs */ +struct xe_tile *tile; +/** @size: Total size of this GGTT */ +u64 size; + +#define XE_GGTT_FLAGS_64K BIT(0) +/** +* @flags: Flags for this GGTT +* Acceptable flags: +* - %XE_GGTT_FLAGS_64K - if PTE size is 64K. Otherwise, regular is 4K. +*/ +unsigned int flags; +/** @scratch: Internal object allocation used as a scratch page */ +struct xe_bo *scratch; +/** @lock: Mutex lock to protect GGTT data */ +struct mutex lock; +/** +* @gsm: The iomem pointer to the actual location of the translation +* table located in the GSM for easy PTE manipulation +*/ +u64 __iomem *gsm; +/** @pt_ops: Page Table operations per platform */ +const struct xe_ggtt_pt_ops *pt_ops; +/** @mm: The memory manager used to manage individual GGTT allocations */ +struct drm_mm mm; +/** @access_count: counts GGTT writes */ +unsigned int access_count; +/** @wq: Dedicated unordered work queue to process node removals */ +struct workqueue_struct *wq; +};static u64 xelp_ggtt_pte_encode_bo (struct xe_bo *bo,u64 bo_offset,u16 pat_index)
drivers/gpu/drm/xe/xe_ggtt_types.h +1 -38
@@ -12,47 +12,10 @@struct xe_bo ;struct xe_gt ; +struct xe_ggtt ;typedef u64 (*xe_ggtt_pte_encode_bo_fn )(struct xe_bo *bo,u64 bo_offset,u16 pat_index); -/** -* struct xe_ggtt - Main GGTT struct -* -* In general, each tile can contains its own Global Graphics Translation Table -* (GGTT) instance. -*/ -struct xe_ggtt { -/** @tile: Back pointer to tile where this GGTT belongs */ -struct xe_tile *tile; -/** @size: Total size of this GGTT */ -u64 size; - -#define XE_GGTT_FLAGS_64K BIT(0) -/** -* @flags: Flags for this GGTT -* Acceptable flags: -* - %XE_GGTT_FLAGS_64K - if PTE size is 64K. Otherwise, regular is 4K. -*/ -unsigned int flags; -/** @scratch: Internal object allocation used as a scratch page */ -struct xe_bo *scratch; -/** @lock: Mutex lock to protect GGTT data */ -struct mutex lock; -/** -* @gsm: The iomem pointer to the actual location of the translation -* table located in the GSM for easy PTE manipulation -*/ -u64 __iomem *gsm; -/** @pt_ops: Page Table operations per platform */ -const struct xe_ggtt_pt_ops *pt_ops; -/** @mm: The memory manager used to manage individual GGTT allocations */ -struct drm_mm mm; -/** @access_count: counts GGTT writes */ -unsigned int access_count; -/** @wq: Dedicated unordered work queue to process node removals */ -struct workqueue_struct *wq; -}; -/** * struct xe_ggtt_node - A node in GGTT. *
Signature · 1 line
2.45.2
Re: [PATCH v3 12/12] drm/xe: Move struct xe_ggtt to xe_ggtt.c
Quoted 5 lines · Maarten Lankhorst
No users left outside of
xe_ggtt.c, so we can make the struct private.This prevents us from accidentally touching it before init.
Signed-off-by Maarten Lankhorst <[email protected]>
This is a good cleanup and honestly we likely should do across the Xe driver for various public structs which no reason to be public (mostly my fault). This enforces correct layering which is a very good thing.
With that:
Quoted 109 lines
--- drivers/gpu/drm/xe/xe_ggtt.c | 37 ++++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_ggtt_types.h | 39 +----------------------------- 2 files changed, 38 insertions(+), 38 deletions(-)drivers/gpu/drm/xe/xe_ggtt.c +37
-0@@ -74,6 +74,43 @@ struct xe_ggtt_pt_ops {void (*ggtt_set_pte)(struct xe_ggtt *ggtt,u64 addr,u64 pte); }; +/** +* struct xe_ggtt - Main GGTT struct +* +* In general, each tile can contains its own Global Graphics Translation Table +* (GGTT) instance. +*/ +struct xe_ggtt { +/** @tile: Back pointer to tile where this GGTT belongs */ +struct xe_tile *tile; +/** @size: Total size of this GGTT */ +u64 size; + +#define XE_GGTT_FLAGS_64K BIT(0) +/** +* @flags: Flags for this GGTT +* Acceptable flags: +* - %XE_GGTT_FLAGS_64K - if PTE size is 64K. Otherwise, regular is 4K. +*/ +unsigned int flags; +/** @scratch: Internal object allocation used as a scratch page */ +struct xe_bo *scratch; +/** @lock: Mutex lock to protect GGTT data */ +struct mutex lock; +/** +* @gsm: The iomem pointer to the actual location of the translation +* table located in the GSM for easy PTE manipulation +*/ +u64 __iomem *gsm; +/** @pt_ops: Page Table operations per platform */ +const struct xe_ggtt_pt_ops *pt_ops; +/** @mm: The memory manager used to manage individual GGTT allocations */ +struct drm_mm mm; +/** @access_count: counts GGTT writes */ +unsigned int access_count; +/** @wq: Dedicated unordered work queue to process node removals */ +struct workqueue_struct *wq; +};static u64 xelp_ggtt_pte_encode_bo (struct xe_bo *bo,u64 bo_offset,u16 pat_index)drivers/gpu/drm/xe/xe_ggtt_types.h +1
-38@@ -12,47 +12,10 @@struct xe_bo ;struct xe_gt ; +struct xe_ggtt ;typedef u64 (*xe_ggtt_pte_encode_bo_fn )(struct xe_bo *bo,u64 bo_offset,u16 pat_index); -/** -* struct xe_ggtt - Main GGTT struct -* -* In general, each tile can contains its own Global Graphics Translation Table -* (GGTT) instance. -*/ -struct xe_ggtt { -/** @tile: Back pointer to tile where this GGTT belongs */ -struct xe_tile *tile; -/** @size: Total size of this GGTT */ -u64 size; - -#define XE_GGTT_FLAGS_64K BIT(0) -/** -* @flags: Flags for this GGTT -* Acceptable flags: -* - %XE_GGTT_FLAGS_64K - if PTE size is 64K. Otherwise, regular is 4K. -*/ -unsigned int flags; -/** @scratch: Internal object allocation used as a scratch page */ -struct xe_bo *scratch; -/** @lock: Mutex lock to protect GGTT data */ -struct mutex lock; -/** -* @gsm: The iomem pointer to the actual location of the translation -* table located in the GSM for easy PTE manipulation -*/ -u64 __iomem *gsm; -/** @pt_ops: Page Table operations per platform */ -const struct xe_ggtt_pt_ops *pt_ops; -/** @mm: The memory manager used to manage individual GGTT allocations */ -struct drm_mm mm; -/** @access_count: counts GGTT writes */ -unsigned int access_count; -/** @wq: Dedicated unordered work queue to process node removals */ -struct workqueue_struct *wq; -}; -/** * struct xe_ggtt_node - A node in GGTT. * Signature · 1 line
2.45.2
Patchwork
CI✓ CI.Patch_applied: success for drm/xe: Reduce flickering when inheriting BIOS fb.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb.
URL : https://patchwork.freedesktop.org/series/139516/
State : success
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 17c0158bdb23 drm-tip: 2024y-10m-03d-14h-08m-13s UTC integration manifest === git am output follows ===
Applying: drm/xe/display: Handle stolen bar readout in the same way as lmem
Applying: drm/xe: Remove double pageflip
Applying: drm/i915/display: Use async flip when available for initial plane config
Applying: drm/xe/display: Remove single wait for vblank
Applying: drm/xe: Move suballocator init to after display init
Applying: drm/xe: Use xe_ggtt_map_bo_unlocked for resume
Applying: drm/xe: Add xe_ggtt_might_lock
Applying: drm/xe: Add xe_ggtt_alloc
Applying: drm/xe: Abstract read/write functions for GGTT PTEs
Applying: drm/xe: Make xe_ggtt_pt_ops private
Applying: drm/xe/display: Stop dereferencing ggtt in xe_fb_pin
Applying: drm/xe: Move struct xe_ggtt to xe_ggtt.c
Patchwork
CI✗ CI.checkpatch: warning for drm/xe: Reduce flickering when inheriting BIOS fb.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb.
URL : https://patchwork.freedesktop.org/series/139516/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 30ab6715fc09baee6cc14cb3c89ad8858688d474
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4718dce252b04e0a5531024295bacfe57f4f44f6
Author: Maarten Lankhorst <[email protected]> Date: Thu Oct 3 17:44:21 2024 +0200
drm/xe: Move struct xe_ggtt to xe_ggtt.c
No users left outside of xe_ggtt.c, so we can make the struct private.
This prevents us from accidentally touching it before init.
+ /mt/dim checkpatch 17c0158bdb239d8b6d23834db5595ea422b69915 drm-intel 76d7456efd8a drm/xe/display: Handle stolen bar readout in the same way as lmem ffa1365b0434 drm/xe: Remove double pageflip72a9f074a561 drm/i915/display: Use async flip when available for initial plane config 7288339db3f2 drm/xe/display: Remove single wait for vblankc499ff2f1cf2 drm/xe: Move suballocator init to after display init 821d2a0e69e0 drm/xe: Use xe_ggtt_map_bo_unlocked for resume 2a7a67143421 drm/xe: Add xe_ggtt_might_lock028643f94e47 drm/xe: Add xe_ggtt_alloc
-:22: WARNING:LINE_SPACING: Missing a blank line after declarations #22: FILE: drivers/gpu/drm/xe/xe_ggtt.c:166:
+ struct xe_ggtt *ggtt = drmm_kzalloc(&tile_to_xe(tile)->drm, sizeof(*ggtt), GFP_KERNEL);
+ if (ggtt)
total: 0 errors, 1 warnings, 0 checks, 35 lines checked 58ecc2b1f800 drm/xe: Abstract read/write functions for GGTT PTEs 275263c3b84a drm/xe: Make xe_ggtt_pt_ops private -:117: CHECK:LINE_SPACING: Please don't use multiple blank lines #117: FILE: drivers/gpu/drm/xe/xe_ggtt.c:78:
+
+
total: 0 errors, 0 warnings, 1 checks, 137 lines checked 4435f04ceacc drm/xe/display: Stop dereferencing ggtt in xe_fb_pin 4718dce252b0 drm/xe: Move struct xe_ggtt to xe_ggtt.c
Patchwork
CI✓ CI.KUnit: success for drm/xe: Reduce flickering when inheriting BIOS fb.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb.
URL : https://patchwork.freedesktop.org/series/139516/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [16:56:30] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[16:56:35] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json ARCH=um O=.kunit --jobs=48
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~[16:57:03] Starting KUnit Kernel (1/1)...
[16:57:03] ============================================================ Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [16:57:03] =================== guc_dbm (7 subtests) =================== [16:57:03] [PASSED] test_empty [16:57:03] [PASSED] test_default [16:57:03] ======================== test_size ======================== [16:57:03] [PASSED] 4 [16:57:03] [PASSED] 8 [16:57:03] [PASSED] 32 [16:57:03] [PASSED] 256 [16:57:03] ==================== [PASSED] test_size ==================== [16:57:03] ======================= test_reuse ======================== [16:57:03] [PASSED] 4 [16:57:03] [PASSED] 8 [16:57:03] [PASSED] 32 [16:57:03] [PASSED] 256 [16:57:03] =================== [PASSED] test_reuse ==================== [16:57:03] =================== test_range_overlap ==================== [16:57:03] [PASSED] 4 [16:57:03] [PASSED] 8 [16:57:03] [PASSED] 32 [16:57:03] [PASSED] 256 [16:57:03] =============== [PASSED] test_range_overlap ================ [16:57:03] =================== test_range_compact ==================== [16:57:03] [PASSED] 4 [16:57:03] [PASSED] 8 [16:57:03] [PASSED] 32 [16:57:03] [PASSED] 256 [16:57:03] =============== [PASSED] test_range_compact ================ [16:57:03] ==================== test_range_spare ===================== [16:57:03] [PASSED] 4 [16:57:03] [PASSED] 8 [16:57:03] [PASSED] 32 [16:57:03] [PASSED] 256 [16:57:03] ================ [PASSED] test_range_spare ================= [16:57:03] ===================== [PASSED] guc_dbm ===================== [16:57:03] =================== guc_idm (6 subtests) =================== [16:57:03] [PASSED] bad_init [16:57:03] [PASSED] no_init [16:57:03] [PASSED] init_fini [16:57:03] [PASSED] check_used [16:57:03] [PASSED] check_quota [16:57:03] [PASSED] check_all [16:57:03] ===================== [PASSED] guc_idm ===================== [16:57:03] ================== no_relay (3 subtests) =================== [16:57:03] [PASSED] xe_drops_guc2pf_if_not_ready [16:57:03] [PASSED] xe_drops_guc2vf_if_not_ready [16:57:03] [PASSED] xe_rejects_send_if_not_ready [16:57:03] ==================== [PASSED] no_relay ===================== [16:57:03] ================== pf_relay (14 subtests) ================== [16:57:03] [PASSED] pf_rejects_guc2pf_too_short [16:57:03] [PASSED] pf_rejects_guc2pf_too_long [16:57:03] [PASSED] pf_rejects_guc2pf_no_payload [16:57:03] [PASSED] pf_fails_no_payload [16:57:03] [PASSED] pf_fails_bad_origin [16:57:03] [PASSED] pf_fails_bad_type [16:57:03] [PASSED] pf_txn_reports_error [16:57:03] [PASSED] pf_txn_sends_pf2guc [16:57:03] [PASSED] pf_sends_pf2guc [16:57:03] [SKIPPED] pf_loopback_nop [16:57:03] [SKIPPED] pf_loopback_echo [16:57:03] [SKIPPED] pf_loopback_fail [16:57:03] [SKIPPED] pf_loopback_busy [16:57:03] [SKIPPED] pf_loopback_retry [16:57:03] ==================== [PASSED] pf_relay ===================== [16:57:03] ================== vf_relay (3 subtests) =================== [16:57:03] [PASSED] vf_rejects_guc2vf_too_short [16:57:03] [PASSED] vf_rejects_guc2vf_too_long [16:57:03] [PASSED] vf_rejects_guc2vf_no_payload [16:57:03] ==================== [PASSED] vf_relay ===================== [16:57:03] ================= pf_service (11 subtests) ================= [16:57:03] [PASSED] pf_negotiate_any [16:57:03] [PASSED] pf_negotiate_base_match [16:57:03] [PASSED] pf_negotiate_base_newer [16:57:03] [PASSED] pf_negotiate_base_next [16:57:03] [SKIPPED] pf_negotiate_base_older [16:57:03] [PASSED] pf_negotiate_base_prev [16:57:03] [PASSED] pf_negotiate_latest_match [16:57:03] [PASSED] pf_negotiate_latest_newer [16:57:03] [PASSED] pf_negotiate_latest_next [16:57:03] [SKIPPED] pf_negotiate_latest_older [16:57:03] [SKIPPED] pf_negotiate_latest_prev [16:57:03] =================== [PASSED] pf_service ==================== [16:57:03] ===================== lmtt (1 subtest) ===================== [16:57:03] ======================== test_ops ========================= [16:57:03] [PASSED] 2-level [16:57:03] [PASSED] multi-level [16:57:03] ==================== [PASSED] test_ops ===================== [16:57:03] ====================== [PASSED] lmtt ======================= [16:57:03] =================== xe_mocs (2 subtests) =================== [16:57:03] ================ xe_live_mocs_kernel_kunit ================ [16:57:03] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [16:57:03] ================ xe_live_mocs_reset_kunit ================= [16:57:03] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [16:57:03] ==================== [SKIPPED] xe_mocs ===================== [16:57:03] ================= xe_migrate (2 subtests) ================== [16:57:03] ================= xe_migrate_sanity_kunit ================= [16:57:03] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [16:57:03] ================== xe_validate_ccs_kunit ================== [16:57:03] ============= [SKIPPED] xe_validate_ccs_kunit ============== [16:57:03] =================== [SKIPPED] xe_migrate =================== [16:57:03] ================== xe_dma_buf (1 subtest) ================== [16:57:03] ==================== xe_dma_buf_kunit ===================== [16:57:03] ================ [SKIPPED] xe_dma_buf_kunit ================ [16:57:03] =================== [SKIPPED] xe_dma_buf =================== [16:57:03] ==================== xe_bo (3 subtests) ==================== [16:57:03] ================== xe_ccs_migrate_kunit =================== [16:57:03] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [16:57:03] ==================== xe_bo_evict_kunit ==================== [16:57:03] =============== [SKIPPED] xe_bo_evict_kunit ================ [16:57:03] =================== xe_bo_shrink_kunit ==================== [16:57:03] =============== [SKIPPED] xe_bo_shrink_kunit =============== [16:57:03] ===================== [SKIPPED] xe_bo ====================== [16:57:03] ==================== args (11 subtests) ==================== [16:57:03] [PASSED] count_args_test [16:57:03] [PASSED] call_args_example [16:57:03] [PASSED] call_args_test [16:57:03] [PASSED] drop_first_arg_example [16:57:03] [PASSED] drop_first_arg_test [16:57:03] [PASSED] first_arg_example [16:57:03] [PASSED] first_arg_test [16:57:03] [PASSED] last_arg_example [16:57:03] [PASSED] last_arg_test [16:57:03] [PASSED] pick_arg_example [16:57:03] [PASSED] sep_comma_examplestty: 'standard input': Inappropriate ioctl for device
[16:57:03] ====================== [PASSED] args ======================= [16:57:03] =================== xe_pci (2 subtests) ==================== [16:57:03] [PASSED] xe_gmdid_graphics_ip
[16:57:03] [PASSED] xe_gmdid_media_ip
[16:57:03] ===================== [PASSED] xe_pci ====================== [16:57:03] =================== xe_rtp (2 subtests) ==================== [16:57:03] =============== xe_rtp_process_to_sr_tests ================ [16:57:03] [PASSED] coalesce-same-reg
[16:57:03] [PASSED] no-match-no-add
[16:57:03] [PASSED] match-or
[16:57:03] [PASSED] match-or-xfail
[16:57:03] [PASSED] no-match-no-add-multiple-rules
[16:57:03] [PASSED] two-regs-two-entries
[16:57:03] [PASSED] clr-one-set-other
[16:57:03] [PASSED] set-field
[16:57:03] [PASSED] conflict-duplicate
[16:57:03] [PASSED] conflict-not-disjoint
[16:57:03] [PASSED] conflict-reg-type
[16:57:03] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [16:57:03] ================== xe_rtp_process_tests =================== [16:57:03] [PASSED] active1
[16:57:03] [PASSED] active2
[16:57:03] [PASSED] active-inactive
[16:57:03] [PASSED] inactive-active
[16:57:03] [PASSED] inactive-1st_or_active-inactive
[16:57:03] [PASSED] inactive-2nd_or_active-inactive
[16:57:03] [PASSED] inactive-last_or_active-inactive
[16:57:03] [PASSED] inactive-no_or_active-inactive
[16:57:03] ============== [PASSED] xe_rtp_process_tests =============== [16:57:03] ===================== [PASSED] xe_rtp ====================== [16:57:03] ==================== xe_wa (1 subtest) ===================== [16:57:03] ======================== xe_wa_gt ========================= [16:57:03] [PASSED] TIGERLAKE (B0)
[16:57:03] [PASSED] DG1 (A0)
[16:57:03] [PASSED] DG1 (B0)
[16:57:03] [PASSED] ALDERLAKE_S (A0)
[16:57:03] [PASSED] ALDERLAKE_S (B0)
[16:57:03] [PASSED] ALDERLAKE_S (C0)
[16:57:03] [PASSED] ALDERLAKE_S (D0)
[16:57:03] [PASSED] ALDERLAKE_P (A0)
[16:57:03] [PASSED] ALDERLAKE_P (B0)
[16:57:03] [PASSED] ALDERLAKE_P (C0)
[16:57:03] [PASSED] ALDERLAKE_S_RPLS (D0)
[16:57:03] [PASSED] ALDERLAKE_P_RPLU (E0)
[16:57:03] [PASSED] DG2_G10 (C0)
[16:57:03] [PASSED] DG2_G11 (B1)
[16:57:03] [PASSED] DG2_G12 (A1)
[16:57:03] [PASSED] METEORLAKE (g:A0, m:A0)
[16:57:03] [PASSED] METEORLAKE (g:A0, m:A0)
[16:57:03] [PASSED] METEORLAKE (g:A0, m:A0)
[16:57:03] [PASSED] LUNARLAKE (g:A0, m:A0)
[16:57:03] [PASSED] LUNARLAKE (g:B0, m:A0)
[16:57:03] [PASSED] BATTLEMAGE (g:A0, m:A1)
[16:57:03] ==================== [PASSED] xe_wa_gt ===================== [16:57:03] ====================== [PASSED] xe_wa ====================== [16:57:03] ============================================================ [16:57:03] Testing complete. Ran 122 tests: passed: 106, skipped: 16 [16:57:03] Elapsed time: 32.641s total, 4.432s configuring, 27.943s building, 0.217s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [16:57:03] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[16:57:05] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json ARCH=um O=.kunit --jobs=48
../lib/iomap.c:156:5: warning: no previous prototype for ‘ioread64_lo_hi’ [-Wmissing-prototypes]
156 | u64 ioread64_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:163:5: warning: no previous prototype for ‘ioread64_hi_lo’ [-Wmissing-prototypes]
163 | u64 ioread64_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~
../lib/iomap.c:170:5: warning: no previous prototype for ‘ioread64be_lo_hi’ [-Wmissing-prototypes]
170 | u64 ioread64be_lo_hi(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:178:5: warning: no previous prototype for ‘ioread64be_hi_lo’ [-Wmissing-prototypes]
178 | u64 ioread64be_hi_lo(const void __iomem *addr)
| ^~~~~~~~~~~~~~~~
../lib/iomap.c:264:6: warning: no previous prototype for ‘iowrite64_lo_hi’ [-Wmissing-prototypes]
264 | void iowrite64_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:272:6: warning: no previous prototype for ‘iowrite64_hi_lo’ [-Wmissing-prototypes]
272 | void iowrite64_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~
../lib/iomap.c:280:6: warning: no previous prototype for ‘iowrite64be_lo_hi’ [-Wmissing-prototypes]
280 | void iowrite64be_lo_hi(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~
../lib/iomap.c:288:6: warning: no previous prototype for ‘iowrite64be_hi_lo’ [-Wmissing-prototypes]
288 | void iowrite64be_hi_lo(u64 val, void __iomem *addr)
| ^~~~~~~~~~~~~~~~~[16:57:28] Starting KUnit Kernel (1/1)...
[16:57:28] ============================================================ Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [16:57:28] ============ drm_test_pick_cmdline (2 subtests) ============ [16:57:28] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [16:57:28] =============== drm_test_pick_cmdline_named =============== [16:57:28] [PASSED] NTSC [16:57:28] [PASSED] NTSC-J [16:57:28] [PASSED] PAL [16:57:28] [PASSED] PAL-M [16:57:28] =========== [PASSED] drm_test_pick_cmdline_named =========== [16:57:28] ============== [PASSED] drm_test_pick_cmdline ============== [16:57:28] ================== drm_buddy (7 subtests) ================== [16:57:28] [PASSED] drm_test_buddy_alloc_limit [16:57:28] [PASSED] drm_test_buddy_alloc_optimistic [16:57:28] [PASSED] drm_test_buddy_alloc_pessimistic [16:57:28] [PASSED] drm_test_buddy_alloc_pathological [16:57:28] [PASSED] drm_test_buddy_alloc_contiguous [16:57:28] [PASSED] drm_test_buddy_alloc_clear [16:57:28] [PASSED] drm_test_buddy_alloc_range_bias [16:57:28] ==================== [PASSED] drm_buddy ==================== [16:57:28] ============= drm_cmdline_parser (40 subtests) ============= [16:57:28] [PASSED] drm_test_cmdline_force_d_only [16:57:28] [PASSED] drm_test_cmdline_force_D_only_dvi [16:57:28] [PASSED] drm_test_cmdline_force_D_only_hdmi [16:57:28] [PASSED] drm_test_cmdline_force_D_only_not_digital [16:57:28] [PASSED] drm_test_cmdline_force_e_only [16:57:28] [PASSED] drm_test_cmdline_res [16:57:28] [PASSED] drm_test_cmdline_res_vesa [16:57:28] [PASSED] drm_test_cmdline_res_vesa_rblank [16:57:28] [PASSED] drm_test_cmdline_res_rblank [16:57:28] [PASSED] drm_test_cmdline_res_bpp [16:57:28] [PASSED] drm_test_cmdline_res_refresh [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [16:57:28] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [16:57:28] [PASSED] drm_test_cmdline_res_margins_force_on [16:57:28] [PASSED] drm_test_cmdline_res_vesa_margins [16:57:28] [PASSED] drm_test_cmdline_name [16:57:28] [PASSED] drm_test_cmdline_name_bpp [16:57:28] [PASSED] drm_test_cmdline_name_option [16:57:28] [PASSED] drm_test_cmdline_name_bpp_option [16:57:28] [PASSED] drm_test_cmdline_rotate_0 [16:57:28] [PASSED] drm_test_cmdline_rotate_90 [16:57:28] [PASSED] drm_test_cmdline_rotate_180 [16:57:28] [PASSED] drm_test_cmdline_rotate_270 [16:57:28] [PASSED] drm_test_cmdline_hmirror [16:57:28] [PASSED] drm_test_cmdline_vmirror [16:57:28] [PASSED] drm_test_cmdline_margin_options [16:57:28] [PASSED] drm_test_cmdline_multiple_options [16:57:28] [PASSED] drm_test_cmdline_bpp_extra_and_option [16:57:28] [PASSED] drm_test_cmdline_extra_and_option [16:57:28] [PASSED] drm_test_cmdline_freestanding_options [16:57:28] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [16:57:28] [PASSED] drm_test_cmdline_panel_orientation [16:57:28] ================ drm_test_cmdline_invalid ================= [16:57:28] [PASSED] margin_only [16:57:28] [PASSED] interlace_only [16:57:28] [PASSED] res_missing_x [16:57:28] [PASSED] res_missing_y [16:57:28] [PASSED] res_bad_y [16:57:28] [PASSED] res_missing_y_bpp [16:57:28] [PASSED] res_bad_bpp [16:57:28] [PASSED] res_bad_refresh [16:57:28] [PASSED] res_bpp_refresh_force_on_off [16:57:28] [PASSED] res_invalid_mode [16:57:28] [PASSED] res_bpp_wrong_place_mode [16:57:28] [PASSED] name_bpp_refresh [16:57:28] [PASSED] name_refresh [16:57:28] [PASSED] name_refresh_wrong_mode [16:57:28] [PASSED] name_refresh_invalid_mode [16:57:28] [PASSED] rotate_multiple [16:57:28] [PASSED] rotate_invalid_val [16:57:28] [PASSED] rotate_truncated [16:57:28] [PASSED] invalid_option [16:57:28] [PASSED] invalid_tv_option [16:57:28] [PASSED] truncated_tv_option [16:57:28] ============ [PASSED] drm_test_cmdline_invalid ============= [16:57:28] =============== drm_test_cmdline_tv_options =============== [16:57:28] [PASSED] NTSC [16:57:28] [PASSED] NTSC_443 [16:57:28] [PASSED] NTSC_J [16:57:28] [PASSED] PAL [16:57:28] [PASSED] PAL_M [16:57:28] [PASSED] PAL_N [16:57:28] [PASSED] SECAM [16:57:28] [PASSED] MONO_525 [16:57:28] [PASSED] MONO_625 [16:57:28] =========== [PASSED] drm_test_cmdline_tv_options =========== [16:57:28] =============== [PASSED] drm_cmdline_parser ================ [16:57:28] ========== drmm_connector_hdmi_init (19 subtests) ========== [16:57:28] [PASSED] drm_test_connector_hdmi_init_valid [16:57:28] [PASSED] drm_test_connector_hdmi_init_bpc_8 [16:57:28] [PASSED] drm_test_connector_hdmi_init_bpc_10 [16:57:28] [PASSED] drm_test_connector_hdmi_init_bpc_12 [16:57:28] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [16:57:28] [PASSED] drm_test_connector_hdmi_init_bpc_null [16:57:28] [PASSED] drm_test_connector_hdmi_init_formats_empty [16:57:28] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [16:57:28] [PASSED] drm_test_connector_hdmi_init_null_ddc [16:57:28] [PASSED] drm_test_connector_hdmi_init_null_product [16:57:28] [PASSED] drm_test_connector_hdmi_init_null_vendor [16:57:28] [PASSED] drm_test_connector_hdmi_init_product_length_exact [16:57:28] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [16:57:28] [PASSED] drm_test_connector_hdmi_init_product_valid [16:57:28] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [16:57:28] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [16:57:28] [PASSED] drm_test_connector_hdmi_init_vendor_valid [16:57:28] ========= drm_test_connector_hdmi_init_type_valid ========= [16:57:28] [PASSED] HDMI-A [16:57:28] [PASSED] HDMI-B [16:57:28] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [16:57:28] ======== drm_test_connector_hdmi_init_type_invalid ======== [16:57:28] [PASSED] Unknown [16:57:28] [PASSED] VGA [16:57:28] [PASSED] DVI-I [16:57:28] [PASSED] DVI-D [16:57:28] [PASSED] DVI-A [16:57:28] [PASSED] Composite [16:57:28] [PASSED] SVIDEO [16:57:28] [PASSED] LVDS [16:57:28] [PASSED] Component [16:57:28] [PASSED] DIN [16:57:28] [PASSED] DP [16:57:28] [PASSED] TV [16:57:28] [PASSED] eDP [16:57:28] [PASSED] Virtual [16:57:28] [PASSED] DSI [16:57:28] [PASSED] DPI [16:57:28] [PASSED] Writeback [16:57:28] [PASSED] SPI [16:57:28] [PASSED] USB [16:57:28] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [16:57:28] ============ [PASSED] drmm_connector_hdmi_init ============= [16:57:28] ============= drmm_connector_init (3 subtests) ============= [16:57:28] [PASSED] drm_test_drmm_connector_init [16:57:28] [PASSED] drm_test_drmm_connector_init_null_ddc [16:57:28] ========= drm_test_drmm_connector_init_type_valid ========= [16:57:28] [PASSED] Unknown [16:57:28] [PASSED] VGA [16:57:28] [PASSED] DVI-I [16:57:28] [PASSED] DVI-D [16:57:28] [PASSED] DVI-A [16:57:28] [PASSED] Composite [16:57:28] [PASSED] SVIDEO [16:57:28] [PASSED] LVDS [16:57:28] [PASSED] Component [16:57:28] [PASSED] DIN [16:57:28] [PASSED] DP [16:57:28] [PASSED] HDMI-A [16:57:28] [PASSED] HDMI-B [16:57:28] [PASSED] TV [16:57:28] [PASSED] eDP [16:57:28] [PASSED] Virtual [16:57:28] [PASSED] DSI [16:57:28] [PASSED] DPI [16:57:28] [PASSED] Writeback [16:57:28] [PASSED] SPI [16:57:28] [PASSED] USB [16:57:28] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [16:57:28] =============== [PASSED] drmm_connector_init =============== [16:57:28] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [16:57:28] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [16:57:28] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [16:57:28] === [PASSED] drm_connector_attach_broadcast_rgb_property === [16:57:28] ========== drm_get_tv_mode_from_name (2 subtests) ========== [16:57:28] ========== drm_test_get_tv_mode_from_name_valid =========== [16:57:28] [PASSED] NTSC [16:57:28] [PASSED] NTSC-443 [16:57:28] [PASSED] NTSC-J [16:57:28] [PASSED] PAL [16:57:28] [PASSED] PAL-M [16:57:28] [PASSED] PAL-N [16:57:28] [PASSED] SECAM [16:57:28] [PASSED] Mono [16:57:28] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [16:57:28] [PASSED] drm_test_get_tv_mode_from_name_truncated [16:57:28] ============ [PASSED] drm_get_tv_mode_from_name ============ [16:57:28] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [16:57:28] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [16:57:28] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [16:57:28] [PASSED] VIC 96 [16:57:28] [PASSED] VIC 97 [16:57:28] [PASSED] VIC 101 [16:57:28] [PASSED] VIC 102 [16:57:28] [PASSED] VIC 106 [16:57:28] [PASSED] VIC 107 [16:57:28] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [16:57:28] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [16:57:28] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [16:57:28] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [16:57:28] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [16:57:28] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [16:57:28] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [16:57:28] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [16:57:28] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [16:57:28] [PASSED] Automatic [16:57:28] [PASSED] Full [16:57:28] [PASSED] Limited 16:235 [16:57:28] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [16:57:28] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [16:57:28] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [16:57:28] == drm_hdmi_connector_get_output_format_name (2 subtests) == [16:57:28] === drm_test_drm_hdmi_connector_get_output_format_name ==== [16:57:28] [PASSED] RGB [16:57:28] [PASSED] YUV 4:2:0 [16:57:28] [PASSED] YUV 4:2:2 [16:57:28] [PASSED] YUV 4:4:4 [16:57:28] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [16:57:28] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [16:57:28] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [16:57:28] ============= drm_damage_helper (21 subtests) ============== [16:57:28] [PASSED] drm_test_damage_iter_no_damage [16:57:28] [PASSED] drm_test_damage_iter_no_damage_fractional_src [16:57:28] [PASSED] drm_test_damage_iter_no_damage_src_moved [16:57:28] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [16:57:28] [PASSED] drm_test_damage_iter_no_damage_not_visible [16:57:28] [PASSED] drm_test_damage_iter_no_damage_no_crtc [16:57:28] [PASSED] drm_test_damage_iter_no_damage_no_fb [16:57:28] [PASSED] drm_test_damage_iter_simple_damage [16:57:28] [PASSED] drm_test_damage_iter_single_damage [16:57:28] [PASSED] drm_test_damage_iter_single_damage_intersect_src [16:57:28] [PASSED] drm_test_damage_iter_single_damage_outside_src [16:57:28] [PASSED] drm_test_damage_iter_single_damage_fractional_src [16:57:28] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [16:57:28] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [16:57:28] [PASSED] drm_test_damage_iter_single_damage_src_moved [16:57:28] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [16:57:28] [PASSED] drm_test_damage_iter_damage [16:57:28] [PASSED] drm_test_damage_iter_damage_one_intersect [16:57:28] [PASSED] drm_test_damage_iter_damage_one_outside [16:57:28] [PASSED] drm_test_damage_iter_damage_src_moved [16:57:28] [PASSED] drm_test_damage_iter_damage_not_visible [16:57:28] ================ [PASSED] drm_damage_helper ================ [16:57:28] ============== drm_dp_mst_helper (3 subtests) ============== [16:57:28] ============== drm_test_dp_mst_calc_pbn_mode ============== [16:57:28] [PASSED] Clock 154000 BPP 30 DSC disabled [16:57:28] [PASSED] Clock 234000 BPP 30 DSC disabled [16:57:28] [PASSED] Clock 297000 BPP 24 DSC disabled [16:57:28] [PASSED] Clock 332880 BPP 24 DSC enabled [16:57:28] [PASSED] Clock 324540 BPP 24 DSC enabled [16:57:28] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [16:57:28] ============== drm_test_dp_mst_calc_pbn_div =============== [16:57:28] [PASSED] Link rate 2000000 lane count 4 [16:57:28] [PASSED] Link rate 2000000 lane count 2 [16:57:28] [PASSED] Link rate 2000000 lane count 1 [16:57:28] [PASSED] Link rate 1350000 lane count 4 [16:57:28] [PASSED] Link rate 1350000 lane count 2 [16:57:28] [PASSED] Link rate 1350000 lane count 1 [16:57:28] [PASSED] Link rate 1000000 lane count 4 [16:57:28] [PASSED] Link rate 1000000 lane count 2 [16:57:28] [PASSED] Link rate 1000000 lane count 1 [16:57:28] [PASSED] Link rate 810000 lane count 4 [16:57:28] [PASSED] Link rate 810000 lane count 2 [16:57:28] [PASSED] Link rate 810000 lane count 1 [16:57:28] [PASSED] Link rate 540000 lane count 4 [16:57:28] [PASSED] Link rate 540000 lane count 2 [16:57:28] [PASSED] Link rate 540000 lane count 1 [16:57:28] [PASSED] Link rate 270000 lane count 4 [16:57:28] [PASSED] Link rate 270000 lane count 2 [16:57:28] [PASSED] Link rate 270000 lane count 1 [16:57:28] [PASSED] Link rate 162000 lane count 4 [16:57:28] [PASSED] Link rate 162000 lane count 2 [16:57:28] [PASSED] Link rate 162000 lane count 1 [16:57:28] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [16:57:28] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [16:57:28] [PASSED] DP_ENUM_PATH_RESOURCES with port number [16:57:28] [PASSED] DP_POWER_UP_PHY with port number [16:57:28] [PASSED] DP_POWER_DOWN_PHY with port number [16:57:28] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [16:57:28] [PASSED] DP_ALLOCATE_PAYLOAD with port number [16:57:28] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [16:57:28] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [16:57:28] [PASSED] DP_QUERY_PAYLOAD with port number [16:57:28] [PASSED] DP_QUERY_PAYLOAD with VCPI [16:57:28] [PASSED] DP_REMOTE_DPCD_READ with port number [16:57:28] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [16:57:28] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [16:57:28] [PASSED] DP_REMOTE_DPCD_WRITE with port number [16:57:28] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [16:57:28] [PASSED] DP_REMOTE_DPCD_WRITE with data array [16:57:28] [PASSED] DP_REMOTE_I2C_READ with port number [16:57:28] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [16:57:28] [PASSED] DP_REMOTE_I2C_READ with transactions array [16:57:28] [PASSED] DP_REMOTE_I2C_WRITE with port number [16:57:28] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [16:57:28] [PASSED] DP_REMOTE_I2C_WRITE with data array [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [16:57:28] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [16:57:28] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [16:57:28] ================ [PASSED] drm_dp_mst_helper ================ [16:57:28] ================== drm_exec (7 subtests) =================== [16:57:28] [PASSED] sanitycheck [16:57:28] [PASSED] test_lock [16:57:28] [PASSED] test_lock_unlock [16:57:28] [PASSED] test_duplicates [16:57:28] [PASSED] test_prepare [16:57:28] [PASSED] test_prepare_array [16:57:28] [PASSED] test_multiple_loops [16:57:28] ==================== [PASSED] drm_exec ===================== [16:57:28] =========== drm_format_helper_test (17 subtests) =========== [16:57:28] ============== drm_test_fb_xrgb8888_to_gray8 ============== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [16:57:28] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [16:57:28] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [16:57:28] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [16:57:28] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [16:57:28] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [16:57:28] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [16:57:28] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [16:57:28] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [16:57:28] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [16:57:28] ============== drm_test_fb_xrgb8888_to_mono =============== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [16:57:28] ==================== drm_test_fb_swab ===================== [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ================ [PASSED] drm_test_fb_swab ================= [16:57:28] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [16:57:28] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [16:57:28] [PASSED] single_pixel_source_buffer [16:57:28] [PASSED] single_pixel_clip_rectangle [16:57:28] [PASSED] well_known_colors [16:57:28] [PASSED] destination_pitch [16:57:28] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [16:57:28] ================= drm_test_fb_clip_offset ================= [16:57:28] [PASSED] pass through [16:57:28] [PASSED] horizontal offset [16:57:28] [PASSED] vertical offset [16:57:28] [PASSED] horizontal and vertical offset [16:57:28] [PASSED] horizontal offset (custom pitch) [16:57:28] [PASSED] vertical offset (custom pitch) [16:57:28] [PASSED] horizontal and vertical offset (custom pitch) [16:57:28] ============= [PASSED] drm_test_fb_clip_offset ============= [16:57:28] ============== drm_test_fb_build_fourcc_list ============== [16:57:28] [PASSED] no native formats [16:57:28] [PASSED] XRGB8888 as native format [16:57:28] [PASSED] remove duplicates [16:57:28] [PASSED] convert alpha formats [16:57:28] [PASSED] random formats [16:57:28] ========== [PASSED] drm_test_fb_build_fourcc_list ========== [16:57:28] =================== drm_test_fb_memcpy ==================== [16:57:28] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [16:57:28] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [16:57:28] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [16:57:28] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [16:57:28] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [16:57:28] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [16:57:28] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [16:57:28] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [16:57:28] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [16:57:28] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [16:57:28] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [16:57:28] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [16:57:28] =============== [PASSED] drm_test_fb_memcpy ================ [16:57:28] ============= [PASSED] drm_format_helper_test ============== [16:57:28] ================= drm_format (18 subtests) ================= [16:57:28] [PASSED] drm_test_format_block_width_invalid [16:57:28] [PASSED] drm_test_format_block_width_one_plane [16:57:28] [PASSED] drm_test_format_block_width_two_plane [16:57:28] [PASSED] drm_test_format_block_width_three_plane [16:57:28] [PASSED] drm_test_format_block_width_tiled [16:57:28] [PASSED] drm_test_format_block_height_invalid [16:57:28] [PASSED] drm_test_format_block_height_one_plane [16:57:28] [PASSED] drm_test_format_block_height_two_plane [16:57:28] [PASSED] drm_test_format_block_height_three_plane [16:57:28] [PASSED] drm_test_format_block_height_tiled [16:57:28] [PASSED] drm_test_format_min_pitch_invalid [16:57:28] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [16:57:28] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [16:57:28] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [16:57:28] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [16:57:28] [PASSED] drm_test_format_min_pitch_two_plane [16:57:28] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [16:57:28] [PASSED] drm_test_format_min_pitch_tiled [16:57:28] =================== [PASSED] drm_format ==================== [16:57:28] ============== drm_framebuffer (10 subtests) =============== [16:57:28] ========== drm_test_framebuffer_check_src_coords ========== [16:57:28] [PASSED] Success: source fits into fb [16:57:28] [PASSED] Fail: overflowing fb with x-axis coordinate [16:57:28] [PASSED] Fail: overflowing fb with y-axis coordinate [16:57:28] [PASSED] Fail: overflowing fb with source width [16:57:28] [PASSED] Fail: overflowing fb with source height [16:57:28] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [16:57:28] [PASSED] drm_test_framebuffer_cleanup [16:57:28] =============== drm_test_framebuffer_create =============== [16:57:28] [PASSED] ABGR8888 normal sizes [16:57:28] [PASSED] ABGR8888 max sizes [16:57:28] [PASSED] ABGR8888 pitch greater than min required [16:57:28] [PASSED] ABGR8888 pitch less than min required [16:57:28] [PASSED] ABGR8888 Invalid width [16:57:28] [PASSED] ABGR8888 Invalid buffer handle [16:57:28] [PASSED] No pixel format [16:57:28] [PASSED] ABGR8888 Width 0 [16:57:28] [PASSED] ABGR8888 Height 0 [16:57:28] [PASSED] ABGR8888 Out of bound height * pitch combination [16:57:28] [PASSED] ABGR8888 Large buffer offset [16:57:28] [PASSED] ABGR8888 Buffer offset for inexistent plane [16:57:28] [PASSED] ABGR8888 Invalid flag [16:57:28] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [16:57:28] [PASSED] ABGR8888 Valid buffer modifier [16:57:28] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [16:57:28] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] NV12 Normal sizes [16:57:28] [PASSED] NV12 Max sizes [16:57:28] [PASSED] NV12 Invalid pitch [16:57:28] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [16:57:28] [PASSED] NV12 different modifier per-plane [16:57:28] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [16:57:28] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] NV12 Modifier for inexistent plane [16:57:28] [PASSED] NV12 Handle for inexistent plane [16:57:28] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [16:57:28] [PASSED] YVU420 Normal sizes [16:57:28] [PASSED] YVU420 Max sizes [16:57:28] [PASSED] YVU420 Invalid pitch [16:57:28] [PASSED] YVU420 Different pitches [16:57:28] [PASSED] YVU420 Different buffer offsets/pitches [16:57:28] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [16:57:28] [PASSED] YVU420 Valid modifier [16:57:28] [PASSED] YVU420 Different modifiers per plane [16:57:28] [PASSED] YVU420 Modifier for inexistent plane [16:57:28] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [16:57:28] [PASSED] X0L2 Normal sizes [16:57:28] [PASSED] X0L2 Max sizes [16:57:28] [PASSED] X0L2 Invalid pitch [16:57:28] [PASSED] X0L2 Pitch greater than minimum required [16:57:28] [PASSED] X0L2 Handle for inexistent plane [16:57:28] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [16:57:28] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [16:57:28] [PASSED] X0L2 Valid modifier [16:57:28] [PASSED] X0L2 Modifier for inexistent plane [16:57:28] =========== [PASSED] drm_test_framebuffer_create =========== [16:57:28] [PASSED] drm_test_framebuffer_free [16:57:28] [PASSED] drm_test_framebuffer_init [16:57:28] [PASSED] drm_test_framebuffer_init_bad_format [16:57:28] [PASSED] drm_test_framebuffer_init_dev_mismatch [16:57:28] [PASSED] drm_test_framebuffer_lookup [16:57:28] [PASSED] drm_test_framebuffer_lookup_inexistent [16:57:28] [PASSED] drm_test_framebuffer_modifiers_not_supported [16:57:28] ================= [PASSED] drm_framebuffer ================= [16:57:28] ================ drm_gem_shmem (8 subtests) ================ [16:57:28] [PASSED] drm_gem_shmem_test_obj_create [16:57:28] [PASSED] drm_gem_shmem_test_obj_create_private [16:57:28] [PASSED] drm_gem_shmem_test_pin_pages [16:57:28] [PASSED] drm_gem_shmem_test_vmap [16:57:28] [PASSED] drm_gem_shmem_test_get_pages_sgt [16:57:28] [PASSED] drm_gem_shmem_test_get_sg_table [16:57:28] [PASSED] drm_gem_shmem_test_madvise [16:57:28] [PASSED] drm_gem_shmem_test_purge [16:57:28] ================== [PASSED] drm_gem_shmem ================== [16:57:28] === drm_atomic_helper_connector_hdmi_check (22 subtests) === [16:57:28] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [16:57:28] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [16:57:28] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [16:57:28] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [16:57:28] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [16:57:28] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [16:57:28] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [16:57:28] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [16:57:28] [PASSED] drm_test_check_hdmi_funcs_reject_rate [16:57:28] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback [16:57:28] [PASSED] drm_test_check_max_tmds_rate_format_fallback [16:57:28] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [16:57:28] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [16:57:28] [PASSED] drm_test_check_output_bpc_dvi [16:57:28] [PASSED] drm_test_check_output_bpc_format_vic_1 [16:57:28] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [16:57:28] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [16:57:28] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [16:57:28] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [16:57:28] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [16:57:28] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [16:57:28] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [16:57:28] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [16:57:28] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [16:57:28] [PASSED] drm_test_check_broadcast_rgb_value [16:57:28] [PASSED] drm_test_check_bpc_8_value [16:57:28] [PASSED] drm_test_check_bpc_10_value [16:57:28] [PASSED] drm_test_check_bpc_12_value [16:57:28] [PASSED] drm_test_check_format_value [16:57:28] [PASSED] drm_test_check_tmds_char_value [16:57:28] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [16:57:28] ================= drm_managed (2 subtests) ================= [16:57:28] [PASSED] drm_test_managed_release_action [16:57:28] [PASSED] drm_test_managed_run_action [16:57:28] =================== [PASSED] drm_managed =================== [16:57:28] =================== drm_mm (6 subtests) ==================== [16:57:28] [PASSED] drm_test_mm_init [16:57:28] [PASSED] drm_test_mm_debug [16:57:28] [PASSED] drm_test_mm_align32 [16:57:28] [PASSED] drm_test_mm_align64 [16:57:28] [PASSED] drm_test_mm_lowest [16:57:28] [PASSED] drm_test_mm_highest [16:57:28] ===================== [PASSED] drm_mm ====================== [16:57:28] ============= drm_modes_analog_tv (5 subtests) ============= stty: 'standard input': Inappropriate ioctl for device [16:57:28] [PASSED] drm_test_modes_analog_tv_mono_576i [16:57:28] [PASSED] drm_test_modes_analog_tv_ntsc_480i [16:57:28] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [16:57:28] [PASSED] drm_test_modes_analog_tv_pal_576i [16:57:28] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [16:57:28] =============== [PASSED] drm_modes_analog_tv =============== [16:57:28] ============== drm_plane_helper (2 subtests) =============== [16:57:28] =============== drm_test_check_plane_state ================ [16:57:28] [PASSED] clipping_simple [16:57:28] [PASSED] clipping_rotate_reflect [16:57:28] [PASSED] positioning_simple [16:57:28] [PASSED] upscaling [16:57:28] [PASSED] downscaling [16:57:28] [PASSED] rounding1 [16:57:28] [PASSED] rounding2 [16:57:28] [PASSED] rounding3 [16:57:28] [PASSED] rounding4 [16:57:28] =========== [PASSED] drm_test_check_plane_state ============ [16:57:28] =========== drm_test_check_invalid_plane_state ============ [16:57:28] [PASSED] positioning_invalid [16:57:28] [PASSED] upscaling_invalid [16:57:28] [PASSED] downscaling_invalid [16:57:28] ======= [PASSED] drm_test_check_invalid_plane_state ======== [16:57:28] ================ [PASSED] drm_plane_helper ================= [16:57:28] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [16:57:28] ====== drm_test_connector_helper_tv_get_modes_check ======= [16:57:28] [PASSED] None [16:57:28] [PASSED] PAL [16:57:28] [PASSED] NTSC [16:57:28] [PASSED] Both, NTSC Default [16:57:28] [PASSED] Both, PAL Default [16:57:28] [PASSED] Both, NTSC Default, with PAL on command-line [16:57:28] [PASSED] Both, PAL Default, with NTSC on command-line [16:57:28] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [16:57:28] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [16:57:28] ================== drm_rect (9 subtests) =================== [16:57:28] [PASSED] drm_test_rect_clip_scaled_div_by_zero [16:57:28] [PASSED] drm_test_rect_clip_scaled_not_clipped [16:57:28] [PASSED] drm_test_rect_clip_scaled_clipped [16:57:28] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [16:57:28] ================= drm_test_rect_intersect ================= [16:57:28] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [16:57:28] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [16:57:28] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [16:57:28] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [16:57:28] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [16:57:28] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [16:57:28] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [16:57:28] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [16:57:28] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [16:57:28] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [16:57:28] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [16:57:28] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [16:57:28] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [16:57:28] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [16:57:28] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [16:57:28] ============= [PASSED] drm_test_rect_intersect ============= [16:57:28] ================ drm_test_rect_calc_hscale ================ [16:57:28] [PASSED] normal use [16:57:28] [PASSED] out of max range [16:57:28] [PASSED] out of min range [16:57:28] [PASSED] zero dst [16:57:28] [PASSED] negative src [16:57:28] [PASSED] negative dst [16:57:28] ============ [PASSED] drm_test_rect_calc_hscale ============ [16:57:28] ================ drm_test_rect_calc_vscale ================ [16:57:28] [PASSED] normal use [16:57:28] [PASSED] out of max range [16:57:28] [PASSED] out of min range [16:57:28] [PASSED] zero dst [16:57:28] [PASSED] negative src [16:57:28] [PASSED] negative dst [16:57:28] ============ [PASSED] drm_test_rect_calc_vscale ============ [16:57:28] ================== drm_test_rect_rotate =================== [16:57:28] [PASSED] reflect-x [16:57:28] [PASSED] reflect-y [16:57:28] [PASSED] rotate-0 [16:57:28] [PASSED] rotate-90 [16:57:28] [PASSED] rotate-180 [16:57:28] [PASSED] rotate-270 [16:57:28] ============== [PASSED] drm_test_rect_rotate =============== [16:57:28] ================ drm_test_rect_rotate_inv ================= [16:57:28] [PASSED] reflect-x [16:57:28] [PASSED] reflect-y [16:57:28] [PASSED] rotate-0 [16:57:28] [PASSED] rotate-90 [16:57:28] [PASSED] rotate-180 [16:57:28] [PASSED] rotate-270 [16:57:28] ============ [PASSED] drm_test_rect_rotate_inv ============= [16:57:28] ==================== [PASSED] drm_rect ===================== [16:57:28] ============================================================ [16:57:28] Testing complete. Ran 531 tests: passed: 531 [16:57:28] Elapsed time: 24.870s total, 1.679s configuring, 22.975s building, 0.168s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [16:57:28] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [16:57:30] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json ARCH=um O=.kunit --jobs=48 [16:57:37] Starting KUnit Kernel (1/1)... [16:57:37] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [16:57:37] ================= ttm_device (5 subtests) ================== [16:57:37] [PASSED] ttm_device_init_basic [16:57:37] [PASSED] ttm_device_init_multiple [16:57:37] [PASSED] ttm_device_fini_basic [16:57:37] [PASSED] ttm_device_init_no_vma_man [16:57:37] ================== ttm_device_init_pools ================== [16:57:37] [PASSED] No DMA allocations, no DMA32 required [16:57:37] [PASSED] DMA allocations, DMA32 required [16:57:37] [PASSED] No DMA allocations, DMA32 required [16:57:37] [PASSED] DMA allocations, no DMA32 required [16:57:37] ============== [PASSED] ttm_device_init_pools ============== [16:57:37] =================== [PASSED] ttm_device ==================== [16:57:37] ================== ttm_pool (8 subtests) =================== [16:57:37] ================== ttm_pool_alloc_basic =================== [16:57:37] [PASSED] One page [16:57:37] [PASSED] More than one page [16:57:37] [PASSED] Above the allocation limit [16:57:37] [PASSED] One page, with coherent DMA mappings enabled [16:57:37] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [16:57:37] ============== [PASSED] ttm_pool_alloc_basic =============== [16:57:37] ============== ttm_pool_alloc_basic_dma_addr ============== [16:57:37] [PASSED] One page [16:57:37] [PASSED] More than one page [16:57:37] [PASSED] Above the allocation limit [16:57:37] [PASSED] One page, with coherent DMA mappings enabled [16:57:37] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [16:57:37] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [16:57:37] [PASSED] ttm_pool_alloc_order_caching_match [16:57:37] [PASSED] ttm_pool_alloc_caching_mismatch [16:57:37] [PASSED] ttm_pool_alloc_order_mismatch [16:57:37] [PASSED] ttm_pool_free_dma_alloc [16:57:37] [PASSED] ttm_pool_free_no_dma_alloc [16:57:37] [PASSED] ttm_pool_fini_basic [16:57:37] ==================== [PASSED] ttm_pool ===================== [16:57:37] ================ ttm_resource (8 subtests) ================= [16:57:37] ================= ttm_resource_init_basic ================= [16:57:37] [PASSED] Init resource in TTM_PL_SYSTEM [16:57:37] [PASSED] Init resource in TTM_PL_VRAM [16:57:37] [PASSED] Init resource in a private placement [16:57:37] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [16:57:37] ============= [PASSED] ttm_resource_init_basic ============= [16:57:37] [PASSED] ttm_resource_init_pinned [16:57:37] [PASSED] ttm_resource_fini_basic [16:57:37] [PASSED] ttm_resource_manager_init_basic [16:57:37] [PASSED] ttm_resource_manager_usage_basic [16:57:37] [PASSED] ttm_resource_manager_set_used_basic [16:57:37] [PASSED] ttm_sys_man_alloc_basic [16:57:37] [PASSED] ttm_sys_man_free_basic [16:57:37] ================== [PASSED] ttm_resource =================== [16:57:37] =================== ttm_tt (15 subtests) =================== [16:57:37] ==================== ttm_tt_init_basic ==================== [16:57:37] [PASSED] Page-aligned size [16:57:37] [PASSED] Extra pages requested [16:57:37] ================ [PASSED] ttm_tt_init_basic ================ [16:57:37] [PASSED] ttm_tt_init_misaligned [16:57:37] [PASSED] ttm_tt_fini_basic [16:57:37] [PASSED] ttm_tt_fini_sg [16:57:37] [PASSED] ttm_tt_fini_shmem [16:57:37] [PASSED] ttm_tt_create_basic [16:57:37] [PASSED] ttm_tt_create_invalid_bo_type [16:57:37] [PASSED] ttm_tt_create_ttm_exists [16:57:37] [PASSED] ttm_tt_create_failed [16:57:37] [PASSED] ttm_tt_destroy_basic [16:57:37] [PASSED] ttm_tt_populate_null_ttm [16:57:37] [PASSED] ttm_tt_populate_populated_ttm [16:57:37] [PASSED] ttm_tt_unpopulate_basic [16:57:37] [PASSED] ttm_tt_unpopulate_empty_ttm [16:57:37] [PASSED] ttm_tt_swapin_basic [16:57:37] ===================== [PASSED] ttm_tt ====================== [16:57:37] =================== ttm_bo (14 subtests) =================== [16:57:37] =========== ttm_bo_reserve_optimistic_no_ticket =========== [16:57:37] [PASSED] Cannot be interrupted and sleeps [16:57:37] [PASSED] Cannot be interrupted, locks straight away [16:57:37] [PASSED] Can be interrupted, sleeps [16:57:37] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [16:57:37] [PASSED] ttm_bo_reserve_locked_no_sleep [16:57:37] [PASSED] ttm_bo_reserve_no_wait_ticket [16:57:37] [PASSED] ttm_bo_reserve_double_resv [16:57:37] [PASSED] ttm_bo_reserve_interrupted [16:57:37] [PASSED] ttm_bo_reserve_deadlock [16:57:37] [PASSED] ttm_bo_unreserve_basic [16:57:37] [PASSED] ttm_bo_unreserve_pinned [16:57:37] [PASSED] ttm_bo_unreserve_bulk [16:57:37] [PASSED] ttm_bo_put_basic [16:57:37] [PASSED] ttm_bo_put_shared_resv [16:57:37] [PASSED] ttm_bo_pin_basic [16:57:37] [PASSED] ttm_bo_pin_unpin_resource [16:57:37] [PASSED] ttm_bo_multiple_pin_one_unpin [16:57:37] ===================== [PASSED] ttm_bo ====================== [16:57:37] ============== ttm_bo_validate (22 subtests) =============== [16:57:37] ============== ttm_bo_init_reserved_sys_man =============== [16:57:37] [PASSED] Buffer object for userspace [16:57:37] [PASSED] Kernel buffer object [16:57:37] [PASSED] Shared buffer object [16:57:37] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [16:57:37] ============== ttm_bo_init_reserved_mock_man ============== [16:57:37] [PASSED] Buffer object for userspace [16:57:37] [PASSED] Kernel buffer object [16:57:37] [PASSED] Shared buffer object [16:57:37] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [16:57:37] [PASSED] ttm_bo_init_reserved_resv [16:57:37] ================== ttm_bo_validate_basic ================== [16:57:37] [PASSED] Buffer object for userspace [16:57:37] [PASSED] Kernel buffer object [16:57:37] [PASSED] Shared buffer object [16:57:37] ============== [PASSED] ttm_bo_validate_basic ============== [16:57:37] [PASSED] ttm_bo_validate_invalid_placement [16:57:37] ============= ttm_bo_validate_same_placement ============== [16:57:37] [PASSED] System manager [16:57:37] [PASSED] VRAM manager [16:57:37] ========= [PASSED] ttm_bo_validate_same_placement ========== [16:57:37] [PASSED] ttm_bo_validate_failed_alloc [16:57:37] [PASSED] ttm_bo_validate_pinned [16:57:37] [PASSED] ttm_bo_validate_busy_placement [16:57:37] ================ ttm_bo_validate_multihop ================= [16:57:37] [PASSED] Buffer object for userspace [16:57:37] [PASSED] Kernel buffer object [16:57:37] [PASSED] Shared buffer object [16:57:37] ============ [PASSED] ttm_bo_validate_multihop ============= [16:57:37] ========== ttm_bo_validate_no_placement_signaled ========== [16:57:37] [PASSED] Buffer object in system domain, no page vector [16:57:37] [PASSED] Buffer object in system domain with an existing page vector [16:57:37] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [16:57:37] ======== ttm_bo_validate_no_placement_not_signaled ======== [16:57:37] [PASSED] Buffer object for userspace [16:57:37] [PASSED] Kernel buffer object [16:57:37] [PASSED] Shared buffer object [16:57:37] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [16:57:37] [PASSED] ttm_bo_validate_move_fence_signaled [16:57:38] ========= ttm_bo_validate_move_fence_not_signaled ========= [16:57:38] [PASSED] Waits for GPU [16:57:38] [PASSED] Tries to lock straight away [16:57:38] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [16:57:38] [PASSED] ttm_bo_validate_swapout [16:57:38] [PASSED] ttm_bo_validate_happy_evict [16:57:38] [PASSED] ttm_bo_validate_all_pinned_evict [16:57:38] [PASSED] ttm_bo_validate_allowed_only_evict [16:57:38] [PASSED] ttm_bo_validate_deleted_evict [16:57:38] [PASSED] ttm_bo_validate_busy_domain_evict [16:57:38] [PASSED] ttm_bo_validate_evict_gutting [16:57:38] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [16:57:38] ================= [PASSED] ttm_bo_validate ================= [16:57:38] ============================================================ [16:57:38] Testing complete. Ran 102 tests: passed: 102 [16:57:38] Elapsed time: 9.974s total, 1.627s configuring, 7.680s building, 0.553s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ CI.Build: failure for drm/xe: Reduce flickering when inheriting BIOS fb.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb.
URL : https://patchwork.freedesktop.org/series/139516/
State : failure
== Summary ==
CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml2_dc_resource_mgmt.o
CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml2_mall_phantom.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml_display_rq_dlg_calc.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_top/dml_top.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_top/dml_top_mcache.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_top/dml2_top_optimization.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/inc/dml2_debug.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_factory.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_dpmm/dml2_dpmm_dcn4.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_dpmm/dml2_dpmm_factory.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_dcn4.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_mcg/dml2_mcg_factory.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_factory.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_standalone_libraries/lib_float_math.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/dml21_translation_helper.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/dml21_wrapper.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/dml21_utils.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_compressor.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_compressor.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_opp_regamma_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_opp_csc_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_mem_input_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_opp_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_transform_v.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_timing_generator.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_timing_generator.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_hw_sequencer.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/hdcp/hdcp_msg.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/dc_spl.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/dc_spl_scl_filters.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/dc_spl_scl_easf_filters.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/dc_spl_isharp_filters.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/dc_spl_filters.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/spl_fixpt31_32.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/spl/spl_custom_float.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stat.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_sink.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_surface.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_debug.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_exports.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_state.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_vm_helper.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dc_edid_parser.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dc_spl_translate.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_table.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/info_packet/info_packet.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv_stat.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_reg.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn20.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn21.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn30.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn301.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn302.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn303.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn31.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn314.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn315.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn316.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn32.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn35.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn351.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn401.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_ddc.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_log.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp1_execution.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp1_transition.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp2_execution.o CC [M] drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp2_transition.o LD [M] drivers/gpu/drm/amd/amdgpu/amdgpu.o
make[5]: *** [../scripts/Makefile.build:478: drivers/gpu/drm] Error 2 make[4]: *** [../scripts/Makefile.build:478: drivers/gpu] Error 2 make[3]: *** [../scripts/Makefile.build:478: drivers] Error 2 make[2]: *** [/kernel/Makefile:1936: .] Error 2
make[1]: *** [/kernel/Makefile:224: __sub-make] Error 2 make[1]: Leaving directory '/kernel/build64-default'
make: *** [Makefile:224: __sub-make] Error 2
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ Fi.CI.BUILD: failure for drm/xe: Reduce flickering when inheriting BIOS fb.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb.
URL : https://patchwork.freedesktop.org/series/139517/
State : failure
== Summary ==
Error: make failed
CALL scripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_headers
CC [M] drivers/gpu/drm/i915/display/skl_universal_plane.odrivers/gpu/drm/i915/display/skl_universal_plane.c: In function ‘skl_fixup_initial_plane_config’:drivers/gpu/drm/i915/display/skl_universal_plane.c:2818:21: error: implicit declaration of function ‘intel_read’; did you mean ‘intel_de_read’? [-Werror=implicit-function-declaration]
2818 | plane_ctl = intel_read(i915, PLANE_CTL(pipe, plane_id));
| ^~~~~~~~~~
| intel_de_readcc1: all warnings being treated as errors
make[6]: *** [scripts/Makefile.build:229: drivers/gpu/drm/i915/display/skl_universal_plane.o] Error 1 make[5]: *** [scripts/Makefile.build:478: drivers/gpu/drm/i915] Error 2
make[4]: *** [scripts/Makefile.build:478: drivers/gpu/drm] Error 2
make[3]: *** [scripts/Makefile.build:478: drivers/gpu] Error 2
make[2]: *** [scripts/Makefile.build:478: drivers] Error 2
make[1]: *** [/home/kbuild2/kernel/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
Build failed, no error log produced
Patchwork
CI✗ CI.Patch_applied: failure for drm/xe: Reduce flickering when inheriting BIOS fb. (rev2)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb. (rev2)
URL : https://patchwork.freedesktop.org/series/139516/
State : failure
== Summary ==
=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 39a016b276ce drm-tip: 2024y-10m-07d-13h-05m-35s UTC integration manifest === git am output follows ===
error: patch failed: drivers/gpu/drm/xe/display/xe_plane_initial.c:245
error: drivers/gpu/drm/xe/display/xe_plane_initial.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: drm/xe/display: Handle stolen bar readout in the same way as lmem
Applying: drm/xe: Remove double pageflip
Patch failed at 0002 drm/xe: Remove double pageflip
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Patchwork
CI✗ Fi.CI.BUILD: failure for drm/xe: Reduce flickering when inheriting BIOS fb. (rev2)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/xe: Reduce flickering when inheriting BIOS fb. (rev2)
URL : https://patchwork.freedesktop.org/series/139517/
State : failure
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/139517/revisions/2/mbox/ not applied
Applying: drm/xe/display: Handle stolen bar readout in the same way as lmem
Applying: drm/xe: Remove double pageflip
error: sha1 information is lacking or useless (drivers/gpu/drm/xe/display/xe_plane_initial.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 drm/xe: Remove double pageflip
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Build failed, no error log produced