menu: Re-enable the ANSI codes
PATCH 1/1 menu: Re-enable the ANSI codes
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/menu.c +1 -1
@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1/* * Internally, each item in a menu is represented by a struct menu_item.
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Quoted 32 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1/* * Internally, each item in a menu is represented by a struct menu_item. Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1
Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I'm sure you have this commit:?
17b45e684af9 ("cli: Correct several bugs in cli_getch()")
Regards,
Simon
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemu
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")
Yes, as it is in the master branch already.
Quoted 2 lines
Regards,
Simon
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemu
I tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.
Python 2 has been deprecated for years and I think it was removed recently.
Quoted 10 lines
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")Yes, as it is in the master branch already.
I tried the following with sandbox:
setenv bootmenu_0 "my item=echo item 0"
setenv bootmenu_1 "second item=echo item 1"
setenv bootmenu_delay 10
bootmenu
I see that with the ANSI patch the 'press key' prompt now appears in the right place.
When I press down key repeatedly, it goes down until the last item and then refuses to go any further.
So I can't repeat this problem.
I tried looking at the Nokia code. The keyboard driver should be in drivers/input, but I eventually found it in the board directory.
Are you sure that rx51_kp_tstc() behaves correctly? Can you add debugging to see what codes it is emitting?
Also you don't need to generate escape sequences in rx51_kp_fill(). You can just use Ctrl-N, Ctrl-P, Ctrl-B and Ctrl-F (see cli_ch_esc()). That should simplify things a bit.
If you can find a way to repeat this problem and have verified that the Nokia code is correct, I can take another look.
Regards,
Simon
[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Quoted 64 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
Quoted 7 lines
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Python 2 has been deprecated for years and I think it was removed recently.
Ach :-( Is not there some configure option to disable python?
In U-Boot CI is qemu compiling without issues (but variant without GUI).
Quoted 18 lines
Quoted 10 lines
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")Yes, as it is in the master branch already.
I tried the following with sandbox:
setenv
bootmenu_0"my item=echo item 0"
setenvbootmenu_1"second item=echo item 1"
setenvbootmenu_delay10
bootmenu
Quoted 7 lines
I see that with the ANSI patch the 'press key' prompt now appears in the right place.
When I press down key repeatedly, it goes down until the last item and then refuses to go any further.
So I can't repeat this problem.
Hm... so it looks like some ARM or UART specific thing... or something which is not triggered by sandbox.
Just some suggestions, could you try to add some more entries? Or trying to wait e.g. 30s before pressing another key (qemu is slow so there can be some delay issue?)? Or could you try to run bootmenu on some real hardware via UART?
Quoted 6 lines
I tried looking at the Nokia code. The keyboard driver should be in
drivers/input, but I eventually found it in the board directory.Are you sure that
rx51_kp_tstc()behaves correctly? Can you add debugging to see what codes it is emitting?
Quoted 6 lines
Also you don't need to generate escape sequences in
rx51_kp_fill(). You can just use Ctrl-N, Ctrl-P, Ctrl-B and Ctrl-F (seecli_ch_esc()). That should simplify things a bit.If you can find a way to repeat this problem and have verified that the Nokia code is correct, I can take another look.
Problem with DOWN key is on the terminal, not on the screen or keyboard. So all those rx51_kp_tstc() and rx51_kp_fill() should not be the cause (unless some input/output multiplexing in u-boot takes a role).
Terminal to qemu is connected via qemu's UART emulation, so omap2 uart driver in this case is the one which connects u-boot to the qemu's UART emulation.
Quoted 4 lines
Regards,
Simon[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Hi Pali,
Quoted 68 lines · Pali Rohár
Quoted 66 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
Quoted 7 lines
Quoted 5 lines
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Python 2 has been deprecated for years and I think it was removed recently.
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
Quoted 2 lines
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
I don't think it is reasonable to base a test on an old version of qemu.
Quoted 27 lines
Quoted 19 lines
Quoted 11 lines
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")Yes, as it is in the master branch already.
I tried the following with sandbox:
setenv
bootmenu_0"my item=echo item 0"
setenvbootmenu_1"second item=echo item 1"
setenvbootmenu_delay10
bootmenuQuoted 7 lines
I see that with the ANSI patch the 'press key' prompt now appears in the right place.
When I press down key repeatedly, it goes down until the last item and then refuses to go any further.
So I can't repeat this problem.
Quoted 7 lines
Hm... so it looks like some ARM or UART specific thing... or something which is not triggered by sandbox.
Just some suggestions, could you try to add some more entries? Or trying to wait e.g. 30s before pressing another key (qemu is slow so there can be some delay issue?)? Or could you try to run bootmenu on some real hardware via UART?
I did get it going by hacking my machine.
I'll send a series with some debugging, etc. I am not quite sure what the problem is, but it seems to be timing-related, or perhaps a bug in the keyboard code (I found one bug already).
Quoted 14 lines
Quoted 7 lines
I tried looking at the Nokia code. The keyboard driver should be in
drivers/input, but I eventually found it in the board directory.Are you sure that
rx51_kp_tstc()behaves correctly? Can you add debugging to see what codes it is emitting?Quoted 6 lines
Also you don't need to generate escape sequences in
rx51_kp_fill(). You can just use Ctrl-N, Ctrl-P, Ctrl-B and Ctrl-F (seecli_ch_esc()). That should simplify things a bit.If you can find a way to repeat this problem and have verified that the Nokia code is correct, I can take another look.
Quoted 12 lines
Problem with DOWN key is on the terminal, not on the screen or keyboard. So all those
rx51_kp_tstc()andrx51_kp_fill()should not be the cause (unless some input/output multiplexing in u-boot takes a role).Terminal to qemu is connected via qemu's UART emulation, so omap2 uart driver in this case is the one which connects u-boot to the qemu's UART emulation.
Quoted 4 lines
Regards,
Simon[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Regards,
SImon
Quoted 76 lines · Simon Glass
Hi Pali,
Quoted 73 lines · Pali Rohár
Quoted 71 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Python 2 has been deprecated for years and I think it was removed recently.
Our Docker image uses Ubuntu 22.04 (Jammy). Ubuntu 22.10 (Kinetic) was the last Ubuntu release providing Python 2.7. So when upgrading our Docker image next year we will have to quit emulating that 14 year old device.
Quoted 4 lines
Quoted 2 lines
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
The Nokia N900 support never existed in upstream QEMU. Is is only in a Linaro repository that has not been update since 2015. (No clue why our CI uses the 2013 version and not the 2015 one.)
I anybody cares about N900 being used in U-Boot's CI he should rework the N900 patch from the Linaro QEMU archive and get it integrated into upstream QEMU.
Best regards
Heinrich
Quoted 78 lines
Quoted 3 lines
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
I don't think it is reasonable to base a test on an old version of qemu.
Quoted 27 lines
Quoted 19 lines
Quoted 11 lines
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")Yes, as it is in the master branch already.
I tried the following with sandbox:
setenv
bootmenu_0"my item=echo item 0"
setenvbootmenu_1"second item=echo item 1"
setenvbootmenu_delay10
bootmenuQuoted 7 lines
I see that with the ANSI patch the 'press key' prompt now appears in the right place.
When I press down key repeatedly, it goes down until the last item and then refuses to go any further.
So I can't repeat this problem.
Quoted 7 lines
Hm... so it looks like some ARM or UART specific thing... or something which is not triggered by sandbox.
Just some suggestions, could you try to add some more entries? Or trying to wait e.g. 30s before pressing another key (qemu is slow so there can be some delay issue?)? Or could you try to run bootmenu on some real hardware via UART?
I did get it going by hacking my machine.
I'll send a series with some debugging, etc. I am not quite sure what the problem is, but it seems to be timing-related, or perhaps a bug in the keyboard code (I found one bug already).
Quoted 14 lines
Quoted 7 lines
I tried looking at the Nokia code. The keyboard driver should be in
drivers/input, but I eventually found it in the board directory.Are you sure that
rx51_kp_tstc()behaves correctly? Can you add debugging to see what codes it is emitting?Quoted 6 lines
Also you don't need to generate escape sequences in
rx51_kp_fill(). You can just use Ctrl-N, Ctrl-P, Ctrl-B and Ctrl-F (seecli_ch_esc()). That should simplify things a bit.If you can find a way to repeat this problem and have verified that the Nokia code is correct, I can take another look.
Quoted 12 lines
Problem with DOWN key is on the terminal, not on the screen or keyboard. So all those
rx51_kp_tstc()andrx51_kp_fill()should not be the cause (unless some input/output multiplexing in u-boot takes a role).Terminal to qemu is connected via qemu's UART emulation, so omap2 uart driver in this case is the one which connects u-boot to the qemu's UART emulation.
Quoted 4 lines
Regards,
Simon[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Regards,
SImon
Quoted 70 lines · On Saturday 17 June 2023 22:28:24 Heinrich Schuchardt wrote:
Quoted 69 lines · Simon Glass
Hi Pali,
Quoted 66 lines · Pali Rohár
Quoted 64 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Python 2 has been deprecated for years and I think it was removed recently.
So install all required dependencies? It is really stupid argument to say that _I have removed X from my PC_ and then _I cannot compile Y because it depends on X_.
Quoted 5 lines
Our Docker image uses Ubuntu 22.04 (Jammy). Ubuntu 22.10 (Kinetic) was the last Ubuntu release providing Python 2.7. So when upgrading our Docker image next year we will have to quit emulating that 14 year old device.
Why to quit? Why you cannot compile and install required dependency?
Also was not the whole purpose of using containers to make easier of using different languages in different versions and also different software?
Also what is the problem with 14 year old device and software? It is _working_. Or are you saying that you do not want to support _working_ device just because it is _old_? What is the logic here?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
The Nokia N900 support never existed in upstream QEMU. Is is only in a Linaro repository that has not been update since 2015. (No clue why our CI uses the 2013 version and not the 2015 one.)
We are using the latest version which contains working n900 emulator. It is written also in the u-boot documentation.
Quoted 3 lines
I anybody cares about N900 being used in U-Boot's CI he should rework the N900 patch from the Linaro QEMU archive and get it integrated into upstream QEMU.
Why? Emulator was already written and it is _working_. Why to invest new time for writing a new emulator?
I think you completely missed the point here. U-Boot is being test in this emulator to ensure that changes in u-boot does not break something. In the past it already caught issues which were not uncovered by any people review and neither by any other CI tests. Also for things which are not n900-related.
Quoted 12 lines
Best regards
Heinrich
Quoted 7 lines
Quoted 3 lines
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
I don't think it is reasonable to base a test on an old version of qemu.
Why not? U-Boot should work on any compatible hardware, so also on older qemu version.
Released hardware is _not_ being changed, so any software testing should use also older emulators, which are bound to the release date of hardware to better match hardware testing.
Quoted 71 lines
Quoted 70 lines
Quoted 27 lines
Quoted 19 lines
Quoted 11 lines
Bootmenu is available on both VGA display and terminal output. Problem with DOWN key is on the terminal.
Quoted 4 lines
I'm sure you have this commit:?
17b45e684af9("cli: Correct several bugs incli_getch()")Yes, as it is in the master branch already.
I tried the following with sandbox:
setenv
bootmenu_0"my item=echo item 0"
setenvbootmenu_1"second item=echo item 1"
setenvbootmenu_delay10
bootmenuQuoted 7 lines
I see that with the ANSI patch the 'press key' prompt now appears in the right place.
When I press down key repeatedly, it goes down until the last item and then refuses to go any further.
So I can't repeat this problem.
Quoted 7 lines
Hm... so it looks like some ARM or UART specific thing... or something which is not triggered by sandbox.
Just some suggestions, could you try to add some more entries? Or trying to wait e.g. 30s before pressing another key (qemu is slow so there can be some delay issue?)? Or could you try to run bootmenu on some real hardware via UART?
I did get it going by hacking my machine.
I'll send a series with some debugging, etc. I am not quite sure what the problem is, but it seems to be timing-related, or perhaps a bug in the keyboard code (I found one bug already).
Quoted 14 lines
Quoted 7 lines
I tried looking at the Nokia code. The keyboard driver should be in
drivers/input, but I eventually found it in the board directory.Are you sure that
rx51_kp_tstc()behaves correctly? Can you add debugging to see what codes it is emitting?Quoted 6 lines
Also you don't need to generate escape sequences in
rx51_kp_fill(). You can just use Ctrl-N, Ctrl-P, Ctrl-B and Ctrl-F (seecli_ch_esc()). That should simplify things a bit.If you can find a way to repeat this problem and have verified that the Nokia code is correct, I can take another look.
Quoted 12 lines
Problem with DOWN key is on the terminal, not on the screen or keyboard. So all those
rx51_kp_tstc()andrx51_kp_fill()should not be the cause (unless some input/output multiplexing in u-boot takes a role).Terminal to qemu is connected via qemu's UART emulation, so omap2 uart driver in this case is the one which connects u-boot to the qemu's UART emulation.
Quoted 4 lines
Regards,
Simon[1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Regards,
SImon
Quoted 77 lines · Pali Rohár
Quoted 76 lines · On Saturday 17 June 2023 22:28:24 Heinrich Schuchardt wrote:
Quoted 75 lines · Simon Glass
Hi Pali,
Quoted 72 lines · Pali Rohár
Quoted 70 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Python 2 has been deprecated for years and I think it was removed recently.
So install all required dependencies? It is really stupid argument to say that _I have removed X from my
PC_and then _I cannot compile Y because it depends on X_.
We're not talking about adding some random but modern dependency. We're talking about adding a language that every person responsible for it says to not use and migrate away from. This is Heinrich's point.
Quoted 6 lines
Quoted 4 lines
Our Docker image uses Ubuntu 22.04 (Jammy). Ubuntu 22.10 (Kinetic) was the last Ubuntu release providing Python 2.7. So when upgrading our Docker image next year we will have to quit emulating that 14 year old device.
Why to quit? Why you cannot compile and install required dependency?
We'll have to quit because Python 2.7 won't be available from the distribution. And no, we don't want to add building Python 2.7 to the list of things our container does. I don't even know that Python 2.7 will compile with the gcc and related that will ship in the host. And that's without repeating what I said above about Python 2.7 being a dead and do not use language.
Quoted 3 lines
Also was not the whole purpose of using containers to make easier of using different languages in different versions and also different software?
No, the point of containers here is to give everyone a common and reproducible base environment. We don't want to have to have a special container just for this one test case, which is what it's looking like would end up being a solution.
Quoted 3 lines
Also what is the problem with 14 year old device and software? It is _working_. Or are you saying that you do not want to support _working_ device just because it is _old_? What is the logic here?
It only works so long as everything else is still available that it requires. Which is starting to not be the case in the near future. It would be better for everyone is this platform was part of modern QEMU instead.
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
The Nokia N900 support never existed in upstream QEMU. Is is only in a Linaro repository that has not been update since 2015. (No clue why our CI uses the 2013 version and not the 2015 one.)
We are using the latest version which contains working n900 emulator. It is written also in the u-boot documentation.
Is it on anyones TODO list to move this emulation to a modern release?
Quoted 4 lines
Quoted 3 lines
I anybody cares about N900 being used in U-Boot's CI he should rework the N900 patch from the Linaro QEMU archive and get it integrated into upstream QEMU.
Quoted 8 lines
Why? Emulator was already written and it is _working_. Why to invest new time for writing a new emulator?
I think you completely missed the point here. U-Boot is being test in this emulator to ensure that changes in u-boot does not break something. In the past it already caught issues which were not uncovered by any people review and neither by any other CI tests. Also for things which are not n900-related.
I think you're missing the point which is that it will very soon be much harder to support this emulator in CI due to it not being actively maintained.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
Quoted 8 lines
Quoted 1 line
Quoted 1 line
I don't think it is reasonable to base a test on an old version of qemu.
Why not? U-Boot should work on any compatible hardware, so also on older qemu version.
Released hardware is _not_ being changed, so any software testing should use also older emulators, which are bound to the release date of hardware to better match hardware testing.
It'll become a problem when we cannot build the emulator anymore.
Signature · 1 line
Tom
Quoted 156 lines · On Saturday 24 June 2023 13:05:11 Tom Rini wrote:
Quoted 77 lines · Pali Rohár
Quoted 76 lines · On Saturday 17 June 2023 22:28:24 Heinrich Schuchardt wrote:
Quoted 75 lines · Simon Glass
Hi Pali,
Quoted 72 lines · Pali Rohár
Quoted 70 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Python 2 has been deprecated for years and I think it was removed recently.
So install all required dependencies? It is really stupid argument to say that _I have removed X from my
PC_and then _I cannot compile Y because it depends on X_.We're not talking about adding some random but modern dependency. We're talking about adding a language that every person responsible for it says to not use and migrate away from. This is Heinrich's point.
Quoted 6 lines
Quoted 4 lines
Our Docker image uses Ubuntu 22.04 (Jammy). Ubuntu 22.10 (Kinetic) was the last Ubuntu release providing Python 2.7. So when upgrading our Docker image next year we will have to quit emulating that 14 year old device.
Why to quit? Why you cannot compile and install required dependency?
We'll have to quit because Python 2.7 won't be available from the distribution. And no, we don't want to add building Python 2.7 to the list of things our container does. I don't even know that Python 2.7 will compile with the gcc and related that will ship in the host. And that's without repeating what I said above about Python 2.7 being a dead and do not use language.
Quoted 3 lines
Also was not the whole purpose of using containers to make easier of using different languages in different versions and also different software?
No, the point of containers here is to give everyone a common and reproducible base environment. We don't want to have to have a special container just for this one test case, which is what it's looking like would end up being a solution.
Quoted 3 lines
Also what is the problem with 14 year old device and software? It is _working_. Or are you saying that you do not want to support _working_ device just because it is _old_? What is the logic here?
It only works so long as everything else is still available that it requires. Which is starting to not be the case in the near future. It would be better for everyone is this platform was part of modern QEMU instead.
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
The Nokia N900 support never existed in upstream QEMU. Is is only in a Linaro repository that has not been update since 2015. (No clue why our CI uses the 2013 version and not the 2015 one.)
We are using the latest version which contains working n900 emulator. It is written also in the u-boot documentation.
Is it on anyones TODO list to move this emulation to a modern release?
Quoted 4 lines
Quoted 3 lines
I anybody cares about N900 being used in U-Boot's CI he should rework the N900 patch from the Linaro QEMU archive and get it integrated into upstream QEMU.
Quoted 8 lines
Why? Emulator was already written and it is _working_. Why to invest new time for writing a new emulator?
I think you completely missed the point here. U-Boot is being test in this emulator to ensure that changes in u-boot does not break something. In the past it already caught issues which were not uncovered by any people review and neither by any other CI tests. Also for things which are not n900-related.
I think you're missing the point which is that it will very soon be much harder to support this emulator in CI due to it not being actively maintained.
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
Quoted 1 line
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
I don't think it is reasonable to base a test on an old version of qemu.
Quoted 11 lines
Quoted 6 lines
Why not? U-Boot should work on any compatible hardware, so also on older qemu version.
Released hardware is _not_ being changed, so any software testing should use also older emulators, which are bound to the release date of hardware to better match hardware testing.
It'll become a problem when we cannot build the emulator anymore.
Signature · 1 line
Tom
So just say it loudly and do not hide your real reasons.
"We have there a bug in code and CI can show it. So we have to drop tests from CI, to make sure that CI always pass and do not report this bugs".
Am 25. Juni 2023 17:26:34 MESZ schrieb "Pali Rohár" <[email protected]>:
Quoted 166 lines · On Saturday 24 June 2023 13:05:11 Tom Rini wrote:
Quoted 165 lines · Pali Rohár
Quoted 77 lines · On Saturday 17 June 2023 22:28:24 Heinrich Schuchardt wrote:
Quoted 76 lines · Simon Glass
Quoted 75 lines
Hi Pali,
Quoted 72 lines · Pali Rohár
Quoted 70 lines · On Thursday 15 June 2023 13:34:09 Simon Glass wrote:
Hi Pali,
Quoted 52 lines · Pali Rohár
Quoted 42 lines · On Monday 12 June 2023 22:17:48 Simon Glass wrote:
Hi Pali,
Quoted 29 lines · Pali Rohár
Quoted 27 lines · On Monday 12 June 2023 21:14:32 Simon Glass wrote:
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1Quoted 9 lines
Quoted 5 lines
common/menu.c +0
-1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
Hello, I have tested this change but bootmenu still does not work. There is still same issue which I reported month ago. When I press DOWN key then bootmenu immediately quit instead of moving into the next entry.
Quoted 4 lines
Thanks for testing this.
Is there a way for me to test this with sandbox? Or does your Nokia test check it?
I guess that bootmenu command could work in sandbox. But I have not tried it.
Quoted 6 lines
Nokia CI test does not try any terminal, keyboard or VGA interaction, so broken rendering or broken keyboard input is not caught by CI.
But it is possible to test it manually. See U-Boot documentation how to run Nokia u-boot image in qemu. Bootmenu is automatically started.
https://u-boot.readthedocs.io/en/latest/board/nokia/rx51.html#run-in-qemuI tried to follow this but got stuck here:
./configure --enable-system --target-list=arm-softmmu --disable-werror
ERROR: Cannot use 'python', Python 2.4 or later is required.
Note that Python 3 or later is not yet supported. Use --python=/path/to/python to specify a supported Python.Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Python 2 has been deprecated for years and I think it was removed recently.
So install all required dependencies? It is really stupid argument to say that _I have removed X from my
PC_and then _I cannot compile Y because it depends on X_.We're not talking about adding some random but modern dependency. We're talking about adding a language that every person responsible for it says to not use and migrate away from. This is Heinrich's point.
Quoted 6 lines
Quoted 4 lines
Our Docker image uses Ubuntu 22.04 (Jammy). Ubuntu 22.10 (Kinetic) was the last Ubuntu release providing Python 2.7. So when upgrading our Docker image next year we will have to quit emulating that 14 year old device.
Why to quit? Why you cannot compile and install required dependency?
We'll have to quit because Python 2.7 won't be available from the distribution. And no, we don't want to add building Python 2.7 to the list of things our container does. I don't even know that Python 2.7 will compile with the gcc and related that will ship in the host. And that's without repeating what I said above about Python 2.7 being a dead and do not use language.
Quoted 3 lines
Also was not the whole purpose of using containers to make easier of using different languages in different versions and also different software?
No, the point of containers here is to give everyone a common and reproducible base environment. We don't want to have to have a special container just for this one test case, which is what it's looking like would end up being a solution.
Quoted 3 lines
Also what is the problem with 14 year old device and software? It is _working_. Or are you saying that you do not want to support _working_ device just because it is _old_? What is the logic here?
It only works so long as everything else is still available that it requires. Which is starting to not be the case in the near future. It would be better for everyone is this platform was part of modern QEMU instead.
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Ach :-( Is not there some configure option to disable python?
I don't know, but the qemu you are using seems to be 10 years old?
The Nokia N900 support never existed in upstream QEMU. Is is only in a Linaro repository that has not been update since 2015. (No clue why our CI uses the 2013 version and not the 2015 one.)
We are using the latest version which contains working n900 emulator. It is written also in the u-boot documentation.
Is it on anyones TODO list to move this emulation to a modern release?
Quoted 4 lines
Quoted 3 lines
I anybody cares about N900 being used in U-Boot's CI he should rework the N900 patch from the Linaro QEMU archive and get it integrated into upstream QEMU.
Quoted 8 lines
Why? Emulator was already written and it is _working_. Why to invest new time for writing a new emulator?
I think you completely missed the point here. U-Boot is being test in this emulator to ensure that changes in u-boot does not break something. In the past it already caught issues which were not uncovered by any people review and neither by any other CI tests. Also for things which are not n900-related.
I think you're missing the point which is that it will very soon be much harder to support this emulator in CI due to it not being actively maintained.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
In U-Boot CI is qemu compiling without issues (but variant without GUI).
You mean that it still uses python 2? But for how much longer?
Quoted 8 lines
Quoted 1 line
Quoted 1 line
I don't think it is reasonable to base a test on an old version of qemu.
Why not? U-Boot should work on any compatible hardware, so also on older qemu version.
Released hardware is _not_ being changed, so any software testing should use also older emulators, which are bound to the release date of hardware to better match hardware testing.
It'll become a problem when we cannot build the emulator anymore.
Quoted 8 lines
Quoted 2 lines
Signature · 1 line
TomSo just say it loudly and do not hide your real reasons.
"We have there a bug in code and CI can show it. So we have to drop tests from CI, to make sure that CI always pass and do not report this bugs".
The suggestion in the thread was: Whoever is interested in the CI running the N900 emulation should upstream it to mainline QEMU.
Best regards
Heinrich
Quoted 7 lines
From: Simon Glass <[email protected]>
Date: Mon, 12 Jun 2023 21:14:32 +0100The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Quoted 7 lines
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")
Quoted 22 lines
---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-1@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1/* * Internally, each item in a menu is represented by a struct menu_item. Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Quoted 6 lines · Simon Glass
Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
The intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Typo: impoosible->impossible.
Quoted 29 lines
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-2@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog
A message that is not in the archive (sent off-list or not yet received): trinity-55ce3472-961b-4f1d-9d01-c7ea55efad1f-1687776294671@3c-app-gmx-bs35
Hi Frank,
Quoted 4 lines · Frank Wunderlich
Hi,
what exact bug does the Patch fix? as i'm listed in reported-By...i remember only the problem with missing line-breaks after "normal" menuitems and the "u-boot-console" i reported in ML. But i don't think this is related to ANSI processing.
It fixes placement of the prompt to select an option. You can ignore this patch if it isn't related to your report.
Regards,
Simon
Quoted 43 lines
regards Frank
Quoted 39 lines
Gesendet: Montag, 12. Juni 2023 um 22:14 Uhr
Von: "Simon Glass" <[email protected]>
An: "U-Boot Mailing List" <[email protected]>
Cc: "Simon Glass" <[email protected]>, "Pali Rohár" <[email protected]>, "Mark Kettenis" <[email protected]>, "Frank Wunderlich" <[email protected]>, "Heinrich Schuchardt" <[email protected]>, "Ilias Apalodimas" <[email protected]>, "Masahisa Kojima" <[email protected]>, "Stefan Roese" <[email protected]>
Betreff: [PATCH] menu: Re-enable the ANSI codesThe intent here was to allow ANSI codes to be disabled, since it was proving impoosible to test operation of the menu code when it kept moving the cursor. Unfortunately this ended up in the patch.
Correct this by enabling ANSI again.
Signed-off-by Simon Glass <[email protected]>Reported-by Pali Rohár <[email protected]>Reported-by Mark Kettenis <[email protected]>Reported-by Frank Wunderlich <[email protected]>Fixes 32bab0eae51b ("menu: Make use of CLI character processing")---
common/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/menu.c +1
-2@@ -15,7 +15,7 @@#include "menu.h" -#define ansi 0 +#define ansi 1/* * Internally, each item in a menu is represented by a struct menu_item. -- 2.41.0.162.gfafddb0af9-goog