Skip to contentSkip to conversation

package/rsync: force HAVE_C99_VSNPRINTF to "yes"

PATCH Applied Markus Mayer via buildroot 2 participants 3 messages Oct 19, 2022 – Nov 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rsync: force HAVE_C99_VSNPRINTF to "yes"

We know the system will have a modern-enough C library that implements the required snprintf() functionality. Since the configure stage can't detect the system's capabilities (because it is cross-compiling), let's hard-code the decision.

As a result, rsync won't be linking in its own copy of snprintf().

---
 package/rsync/rsync.mk | 3 +++
 1 file changed, 3 insertions(+)
package/rsync/rsync.mk +3 -0
index e288033b9819..0d311aa1673c 100644
@@ -11,6 +11,9 @@ RSYNC_LICENSE_FILES = COPYING
 RSYNC_CPE_ID_VENDOR = samba
 RSYNC_SELINUX_MODULES = rsync
 RSYNC_DEPENDENCIES = zlib popt
+# We know that our C library is modern enough for C99 vsnprintf(). Since
+# configure can't detect this, we tell configure that vsnprintf() is safe.
+RSYNC_CONF_ENV = rsync_cv_HAVE_C99_VSNPRINTF=yes
 RSYNC_CONF_OPTS = \
 	--with-included-zlib=no \
 	--with-included-popt=no \
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 11 lines · On Wed, 19 Oct 2022 16:34:14 -0700 Markus Mayer via buildroot…

We know the system will have a modern-enough C library that implements the required snprintf() functionality. Since the configure stage can't detect the system's capabilities (because it is cross-compiling), let's hard-code the decision.

As a result, rsync won't be linking in its own copy of snprintf().

---
 package/rsync/rsync.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Markus Mayer via buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Markus" == Markus Mayer via buildroot <[email protected]> writes:

We know the system will have a modern-enough C library that implements the required snprintf() functionality. Since the configure stage can't detect the system's capabilities (because it is cross-compiling), let's hard-code the decision.

As a result, rsync won't be linking in its own copy of snprintf().

Committed to 2022.08.x and 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot