drm/i915: add display sub-struct to drm_i915_private
Subsystems (4)
PATCH 25/39 drm/i915: move vbt to display.vbt
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
--- drivers/gpu/drm/i915/display/intel_bios.c | 210 +++++++++--------- drivers/gpu/drm/i915/display/intel_crt.c | 4 +- drivers/gpu/drm/i915/display/intel_display.c | 12 +- .../gpu/drm/i915/display/intel_display_core.h | 38 ++++ drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/display/intel_dpll.c | 14 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 18 +- drivers/gpu/drm/i915/display/intel_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_lvds.c | 4 +- drivers/gpu/drm/i915/display/intel_panel.c | 2 +- .../gpu/drm/i915/display/intel_pch_refclk.c | 2 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 18 +- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 8 +- drivers/gpu/drm/i915/i915_drv.h | 37 --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 15 files changed, 187 insertions(+), 186 deletions(-)
drivers/gpu/drm/i915/display/intel_bios.c +105 -105
@@ -159,7 +159,7 @@ find_section(struct drm_i915_private *i915, {struct bdb_block_entry *entry; -list_for_each_entry (entry, &i915->vbt.bdb_blocks, node) { +list_for_each_entry (entry, &i915->display.vbt.bdb_blocks, node) {if (entry->section_id == section_id)return entry->data +3 ; }
@@ -501,7 +501,7 @@ init_bdb_block(struct drm_i915_private *i915,return ; } -list_add_tail (&entry->node, &i915->vbt.bdb_blocks); +list_add_tail (&entry->node, &i915->display.vbt.bdb_blocks); } static void init_bdb_blocks(struct drm_i915_private *i915,
@@ -878,7 +878,7 @@ parse_lfp_data(struct drm_i915_private *i915,if (!tail)return ; -if (i915->vbt.version >=188 ) { +if (i915->display.vbt.version >=188 ) { panel->vbt.seamless_drrs_min_refresh_rate = tail->seamless_drrs_min_refresh_rate[panel_type]; drm_dbg_kms(&i915->drm,
@@ -904,7 +904,7 @@ parse_generic_dtd(struct drm_i915_private *i915,* first on VBT >= 229, but still fall back to trying the old LFP * block if that fails. */ -if (i915->vbt.version <229 ) +if (i915->display.vbt.version <229 )return ; generic_dtd =find_section (i915,BDB_GENERIC_DTD );
@@ -1008,12 +1008,12 @@ parse_lfp_backlight(struct drm_i915_private *i915, } panel->vbt.backlight.type =INTEL_BACKLIGHT_DISPLAY_DDI ; -if (i915->vbt.version >=191 ) { +if (i915->display.vbt.version >=191 ) {size_t exp_size; -if (i915->vbt.version >=236 ) +if (i915->display.vbt.version >=236 ) exp_size =sizeof (struct bdb_lfp_backlight_data ); -else if (i915->vbt.version >=234 ) +else if (i915->display.vbt.version >=234 ) exp_size =EXP_BDB_LFP_BL_DATA_SIZE_REV_234 ;else exp_size =EXP_BDB_LFP_BL_DATA_SIZE_REV_191 ;
@@ -1030,14 +1030,14 @@ parse_lfp_backlight(struct drm_i915_private *i915, panel->vbt.backlight.pwm_freq_hz = entry->pwm_freq_hz; panel->vbt.backlight.active_low_pwm = entry->active_low_pwm; -if (i915->vbt.version >=234 ) { +if (i915->display.vbt.version >=234 ) {u16 min_level;bool scale; level = backlight_data->brightness_level[panel_type].level; min_level = backlight_data->brightness_min_level[panel_type].level; -if (i915->vbt.version >=236 ) +if (i915->display.vbt.version >=236 ) scale = backlight_data->brightness_precision_bits[panel_type] ==16 ;else scale = level >255 ;
@@ -1134,37 +1134,37 @@ parse_general_features(struct drm_i915_private *i915)if (!general)return ; - i915->vbt.int_tv_support = general->int_tv_support; + i915->display.vbt.int_tv_support = general->int_tv_support;/* int_crt_support can't be trusted on earlier platforms */ -if (i915->vbt.version >=155 && +if (i915->display.vbt.version >=155 && (HAS_DDI (i915) ||IS_VALLEYVIEW (i915))) - i915->vbt.int_crt_support = general->int_crt_support; - i915->vbt.lvds_use_ssc = general->enable_ssc; - i915->vbt.lvds_ssc_freq = + i915->display.vbt.int_crt_support = general->int_crt_support; + i915->display.vbt.lvds_use_ssc = general->enable_ssc; + i915->display.vbt.lvds_ssc_freq =intel_bios_ssc_frequency (i915, general->ssc_freq); - i915->vbt.display_clock_mode = general->display_clock_mode; - i915->vbt.fdi_rx_polarity_inverted = general->fdi_rx_polarity_inverted; -if (i915->vbt.version >=181 ) { - i915->vbt.orientation = general->rotate_180 ? + i915->display.vbt.display_clock_mode = general->display_clock_mode; + i915->display.vbt.fdi_rx_polarity_inverted = general->fdi_rx_polarity_inverted; +if (i915->display.vbt.version >=181 ) { + i915->display.vbt.orientation = general->rotate_180 ?DRM_MODE_PANEL_ORIENTATION_BOTTOM_UP :DRM_MODE_PANEL_ORIENTATION_NORMAL ; }else { - i915->vbt.orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; + i915->display.vbt.orientation =DRM_MODE_PANEL_ORIENTATION_UNKNOWN ; } -if (i915->vbt.version >=249 && general->afc_startup_config) { - i915->vbt.override_afc_startup = true; - i915->vbt.override_afc_startup_val = general->afc_startup_config ==0x1 ?0x0 :0x7 ; +if (i915->display.vbt.version >=249 && general->afc_startup_config) { + i915->display.vbt.override_afc_startup = true; + i915->display.vbt.override_afc_startup_val = general->afc_startup_config ==0x1 ?0x0 :0x7 ; }drm_dbg_kms (&i915->drm,"BDB_GENERAL_FEATURES int_tv_support %d int_crt_support %d lvds_use_ssc %d lvds_ssc_freq %d display_clock_mode %d fdi_rx_polarity_inverted %d\n" , - i915->vbt.int_tv_support, - i915->vbt.int_crt_support, - i915->vbt.lvds_use_ssc, - i915->vbt.lvds_ssc_freq, - i915->vbt.display_clock_mode, - i915->vbt.fdi_rx_polarity_inverted); + i915->display.vbt.int_tv_support, + i915->display.vbt.int_crt_support, + i915->display.vbt.lvds_use_ssc, + i915->display.vbt.lvds_ssc_freq, + i915->display.vbt.display_clock_mode, + i915->display.vbt.fdi_rx_polarity_inverted); } static const struct child_device_config *
@@ -1190,7 +1190,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *i915)return ; } -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child; if (child->slave_addr != SLAVE_ADDR1 &&
@@ -1214,7 +1214,7 @@ parse_sdvo_device_mapping(struct drm_i915_private *i915) child->slave_addr, (child->dvo_port ==DEVICE_PORT_DVOB ) ? "SDVOB" : "SDVOC"); - mapping = &i915->vbt.sdvo_mappings[child->dvo_port -1 ]; + mapping = &i915->display.vbt.sdvo_mappings[child->dvo_port -1 ];if (!mapping->initialized) { mapping->dvo_port = child->dvo_port; mapping->slave_addr = child->slave_addr;
@@ -1265,7 +1265,7 @@ parse_driver_features(struct drm_i915_private *i915)* interpretation, but real world VBTs seem to. */ if (driver->lvds_config !=BDB_DRIVER_FEATURE_INT_LVDS ) - i915->vbt.int_lvds_support =0 ; + i915->display.vbt.int_lvds_support =0 ; }else {/* * FIXME it's not clear which BDB version has the LVDS config
@@ -1278,10 +1278,10 @@ parse_driver_features(struct drm_i915_private *i915)* in the wild with the bits correctly populated. Version * 108 (on i85x) does not have the bits correctly populated. */ -if (i915->vbt.version >=134 && +if (i915->display.vbt.version >=134 && driver->lvds_config !=BDB_DRIVER_FEATURE_INT_LVDS && driver->lvds_config !=BDB_DRIVER_FEATURE_INT_SDVO_LVDS ) - i915->vbt.int_lvds_support =0 ; + i915->display.vbt.int_lvds_support =0 ; } }
@@ -1295,7 +1295,7 @@ parse_panel_driver_features(struct drm_i915_private *i915,if (!driver)return ; -if (i915->vbt.version <228 ) { +if (i915->display.vbt.version <228 ) {drm_dbg_kms (&i915->drm,"DRRS State Enabled:%d\n" , driver->drrs_enabled);/*
@@ -1328,7 +1328,7 @@ parse_power_conservation_features(struct drm_i915_private *i915, panel->vbt.vrr = true;/* matches Windows behaviour */ -if (i915->vbt.version <228 ) +if (i915->display.vbt.version <228 )return ; power =find_section (i915,BDB_LFP_POWER );
@@ -1354,10 +1354,10 @@ parse_power_conservation_features(struct drm_i915_private *i915, panel->vbt.drrs_type =DRRS_TYPE_NONE ; } -if (i915->vbt.version >=232 ) +if (i915->display.vbt.version >=232 ) panel->vbt.edp.hobl =panel_bool (power->hobl, panel_type); -if (i915->vbt.version >=233 ) +if (i915->display.vbt.version >=233 ) panel->vbt.vrr =panel_bool (power->vrr_feature_enabled, panel_type); }
@@ -1393,7 +1393,7 @@ parse_edp(struct drm_i915_private *i915, panel->vbt.edp.pps = *edp_pps; -if (i915->vbt.version >=224 ) { +if (i915->display.vbt.version >=224 ) { panel->vbt.edp.rate = edp->edp_fast_link_training_rate[panel_type] *20 ; }else {
@@ -1472,7 +1472,7 @@ parse_edp(struct drm_i915_private *i915,break ; } -if (i915->vbt.version >=173 ) { +if (i915->display.vbt.version >=173 ) {u8 vswing;/* Don't read from VBT if module parameter has valid value*/
@@ -1488,7 +1488,7 @@ parse_edp(struct drm_i915_private *i915, panel->vbt.edp.drrs_msa_timing_delay =panel_bits (edp->sdrrs_msa_timing_delay, panel_type,2 ); -if (i915->vbt.version >=244 ) +if (i915->display.vbt.version >=244 ) panel->vbt.edp.max_link_rate = edp->edp_max_port_link_rate[panel_type] *20 ; }
@@ -1520,7 +1520,7 @@ parse_psr(struct drm_i915_private *i915,* New psr options 0=500us, 1=100us, 2=2500us, 3=0us * Old decimal value is wake up time in multiples of 100 us. */ -if (i915->vbt.version >=205 && +if (i915->display.vbt.version >=205 && (DISPLAY_VER (i915) >=9 && !IS_BROXTON (i915))) {switch (psr_table->tp1_wakeup_time) {case 0 :
@@ -1566,7 +1566,7 @@ parse_psr(struct drm_i915_private *i915, panel->vbt.psr.tp2_tp3_wakeup_time_us = psr_table->tp2_tp3_wakeup_time *100 ; } -if (i915->vbt.version >=226 ) { +if (i915->display.vbt.version >=226 ) {u32 wakeup_time = psr->psr2_tp2_tp3_wakeup_time; wakeup_time =panel_bits (wakeup_time, panel_type,2 );
@@ -1596,7 +1596,7 @@ static void parse_dsi_backlight_ports(struct drm_i915_private *i915, struct intel_panel *panel, enum port port) { -if (!panel->vbt.dsi.config->dual_link || i915->vbt.version <197 ) { +if (!panel->vbt.dsi.config->dual_link || i915->display.vbt.version <197 ) { panel->vbt.dsi.bl_ports =BIT (port);if (panel->vbt.dsi.config->cabc_supported) panel->vbt.dsi.cabc_ports =BIT (port);
@@ -2051,7 +2051,7 @@ parse_compression_parameters(struct drm_i915_private *i915)u16 block_size;int index; -if (i915->vbt.version <198 ) +if (i915->display.vbt.version <198 )return ; params =find_section (i915,BDB_COMPRESSION_PARAMETERS );
@@ -2071,7 +2071,7 @@ parse_compression_parameters(struct drm_i915_private *i915) } } -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child;if (!child->compression_enable)
@@ -2205,7 +2205,7 @@ static enum port get_port_by_ddc_pin(struct drm_i915_private *i915, u8 ddc_pin)return PORT_NONE ;for_each_port (port) { - devdata = i915->vbt.ports[port]; + devdata = i915->display.vbt.ports[port];if (devdata && ddc_pin == devdata->child.ddc_pin)return port;
@@ -2254,7 +2254,7 @@ static void sanitize_ddc_pin(struct intel_bios_encoder_data *devdata,* there are real machines (eg. Asrock B250M-HDV) where VBT has both * port A and port E with the same AUX ch and we must pick port E :( */ - child = &i915->vbt.ports[p]->child; + child = &i915->display.vbt.ports[p]->child; child->device_type &= ~DEVICE_TYPE_TMDS_DVI_SIGNALING ; child->device_type |=DEVICE_TYPE_NOT_HDMI_OUTPUT ;
@@ -2271,7 +2271,7 @@ static enum port get_port_by_aux_ch(struct drm_i915_private *i915, u8 aux_ch)return PORT_NONE ;for_each_port (port) { - devdata = i915->vbt.ports[port]; + devdata = i915->display.vbt.ports[port];if (devdata && aux_ch == devdata->child.aux_channel)return port;
@@ -2306,7 +2306,7 @@ static void sanitize_aux_ch(struct intel_bios_encoder_data *devdata,* there are real machines (eg. Asrock B250M-HDV) where VBT has both * port A and port E with the same AUX ch and we must pick port E :( */ - child = &i915->vbt.ports[p]->child; + child = &i915->display.vbt.ports[p]->child; child->device_type &= ~DEVICE_TYPE_DISPLAYPORT_OUTPUT ; child->aux_channel =0 ;
@@ -2480,10 +2480,10 @@ static int parse_bdb_216_dp_max_link_rate(const int vbt_max_link_rate)static int _intel_bios_dp_max_link_rate (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->vbt.version <216 ) +if (!devdata || devdata->i915->display.vbt.version <216 )return 0 ; -if (devdata->i915->vbt.version >=230 ) +if (devdata->i915->display.vbt.version >=230 )return parse_bdb_230_dp_max_link_rate (devdata->child.dp_max_link_rate);else return parse_bdb_216_dp_max_link_rate (devdata->child.dp_max_link_rate);
@@ -2544,7 +2544,7 @@ intel_bios_encoder_supports_edp(const struct intel_bios_encoder_data *devdata)static int _intel_bios_hdmi_level_shift (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->vbt.version <158 ) +if (!devdata || devdata->i915->display.vbt.version <158 )return -1 ;return devdata->child.hdmi_level_shifter_value;
@@ -2552,7 +2552,7 @@ static int _intel_bios_hdmi_level_shift(const struct intel_bios_encoder_data *destatic int _intel_bios_max_tmds_clock (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->vbt.version <204 ) +if (!devdata || devdata->i915->display.vbt.version <204 )return 0 ;switch (devdata->child.hdmi_max_data_rate) {
@@ -2661,7 +2661,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)return ; } -if (i915->vbt.ports[port]) { +if (i915->display.vbt.ports[port]) {drm_dbg_kms (&i915->drm,"More than one child device for port %c in VBT, using the first.\n" ,port_name (port));
@@ -2676,7 +2676,7 @@ static void parse_ddi_port(struct intel_bios_encoder_data *devdata)if (intel_bios_encoder_supports_dp (devdata))sanitize_aux_ch (devdata, port); - i915->vbt.ports[port] = devdata; + i915->display.vbt.ports[port] = devdata; }static bool has_ddi_port_info (struct drm_i915_private *i915)
@@ -2692,12 +2692,12 @@ static void parse_ddi_ports(struct drm_i915_private *i915)if (!has_ddi_port_info (i915))return ; -list_for_each_entry (devdata, &i915->vbt.display_devices, node) +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node)parse_ddi_port (devdata);for_each_port (port) { -if (i915->vbt.ports[port]) -print_ddi_port (i915->vbt.ports[port], port); +if (i915->display.vbt.ports[port]) +print_ddi_port (i915->display.vbt.ports[port], port); } }
@@ -2730,33 +2730,33 @@ parse_general_definitions(struct drm_i915_private *i915) bus_pin = defs->crt_ddc_gmbus_pin;drm_dbg_kms (&i915->drm,"crt_ddc_bus_pin: %d\n" , bus_pin);if (intel_gmbus_is_valid_pin (i915, bus_pin)) - i915->vbt.crt_ddc_pin = bus_pin; + i915->display.vbt.crt_ddc_pin = bus_pin; -if (i915->vbt.version <106 ) { +if (i915->display.vbt.version <106 ) { expected_size =22 ; - }else if (i915->vbt.version <111 ) { + }else if (i915->display.vbt.version <111 ) { expected_size =27 ; - }else if (i915->vbt.version <195 ) { + }else if (i915->display.vbt.version <195 ) { expected_size =LEGACY_CHILD_DEVICE_CONFIG_SIZE ; - }else if (i915->vbt.version ==195 ) { + }else if (i915->display.vbt.version ==195 ) { expected_size =37 ; - }else if (i915->vbt.version <=215 ) { + }else if (i915->display.vbt.version <=215 ) { expected_size =38 ; - }else if (i915->vbt.version <=237 ) { + }else if (i915->display.vbt.version <=237 ) { expected_size =39 ; }else { expected_size =sizeof (*child);BUILD_BUG_ON (sizeof (*child) <39 );drm_dbg (&i915->drm,"Expected child device config size for VBT version %u not known; assuming %u\n" , - i915->vbt.version, expected_size); + i915->display.vbt.version, expected_size); }/* Flag an error for unexpected size, but continue anyway. */ if (defs->child_dev_size != expected_size)drm_err (&i915->drm,"Unexpected child device config size %u (expected %u for VBT version %u)\n" , - defs->child_dev_size, expected_size, i915->vbt.version); + defs->child_dev_size, expected_size, i915->display.vbt.version);/* The legacy sized child device config is the minimum we need. */ if (defs->child_dev_size <LEGACY_CHILD_DEVICE_CONFIG_SIZE ) {
@@ -2792,10 +2792,10 @@ parse_general_definitions(struct drm_i915_private *i915)memcpy (&devdata->child, child,min_t (size_t, defs->child_dev_size,sizeof (*child))); -list_add_tail (&devdata->node, &i915->vbt.display_devices); +list_add_tail (&devdata->node, &i915->display.vbt.display_devices); } -if (list_empty (&i915->vbt.display_devices)) +if (list_empty (&i915->display.vbt.display_devices))drm_dbg_kms (&i915->drm,"no child dev is parsed from VBT\n" ); }
@@ -2804,25 +2804,25 @@ parse_general_definitions(struct drm_i915_private *i915)static void init_vbt_defaults (struct drm_i915_private *i915) { - i915->vbt.crt_ddc_pin =GMBUS_PIN_VGADDC ; + i915->display.vbt.crt_ddc_pin =GMBUS_PIN_VGADDC ;/* general features */ - i915->vbt.int_tv_support =1 ; - i915->vbt.int_crt_support =1 ; + i915->display.vbt.int_tv_support =1 ; + i915->display.vbt.int_crt_support =1 ;/* driver features */ - i915->vbt.int_lvds_support =1 ; + i915->display.vbt.int_lvds_support =1 ;/* Default to using SSC */ - i915->vbt.lvds_use_ssc =1 ; + i915->display.vbt.lvds_use_ssc =1 ;/* * Core/SandyBridge/IvyBridge use alternative (120MHz) reference * clock for LVDS. */ - i915->vbt.lvds_ssc_freq =intel_bios_ssc_frequency (i915, + i915->display.vbt.lvds_ssc_freq =intel_bios_ssc_frequency (i915, !HAS_PCH_SPLIT (i915));drm_dbg_kms (&i915->drm,"Set default to SSC at %d kHz\n" , - i915->vbt.lvds_ssc_freq); + i915->display.vbt.lvds_ssc_freq); }/* Common defaults which may be overridden by VBT. */
@@ -2883,7 +2883,7 @@ init_vbt_missing_defaults(struct drm_i915_private *i915)if (port ==PORT_A ) child->device_type |=DEVICE_TYPE_INTERNAL_CONNECTOR ; -list_add_tail (&devdata->node, &i915->vbt.display_devices); +list_add_tail (&devdata->node, &i915->display.vbt.display_devices); drm_dbg_kms(&i915->drm, "Generating default VBT child device with type 0x04%x on port %c\n",
@@ -2891,7 +2891,7 @@ init_vbt_missing_defaults(struct drm_i915_private *i915) }/* Bypass some minimum baseline VBT version checks */ - i915->vbt.version =155 ; + i915->display.vbt.version =155 ; }static const struct bdb_header *get_bdb_header (const struct vbt_header *vbt)
@@ -3082,8 +3082,8 @@ void intel_bios_init(struct drm_i915_private *i915)struct vbt_header *oprom_vbt =NULL ;const struct bdb_header *bdb; -INIT_LIST_HEAD (&i915->vbt.display_devices); -INIT_LIST_HEAD (&i915->vbt.bdb_blocks); +INIT_LIST_HEAD (&i915->display.vbt.display_devices); +INIT_LIST_HEAD (&i915->display.vbt.bdb_blocks);if (!HAS_DISPLAY (i915)) { drm_dbg_kms(&i915->drm,
@@ -3111,11 +3111,11 @@ void intel_bios_init(struct drm_i915_private *i915) goto out; bdb =get_bdb_header (vbt); - i915->vbt.version = bdb->version; + i915->display.vbt.version = bdb->version;drm_dbg_kms (&i915->drm,"VBT signature \"%.*s\", BDB version %d\n" , - (int )sizeof (vbt->signature), vbt->signature, i915->vbt.version); + (int )sizeof (vbt->signature), vbt->signature, i915->display.vbt.version);init_bdb_blocks (i915, bdb);
@@ -3172,13 +3172,13 @@ void intel_bios_driver_remove(struct drm_i915_private *i915)struct intel_bios_encoder_data *devdata, *nd;struct bdb_block_entry *entry, *ne; -list_for_each_entry_safe (devdata, nd, &i915->vbt.display_devices, node) { +list_for_each_entry_safe (devdata, nd, &i915->display.vbt.display_devices, node) {list_del (&devdata->node);kfree (devdata->dsc);kfree (devdata); } -list_for_each_entry_safe (entry, ne, &i915->vbt.bdb_blocks, node) { +list_for_each_entry_safe (entry, ne, &i915->display.vbt.bdb_blocks, node) {list_del (&entry->node);kfree (entry); }
@@ -3212,13 +3212,13 @@ bool intel_bios_is_tv_present(struct drm_i915_private *i915)const struct intel_bios_encoder_data *devdata;const struct child_device_config *child; -if (!i915->vbt.int_tv_support) +if (!i915->display.vbt.int_tv_support)return false; -if (list_empty (&i915->vbt.display_devices)) +if (list_empty (&i915->display.vbt.display_devices))return true; -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child;/*
@@ -3255,10 +3255,10 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *i915, u8 *i2c_pin)const struct intel_bios_encoder_data *devdata;const struct child_device_config *child; -if (list_empty (&i915->vbt.display_devices)) +if (list_empty (&i915->display.vbt.display_devices))return true; -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child;/* If the device type is not LFP, continue.
@@ -3304,7 +3304,7 @@ bool intel_bios_is_port_present(struct drm_i915_private *i915, enum port port)if (WARN_ON (!has_ddi_port_info (i915)))return true; -return i915->vbt.ports[port]; +return i915->display.vbt.ports[port]; }/**
@@ -3364,7 +3364,7 @@ bool intel_bios_is_dsi_present(struct drm_i915_private *i915,const struct child_device_config *child;u8 dvo_port; -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child;if (!(child->device_type &DEVICE_TYPE_MIPI_OUTPUT ))
@@ -3463,7 +3463,7 @@ bool intel_bios_get_dsc_params(struct intel_encoder *encoder,const struct intel_bios_encoder_data *devdata;const struct child_device_config *child; -list_for_each_entry (devdata, &i915->vbt.display_devices, node) { +list_for_each_entry (devdata, &i915->display.vbt.display_devices, node) { child = &devdata->child;if (!(child->device_type &DEVICE_TYPE_MIPI_OUTPUT ))
@@ -3494,7 +3494,7 @@ bool intel_bios_is_port_hpd_inverted(const struct drm_i915_private *i915, enum port port) { -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[port];if (drm_WARN_ON_ONCE (&i915->drm, !IS_GEMINILAKE (i915) && !IS_BROXTON (i915)))
@@ -3514,7 +3514,7 @@ bool intel_bios_is_lspcon_present(const struct drm_i915_private *i915, enum port port) { -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[port];return HAS_LSPCON (i915) && devdata && devdata->child.lspcon; }
@@ -3530,7 +3530,7 @@ bool intel_bios_is_lane_reversal_needed(const struct drm_i915_private *i915, enum port port) { -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[port];return devdata && devdata->child.lane_reversal; }
@@ -3538,7 +3538,7 @@ intel_bios_is_lane_reversal_needed(const struct drm_i915_private *i915,enum aux_ch intel_bios_port_aux_ch (struct drm_i915_private *i915,enum port port) { -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[port];enum aux_ch aux_ch;if (!devdata || !devdata->child.aux_channel) {
@@ -3632,7 +3632,7 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *i915,int intel_bios_max_tmds_clock (struct intel_encoder *encoder) {struct drm_i915_private *i915 =to_i915 (encoder->base.dev); -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[encoder->port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];return _intel_bios_max_tmds_clock (devdata); }
@@ -3641,14 +3641,14 @@ int intel_bios_max_tmds_clock(struct intel_encoder *encoder)int intel_bios_hdmi_level_shift (struct intel_encoder *encoder) {struct drm_i915_private *i915 =to_i915 (encoder->base.dev); -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[encoder->port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];return _intel_bios_hdmi_level_shift (devdata); }int intel_bios_encoder_dp_boost_level (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->vbt.version <196 || !devdata->child.iboost) +if (!devdata || devdata->i915->display.vbt.version <196 || !devdata->child.iboost)return 0 ;return translate_iboost (devdata->child.dp_iboost_level);
@@ -3656,7 +3656,7 @@ int intel_bios_encoder_dp_boost_level(const struct intel_bios_encoder_data *devdint intel_bios_encoder_hdmi_boost_level (const struct intel_bios_encoder_data *devdata) { -if (!devdata || devdata->i915->vbt.version <196 || !devdata->child.iboost) +if (!devdata || devdata->i915->display.vbt.version <196 || !devdata->child.iboost)return 0 ;return translate_iboost (devdata->child.hdmi_iboost_level);
@@ -3665,7 +3665,7 @@ int intel_bios_encoder_hdmi_boost_level(const struct intel_bios_encoder_data *deint intel_bios_dp_max_link_rate (struct intel_encoder *encoder) {struct drm_i915_private *i915 =to_i915 (encoder->base.dev); -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[encoder->port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];return _intel_bios_dp_max_link_rate (devdata); }
@@ -3673,7 +3673,7 @@ int intel_bios_dp_max_link_rate(struct intel_encoder *encoder)int intel_bios_alternate_ddc_pin (struct intel_encoder *encoder) {struct drm_i915_private *i915 =to_i915 (encoder->base.dev); -const struct intel_bios_encoder_data *devdata = i915->vbt.ports[encoder->port]; +const struct intel_bios_encoder_data *devdata = i915->display.vbt.ports[encoder->port];if (!devdata || !devdata->child.ddc_pin)return 0 ;
@@ -3683,16 +3683,16 @@ int intel_bios_alternate_ddc_pin(struct intel_encoder *encoder)bool intel_bios_encoder_supports_typec_usb (const struct intel_bios_encoder_data *devdata) { -return devdata->i915->vbt.version >=195 && devdata->child.dp_usb_type_c; +return devdata->i915->display.vbt.version >=195 && devdata->child.dp_usb_type_c; }bool intel_bios_encoder_supports_tbt (const struct intel_bios_encoder_data *devdata) { -return devdata->i915->vbt.version >=209 && devdata->child.tbt; +return devdata->i915->display.vbt.version >=209 && devdata->child.tbt; }const struct intel_bios_encoder_data *intel_bios_encoder_data_lookup (struct drm_i915_private *i915,enum port port) { -return i915->vbt.ports[port]; +return i915->display.vbt.ports[port]; }
drivers/gpu/drm/i915/display/intel_crt.c +2 -2
@@ -645,7 +645,7 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector)BUG_ON (crt->base.type !=INTEL_OUTPUT_ANALOG ); - i2c =intel_gmbus_get_adapter (dev_priv, dev_priv->vbt.crt_ddc_pin); + i2c =intel_gmbus_get_adapter (dev_priv, dev_priv->display.vbt.crt_ddc_pin); edid =intel_crt_get_edid (connector, i2c);if (edid) {
@@ -931,7 +931,7 @@ static int intel_crt_get_modes(struct drm_connector *connector) wakeref =intel_display_power_get (dev_priv, intel_encoder->power_domain); - i2c =intel_gmbus_get_adapter (dev_priv, dev_priv->vbt.crt_ddc_pin); + i2c =intel_gmbus_get_adapter (dev_priv, dev_priv->display.vbt.crt_ddc_pin); ret =intel_crt_ddc_get_modes (connector, i2c);if (ret || !IS_G4X (dev_priv)) goto out;
drivers/gpu/drm/i915/display/intel_display.c +6 -6
@@ -2772,12 +2772,12 @@ static void intel_panel_sanitize_ssc(struct drm_i915_private *dev_priv) PCH_DREF_CONTROL) &DREF_SSC1_ENABLE ; -if (dev_priv->vbt.lvds_use_ssc != bios_lvds_use_ssc) { +if (dev_priv->display.vbt.lvds_use_ssc != bios_lvds_use_ssc) {drm_dbg_kms (&dev_priv->drm,"SSC %s by BIOS, overriding VBT which says %s\n" ,str_enabled_disabled (bios_lvds_use_ssc), -str_enabled_disabled (dev_priv->vbt.lvds_use_ssc)); - dev_priv->vbt.lvds_use_ssc = bios_lvds_use_ssc; +str_enabled_disabled (dev_priv->display.vbt.lvds_use_ssc)); + dev_priv->display.vbt.lvds_use_ssc = bios_lvds_use_ssc; } } }
@@ -4373,7 +4373,7 @@ static int i9xx_pll_refclk(struct drm_device *dev,u32 dpll = pipe_config->dpll_hw_state.dpll;if ((dpll &PLL_REF_INPUT_MASK ) ==PLLB_REF_INPUT_SPREADSPECTRUMIN ) -return dev_priv->vbt.lvds_ssc_freq; +return dev_priv->display.vbt.lvds_ssc_freq;else if (HAS_PCH_SPLIT (dev_priv))return 120000 ;else if (DISPLAY_VER (dev_priv) !=2 )
@@ -7923,7 +7923,7 @@ static bool intel_ddi_crt_present(struct drm_i915_private *dev_priv)if (intel_de_read (dev_priv,DDI_BUF_CTL (PORT_A )) &DDI_A_4_LANES )return false; -if (!dev_priv->vbt.int_crt_support) +if (!dev_priv->display.vbt.int_crt_support)return false;return true;
@@ -8058,7 +8058,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) }else if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) {bool has_edp, has_port; -if (IS_VALLEYVIEW (dev_priv) && dev_priv->vbt.int_crt_support) +if (IS_VALLEYVIEW (dev_priv) && dev_priv->display.vbt.int_crt_support)intel_crt_init (dev_priv);/*
drivers/gpu/drm/i915/display/intel_display_core.h +38 -0
@@ -6,11 +6,14 @@#ifndef __INTEL_DISPLAY_CORE_H__#define __INTEL_DISPLAY_CORE_H__ +#include <linux/list.h> #include <linux/mutex.h> #include <linux/types.h> #include <linux/wait.h> #include <linux/workqueue.h> +#include <drm/drm_connector.h> +#include "intel_cdclk.h" #include "intel_display.h" #include "intel_dmc.h"
@@ -25,6 +28,7 @@ struct i915_audio_component;struct i915_hdcp_comp_master ;struct intel_atomic_state ;struct intel_audio_funcs ; +struct intel_bios_encoder_data ;struct intel_cdclk_funcs ;struct intel_cdclk_vals ;struct intel_clock_gating_funcs ;
@@ -152,6 +156,39 @@ struct intel_hotplug {struct workqueue_struct *dp_wq; }; +struct intel_vbt_data { +/* bdb version */ +u16 version; + +/* Feature bits */ +unsigned int int_tv_support:1 ; +unsigned int int_crt_support:1 ; +unsigned int lvds_use_ssc:1 ; +unsigned int int_lvds_support:1 ; +unsigned int display_clock_mode:1 ; +unsigned int fdi_rx_polarity_inverted:1 ; +int lvds_ssc_freq; +enum drm_panel_orientation orientation; + +bool override_afc_startup; +u8 override_afc_startup_val; + +int crt_ddc_pin; + +struct list_head display_devices; +struct list_head bdb_blocks; + +struct intel_bios_encoder_data *ports[I915_MAX_PORTS ];/* Non-NULL if port present. */ +struct sdvo_device_mapping { +u8 initialized; +u8 dvo_port; +u8 slave_addr; +u8 dvo_wiring; +u8 i2c_pin; +u8 ddc_pin; + } sdvo_mappings[2 ]; +}; +struct intel_wm {/* * Raw watermark latency values:
@@ -313,6 +350,7 @@ struct intel_display {struct intel_hotplug hotplug;struct intel_opregion opregion;struct intel_overlay *overlay; +struct intel_vbt_data vbt;struct intel_wm wm; };
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -5183,7 +5183,7 @@ intel_edp_add_properties(struct intel_dp *intel_dp)return ;drm_connector_set_panel_orientation_with_quirk (&connector->base, - i915->vbt.orientation, + i915->display.vbt.orientation, fixed_mode->hdisplay, fixed_mode->vdisplay); }
drivers/gpu/drm/i915/display/intel_dpll.c +7 -7
@@ -991,7 +991,7 @@ static void ilk_update_pll_dividers(struct intel_crtc_state *crtc_state, factor =21 ;if (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_LVDS )) {if ((intel_panel_use_ssc (dev_priv) && - dev_priv->vbt.lvds_ssc_freq ==100000 ) || + dev_priv->display.vbt.lvds_ssc_freq ==100000 ) || (HAS_PCH_IBX (dev_priv) &&intel_is_dual_link_lvds (dev_priv))) factor =25 ;
@@ -1105,8 +1105,8 @@ static int ilk_crtc_compute_clock(struct intel_atomic_state *state,if (intel_panel_use_ssc (dev_priv)) {drm_dbg_kms (&dev_priv->drm,"using SSC reference clock of %d kHz\n" , - dev_priv->vbt.lvds_ssc_freq); - refclk = dev_priv->vbt.lvds_ssc_freq; + dev_priv->display.vbt.lvds_ssc_freq); + refclk = dev_priv->display.vbt.lvds_ssc_freq; }if (intel_is_dual_link_lvds (dev_priv)) {
@@ -1231,7 +1231,7 @@ static int g4x_crtc_compute_clock(struct intel_atomic_state *state,if (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_LVDS )) {if (intel_panel_use_ssc (dev_priv)) { - refclk = dev_priv->vbt.lvds_ssc_freq; + refclk = dev_priv->display.vbt.lvds_ssc_freq;drm_dbg_kms (&dev_priv->drm,"using SSC reference clock of %d kHz\n" , refclk);
@@ -1273,7 +1273,7 @@ static int pnv_crtc_compute_clock(struct intel_atomic_state *state,if (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_LVDS )) {if (intel_panel_use_ssc (dev_priv)) { - refclk = dev_priv->vbt.lvds_ssc_freq; + refclk = dev_priv->display.vbt.lvds_ssc_freq;drm_dbg_kms (&dev_priv->drm,"using SSC reference clock of %d kHz\n" , refclk);
@@ -1306,7 +1306,7 @@ static int i9xx_crtc_compute_clock(struct intel_atomic_state *state,if (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_LVDS )) {if (intel_panel_use_ssc (dev_priv)) { - refclk = dev_priv->vbt.lvds_ssc_freq; + refclk = dev_priv->display.vbt.lvds_ssc_freq;drm_dbg_kms (&dev_priv->drm,"using SSC reference clock of %d kHz\n" , refclk);
@@ -1339,7 +1339,7 @@ static int i8xx_crtc_compute_clock(struct intel_atomic_state *state,if (intel_crtc_has_type (crtc_state,INTEL_OUTPUT_LVDS )) {if (intel_panel_use_ssc (dev_priv)) { - refclk = dev_priv->vbt.lvds_ssc_freq; + refclk = dev_priv->display.vbt.lvds_ssc_freq;drm_dbg_kms (&dev_priv->drm,"using SSC reference clock of %d kHz\n" , refclk);
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +9 -9
@@ -2769,8 +2769,8 @@ static void icl_calc_dpll_state(struct drm_i915_private *i915,else pll_state->cfgcr1 |=DPLL_CFGCR1_CENTRAL_FREQ_8400 ; -if (i915->vbt.override_afc_startup) - pll_state->div0 =TGL_DPLL0_DIV0_AFC_STARTUP (i915->vbt.override_afc_startup_val); +if (i915->display.vbt.override_afc_startup) + pll_state->div0 =TGL_DPLL0_DIV0_AFC_STARTUP (i915->display.vbt.override_afc_startup_val); } static int icl_mg_pll_find_divisors(int clock_khz, bool is_dp, bool use_ssc,
@@ -2965,8 +2965,8 @@ static int icl_calc_mg_pll_state(struct intel_crtc_state *crtc_state,DKL_PLL_DIV0_PROP_COEFF (prop_coeff) |DKL_PLL_DIV0_FBPREDIV (m1div) |DKL_PLL_DIV0_FBDIV_INT (m2div_int); -if (dev_priv->vbt.override_afc_startup) { -u8 val = dev_priv->vbt.override_afc_startup_val; +if (dev_priv->display.vbt.override_afc_startup) { +u8 val = dev_priv->display.vbt.override_afc_startup_val; pll_state->mg_pll_div0 |=DKL_PLL_DIV0_AFC_STARTUP (val); }
@@ -3502,7 +3502,7 @@ static bool dkl_pll_get_hw_state(struct drm_i915_private *dev_priv, hw_state->mg_pll_div0 =intel_de_read (dev_priv,DKL_PLL_DIV0 (tc_port)); val =DKL_PLL_DIV0_MASK ; -if (dev_priv->vbt.override_afc_startup) +if (dev_priv->display.vbt.override_afc_startup) val |=DKL_PLL_DIV0_AFC_STARTUP_MASK ; hw_state->mg_pll_div0 &= val;
@@ -3566,7 +3566,7 @@ static bool icl_pll_get_hw_state(struct drm_i915_private *dev_priv, TGL_DPLL_CFGCR0(id)); hw_state->cfgcr1 =intel_de_read (dev_priv,TGL_DPLL_CFGCR1 (id)); -if (dev_priv->vbt.override_afc_startup) { +if (dev_priv->display.vbt.override_afc_startup) { hw_state->div0 =intel_de_read (dev_priv,TGL_DPLL0_DIV0 (id)); hw_state->div0 &=TGL_DPLL0_DIV0_AFC_STARTUP_MASK ; }
@@ -3638,9 +3638,9 @@ static void icl_dpll_write(struct drm_i915_private *dev_priv,intel_de_write (dev_priv, cfgcr0_reg, hw_state->cfgcr0);intel_de_write (dev_priv, cfgcr1_reg, hw_state->cfgcr1); -drm_WARN_ON_ONCE (&dev_priv->drm, dev_priv->vbt.override_afc_startup && +drm_WARN_ON_ONCE (&dev_priv->drm, dev_priv->display.vbt.override_afc_startup && !i915_mmio_reg_valid (div0_reg)); -if (dev_priv->vbt.override_afc_startup && +if (dev_priv->display.vbt.override_afc_startup &&i915_mmio_reg_valid (div0_reg))intel_de_rmw (dev_priv, div0_reg,TGL_DPLL0_DIV0_AFC_STARTUP_MASK , hw_state->div0);
@@ -3732,7 +3732,7 @@ static void dkl_pll_write(struct drm_i915_private *dev_priv,intel_de_write (dev_priv,DKL_CLKTOP2_HSCLKCTL (tc_port), val); val =DKL_PLL_DIV0_MASK ; -if (dev_priv->vbt.override_afc_startup) +if (dev_priv->display.vbt.override_afc_startup) val |=DKL_PLL_DIV0_AFC_STARTUP_MASK ;intel_de_rmw (dev_priv,DKL_PLL_DIV0 (tc_port), val, hw_state->mg_pll_div0);
drivers/gpu/drm/i915/display/intel_dsi.c +1 -1
@@ -106,7 +106,7 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return orientation; - orientation = dev_priv->vbt.orientation; + orientation = dev_priv->display.vbt.orientation;if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return orientation;
drivers/gpu/drm/i915/display/intel_lvds.c +2 -2
@@ -837,12 +837,12 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)/* Skip init on machines we know falsely report LVDS */ if (dmi_check_system (intel_no_lvds)) { -drm_WARN (dev, !dev_priv->vbt.int_lvds_support, +drm_WARN (dev, !dev_priv->display.vbt.int_lvds_support,"Useless DMI match. Internal LVDS support disabled by VBT\n" );return ; } -if (!dev_priv->vbt.int_lvds_support) { +if (!dev_priv->display.vbt.int_lvds_support) {drm_dbg_kms (&dev_priv->drm,"Internal LVDS support disabled by VBT\n" );return ;
drivers/gpu/drm/i915/display/intel_panel.c +1 -1
@@ -42,7 +42,7 @@ bool intel_panel_use_ssc(struct drm_i915_private *i915) {if (i915->params.panel_use_ssc >=0 )return i915->params.panel_use_ssc !=0 ; -return i915->vbt.lvds_use_ssc +return i915->display.vbt.lvds_use_ssc && !(i915->quirks &QUIRK_LVDS_SSC_DISABLE ); }
drivers/gpu/drm/i915/display/intel_pch_refclk.c +1 -1
@@ -514,7 +514,7 @@ static void ilk_init_pch_refclk(struct drm_i915_private *dev_priv) }if (HAS_PCH_IBX (dev_priv)) { - has_ck505 = dev_priv->vbt.display_clock_mode; + has_ck505 = dev_priv->display.vbt.display_clock_mode; can_ssc = has_ck505; }else { has_ck505 = false;
drivers/gpu/drm/i915/display/intel_sdvo.c +9 -9
@@ -2016,7 +2016,7 @@ intel_sdvo_get_analog_edid(struct drm_connector *connector)return drm_get_edid (connector,intel_gmbus_get_adapter (dev_priv, - dev_priv->vbt.crt_ddc_pin)); + dev_priv->display.vbt.crt_ddc_pin)); } static enum drm_connector_status
@@ -2581,9 +2581,9 @@ intel_sdvo_select_ddc_bus(struct drm_i915_private *dev_priv,struct sdvo_device_mapping *mapping;if (sdvo->port ==PORT_B ) - mapping = &dev_priv->vbt.sdvo_mappings[0 ]; + mapping = &dev_priv->display.vbt.sdvo_mappings[0 ];else - mapping = &dev_priv->vbt.sdvo_mappings[1 ]; + mapping = &dev_priv->display.vbt.sdvo_mappings[1 ];if (mapping->initialized) sdvo->ddc_bus =1 << ((mapping->ddc_pin &0xf0 ) >>4 );
@@ -2599,9 +2599,9 @@ intel_sdvo_select_i2c_bus(struct drm_i915_private *dev_priv,u8 pin;if (sdvo->port ==PORT_B ) - mapping = &dev_priv->vbt.sdvo_mappings[0 ]; + mapping = &dev_priv->display.vbt.sdvo_mappings[0 ];else - mapping = &dev_priv->vbt.sdvo_mappings[1 ]; + mapping = &dev_priv->display.vbt.sdvo_mappings[1 ];if (mapping->initialized &&intel_gmbus_is_valid_pin (dev_priv, mapping->i2c_pin))
@@ -2639,11 +2639,11 @@ intel_sdvo_get_slave_addr(struct drm_i915_private *dev_priv,struct sdvo_device_mapping *my_mapping, *other_mapping;if (sdvo->port ==PORT_B ) { - my_mapping = &dev_priv->vbt.sdvo_mappings[0 ]; - other_mapping = &dev_priv->vbt.sdvo_mappings[1 ]; + my_mapping = &dev_priv->display.vbt.sdvo_mappings[0 ]; + other_mapping = &dev_priv->display.vbt.sdvo_mappings[1 ]; }else { - my_mapping = &dev_priv->vbt.sdvo_mappings[1 ]; - other_mapping = &dev_priv->vbt.sdvo_mappings[0 ]; + my_mapping = &dev_priv->display.vbt.sdvo_mappings[1 ]; + other_mapping = &dev_priv->display.vbt.sdvo_mappings[0 ]; }/* If the BIOS described our SDVO device, take advantage of it. */
drivers/gpu/drm/i915/display/intel_vbt_defs.h +4 -4
@@ -362,10 +362,10 @@ enum vbt_gmbus_ddi {* basically any of the fields to ensure the correct interpretation for the BDB * version in question. * -* When we copy the child device configs to dev_priv->vbt.child_dev, we reserve -* space for the full structure below, and initialize the tail not actually -* present in VBT to zeros. Accessing those fields is fine, as long as the -* default zero is taken into account, again according to the BDB version. +* When we copy the child device configs to dev_priv->display.vbt.child_dev, we +* reserve space for the full structure below, and initialize the tail not +* actually present in VBT to zeros. Accessing those fields is fine, as long as +* the default zero is taken into account, again according to the BDB version. * * BDB versions 155 and below are considered legacy, and version 155 seems to be * a baseline for some of the VBT documentation. When adding new fields, please
drivers/gpu/drm/i915/i915_drv.h +0 -37
@@ -34,7 +34,6 @@#include <linux/pm_qos.h> -#include <drm/drm_connector.h> #include <drm/ttm/ttm_device.h> #include "display/intel_display.h"
@@ -89,15 +88,6 @@ struct vlv_s0ix_state; I915_GEM_DOMAIN_INSTRUCTION | \ I915_GEM_DOMAIN_VERTEX) -struct sdvo_device_mapping { -u8 initialized; -u8 dvo_port; -u8 slave_addr; -u8 dvo_wiring; -u8 i2c_pin; -u8 ddc_pin; -}; -#define I915_COLOR_UNEVICTABLE (-1)/* a non-vma sharing the address space */ #define QUIRK_LVDS_SSC_DISABLE (1<<1)
@@ -198,32 +188,6 @@ i915_fence_timeout(const struct drm_i915_private *i915)#define HAS_HW_SAGV_WM (i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915)) -struct intel_vbt_data { -/* bdb version */ -u16 version; - -/* Feature bits */ -unsigned int int_tv_support:1 ; -unsigned int int_crt_support:1 ; -unsigned int lvds_use_ssc:1 ; -unsigned int int_lvds_support:1 ; -unsigned int display_clock_mode:1 ; -unsigned int fdi_rx_polarity_inverted:1 ; -int lvds_ssc_freq; -enum drm_panel_orientation orientation; - -bool override_afc_startup; -u8 override_afc_startup_val; - -int crt_ddc_pin; - -struct list_head display_devices; -struct list_head bdb_blocks; - -struct intel_bios_encoder_data *ports[I915_MAX_PORTS ];/* Non-NULL if port present. */ -struct sdvo_device_mapping sdvo_mappings[2 ]; -}; -struct i915_frontbuffer_tracking {spinlock_t lock;
@@ -321,7 +285,6 @@ struct drm_i915_private {u32 pipestat_irq_mask[I915_MAX_PIPES ];struct intel_fbc *fbc[I915_MAX_FBCS ]; -struct intel_vbt_data vbt;bool preserve_bios_swizzle;
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -7435,7 +7435,7 @@ static void cpt_init_clock_gating(struct drm_i915_private *dev_priv) val =intel_uncore_read (&dev_priv->uncore,TRANS_CHICKEN2 (pipe)); val |=TRANS_CHICKEN2_TIMING_OVERRIDE ; val &= ~TRANS_CHICKEN2_FDI_POLARITY_REVERSED ; -if (dev_priv->vbt.fdi_rx_polarity_inverted) +if (dev_priv->display.vbt.fdi_rx_polarity_inverted) val |=TRANS_CHICKEN2_FDI_POLARITY_REVERSED ; val &= ~TRANS_CHICKEN2_DISABLE_DEEP_COLOR_COUNTER ; val &= ~TRANS_CHICKEN2_DISABLE_DEEP_COLOR_MODESWITCH ;
Signature · 1 line
2.34.1
PATCH 26/39 drm/i915: move fbc to display.fbc
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
Pointers and arrays of pointers to structs that we defined are fine without a sub-struct wrapping.
--- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/intel_display_core.h | 2 ++ drivers/gpu/drm/i915/display/intel_fbc.c | 6 +++--- drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 3 --- 5 files changed, 7 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/i9xx_plane.c +1 -1
@@ -125,7 +125,7 @@ static struct intel_fbc *i9xx_plane_fbc(struct drm_i915_private *dev_priv, enum i9xx_plane_id i9xx_plane) {if (i9xx_plane_has_fbc (dev_priv, i9xx_plane)) -return dev_priv->fbc[INTEL_FBC_A ]; +return dev_priv->display.fbc[INTEL_FBC_A ];else return NULL ; }
drivers/gpu/drm/i915/display/intel_display_core.h +2 -0
@@ -18,6 +18,7 @@#include "intel_display.h" #include "intel_dmc.h" #include "intel_dpll_mgr.h" +#include "intel_fbc.h" #include "intel_global_state.h" #include "intel_gmbus.h" #include "intel_opregion.h"
@@ -347,6 +348,7 @@ struct intel_display {struct intel_audio audio;struct intel_dmc dmc;struct intel_dpll dpll; +struct intel_fbc *fbc[I915_MAX_FBCS ];struct intel_hotplug hotplug;struct intel_opregion opregion;struct intel_overlay *overlay;
drivers/gpu/drm/i915/display/intel_fbc.c +3 -3
@@ -59,7 +59,7 @@#define for_each_intel_fbc (__dev_priv, __fbc, __fbc_id) \ for_each_fbc_id((__dev_priv), (__fbc_id)) \ - for_each_if((__fbc) = (__dev_priv)->fbc[(__fbc_id)]) + for_each_if((__fbc) = (__dev_priv)->display.fbc[(__fbc_id)])struct intel_fbc_funcs {void (*activate)(struct intel_fbc *fbc);
@@ -1720,7 +1720,7 @@ void intel_fbc_init(struct drm_i915_private *i915) i915->params.enable_fbc);for_each_fbc_id (i915, fbc_id) - i915->fbc[fbc_id] =intel_fbc_create (i915, fbc_id); + i915->display.fbc[fbc_id] =intel_fbc_create (i915, fbc_id); }/**
@@ -1840,7 +1840,7 @@ void intel_fbc_debugfs_register(struct drm_i915_private *i915)struct drm_minor *minor = i915->drm.primary;struct intel_fbc *fbc; - fbc = i915->fbc[INTEL_FBC_A ]; + fbc = i915->display.fbc[INTEL_FBC_A ];if (fbc)intel_fbc_debugfs_add (fbc, minor->debugfs_root); }
drivers/gpu/drm/i915/display/skl_universal_plane.c +1 -1
@@ -1940,7 +1940,7 @@ static struct intel_fbc *skl_plane_fbc(struct drm_i915_private *dev_priv,enum intel_fbc_id fbc_id =skl_fbc_id_for_pipe (pipe);if (skl_plane_has_fbc (dev_priv, fbc_id, plane_id)) -return dev_priv->fbc[fbc_id]; +return dev_priv->display.fbc[fbc_id];else return NULL ; }
drivers/gpu/drm/i915/i915_drv.h +0 -3
@@ -40,7 +40,6 @@#include "display/intel_display_core.h" #include "display/intel_display_power.h" #include "display/intel_dsb.h" -#include "display/intel_fbc.h" #include "display/intel_frontbuffer.h" #include "gem/i915_gem_context_types.h"
@@ -284,8 +283,6 @@ struct drm_i915_private { };u32 pipestat_irq_mask[I915_MAX_PIPES ]; -struct intel_fbc *fbc[I915_MAX_FBCS ]; -bool preserve_bios_swizzle;unsigned int fsb_freq, mem_freq, is_ddr3;
Signature · 1 line
2.34.1
PATCH 27/39 drm/i915/vrr: drop window2_delay member from i915
In reply to Jani NikulaThe window2_delay member has been functionally unused (always set to 0) since it was added in commit bb265dbdf38d ("drm/i915/xelpd: Add VRR guardband for VRR CTL"). Replace it with a FIXME comment.
--- drivers/gpu/drm/i915/display/intel_display.c | 2 -- drivers/gpu/drm/i915/display/intel_vrr.c | 14 ++++++++++---- drivers/gpu/drm/i915/i915_drv.h | 3 --- 3 files changed, 10 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -2
@@ -8685,8 +8685,6 @@ int intel_modeset_init_noirq(struct drm_i915_private *i915) i915->flip_wq =alloc_workqueue ("i915_flip" ,WQ_HIGHPRI |WQ_UNBOUND ,WQ_UNBOUND_MAX_ACTIVE ); - i915->window2_delay =0 ;/* No DSB so no window2 delay */ -intel_mode_config_init (i915); ret =intel_cdclk_init (i915);
drivers/gpu/drm/i915/display/intel_vrr.c +10 -4
@@ -142,11 +142,16 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,* For XE_LPD+, we use guardband and pipeline override * is deprecated. */ -if (DISPLAY_VER (i915) >=13 ) +if (DISPLAY_VER (i915) >=13 ) { +/* +* FIXME: Substract Window2 delay from below value. +* +* Window2 specifies time required to program DSB (Window2) in +* number of scan lines. Assuming 0 for no DSB. +*/ crtc_state->vrr.guardband = - crtc_state->vrr.vmin - adjusted_mode->crtc_vdisplay - - i915->window2_delay; -else + crtc_state->vrr.vmin - adjusted_mode->crtc_vdisplay; + }else {/* * FIXME: s/4/framestart_delay/ to get consistent * earliest/latest points for register latching regardless
@@ -159,6 +164,7 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,*/ crtc_state->vrr.pipeline_full =min (255 , crtc_state->vrr.vmin - adjusted_mode->crtc_vdisplay -4 -1 ); + } crtc_state->mode_flags |=I915_MODE_FLAG_VRR ; }
drivers/gpu/drm/i915/i915_drv.h +0 -3
@@ -426,9 +426,6 @@ struct drm_i915_private {struct file *mmap_singleton; } gem; -/* Window2 specifies time required to program DSB (Window2) in number of scan lines */ -u8 window2_delay; -u8 pch_ssc_use;/* For i915gm/i945gm vblank irq workaround */
Signature · 1 line
2.34.1
PATCH 28/39 drm/i915: move and group power related members under display.power
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
Arguably chv_phy_control and chv_phy_assert could be placed in a phy substruct, but they are only used in the power code.
--- .../gpu/drm/i915/display/intel_display_core.h | 11 ++ .../drm/i915/display/intel_display_power.c | 112 +++++++++--------- .../i915/display/intel_display_power_map.c | 4 +- .../i915/display/intel_display_power_well.c | 56 ++++----- .../i915/display/intel_display_power_well.h | 12 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 20 +--- 8 files changed, 110 insertions(+), 109 deletions(-)
drivers/gpu/drm/i915/display/intel_display_core.h +11 -0
@@ -16,6 +16,7 @@#include "intel_cdclk.h" #include "intel_display.h" +#include "intel_display_power.h" #include "intel_dmc.h" #include "intel_dpll_mgr.h" #include "intel_fbc.h"
@@ -326,6 +327,16 @@ struct intel_display {struct mutex comp_mutex; } hdcp; +struct { +struct i915_power_domains domains; + +/* Shadow for DISPLAY_PHY_CONTROL which can't be safely read */ +u32 chv_phy_control; + +/* perform PHY state sanity checks? */ +bool chv_phy_assert[2 ]; + } power; +struct {u32 mmio_base;
drivers/gpu/drm/i915/display/intel_display_power.c +56 -56
395 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_map.c +2 -2
@@ -1388,7 +1388,7 @@ __set_power_wells(struct i915_power_domains *power_domains, {struct drm_i915_private *i915 =container_of (power_domains, struct drm_i915_private, - power_domains); + display.power.domains);u64 power_well_ids =0 ;const struct i915_power_well_desc_list *desc_list;const struct i915_power_well_desc *desc;
@@ -1447,7 +1447,7 @@ int intel_display_power_map_init(struct i915_power_domains *power_domains) {struct drm_i915_private *i915 =container_of (power_domains, struct drm_i915_private, - power_domains); + display.power.domains);/* * The enabling order will be from lower to higher indexed wells, * the disabling order is reversed.
drivers/gpu/drm/i915/display/intel_display_power_well.c +28 -28
168 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_power_well.h +6 -6
@@ -14,15 +14,15 @@ struct drm_i915_private;struct i915_power_well ;#define for_each_power_well (__dev_priv, __power_well) \ - for ((__power_well) = (__dev_priv)->power_domains.power_wells; \ - (__power_well) - (__dev_priv)->power_domains.power_wells < \ - (__dev_priv)->power_domains.power_well_count; \ + for ((__power_well) = (__dev_priv)->display.power.domains.power_wells; \ + (__power_well) - (__dev_priv)->display.power.domains.power_wells < \ + (__dev_priv)->display.power.domains.power_well_count; \ (__power_well)++)#define for_each_power_well_reverse (__dev_priv, __power_well) \ - for ((__power_well) = (__dev_priv)->power_domains.power_wells + \ - (__dev_priv)->power_domains.power_well_count - 1; \ - (__power_well) - (__dev_priv)->power_domains.power_wells >= 0; \ + for ((__power_well) = (__dev_priv)->display.power.domains.power_wells + \ + (__dev_priv)->display.power.domains.power_well_count - 1; \ + (__power_well) - (__dev_priv)->display.power.domains.power_wells >= 0; \ (__power_well)--)/*
drivers/gpu/drm/i915/display/intel_dpio_phy.c +1 -1
@@ -484,7 +484,7 @@ void bxt_ddi_phy_init(struct drm_i915_private *dev_priv, enum dpio_phy phy)enum dpio_phy rcomp_phy = phy_info->rcomp_phy;bool was_enabled; -lockdep_assert_held (&dev_priv->power_domains.lock); +lockdep_assert_held (&dev_priv->display.power.domains.lock); was_enabled = true;if (rcomp_phy !=-1 )
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
@@ -493,7 +493,7 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused)seq_puts (m,"Runtime power management not supported\n" );seq_printf (m,"Runtime power status: %s\n" , -str_enabled_disabled (!dev_priv->power_domains.init_wakeref)); +str_enabled_disabled (!dev_priv->display.power.domains.init_wakeref));seq_printf (m,"GPU idle: %s\n" ,str_yes_no (!to_gt (dev_priv)->awake)); seq_printf(m, "IRQs disabled: %s\n",
drivers/gpu/drm/i915/i915_drv.h +5 -15
@@ -38,7 +38,6 @@#include "display/intel_display.h" #include "display/intel_display_core.h" -#include "display/intel_display_power.h" #include "display/intel_dsb.h" #include "display/intel_frontbuffer.h"
@@ -354,8 +353,6 @@ struct drm_i915_private {*/ u32 edram_size_mb; -struct i915_power_domains power_domains; -struct i915_gpu_error gpu_error;struct drm_property *broadcast_rgb_property;
@@ -363,8 +360,6 @@ struct drm_i915_private {u32 fdi_rx_config; -/* Shadow for DISPLAY_PHY_CONTROL which can't be safely read */ -u32 chv_phy_control;/* * Shadows for CHV DPLL_MD regs to keep the state * checker somewhat working in the presence hardware
@@ -433,16 +428,11 @@ struct drm_i915_private {bool irq_enabled; -union { -/* perform PHY state sanity checks? */ -bool chv_phy_assert[2 ]; - -/* -* DG2: Mask of PHYs that were not calibrated by the firmware -* and should not be used. -*/ -u8 snps_phy_failed_calibration; - }; +/* +* DG2: Mask of PHYs that were not calibrated by the firmware +* and should not be used. +*/ +u8 snps_phy_failed_calibration;bool ipc_enabled;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 28/39] drm/i915: move and group power related members under display.power
Quoted 30 lines · Jani Nikula
Move display related members under
drm_i915_privatedisplay sub-struct.Arguably
chv_phy_controlandchv_phy_assertcould be placed in a phy substruct, but they are only used in the power code.Signed-off-by Jani Nikula <[email protected]>---
.../gpu/drm/i915/display/intel_display_core.h | 11 ++ .../drm/i915/display/intel_display_power.c | 112 +++++++++--------- .../i915/display/intel_display_power_map.c | 4 +- .../i915/display/intel_display_power_well.c | 56 ++++----- .../i915/display/intel_display_power_well.h | 12 +- drivers/gpu/drm/i915/display/intel_dpio_phy.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 20 +--- 8 files changed, 110 insertions(+), 109 deletions(-)drivers/gpu/drm/i915/display/intel_display_core.h +1
-0@@ -16,6 +16,7 @@#include "intel_cdclk.h" #include "intel_display.h" +#include "intel_display_power.h" #include "intel_dmc.h" #include "intel_dpll_mgr.h" #include "intel_fbc.h"
drivers/gpu/drm/i915/display/intel_display_core.h struct intel_display { · line 331
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_core.h +2
-0@@ -326,6 +327,16 @@ struct intel_display {struct mutex comp_mutex; } hdcp; +struct { +struct i915_power_domains domains;
rename the struct to display_power_domains?
for all patches til this, expect patch 5
Lucas De Marchi
PATCH 29/39 drm/i915: move and group fdi members under display.fdi
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
--- drivers/gpu/drm/i915/display/intel_crt.c | 2 +- drivers/gpu/drm/i915/display/intel_display_core.h | 5 +++++ drivers/gpu/drm/i915/display/intel_fdi.c | 10 +++++----- drivers/gpu/drm/i915/i915_drv.h | 3 --- 4 files changed, 11 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_crt.c +1 -1
@@ -1110,7 +1110,7 @@ void intel_crt_init(struct drm_i915_private *dev_priv)u32 fdi_config =FDI_RX_POLARITY_REVERSED_LPT |FDI_RX_LINK_REVERSAL_OVERRIDE ; - dev_priv->fdi_rx_config =intel_de_read (dev_priv, + dev_priv->display.fdi.rx_config =intel_de_read (dev_priv,FDI_RX_CTL (PIPE_A )) & fdi_config; }
drivers/gpu/drm/i915/display/intel_display_core.h +5 -0
@@ -301,6 +301,11 @@ struct intel_display {struct work_struct suspend_work; } fbdev; +struct { +unsigned int pll_freq; +u32 rx_config; + } fdi; +struct {/* * Base address of where the gmbus and gpio blocks are located
drivers/gpu/drm/i915/display/intel_fdi.c +5 -5
@@ -210,14 +210,14 @@ void intel_fdi_pll_freq_update(struct drm_i915_private *i915)u32 fdi_pll_clk =intel_de_read (i915,FDI_PLL_BIOS_0 ) &FDI_PLL_FB_CLOCK_MASK ; - i915->fdi_pll_freq = (fdi_pll_clk +2 ) *10000 ; + i915->display.fdi.pll_freq = (fdi_pll_clk +2 ) *10000 ; }else if (IS_SANDYBRIDGE (i915) ||IS_IVYBRIDGE (i915)) { - i915->fdi_pll_freq =270000 ; + i915->display.fdi.pll_freq =270000 ; }else {return ; } -drm_dbg (&i915->drm,"FDI PLL freq=%d\n" , i915->fdi_pll_freq); +drm_dbg (&i915->drm,"FDI PLL freq=%d\n" , i915->display.fdi.pll_freq); } int intel_fdi_link_freq(struct drm_i915_private *i915,
@@ -226,7 +226,7 @@ int intel_fdi_link_freq(struct drm_i915_private *i915,if (HAS_DDI (i915))return pipe_config->port_clock;/* SPLL */ else -return i915->fdi_pll_freq; +return i915->display.fdi.pll_freq; } int ilk_fdi_compute_config(struct intel_crtc *crtc,
@@ -789,7 +789,7 @@ void hsw_fdi_link_train(struct intel_encoder *encoder, FDI_RX_PWRDN_LANE1_VAL(2) | FDI_RX_PWRDN_LANE0_VAL(2) | FDI_RX_TP1_TO_TP2_48 | FDI_RX_FDI_DELAY_90);/* Enable the PCH Receiver FDI PLL */ - rx_ctl_val = dev_priv->fdi_rx_config |FDI_RX_ENHANCE_FRAME_ENABLE | + rx_ctl_val = dev_priv->display.fdi.rx_config |FDI_RX_ENHANCE_FRAME_ENABLE |FDI_RX_PLL_ENABLE |FDI_DP_PORT_WIDTH (crtc_state->fdi_lanes);intel_de_write (dev_priv,FDI_RX_CTL (PIPE_A ), rx_ctl_val);
drivers/gpu/drm/i915/i915_drv.h +0 -3
@@ -289,7 +289,6 @@ struct drm_i915_private {unsigned int max_dotclk_freq;unsigned int hpll_freq; -unsigned int fdi_pll_freq;unsigned int czclk_freq;struct {
@@ -358,8 +357,6 @@ struct drm_i915_private {struct drm_property *broadcast_rgb_property;struct drm_property *force_audio_property; -u32 fdi_rx_config; -/* * Shadows for CHV DPLL_MD regs to keep the state * checker somewhat working in the presence hardware
Signature · 1 line
2.34.1
PATCH 30/39 drm/i915: move fb_tracking under display sub-struct
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
Rename struct i915_frontbuffer_tracking to intel_frontbuffer_tracking while at it.
FIXME: fb_tracking.lock mutex init should be moved away from i915_gem_init_early().
--- .../gpu/drm/i915/display/intel_display_core.h | 12 +++++ .../drm/i915/display/intel_display_debugfs.c | 4 +- .../gpu/drm/i915/display/intel_frontbuffer.c | 54 +++++++++---------- drivers/gpu/drm/i915/i915_drv.h | 14 ----- drivers/gpu/drm/i915/i915_gem.c | 2 +- 5 files changed, 42 insertions(+), 44 deletions(-)
drivers/gpu/drm/i915/display/intel_display_core.h +12 -0
@@ -119,6 +119,17 @@ struct intel_dpll { } ref_clks; }; +struct intel_frontbuffer_tracking { +spinlock_t lock; + +/* +* Tracking bits for delayed frontbuffer flushing du to gpu activity or +* scheduled flips. +*/ +unsigned busy_bits; +unsigned flip_bits; +}; +struct intel_hotplug {struct delayed_work hotplug_work;
@@ -365,6 +376,7 @@ struct intel_display {struct intel_dmc dmc;struct intel_dpll dpll;struct intel_fbc *fbc[I915_MAX_FBCS ]; +struct intel_frontbuffer_tracking fb_tracking;struct intel_hotplug hotplug;struct intel_opregion opregion;struct intel_overlay *overlay;
drivers/gpu/drm/i915/display/intel_display_debugfs.c +2 -2
@@ -37,10 +37,10 @@ static int i915_frontbuffer_tracking(struct seq_file *m, void *unused)struct drm_i915_private *dev_priv =node_to_i915 (m->private);seq_printf (m,"FB tracking busy bits: 0x%08x\n" , - dev_priv->fb_tracking.busy_bits); + dev_priv->display.fb_tracking.busy_bits);seq_printf (m,"FB tracking flip bits: 0x%08x\n" , - dev_priv->fb_tracking.flip_bits); + dev_priv->display.fb_tracking.flip_bits);return 0 ; }
drivers/gpu/drm/i915/display/intel_frontbuffer.c +27 -27
124 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drv.h +0 -14
@@ -39,7 +39,6 @@#include "display/intel_display.h" #include "display/intel_display_core.h" #include "display/intel_dsb.h" -#include "display/intel_frontbuffer.h" #include "gem/i915_gem_context_types.h" #include "gem/i915_gem_lmem.h"
@@ -186,17 +185,6 @@ i915_fence_timeout(const struct drm_i915_private *i915)#define HAS_HW_SAGV_WM (i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915)) -struct i915_frontbuffer_tracking { -spinlock_t lock; - -/* -* Tracking bits for delayed frontbuffer flushing du to gpu activity or -* scheduled flips. -*/ -unsigned busy_bits; -unsigned flip_bits; -}; -struct i915_virtual_gpu {struct mutex lock;/* serialises sending of g2v_notify command pkts */ bool active;
@@ -327,8 +315,6 @@ struct drm_i915_private {struct list_head global_obj_list; -struct i915_frontbuffer_tracking fb_tracking; -struct intel_atomic_helper {struct llist_head free_list;struct work_struct free_work;
drivers/gpu/drm/i915/i915_gem.c +1 -1
@@ -1213,7 +1213,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv)i915_gem_init__mm (dev_priv);i915_gem_init__contexts (dev_priv); -spin_lock_init (&dev_priv->fb_tracking.lock); +spin_lock_init (&dev_priv->display.fb_tracking.lock); }void i915_gem_cleanup_early (struct drm_i915_private *dev_priv)
Signature · 1 line
2.34.1
PATCH 31/39 drm/i915: move INTEL_FRONTBUFFER_* macros to intel_frontbuffer.h
In reply to Jani NikulaThe macros clearly don't belong in i915_drv.h. Move to intel_frontbuffer.h.
Also split the BUILD_BUG_ON()s to intel_frontbuffer_track() to avoid depending on some other macros in the header.
--- .../gpu/drm/i915/display/intel_frontbuffer.c | 2 ++ .../gpu/drm/i915/display/intel_frontbuffer.h | 18 +++++++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 20 ------------------- 3 files changed, 20 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/display/intel_frontbuffer.c +2 -0
@@ -311,6 +311,8 @@ void intel_frontbuffer_track(struct intel_frontbuffer *old,*/ BUILD_BUG_ON (INTEL_FRONTBUFFER_BITS_PER_PIPE *I915_MAX_PIPES >BITS_PER_TYPE (atomic_t)); +BUILD_BUG_ON (INTEL_FRONTBUFFER_BITS_PER_PIPE *I915_MAX_PIPES >32 ); +BUILD_BUG_ON (I915_MAX_PLANES >INTEL_FRONTBUFFER_BITS_PER_PIPE );if (old) { drm_WARN_ON(old->obj->base.dev,
drivers/gpu/drm/i915/display/intel_frontbuffer.h +18 -0
@@ -25,6 +25,7 @@#define __INTEL_FRONTBUFFER_H__#include <linux/atomic.h> +#include <linux/bits.h> #include <linux/kref.h> #include "gem/i915_gem_object_types.h"
@@ -48,6 +49,23 @@ struct intel_frontbuffer {struct rcu_head rcu; }; +/* +* Frontbuffer tracking bits. Set in obj->frontbuffer_bits while a gem bo is +* considered to be the frontbuffer for the given plane interface-wise. This +* doesn't mean that the hw necessarily already scans it out, but that any +* rendering (by the cpu or gpu) will land in the frontbuffer eventually. +* +* We have one bit per pipe and per scanout plane type. +*/ +#define INTEL_FRONTBUFFER_BITS_PER_PIPE 8 +#define INTEL_FRONTBUFFER (pipe, plane_id) \ + BIT((plane_id) + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)); +#define INTEL_FRONTBUFFER_OVERLAY (pipe) \ + BIT(INTEL_FRONTBUFFER_BITS_PER_PIPE - 1 + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)) +#define INTEL_FRONTBUFFER_ALL_MASK (pipe) \ + GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \ + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)) +void intel_frontbuffer_flip_prepare (struct drm_i915_private *i915,unsigned frontbuffer_bits); void intel_frontbuffer_flip_complete(struct drm_i915_private *i915,
drivers/gpu/drm/i915/i915_drv.h +0 -20
@@ -483,26 +483,6 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define I915_GTT_OFFSET_NONE ((u32)-1) -/* -* Frontbuffer tracking bits. Set in obj->frontbuffer_bits while a gem bo is -* considered to be the frontbuffer for the given plane interface-wise. This -* doesn't mean that the hw necessarily already scans it out, but that any -* rendering (by the cpu or gpu) will land in the frontbuffer eventually. -* -* We have one bit per pipe and per scanout plane type. -*/ -#define INTEL_FRONTBUFFER_BITS_PER_PIPE 8 -#define INTEL_FRONTBUFFER (pipe, plane_id) ({ \ - BUILD_BUG_ON(INTEL_FRONTBUFFER_BITS_PER_PIPE * I915_MAX_PIPES > 32); \ - BUILD_BUG_ON(I915_MAX_PLANES > INTEL_FRONTBUFFER_BITS_PER_PIPE); \ - BIT((plane_id) + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)); \ -}) -#define INTEL_FRONTBUFFER_OVERLAY (pipe) \ - BIT(INTEL_FRONTBUFFER_BITS_PER_PIPE - 1 + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)) -#define INTEL_FRONTBUFFER_ALL_MASK (pipe) \ - GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \ - INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe)) -#define INTEL_INFO (dev_priv) (&(dev_priv)->__info)#define RUNTIME_INFO (dev_priv) (&(dev_priv)->__runtime)#define DRIVER_CAPS (dev_priv) (&(dev_priv)->caps)
Signature · 1 line
2.34.1
PATCH 32/39 drm/i915: move dbuf under display sub-struct
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
--- drivers/gpu/drm/i915/display/intel_display_core.h | 7 +++++++ drivers/gpu/drm/i915/display/intel_display_power.c | 6 +++--- .../drm/i915/display/intel_display_power_well.c | 2 +- drivers/gpu/drm/i915/display/intel_modeset_setup.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 7 ------- drivers/gpu/drm/i915/intel_pm.c | 14 +++++++------- drivers/gpu/drm/i915/intel_pm.h | 4 ++-- 7 files changed, 22 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/display/intel_display_core.h +7 -0
@@ -301,6 +301,13 @@ struct intel_display {unsigned int max_cdclk_freq; } cdclk; +struct { +/* The current hardware dbuf configuration */ +u8 enabled_slices; + +struct intel_global_obj obj; + } dbuf; +struct {/* VLV/CHV/BXT/GLK DSI MMIO register base address */ u32 mmio_base;
drivers/gpu/drm/i915/display/intel_display_power.c +3 -3
@@ -1060,14 +1060,14 @@ void gen9_dbuf_slices_update(struct drm_i915_private *dev_priv,for_each_dbuf_slice (dev_priv, slice)gen9_dbuf_slice_set (dev_priv, slice, req_slices &BIT (slice)); - dev_priv->dbuf.enabled_slices = req_slices; + dev_priv->display.dbuf.enabled_slices = req_slices;mutex_unlock (&power_domains->lock); }static void gen9_dbuf_enable (struct drm_i915_private *dev_priv) { - dev_priv->dbuf.enabled_slices = + dev_priv->display.dbuf.enabled_slices =intel_enabled_dbuf_slices_mask (dev_priv);/*
@@ -1075,7 +1075,7 @@ static void gen9_dbuf_enable(struct drm_i915_private *dev_priv)* figure out later which slices we have and what we need. */ gen9_dbuf_slices_update (dev_priv,BIT (DBUF_S1 ) | - dev_priv->dbuf.enabled_slices); + dev_priv->display.dbuf.enabled_slices); }static void gen9_dbuf_disable (struct drm_i915_private *dev_priv)
drivers/gpu/drm/i915/display/intel_display_power_well.c +1 -1
@@ -945,7 +945,7 @@ static bool gen9_dc_off_power_well_enabled(struct drm_i915_private *dev_priv,static void gen9_assert_dbuf_enabled (struct drm_i915_private *dev_priv) {u8 hw_enabled_dbuf_slices =intel_enabled_dbuf_slices_mask (dev_priv); -u8 enabled_dbuf_slices = dev_priv->dbuf.enabled_slices; +u8 enabled_dbuf_slices = dev_priv->display.dbuf.enabled_slices; drm_WARN(&dev_priv->drm, hw_enabled_dbuf_slices != enabled_dbuf_slices,
drivers/gpu/drm/i915/display/intel_modeset_setup.c +2 -2
@@ -34,7 +34,7 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,struct intel_cdclk_state *cdclk_state =to_intel_cdclk_state (i915->display.cdclk.obj.state);struct intel_dbuf_state *dbuf_state = -to_intel_dbuf_state (i915->dbuf.obj.state); +to_intel_dbuf_state (i915->display.dbuf.obj.state);struct intel_crtc_state *crtc_state =to_intel_crtc_state (crtc->base.state);struct intel_plane *plane;
@@ -417,7 +417,7 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)struct intel_cdclk_state *cdclk_state =to_intel_cdclk_state (i915->display.cdclk.obj.state);struct intel_dbuf_state *dbuf_state = -to_intel_dbuf_state (i915->dbuf.obj.state); +to_intel_dbuf_state (i915->display.dbuf.obj.state);enum pipe pipe;struct intel_crtc *crtc;struct intel_encoder *encoder;
drivers/gpu/drm/i915/i915_drv.h +0 -7
@@ -279,13 +279,6 @@ struct drm_i915_private {unsigned int hpll_freq;unsigned int czclk_freq; -struct { -/* The current hardware dbuf configuration */ -u8 enabled_slices; - -struct intel_global_obj obj; - } dbuf; -/** * wq - Driver workqueue for GEM. *
drivers/gpu/drm/i915/intel_pm.c +7 -7
@@ -6546,7 +6546,7 @@ static void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc,void skl_wm_get_hw_state (struct drm_i915_private *dev_priv) {struct intel_dbuf_state *dbuf_state = -to_intel_dbuf_state (dev_priv->dbuf.obj.state); +to_intel_dbuf_state (dev_priv->display.dbuf.obj.state);struct intel_crtc *crtc;if (HAS_MBUS_JOINING (dev_priv))
@@ -6602,13 +6602,13 @@ void skl_wm_get_hw_state(struct drm_i915_private *dev_priv) str_yes_no(dbuf_state->joined_mbus)); } - dbuf_state->enabled_slices = dev_priv->dbuf.enabled_slices; + dbuf_state->enabled_slices = dev_priv->display.dbuf.enabled_slices; }static bool skl_dbuf_is_misconfigured (struct drm_i915_private *i915) {const struct intel_dbuf_state *dbuf_state = -to_intel_dbuf_state (i915->dbuf.obj.state); +to_intel_dbuf_state (i915->display.dbuf.obj.state);struct skl_ddb_entry entries[I915_MAX_PIPES ] = {};struct intel_crtc *crtc;
@@ -7194,10 +7194,10 @@ void intel_wm_state_verify(struct intel_crtc *crtc, hw_enabled_slices =intel_enabled_dbuf_slices_mask (dev_priv);if (DISPLAY_VER (dev_priv) >=11 && - hw_enabled_slices != dev_priv->dbuf.enabled_slices) + hw_enabled_slices != dev_priv->display.dbuf.enabled_slices)drm_err (&dev_priv->drm,"mismatch in DBUF Slices (expected 0x%x, got 0x%x)\n" , - dev_priv->dbuf.enabled_slices, + dev_priv->display.dbuf.enabled_slices, hw_enabled_slices);for_each_intel_plane_on_crtc (&dev_priv->drm, crtc, plane) {
@@ -8314,7 +8314,7 @@ intel_atomic_get_dbuf_state(struct intel_atomic_state *state)struct drm_i915_private *dev_priv =to_i915 (state->base.dev);struct intel_global_state *dbuf_state; - dbuf_state =intel_atomic_get_global_obj_state (state, &dev_priv->dbuf.obj); + dbuf_state =intel_atomic_get_global_obj_state (state, &dev_priv->display.dbuf.obj);if (IS_ERR (dbuf_state))return ERR_CAST (dbuf_state);
@@ -8329,7 +8329,7 @@ int intel_dbuf_init(struct drm_i915_private *dev_priv)if (!dbuf_state)return -ENOMEM ; -intel_atomic_global_obj_init (dev_priv, &dev_priv->dbuf.obj, +intel_atomic_global_obj_init (dev_priv, &dev_priv->display.dbuf.obj, &dbuf_state->base, &intel_dbuf_funcs);return 0 ;
drivers/gpu/drm/i915/intel_pm.h +2 -2
@@ -77,9 +77,9 @@ intel_atomic_get_dbuf_state(struct intel_atomic_state *state);#define to_intel_dbuf_state (x) container_of((x), struct intel_dbuf_state, base)#define intel_atomic_get_old_dbuf_state (state) \ - to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj)) + to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->display.dbuf.obj))#define intel_atomic_get_new_dbuf_state (state) \ - to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->dbuf.obj)) + to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->display.dbuf.obj))int intel_dbuf_init (struct drm_i915_private *dev_priv);void intel_dbuf_pre_plane_update (struct intel_atomic_state *state);
Signature · 1 line
2.34.1
PATCH 33/39 drm/i915: move and group modeset_wq and flip_wq under display.wq
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
--- drivers/gpu/drm/i915/display/intel_display.c | 20 +++++++++---------- .../gpu/drm/i915/display/intel_display_core.h | 8 ++++++++ drivers/gpu/drm/i915/i915_drv.h | 5 ----- 3 files changed, 18 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +10 -10
@@ -7812,12 +7812,12 @@ static int intel_atomic_commit(struct drm_device *dev,i915_sw_fence_commit (&state->commit_ready);if (nonblock && state->modeset) { -queue_work (dev_priv->modeset_wq, &state->base.commit_work); +queue_work (dev_priv->display.wq.modeset, &state->base.commit_work); }else if (nonblock) { -queue_work (dev_priv->flip_wq, &state->base.commit_work); +queue_work (dev_priv->display.wq.flip, &state->base.commit_work); }else {if (state->modeset) -flush_workqueue (dev_priv->modeset_wq); +flush_workqueue (dev_priv->display.wq.modeset);intel_atomic_commit_tail (state); }
@@ -8681,9 +8681,9 @@ int intel_modeset_init_noirq(struct drm_i915_private *i915)intel_dmc_ucode_init (i915); - i915->modeset_wq =alloc_ordered_workqueue ("i915_modeset" ,0 ); - i915->flip_wq =alloc_workqueue ("i915_flip" ,WQ_HIGHPRI | -WQ_UNBOUND ,WQ_UNBOUND_MAX_ACTIVE ); + i915->display.wq.modeset =alloc_ordered_workqueue ("i915_modeset" ,0 ); + i915->display.wq.flip =alloc_workqueue ("i915_flip" ,WQ_HIGHPRI | +WQ_UNBOUND ,WQ_UNBOUND_MAX_ACTIVE );intel_mode_config_init (i915);
@@ -8990,8 +8990,8 @@ void intel_modeset_driver_remove(struct drm_i915_private *i915)if (!HAS_DISPLAY (i915))return ; -flush_workqueue (i915->flip_wq); -flush_workqueue (i915->modeset_wq); +flush_workqueue (i915->display.wq.flip); +flush_workqueue (i915->display.wq.modeset);flush_work (&i915->atomic_helper.free_work);drm_WARN_ON (&i915->drm, !llist_empty (&i915->atomic_helper.free_list));
@@ -9032,8 +9032,8 @@ void intel_modeset_driver_remove_noirq(struct drm_i915_private *i915)intel_gmbus_teardown (i915); -destroy_workqueue (i915->flip_wq); -destroy_workqueue (i915->modeset_wq); +destroy_workqueue (i915->display.wq.flip); +destroy_workqueue (i915->display.wq.modeset);intel_fbc_cleanup (i915); }
drivers/gpu/drm/i915/display/intel_display_core.h +8 -0
@@ -378,6 +378,14 @@ struct intel_display {u32 block_time_us; } sagv; +struct { +/* ordered wq for modesets */ +struct workqueue_struct *modeset; + +/* unbound hipri wq for page flips/plane updates */ +struct workqueue_struct *flip; + } wq; +/* Grouping using named structs. Keep sorted. */ struct intel_audio audio;struct intel_dmc dmc;
drivers/gpu/drm/i915/i915_drv.h +0 -5
@@ -288,11 +288,6 @@ struct drm_i915_private {*/ struct workqueue_struct *wq; -/* ordered wq for modesets */ -struct workqueue_struct *modeset_wq; -/* unbound hipri wq for page flips/plane updates */ -struct workqueue_struct *flip_wq; -/* PCH chipset type */ enum intel_pch pch_type;unsigned short pch_id;
Signature · 1 line
2.34.1
PATCH 34/39 drm/i915: split gem quirks from display quirks
In reply to Jani NikulaThe lone gem quirk is an outlier, not even handled by the common quirk code. Split it to a separate gem_quirks member.
--- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 4 ++-- drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c | 2 +- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_gem.c | 2 +- 8 files changed, 12 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_pages.c +1 -1
@@ -66,7 +66,7 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj, shrinkable =i915_gem_object_is_shrinkable (obj);if (i915_gem_object_is_tiled (obj) && - i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) { + i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES ) {GEM_BUG_ON (i915_gem_object_has_tiling_quirk (obj));i915_gem_object_set_tiling_quirk (obj);GEM_BUG_ON (!list_empty (&obj->mm.link));
drivers/gpu/drm/i915/gem/i915_gem_tiling.c +2 -2
@@ -278,7 +278,7 @@ i915_gem_object_set_tiling(struct drm_i915_gem_object *obj,*/ if (i915_gem_object_has_pages (obj) && obj->mm.madv ==I915_MADV_WILLNEED && - i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) { + i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES ) {if (tiling ==I915_TILING_NONE ) {GEM_BUG_ON (!i915_gem_object_has_tiling_quirk (obj));i915_gem_object_clear_tiling_quirk (obj);
@@ -458,7 +458,7 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data, }/* Hide bit 17 from the user -- see comment in i915_gem_set_tiling */ -if (dev_priv->quirks &QUIRK_PIN_SWIZZLED_PAGES ) +if (dev_priv->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES ) args->phys_swizzle_mode =I915_BIT_6_SWIZZLE_UNKNOWN ;else args->phys_swizzle_mode = args->swizzle_mode;
drivers/gpu/drm/i915/gem/selftests/i915_gem_client_blt.c +1 -1
@@ -711,7 +711,7 @@ static bool bad_swizzling(struct drm_i915_private *i915) {struct i915_ggtt *ggtt =to_gt (i915)->ggtt; -if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) +if (i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES )return true; if (has_bit17_swizzle(ggtt->bit_6_swizzle_x) ||
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +2 -2
@@ -367,7 +367,7 @@ static int igt_partial_tiling(void *arg)unsigned int pitch;struct tile tile; -if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) +if (i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES )/* * The swizzling pattern is actually unknown as it * varies based on physical address of each page.
@@ -464,7 +464,7 @@ static int igt_smoke_tiling(void *arg)* Remember to look at the st_seed if we see a flip-flop in BAT! */ -if (i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) +if (i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES )return 0 ; obj = huge_gem_object(i915,
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1 -1
@@ -727,7 +727,7 @@ static void detect_bit_6_swizzle(struct i915_ggtt *ggtt)* bit17 dependent, and so we need to also prevent the pages * from being moved. */ - i915->quirks |=QUIRK_PIN_SWIZZLED_PAGES ; + i915->gem_quirks |=GEM_QUIRK_PIN_SWIZZLED_PAGES ; swizzle_x =I915_BIT_6_SWIZZLE_NONE ; swizzle_y =I915_BIT_6_SWIZZLE_NONE ; }
drivers/gpu/drm/i915/i915_debugfs.c +1 -1
@@ -411,7 +411,7 @@ static int i915_swizzle_info(struct seq_file *m, void *data)seq_printf (m,"bit6 swizzle for Y-tiling = %s\n" ,swizzle_string (to_gt (dev_priv)->ggtt->bit_6_swizzle_y)); -if (dev_priv->quirks &QUIRK_PIN_SWIZZLED_PAGES ) +if (dev_priv->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES )seq_puts (m,"L-shaped memory detected\n" );/* On BDW+, swizzling is not used. See detect_bit_6_swizzle() */
drivers/gpu/drm/i915/i915_drv.h +3 -1
@@ -87,10 +87,11 @@ struct vlv_s0ix_state;#define I915_COLOR_UNEVICTABLE (-1)/* a non-vma sharing the address space */ +#define GEM_QUIRK_PIN_SWIZZLED_PAGES BIT(0) +#define QUIRK_LVDS_SSC_DISABLE (1<<1)#define QUIRK_INVERT_BRIGHTNESS (1<<2)#define QUIRK_BACKLIGHT_PRESENT (1<<3) -#define QUIRK_PIN_SWIZZLED_PAGES (1<<5)#define QUIRK_INCREASE_T12_DELAY (1<<6)#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)#define QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK (1<<8)
@@ -292,6 +293,7 @@ struct drm_i915_private {enum intel_pch pch_type;unsigned short pch_id; +unsigned long gem_quirks;unsigned long quirks;struct drm_atomic_state *modeset_restore_state;
drivers/gpu/drm/i915/i915_gem.c +1 -1
@@ -1035,7 +1035,7 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,if (i915_gem_object_has_pages (obj) &&i915_gem_object_is_tiled (obj) && - i915->quirks &QUIRK_PIN_SWIZZLED_PAGES ) { + i915->gem_quirks &GEM_QUIRK_PIN_SWIZZLED_PAGES ) {if (obj->mm.madv ==I915_MADV_WILLNEED ) {GEM_BUG_ON (!i915_gem_object_has_tiling_quirk (obj));i915_gem_object_clear_tiling_quirk (obj);
Signature · 1 line
2.34.1
PATCH 35/39 drm/i915/quirks: abstract checking for display quirks
In reply to Jani NikulaAdd intel_has_quirk() for checking if a display quirk is present. Avoid accessing i915->quirks all over the place.
--- drivers/gpu/drm/i915/display/intel_backlight.c | 7 ++++--- drivers/gpu/drm/i915/display/intel_ddi.c | 3 ++- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- drivers/gpu/drm/i915/display/intel_panel.c | 5 +++-- drivers/gpu/drm/i915/display/intel_pps.c | 3 ++- drivers/gpu/drm/i915/display/intel_quirks.c | 5 +++++ drivers/gpu/drm/i915/display/intel_quirks.h | 5 ++++- 7 files changed, 22 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_backlight.c +4 -3
@@ -16,6 +16,7 @@#include "intel_dsi_dcs_backlight.h" #include "intel_panel.h" #include "intel_pci_config.h" +#include "intel_quirks.h" /** * scale - scale values from one range to another
@@ -86,7 +87,7 @@ u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 val)return val;if (dev_priv->params.invert_brightness >0 || - dev_priv->quirks &QUIRK_INVERT_BRIGHTNESS ) { +intel_has_quirk (dev_priv,QUIRK_INVERT_BRIGHTNESS )) {return panel->backlight.pwm_level_max - val + panel->backlight.pwm_level_min; }
@@ -126,7 +127,7 @@ u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val) panel->backlight.max == 0 || panel->backlight.pwm_level_max == 0);if (dev_priv->params.invert_brightness >0 || - (dev_priv->params.invert_brightness ==0 && dev_priv->quirks &QUIRK_INVERT_BRIGHTNESS )) + (dev_priv->params.invert_brightness ==0 &&intel_has_quirk (dev_priv,QUIRK_INVERT_BRIGHTNESS ))) val = panel->backlight.pwm_level_max - (val - panel->backlight.pwm_level_min); return scale(val, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max,
@@ -1605,7 +1606,7 @@ int intel_backlight_setup(struct intel_connector *connector, enum pipe pipe)int ret;if (!connector->panel.vbt.backlight.present) { -if (dev_priv->quirks &QUIRK_BACKLIGHT_PRESENT ) { +if (intel_has_quirk (dev_priv,QUIRK_BACKLIGHT_PRESENT )) {drm_dbg_kms (&dev_priv->drm,"no backlight present per VBT, but present per quirk\n" ); }else {
drivers/gpu/drm/i915/display/intel_ddi.c +2 -1
@@ -57,6 +57,7 @@#include "intel_lspcon.h" #include "intel_pps.h" #include "intel_psr.h" +#include "intel_quirks.h" #include "intel_snps_phy.h" #include "intel_sprite.h" #include "intel_tc.h"
@@ -631,7 +632,7 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_stateintel_de_write (dev_priv,TRANS_DDI_FUNC_CTL (cpu_transcoder), ctl); -if (dev_priv->quirks &QUIRK_INCREASE_DDI_DISABLED_TIME && +if (intel_has_quirk (dev_priv,QUIRK_INCREASE_DDI_DISABLED_TIME ) &&intel_crtc_has_type (crtc_state,INTEL_OUTPUT_HDMI )) {drm_dbg_kms (&dev_priv->drm,"Quirk Increase DDI disabled time\n" );
drivers/gpu/drm/i915/display/intel_dp.c +2 -1
@@ -72,6 +72,7 @@#include "intel_pch_display.h" #include "intel_pps.h" #include "intel_psr.h" +#include "intel_quirks.h" #include "intel_tc.h" #include "intel_vdsc.h" #include "intel_vrr.h"
@@ -5293,7 +5294,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,intel_panel_init (intel_connector); -if (!(dev_priv->quirks &QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK )) +if (!intel_has_quirk (dev_priv,QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK )) intel_connector->panel.backlight.power = intel_pps_backlight_power;intel_backlight_setup (intel_connector, pipe);
drivers/gpu/drm/i915/display/intel_panel.c +3 -2
@@ -37,13 +37,14 @@#include "intel_display_types.h" #include "intel_drrs.h" #include "intel_panel.h" +#include "intel_quirks.h" bool intel_panel_use_ssc (struct drm_i915_private *i915) {if (i915->params.panel_use_ssc >=0 )return i915->params.panel_use_ssc !=0 ; -return i915->display.vbt.lvds_use_ssc - && !(i915->quirks &QUIRK_LVDS_SSC_DISABLE ); +return i915->display.vbt.lvds_use_ssc && + !intel_has_quirk (i915,QUIRK_LVDS_SSC_DISABLE ); } const struct drm_display_mode *
drivers/gpu/drm/i915/display/intel_pps.c +2 -1
@@ -12,6 +12,7 @@#include "intel_dpll.h" #include "intel_lvds.h" #include "intel_pps.h" +#include "intel_quirks.h" static void vlv_steal_power_sequencer (struct drm_i915_private *dev_priv,enum pipe pipe);
@@ -1202,7 +1203,7 @@ static void pps_init_delays_vbt(struct intel_dp *intel_dp,* just fails to power back on. Increasing the delay to 800ms * seems sufficient to avoid this problem. */ -if (dev_priv->quirks &QUIRK_INCREASE_T12_DELAY ) { +if (intel_has_quirk (dev_priv,QUIRK_INCREASE_T12_DELAY )) { vbt->t11_t12 =max_t (u16, vbt->t11_t12,1300 *10 ); drm_dbg_kms(&dev_priv->drm, "Increasing T12 panel delay as per the quirk to %d\n",
drivers/gpu/drm/i915/display/intel_quirks.c +5 -0
@@ -213,3 +213,8 @@ void intel_init_quirks(struct drm_i915_private *i915) intel_dmi_quirks[i].hook (i915); } } + +bool intel_has_quirk (struct drm_i915_private *i915,unsigned long quirk) +{ +return i915->quirks & quirk; +}
drivers/gpu/drm/i915/display/intel_quirks.h +4 -1
@@ -6,8 +6,11 @@#ifndef __INTEL_QUIRKS_H__#define __INTEL_QUIRKS_H__ +#include <linux/types.h> +struct drm_i915_private ; -void intel_init_quirks (struct drm_i915_private *dev_priv); +void intel_init_quirks (struct drm_i915_private *i915); +bool intel_has_quirk (struct drm_i915_private *i915,unsigned long quirk);#endif /* __INTEL_QUIRKS_H__ */
Signature · 1 line
2.34.1
PATCH 36/39 drm/i915/quirks: abstract quirks further by making quirk ids an enum
In reply to Jani NikulaTurn the quirk ids to enums instead of bits, and hide the masking inside intel_quirks.c. Define the enums in intel_quirks.h to declutter i915_drv.h while at it.
--- drivers/gpu/drm/i915/display/intel_quirks.c | 21 +++++++++++++-------- drivers/gpu/drm/i915/display/intel_quirks.h | 11 ++++++++++- drivers/gpu/drm/i915/i915_drv.h | 7 ------- 3 files changed, 23 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_quirks.c +13 -8
@@ -9,12 +9,17 @@#include "intel_display_types.h" #include "intel_quirks.h" +static void intel_set_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk) +{ + i915->quirks |=BIT (quirk); +} +/* * Some machines (Lenovo U160) do not work with SSC on LVDS for some reason */ static void quirk_ssc_force_disable (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_LVDS_SSC_DISABLE ; +intel_set_quirk (i915,QUIRK_LVDS_SSC_DISABLE );drm_info (&i915->drm,"applying lvds SSC disable quirk\n" ); }
@@ -24,14 +29,14 @@ static void quirk_ssc_force_disable(struct drm_i915_private *i915)*/ static void quirk_invert_brightness (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_INVERT_BRIGHTNESS ; +intel_set_quirk (i915,QUIRK_INVERT_BRIGHTNESS );drm_info (&i915->drm,"applying inverted panel brightness quirk\n" ); }/* Some VBT's incorrectly indicate no backlight is present */ static void quirk_backlight_present (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_BACKLIGHT_PRESENT ; +intel_set_quirk (i915,QUIRK_BACKLIGHT_PRESENT );drm_info (&i915->drm,"applying backlight present quirk\n" ); }
@@ -40,7 +45,7 @@ static void quirk_backlight_present(struct drm_i915_private *i915)*/ static void quirk_increase_t12_delay (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_INCREASE_T12_DELAY ; +intel_set_quirk (i915,QUIRK_INCREASE_T12_DELAY );drm_info (&i915->drm,"Applying T12 delay quirk\n" ); }
@@ -50,13 +55,13 @@ static void quirk_increase_t12_delay(struct drm_i915_private *i915)*/ static void quirk_increase_ddi_disabled_time (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_INCREASE_DDI_DISABLED_TIME ; +intel_set_quirk (i915,QUIRK_INCREASE_DDI_DISABLED_TIME );drm_info (&i915->drm,"Applying Increase DDI Disabled quirk\n" ); }static void quirk_no_pps_backlight_power_hook (struct drm_i915_private *i915) { - i915->quirks |=QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK ; +intel_set_quirk (i915,QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK );drm_info (&i915->drm,"Applying no pps backlight power quirk\n" ); }
@@ -214,7 +219,7 @@ void intel_init_quirks(struct drm_i915_private *i915) } } -bool intel_has_quirk (struct drm_i915_private *i915,unsigned long quirk) +bool intel_has_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk) { -return i915->quirks & quirk; +return i915->quirks &BIT (quirk); }
drivers/gpu/drm/i915/display/intel_quirks.h +10 -1
@@ -10,7 +10,16 @@struct drm_i915_private ; +enum intel_quirk_id { +QUIRK_BACKLIGHT_PRESENT , +QUIRK_INCREASE_DDI_DISABLED_TIME , +QUIRK_INCREASE_T12_DELAY , +QUIRK_INVERT_BRIGHTNESS , +QUIRK_LVDS_SSC_DISABLE , +QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK , +}; +void intel_init_quirks (struct drm_i915_private *i915); -bool intel_has_quirk (struct drm_i915_private *i915,unsigned long quirk); +bool intel_has_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk);#endif /* __INTEL_QUIRKS_H__ */
drivers/gpu/drm/i915/i915_drv.h +0 -7
@@ -89,13 +89,6 @@ struct vlv_s0ix_state;#define GEM_QUIRK_PIN_SWIZZLED_PAGES BIT(0) -#define QUIRK_LVDS_SSC_DISABLE (1<<1) -#define QUIRK_INVERT_BRIGHTNESS (1<<2) -#define QUIRK_BACKLIGHT_PRESENT (1<<3) -#define QUIRK_INCREASE_T12_DELAY (1<<6) -#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7) -#define QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK (1<<8) -struct i915_suspend_saved_registers {u32 saveDSPARB;u32 saveSWF0[16 ];
Signature · 1 line
2.34.1
PATCH 37/39 drm/i915: move quirks under display sub-struct
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
Prefer adding anonymous sub-structs even for single members that aren't our own structs.
--- drivers/gpu/drm/i915/display/intel_display_core.h | 4 ++++ drivers/gpu/drm/i915/display/intel_quirks.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 1 - 3 files changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_core.h +4 -0
@@ -367,6 +367,10 @@ struct intel_display {struct mutex mutex; } pps; +struct { +unsigned long mask; + } quirks; + struct { enum { I915_SAGV_UNKNOWN = 0,
drivers/gpu/drm/i915/display/intel_quirks.c +2 -2
@@ -11,7 +11,7 @@static void intel_set_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk) { - i915->quirks |=BIT (quirk); + i915->display.quirks.mask |=BIT (quirk); }/*
@@ -221,5 +221,5 @@ void intel_init_quirks(struct drm_i915_private *i915)bool intel_has_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk) { -return i915->quirks &BIT (quirk); +return i915->display.quirks.mask &BIT (quirk); }
drivers/gpu/drm/i915/i915_drv.h +0 -1
@@ -287,7 +287,6 @@ struct drm_i915_private {unsigned short pch_id;unsigned long gem_quirks; -unsigned long quirks;struct drm_atomic_state *modeset_restore_state;struct drm_modeset_acquire_ctx reset_ctx;
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH 37/39] drm/i915: move quirks under display sub-struct
Quoted 32 lines · Jani Nikula
Move display related members under
drm_i915_privatedisplay sub-struct.Prefer adding anonymous sub-structs even for single members that aren't our own structs.
Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_display_core.h | 4 ++++ drivers/gpu/drm/i915/display/intel_quirks.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 1 - 3 files changed, 6 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_display_core.h +4
-0@@ -367,6 +367,10 @@ struct intel_display {struct mutex mutex; } pps; +struct { +unsigned long mask; + } quirks; + struct { enum { I915_SAGV_UNKNOWN = 0,drivers/gpu/drm/i915/display/intel_quirks.c +0
-0
drivers/gpu/drm/i915/display/intel_quirks.c line 14
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_quirks.c +1
-1@@ -11,7 +11,7 @@static void intel_set_quirk (struct drm_i915_private *i915,enum intel_quirk_id quirk) { - i915->quirks |=BIT (quirk); + i915->display.quirks.mask |=BIT (quirk);
you started splitting gem from the display, so maybe this could be intel_display_set_quirk()? similar for other functions
anyway:
until this patch, except patch 5
Lucas De Marchi
PATCH 38/39 drm/i915: move atomic_helper under display sub-struct
In reply to Jani NikulaMove display related members under drm_i915_private display sub-struct.
--- drivers/gpu/drm/i915/display/intel_display.c | 14 +++++++------- drivers/gpu/drm/i915/display/intel_display_core.h | 6 ++++++ drivers/gpu/drm/i915/i915_drv.h | 5 ----- 3 files changed, 13 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +7 -7
@@ -7409,7 +7409,7 @@ static void intel_atomic_helper_free_state(struct drm_i915_private *dev_priv)struct intel_atomic_state *state, *next;struct llist_node *freed; - freed =llist_del_all (&dev_priv->atomic_helper.free_list); + freed =llist_del_all (&dev_priv->display.atomic_helper.free_list);llist_for_each_entry_safe (state, next, freed, freed)drm_atomic_state_put (&state->base); }
@@ -7417,7 +7417,7 @@ static void intel_atomic_helper_free_state(struct drm_i915_private *dev_priv)static void intel_atomic_helper_free_state_worker (struct work_struct *work) {struct drm_i915_private *dev_priv = -container_of (work,typeof (*dev_priv), atomic_helper.free_work); +container_of (work,typeof (*dev_priv), display.atomic_helper.free_work);intel_atomic_helper_free_state (dev_priv); }
@@ -7709,7 +7709,7 @@ intel_atomic_commit_ready(struct i915_sw_fence *fence,case FENCE_FREE : {struct intel_atomic_helper *helper = - &to_i915 (state->base.dev)->atomic_helper; + &to_i915 (state->base.dev)->display.atomic_helper;if (llist_add (&state->freed, &helper->free_list))schedule_work (&helper->free_work);
@@ -8699,8 +8699,8 @@ int intel_modeset_init_noirq(struct drm_i915_private *i915)if (ret) goto cleanup_vga_client_pw_domain_dmc; -init_llist_head (&i915->atomic_helper.free_list); -INIT_WORK (&i915->atomic_helper.free_work, +init_llist_head (&i915->display.atomic_helper.free_list); +INIT_WORK (&i915->display.atomic_helper.free_work, intel_atomic_helper_free_state_worker);intel_init_quirks (i915);
@@ -8993,8 +8993,8 @@ void intel_modeset_driver_remove(struct drm_i915_private *i915)flush_workqueue (i915->display.wq.flip);flush_workqueue (i915->display.wq.modeset); -flush_work (&i915->atomic_helper.free_work); -drm_WARN_ON (&i915->drm, !llist_empty (&i915->atomic_helper.free_list)); +flush_work (&i915->display.atomic_helper.free_work); +drm_WARN_ON (&i915->drm, !llist_empty (&i915->display.atomic_helper.free_list)); }/* part #2: call after irq uninstall */
drivers/gpu/drm/i915/display/intel_display_core.h +6 -0
@@ -7,6 +7,7 @@#define __INTEL_DISPLAY_CORE_H__#include <linux/list.h> +#include <linux/llist.h> #include <linux/mutex.h> #include <linux/types.h> #include <linux/wait.h>
@@ -270,6 +271,11 @@ struct intel_display { } funcs;/* Grouping using anonymous structs. Keep sorted. */ +struct intel_atomic_helper { +struct llist_head free_list; +struct work_struct free_work; + } atomic_helper; +struct {/* backlight registers and fields in struct intel_panel */ struct mutex lock;
drivers/gpu/drm/i915/i915_drv.h +0 -5
@@ -297,11 +297,6 @@ struct drm_i915_private {struct list_head global_obj_list; -struct intel_atomic_helper { -struct llist_head free_list; -struct work_struct free_work; - } atomic_helper; -bool mchbar_need_disable;struct intel_l3_parity l3_parity;
Signature · 1 line
2.34.1
PATCH 39/39 drm/i915: move and group properties under display.properties
In reply to Jani Nikula--- drivers/gpu/drm/i915/display/intel_atomic.c | 8 ++++---- drivers/gpu/drm/i915/display/intel_connector.c | 8 ++++---- drivers/gpu/drm/i915/display/intel_display_core.h | 6 ++++++ drivers/gpu/drm/i915/i915_drv.h | 3 --- 4 files changed, 14 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/display/intel_atomic.c +4 -4
@@ -62,9 +62,9 @@ int intel_digital_connector_atomic_get_property(struct drm_connector *connector,struct intel_digital_connector_state *intel_conn_state =to_intel_digital_connector_state (state); -if (property == dev_priv->force_audio_property) +if (property == dev_priv->display.properties.force_audio) *val = intel_conn_state->force_audio; -else if (property == dev_priv->broadcast_rgb_property) +else if (property == dev_priv->display.properties.broadcast_rgb) *val = intel_conn_state->broadcast_rgb;else { drm_dbg_atomic(&dev_priv->drm,
@@ -95,12 +95,12 @@ int intel_digital_connector_atomic_set_property(struct drm_connector *connector,struct intel_digital_connector_state *intel_conn_state =to_intel_digital_connector_state (state); -if (property == dev_priv->force_audio_property) { +if (property == dev_priv->display.properties.force_audio) { intel_conn_state->force_audio = val;return 0 ; } -if (property == dev_priv->broadcast_rgb_property) { +if (property == dev_priv->display.properties.broadcast_rgb) { intel_conn_state->broadcast_rgb = val;return 0 ; }
drivers/gpu/drm/i915/display/intel_connector.c +4 -4
@@ -229,7 +229,7 @@ intel_attach_force_audio_property(struct drm_connector *connector)struct drm_i915_private *dev_priv =to_i915 (dev);struct drm_property *prop; - prop = dev_priv->force_audio_property; + prop = dev_priv->display.properties.force_audio;if (prop ==NULL ) { prop = drm_property_create_enum(dev, 0, "audio",
@@ -238,7 +238,7 @@ intel_attach_force_audio_property(struct drm_connector *connector)if (prop ==NULL )return ; - dev_priv->force_audio_property = prop; + dev_priv->display.properties.force_audio = prop; }drm_object_attach_property (&connector->base, prop,0 ); }
@@ -256,7 +256,7 @@ intel_attach_broadcast_rgb_property(struct drm_connector *connector)struct drm_i915_private *dev_priv =to_i915 (dev);struct drm_property *prop; - prop = dev_priv->broadcast_rgb_property; + prop = dev_priv->display.properties.broadcast_rgb;if (prop ==NULL ) { prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM, "Broadcast RGB",
@@ -265,7 +265,7 @@ intel_attach_broadcast_rgb_property(struct drm_connector *connector)if (prop ==NULL )return ; - dev_priv->broadcast_rgb_property = prop; + dev_priv->display.properties.broadcast_rgb = prop; }drm_object_attach_property (&connector->base, prop,0 );
drivers/gpu/drm/i915/display/intel_display_core.h +6 -0
@@ -27,6 +27,7 @@#include "intel_pm_types.h" struct drm_i915_private ; +struct drm_property ;struct i915_audio_component ;struct i915_hdcp_comp_master ;struct intel_atomic_state ;
@@ -373,6 +374,11 @@ struct intel_display {struct mutex mutex; } pps; +struct { +struct drm_property *broadcast_rgb; +struct drm_property *force_audio; + } properties; +struct {unsigned long mask; } quirks;
drivers/gpu/drm/i915/i915_drv.h +0 -3
@@ -317,9 +317,6 @@ struct drm_i915_private {struct i915_gpu_error gpu_error; -struct drm_property *broadcast_rgb_property; -struct drm_property *force_audio_property; -/* * Shadows for CHV DPLL_MD regs to keep the state * checker somewhat working in the presence hardware
Signature · 1 line
2.34.1
Quoted 8 lines · Jani Nikula
Add display sub-struct to
drm_i915_private, and start moving display related members there.This doesn't help with build dependencies yet, but adds a lot of clarity in organizing the display data, and who accesses display data and where.
This is a beginning, there are still stragglers, but need to start sending the patches instead of accumulating tons more.
Also pushed the lot to
https://cgit.freedesktop.org/~jani/drm/log/?h=display-substruct
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add display sub-struct to drm_i915_private
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private
URL : https://patchwork.freedesktop.org/series/107170/
State : warning
== Summary ==
Error: dim checkpatch failed81a599e0acc6 drm/i915: add display sub-struct to drm_i915_private
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:125: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #125:
new file mode 100644
-:147: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #147: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:18:
+ * fills out the pipe-config with the hw state. */
-:148: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc *' should also have an identifier name #148: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:19:
+ bool (*get_pipe_config)(struct intel_crtc *,
-:148: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc_state *' should also have an identifier name #148: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:19:
+ bool (*get_pipe_config)(struct intel_crtc *,
-:150: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_crtc *' should also have an identifier name #150: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:21:
+ void (*get_initial_plane_config)(struct intel_crtc *,
-:150: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct intel_initial_plane_config *' should also have an identifier name #150: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:21:
+ void (*get_initial_plane_config)(struct intel_crtc *,
total: 0 errors, 6 warnings, 0 checks, 198 lines checked 98eec48f505c drm/i915: move cdclk_funcs to display.funcs 699528783267 drm/i915: move dpll_funcs to display.funcs 22eeabd10546 drm/i915: move hotplug_funcs to display.funcs af7f4c94cba1 drm/i915: move clock_gating_funcs to display.funcs 5902bf135e5f drm/i915: move wm_disp funcs to display.funcs 763b41870eb1 drm/i915: move fdi_funcs to display.funcs d4e25a89ea42 drm/i915: move color_funcs to display.funcs 97a1a55d792b drm/i915: move and group gmbus members under display.gmbus -:347: WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #347: FILE: drivers/gpu/drm/i915/i915_reg.h:1485:
+#define GMBUS0 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5100) /* clock/port select */
-:356: WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns #356: FILE: drivers/gpu/drm/i915/i915_reg.h:1494:
+#define GMBUS1 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5104) /* command/status */
-:375: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns #375: FILE: drivers/gpu/drm/i915/i915_reg.h:1517:
+#define GMBUS3 _MMIO(dev_priv->display.gmbus.mmio_base + 0x510c) /* data buffer bytes 3-0 */
-:376: WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns #376: FILE: drivers/gpu/drm/i915/i915_reg.h:1518:
+#define GMBUS4 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5110) /* interrupt mask (Pineview+) */
total: 0 errors, 4 warnings, 0 checks, 320 lines checked c81231bd7491 drm/i915: move and group pps members under display.pps 9691040cd55f drm/i915: move dmc to display.dmc
-:210: WARNING:LONG_LINE: line length of 115 exceeds 100 columns #210: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:455:
+ !intel_de_read(i915, DMC_PROGRAM(i915->display.dmc.dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)),
total: 0 errors, 1 warnings, 0 checks, 339 lines checkedcb5448c3b8e0 drm/i915: move and split audio under display.audio and display.funcs
-:318: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "dev_priv->display.audio.lpe.platdev" #318: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1406:
+ if (dev_priv->display.audio.lpe.platdev != NULL)
-:394: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "display.audio.lpe.platdev" #394: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:78:
+#define HAS_LPE_AUDIO(dev_priv) ((dev_priv)->display.audio.lpe.platdev != NULL)
-:403: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #403: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:100:
+ rsc[0].start = rsc[0].end = dev_priv->display.audio.lpe.irq;
total: 0 errors, 0 warnings, 3 checks, 501 lines checked 45cea2c0cb3f drm/i915: move dpll under display.dpll
-:213: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #213: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:89:
+ struct mutex lock;
-:562: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #562: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:4210:
+ BUG_ON(dev_priv->display.dpll.num_shared_dpll > I915_NUM_PLLS);
total: 0 errors, 1 warnings, 1 checks, 628 lines checked 911a4d8416a9 drm/i915: move and group fbdev under display.fbdev 44d269d91c7f drm/i915: move wm to display.wm a73009c01d23 drm/i915: move and group hdcp under display.hdcp 2a6c083eab3a drm/i915: move hotplug to display.hotplug -:434: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #434: FILE: drivers/gpu/drm/i915/display/intel_hotplug.c:570:
+ queue_work(dev_priv->display.hotplug.dp_wq, &dev_priv->display.hotplug.dig_port_work);
-:590: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!dev_priv->display.hotplug.dp_wq" #590: FILE: drivers/gpu/drm/i915/i915_driver.c:256:
+ if (dev_priv->display.hotplug.dp_wq == NULL)
total: 0 errors, 1 warnings, 1 checks, 738 lines checked b6f4b60b07d8 drm/i915: move overlay to display.overlay 05330effbd89 drm/i915: move and group sagv under display.sagv -:210: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #210: FILE: drivers/gpu/drm/i915/intel_pm.c:5599:
+ latency = dev_priv->display.sagv.block_time_us + dev_priv->display.wm.skl_latency[0];
total: 0 errors, 1 warnings, 0 checks, 174 lines checked 1527cbe5e360 drm/i915: move and group max_bw and bw_obj under display.bw 5f212c8cffc9 drm/i915: move opregion to display.opregion e193c1b4ed89 drm/i915: move and group cdclk under display.cdclk -:41: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #41: FILE: drivers/gpu/drm/i915/display/intel_audio.c:974:
+ get_aud_ts_cdclk_m_n(i915->display.cdclk.hw.ref, i915->display.cdclk.hw.cdclk, &aud_ts);
-:702: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #702: FILE: drivers/gpu/drm/i915/display/intel_cdclk.h:80:
+ to_intel_cdclk_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->display.cdclk.obj))
-:705: WARNING:LONG_LINE: line length of 120 exceeds 100 columns #705: FILE: drivers/gpu/drm/i915/display/intel_cdclk.h:82:
+ to_intel_cdclk_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->display.cdclk.obj))
-:733: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #733: FILE: drivers/gpu/drm/i915/display/intel_display.c:8401:
+ cdclk_state->logical = cdclk_state->actual = i915->display.cdclk.hw;
total: 0 errors, 3 warnings, 1 checks, 815 lines checked 1cd4ceb70c16 drm/i915: move backlight to display.backlight 1da9f25eea3a drm/i915: move mipi_mmio_base to display.dsi 8a9779b4fd6f drm/i915: move vbt to display.vbt
-:120: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #120: FILE: drivers/gpu/drm/i915/display/intel_bios.c:1157:
+ i915->display.vbt.override_afc_startup_val = general->afc_startup_config == 0x1 ? 0x0 : 0x7;
-:466: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #466: FILE: drivers/gpu/drm/i915/display/intel_bios.c:2823:
+ i915->display.vbt.lvds_ssc_freq = intel_bios_ssc_frequency(i915,
!HAS_PCH_SPLIT(i915));
-:926: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #926: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:2773:
+ pll_state->div0 = TGL_DPLL0_DIV0_AFC_STARTUP(i915->display.vbt.override_afc_startup_val);
total: 0 errors, 2 warnings, 1 checks, 1030 lines checked 715d5e56ca5b drm/i915: move fbc to display.fbc5fad180f909e drm/i915/vrr: drop window2_delay member from i915 -:36: WARNING:TYPO_SPELLING: 'Substract' may be misspelled - perhaps 'Subtract'? #36: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:147:
+ * FIXME: Substract Window2 delay from below value.
^^^^^^^^^
total: 0 errors, 1 warnings, 0 checks, 44 lines checkedcf5121f27e5e drm/i915: move and group power related members under display.power -:385: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#385: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:1920:
+ i915->display.power.domains.disable_wakeref = intel_display_power_get(i915,
POWER_DOMAIN_INIT);
-:399: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #399: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:1946:
+ fetch_and_zero(&i915->display.power.domains.disable_wakeref));
-:444: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #444: FILE: drivers/gpu/drm/i915/display/intel_display_power.c:2067:
+ fetch_and_zero(&i915->display.power.domains.disable_wakeref));
total: 0 errors, 2 warnings, 1 checks, 683 lines checked7dbf3b63780b drm/i915: move and group fdi members under display.fdi
-:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #20: FILE: drivers/gpu/drm/i915/display/intel_crt.c:1114:
+ dev_priv->display.fdi.rx_config = intel_de_read(dev_priv,
FDI_RX_CTL(PIPE_A)) & fdi_config;
total: 0 errors, 0 warnings, 1 checks, 67 lines checked 7761e27c8757 drm/i915: move fb_tracking under display sub-struct -:25: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #25: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:123:
+ spinlock_t lock;
-:31: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #31: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:129:
+ unsigned busy_bits;
-:32: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #32: FILE: drivers/gpu/drm/i915/display/intel_display_core.h:130:
+ unsigned flip_bits;
total: 0 errors, 2 warnings, 1 checks, 200 lines checked ada2d6104385 drm/i915: move INTEL_FRONTBUFFER_* macros to intel_frontbuffer.h -:53: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #53: FILE: drivers/gpu/drm/i915/display/intel_frontbuffer.h:61:
+#define INTEL_FRONTBUFFER(pipe, plane_id) \
+ BIT((plane_id) + INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe));
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/display/intel_frontbuffer.h:65:
+#define INTEL_FRONTBUFFER_ALL_MASK(pipe) \
+ GENMASK(INTEL_FRONTBUFFER_BITS_PER_PIPE * ((pipe) + 1) - 1, \
+ INTEL_FRONTBUFFER_BITS_PER_PIPE * (pipe))
total: 0 errors, 1 warnings, 1 checks, 64 lines checked 6e09cf9e9a8d drm/i915: move dbuf under display sub-struct -:180: WARNING:LONG_LINE: line length of 118 exceeds 100 columns #180: FILE: drivers/gpu/drm/i915/intel_pm.h:80:
+ to_intel_dbuf_state(intel_atomic_get_old_global_obj_state(state, &to_i915(state->base.dev)->display.dbuf.obj))
-:183: WARNING:LONG_LINE: line length of 118 exceeds 100 columns #183: FILE: drivers/gpu/drm/i915/intel_pm.h:82:
+ to_intel_dbuf_state(intel_atomic_get_new_global_obj_state(state, &to_i915(state->base.dev)->display.dbuf.obj))
total: 0 errors, 2 warnings, 0 checks, 136 lines checked b4bb59b99188 drm/i915: move and group modeset_wq and flip_wq under display.wq 309e0c8e99e6 drm/i915: split gem quirks from display quirks 7d72fe97d832 drm/i915/quirks: abstract checking for display quirks -:37: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #37: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:130:
+ (dev_priv->params.invert_brightness == 0 && intel_has_quirk(dev_priv, QUIRK_INVERT_BRIGHTNESS)))
total: 0 errors, 1 warnings, 0 checks, 112 lines checked 1261c09ec71b drm/i915/quirks: abstract quirks further by making quirk ids an enum 856c7041cdfc drm/i915: move quirks under display sub-struct b87932c1ae0e drm/i915: move atomic_helper under display sub-struct dfb37a2ed796 drm/i915: move and group properties under display.properties -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 84 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add display sub-struct to drm_i915_private
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private
URL : https://patchwork.freedesktop.org/series/107170/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add display sub-struct to drm_i915_private
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private
URL : https://patchwork.freedesktop.org/series/107170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11983 -> Patchwork_107170v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/index.html
Participating hosts (29 -> 38)
------------------------------
Additional (13): bat-dg1-6 bat-dg1-5 bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 fi-cfl-8109u bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-jsl-1
Missing (4): fi-ctg-p8600 fi-rkl-11600 fi-hsw-4200u fi-snb-2600
Known issues
------------
Here are the changes found in Patchwork_107170v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@nullptr:
- bat-dg1-5: NOTRUN -> [SKIP][1] ([i915#2582]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@fbdev@read:
- bat-adlp-4: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-cfl-8109u: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-cfl-8109u/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-apl-guc/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-cfl-8109u/igt@[email protected]
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4083])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][8] ([i915#4083])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4079]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@gem_tiled_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#4077]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][11] ([i915#4077]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4079]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][13] ([i915#3282])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#1155])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][15] ([i915#1155])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#1155])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][17] -> [INCOMPLETE][18] ([i915#5847])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-bsw-nick/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-bsw-nick/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-skl-6700k2: [PASS][19] -> [DMESG-FAIL][20] ([i915#5334])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-skl-6700k2/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][21] ([i915#4957])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@i915_selftest@[email protected]
- bat-dg1-6: NOTRUN -> [DMESG-FAIL][22] ([i915#4494] / [i915#4957])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][23] -> [DMESG-FAIL][24] ([i915#4528])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-blb-e6850/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][25] ([i915#6011])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [INCOMPLETE][26] ([i915#6011])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#4212]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][28] ([i915#4215])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][29] ([i915#4215])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][30] ([i915#4212]) +7 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][31] ([i915#1845] / [i915#4303])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-apl-guc: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-apl-guc/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][33] ([fdo#111827]) +8 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][34] ([fdo#111827]) +7 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- bat-dg1-6: NOTRUN -> [SKIP][35] ([fdo#111827]) +7 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-cfl-8109u: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +8 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-cfl-8109u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-dg1-6: NOTRUN -> [SKIP][37] ([i915#4103] / [i915#4213])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [PASS][38] -> [FAIL][39] ([i915#6298])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-adlp-4: NOTRUN -> [SKIP][40] ([i915#3637]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][41] ([i915#4093]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][42] ([fdo#109285])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][43] ([fdo#109285])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- bat-adlp-4: NOTRUN -> [SKIP][44] ([i915#4342])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-dg1-5: NOTRUN -> [SKIP][45] ([i915#4078]) +13 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-adlp-4: NOTRUN -> [SKIP][46] ([i915#3546]) +10 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#1072] / [i915#4078]) +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][48] ([i915#1072] / [i915#4078]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
- bat-adlp-4: NOTRUN -> [SKIP][49] ([i915#1072]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-5: NOTRUN -> [SKIP][50] ([i915#3555])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][51] ([i915#3555])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][52] ([i915#3555] / [i915#4579])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- bat-adlp-4: NOTRUN -> [SKIP][53] ([fdo#109295] / [i915#3546] / [i915#3708])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][54] ([i915#1845] / [i915#3708])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][55] ([i915#3708]) +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][56] ([i915#3708] / [i915#4077]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][57] ([i915#3708] / [i915#4077]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-cfl-8109u: NOTRUN -> [SKIP][58] ([fdo#109271]) +10 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-cfl-8109u/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][59] ([i915#3708] / [i915#4873])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][60] ([fdo#109295] / [i915#3301] / [i915#3708])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][61] ([i915#3708] / [i915#4873])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-dg1-6: NOTRUN -> [SKIP][62] ([i915#3708]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][63] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-adlp-4/igt@[email protected]
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][64] ([i915#4312] / [i915#5257])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [FAIL][65] ([i915#4312] / [i915#5257])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/bat-dg1-6/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][66] ([fdo#109271] / [i915#4312])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-bsw-nick/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-apl-guc: [INCOMPLETE][67] ([i915#6533]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/fi-apl-guc/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/fi-apl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5847]: https://gitlab.freedesktop.org/drm/intel/issues/5847
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950
[i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6531]: https://gitlab.freedesktop.org/drm/intel/issues/6531
[i915#6533]: https://gitlab.freedesktop.org/drm/intel/issues/6533
Build changes
-------------
* Linux: CI_DRM_11983 -> Patchwork_107170v1
CI-20190529: 20190529
CI_DRM_11983: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6621: 62685978a0c00bb4b874935129b9761ae10d5ca1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107170v1: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
13c1b8e7e6b5 drm/i915: move and group properties under display.properties b9e74f9c3726 drm/i915: move atomic_helper under display sub-struct c21adb4e612d drm/i915: move quirks under display sub-struct 70427ae20e4a drm/i915/quirks: abstract quirks further by making quirk ids an enum 749d9ac037ac drm/i915/quirks: abstract checking for display quirks b28e422dbcc1 drm/i915: split gem quirks from display quirks dacf3a3beb21 drm/i915: move and group modeset_wq and flip_wq under display.wq 6a1fda99b6ec drm/i915: move dbuf under display sub-struct 15c5601052bb drm/i915: move INTEL_FRONTBUFFER_* macros to intel_frontbuffer.h f8c6d650f22e drm/i915: move fb_tracking under display sub-struct d08ab9f2db6c drm/i915: move and group fdi members under display.fdi ac9771b0eda8 drm/i915: move and group power related members under display.power 52e709f45d4b drm/i915/vrr: drop window2_delay member from i915 d845d1e8c9a8 drm/i915: move fbc to display.fbc61995fd9949f drm/i915: move vbt to display.vbt0246de41833c drm/i915: move mipi_mmio_base to display.dsi 4b6d84fd1029 drm/i915: move backlight to display.backlight b4d66dac6ec0 drm/i915: move and group cdclk under display.cdclk efe269abf8ef drm/i915: move opregion to display.opregion 34282f2273d4 drm/i915: move and group max_bw and bw_obj under display.bw 42f39a0a4e80 drm/i915: move and group sagv under display.sagv 213afa4afcfc drm/i915: move overlay to display.overlay12901d325160 drm/i915: move hotplug to display.hotplug1f3d6e226eb5 drm/i915: move and group hdcp under display.hdcp e9f4ec8f74c7 drm/i915: move wm to display.wm3f35c02a408b drm/i915: move and group fbdev under display.fbdev 95135ba8ee1f drm/i915: move dpll under display.dplle5223855144b drm/i915: move and split audio under display.audio and display.funcs 16d3a0f999ac drm/i915: move dmc to display.dmc086157a50dd0 drm/i915: move and group pps members under display.pps f22526ad0c49 drm/i915: move and group gmbus members under display.gmbus a083842cd0ec drm/i915: move color_funcs to display.funcs 9c47c12b7b77 drm/i915: move fdi_funcs to display.funcsad9f3ff1080c drm/i915: move wm_disp funcs to display.funcs df2233ea0e1b drm/i915: move clock_gating_funcs to display.funcs 36dcc4ad40bf drm/i915: move hotplug_funcs to display.funcs 58132a37a737 drm/i915: move dpll_funcs to display.funcs49cc074d7acb drm/i915: move cdclk_funcs to display.funcs e2f30b144cf7 drm/i915: add display sub-struct to drm_i915_private
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: add display sub-struct to drm_i915_private
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: add display sub-struct to drm_i915_private
URL : https://patchwork.freedesktop.org/series/107170/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11983_full -> Patchwork_107170v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107170v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_pm_rc6_residency@rc6-idle@vecs0:
- {shard-rkl}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@i915_pm_rc6_residency@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-5/igt@i915_pm_rc6_residency@[email protected]
Known issues
------------
Here are the changes found in Patchwork_107170v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27]) -> ([PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50], [PASS][51]) ([i915#4392])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk1/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk3/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk3/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk3/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk8/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk8/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk8/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk9/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk1/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk1/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk9/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk9/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk8/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk3/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk2/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][52] -> [DMESG-WARN][53] ([i915#180]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-apl7/igt@gem_ctx_isolation@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl2/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_persistence@engines-hang:
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#1099])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-snb5/igt@[email protected]
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][55] -> [SKIP][56] ([i915#4525]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb8/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-tglb7/igt@gem_exec_fair@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][59] -> [FAIL][60] ([i915#2851])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@gem_exec_fair@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][61] -> [FAIL][62] ([i915#2842])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@gem_exec_fair@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][63] -> [FAIL][64] ([i915#2842])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb3/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@smem-oom:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl1/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@gem_spin_batch@spin-each:
- shard-apl: [PASS][67] -> [FAIL][68] ([i915#2898])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-apl1/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl8/igt@[email protected]
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-snb: NOTRUN -> [SKIP][69] ([fdo#109271]) +63 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-snb5/igt@[email protected]
* igt@i915_pm_rpm@dpms-lpsp:
- shard-kbl: NOTRUN -> [SKIP][70] ([fdo#109271]) +102 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][71] -> [INCOMPLETE][72] ([i915#3921])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-snb2/igt@i915_selftest@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-snb2/igt@i915_selftest@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [PASS][73] -> [FAIL][74] ([i915#2521]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl10/igt@kms_async_flips@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl6/igt@kms_async_flips@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][75] ([i915#3743])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl10/igt@[email protected]
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#3886]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl4/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271]) +16 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl1/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3886]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3886]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271]) +82 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl1/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271] / [fdo#111827]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@kms_chamelium@hdmi-audio:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [fdo#111827]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl1/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-snb: NOTRUN -> [SKIP][84] ([fdo#109271] / [fdo#111827]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-snb5/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions:
- shard-iclb: [PASS][85] -> [FAIL][86] ([i915#5072])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb3/igt@kms_cursor_legacy@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb7/igt@kms_cursor_legacy@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [INCOMPLETE][87] ([i915#6528])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl1/igt@kms_cursor_legacy@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][88] -> [FAIL][89] ([i915#4767])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][90] -> [FAIL][91] ([i915#2122])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk9/igt@kms_flip@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][92] -> [FAIL][93] ([i915#79])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl10/igt@kms_flip@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-dp1:
- shard-kbl: [PASS][94] -> [FAIL][95] ([i915#79])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl4/igt@kms_flip@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [PASS][96] -> [DMESG-WARN][97] ([i915#180]) +6 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@kms_flip@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2672]) +5 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][99] -> [SKIP][100] ([i915#3555])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][101] ([i915#3555])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#2672] / [i915#3555])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271]) +26 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: NOTRUN -> [DMESG-WARN][104] ([i915#180])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@kms_hdr@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][106] ([fdo#108145] / [i915#265])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][107] -> [FAIL][108] ([fdo#108145] / [i915#265])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#658])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#658])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl4/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#658]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][112] -> [SKIP][113] ([fdo#109642] / [fdo#111068] / [i915#658])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb1/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][114] -> [SKIP][115] ([fdo#109441]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_writeback@writeback-check-output:
- shard-kbl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#2437])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [PASS][117] -> [FAIL][118] ([i915#5639])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl6/igt@[email protected]
* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#2994])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#2994]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl1/igt@[email protected]
* igt@sysfs_clients@split-10:
- shard-glk: NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@[email protected]
#### Possible fixes ####
* igt@device_reset@unbind-reset-rebind:
- {shard-rkl}: [FAIL][122] ([i915#4778]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@fbdev@pan:
- {shard-rkl}: [SKIP][124] ([i915#2582]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][126] ([i915#658]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb6/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb2/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][128] ([i915#6268]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-tglu-1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-tglu-1/igt@[email protected]
* igt@gem_ctx_persistence@engines-hang@vcs0:
- {shard-dg1}: [FAIL][130] ([i915#4883]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-dg1-17/igt@gem_ctx_persistence@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-dg1-16/igt@gem_ctx_persistence@[email protected]
* igt@gem_eio@hibernate:
- shard-snb: [INCOMPLETE][132] -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-snb5/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-snb5/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-tglu}: [FAIL][134] ([i915#2842]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-tglu-5/igt@gem_exec_fair@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-tglu-2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][136] ([i915#2842]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl4/igt@gem_exec_fair@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][138] ([i915#2842]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk6/igt@gem_exec_fair@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-write-read-noreloc:
- {shard-rkl}: [SKIP][140] ([i915#3281]) -> [PASS][141] +4 similar issues
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-5/igt@[email protected]
* igt@gem_fence_thrash@bo-write-verify-none:
- {shard-rkl}: [SKIP][142] ([fdo#109315]) -> [PASS][143] +25 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@gem_partial_pwrite_pread@reads-uncached:
- {shard-rkl}: [SKIP][144] ([i915#3282]) -> [PASS][145] +3 similar issues
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-5/igt@[email protected]
* igt@gem_ppgtt@blt-vs-render-ctxn:
- {shard-rkl}: [INCOMPLETE][146] ([i915#3692]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][148] ([i915#180]) -> [PASS][149] +3 similar issues
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl1/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl7/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-kbl: [DMESG-WARN][150] ([i915#5566] / [i915#716]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
* igt@gen9_exec_parse@basic-rejected:
- {shard-rkl}: [SKIP][152] ([i915#2527]) -> [PASS][153] +1 similar issue
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-dg1}: [SKIP][154] ([i915#1397]) -> [PASS][155]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-dg1-15/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-dg1-19/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-devices:
- {shard-rkl}: [SKIP][156] ([i915#5174]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][158] ([i915#4387]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-5/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- {shard-tglu}: [DMESG-FAIL][160] ([i915#3987]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-tglu-8/igt@i915_selftest@live@gt_pm.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-tglu-4/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@fence-restore-untiled:
- shard-skl: [INCOMPLETE][162] ([i915#4817] / [i915#4939]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl9/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl1/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-skl: [FAIL][164] ([i915#2521]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl10/igt@kms_async_flips@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl6/igt@kms_async_flips@[email protected]
* igt@kms_atomic@atomic_plane_damage:
- {shard-rkl}: [SKIP][166] ([i915#4098]) -> [PASS][167]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@kms_atomic@atomic_plane_damage.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [SKIP][168] ([i915#1845] / [i915#4098]) -> [PASS][169] +21 similar issues
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
- {shard-rkl}: [SKIP][170] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][171] +7 similar issues
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][172] ([i915#79]) -> [PASS][173] +1 similar issue
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl10/igt@kms_flip@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [FAIL][174] ([i915#2122]) -> [PASS][175]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl6/igt@kms_flip@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
- {shard-rkl}: [SKIP][176] ([i915#1849] / [i915#4098]) -> [PASS][177] +12 similar issues
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-rkl}: [SKIP][178] ([i915#1849] / [i915#3558]) -> [PASS][179] +4 similar issues
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@kms_plane@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- {shard-rkl}: [SKIP][180] ([i915#2575]) -> [PASS][181] +7 similar issues
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- {shard-rkl}: [SKIP][182] ([i915#1849] / [i915#3546] / [i915#4070] / [i915#4098]) -> [PASS][183] +1 similar issue
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- {shard-rkl}: [SKIP][184] ([i915#1849] / [i915#3546] / [i915#4098]) -> [PASS][185]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][186] ([i915#5235]) -> [PASS][187] +2 similar issues
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr@primary_render:
- {shard-rkl}: [SKIP][188] ([i915#1072]) -> [PASS][189] +1 similar issue
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@kms_psr@primary_render.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@kms_psr@primary_render.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][190] ([fdo#109441]) -> [PASS][191] +2 similar issues
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- {shard-rkl}: [SKIP][192] ([i915#5461]) -> [PASS][193]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-1/igt@[email protected]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- {shard-rkl}: [SKIP][194] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][195]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][196] ([i915#180]) -> [PASS][197] +4 similar issues
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-apl3/igt@[email protected]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl1/igt@[email protected]
* igt@perf@polling:
- shard-skl: [FAIL][198] ([i915#1542]) -> [PASS][199]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-skl7/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-skl4/igt@[email protected]
* igt@perf@polling-parameterized:
- {shard-rkl}: [FAIL][200] ([i915#5639]) -> [PASS][201]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-2/igt@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-2/igt@[email protected]
* igt@perf@short-reads:
- {shard-rkl}: [SKIP][202] ([i915#5608]) -> [PASS][203]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-rkl-5/igt@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-rkl-6/igt@[email protected]
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][204] ([i915#5213]) -> [PASS][205]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-glk7/igt@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-glk5/igt@[email protected]
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][206] ([i915#3063]) -> [FAIL][207] ([i915#5784])
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-tglb7/igt@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-tglb2/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][208] ([i915#2842]) -> [FAIL][209] ([i915#2852])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb5/igt@gem_exec_fair@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][210] ([i915#2842]) -> [SKIP][211] ([fdo#109271])
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@gem_exec_fair@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][212] ([i915#588]) -> [SKIP][213] ([i915#658])
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@[email protected]
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb1/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][214] ([i915#4767]) -> [INCOMPLETE][215] ([i915#180] / [i915#1982] / [i915#4939])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-apl1/igt@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-apl2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][216] ([i915#2920]) -> [SKIP][217] ([i915#658]) +1 similar issue
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb8/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][218] ([i915#5939]) -> [SKIP][219] ([fdo#109642] / [fdo#111068] / [i915#658])
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][220], [FAIL][221], [FAIL][222], [FAIL][223], [FAIL][224], [FAIL][225], [FAIL][226]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716] / [i915#92]) -> ([FAIL][227], [FAIL][228], [FAIL][229], [FAIL][230], [FAIL][231], [FAIL][232], [FAIL][233], [FAIL][234], [FAIL][235], [FAIL][236], [FAIL][237]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl1/igt@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl4/igt@[email protected]
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl1/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl4/igt@[email protected]
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl4/igt@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl1/igt@[email protected]
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11983/shard-kbl7/igt@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@[email protected]
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@[email protected]
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@[email protected]
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl4/igt@[email protected]
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/shard-kbl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2898]: https://gitlab.freedesktop.org/drm/intel/issues/2898
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4392]: https://gitlab.freedesktop.org/drm/intel/issues/4392
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4941]: https://gitlab.freedesktop.org/drm/intel/issues/4941
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6474]: https://gitlab.freedesktop.org/drm/intel/issues/6474
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6528]: https://gitlab.freedesktop.org/drm/intel/issues/6528
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_11983 -> Patchwork_107170v1
CI-20190529: 20190529
CI_DRM_11983: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6621: 62685978a0c00bb4b874935129b9761ae10d5ca1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107170v1: be61f160096902ab2f402179c81f6de59b016d82 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107170v1/index.html
Quoted 11 lines · Jani Nikula
Add display sub-struct to
drm_i915_private, and start moving display related members there.This doesn't help with build dependencies yet, but adds a lot of clarity in organizing the display data, and who accesses display data and where.
This is a beginning, there are still stragglers, but need to start sending the patches instead of accumulating tons more.
BR,
Jani.
I was not sure if I would have time to review all the patches, so I started adding my r-b on each of them. But I made it through the end.
You can add my Reviewed-by: Lucas De Marchi <[email protected]> on all of them, except patch 5.
For patch 5, movingo clock_gating_funcs, I'm not really sure it's what we want.
thanks
Lucas De Marchi