Skip to contentSkip to conversation

package/wpa_supplicant: enable libnl for the WIRED driver

PATCH Applied yegorslists--- via buildroot 4 participants 4 messages Apr 11, 2022 – May 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wpa_supplicant: enable libnl for the WIRED driver

From: Yegor Yefremov <[email protected]>

BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX driver. This driver requires libnl.

Also fix CONFIG_DRIVER_MACSEC option to enable only the generic Linux driver and not QCA extensions.

Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

---
 package/wpa_supplicant/Config.in         |  2 ++
 package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)
package/wpa_supplicant/Config.in +2 -0
index 8f095cdf2d..0094531548 100644
@@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 
 config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	bool "Enable wired support"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+	select BR2_PACKAGE_LIBNL
 	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
 	help
 	  Include the "wired" driver, so the internal IEEE 802.1x
package/wpa_supplicant/wpa_supplicant.mk +9 -2
index a2ca8a0b30..ac66d1f7e0 100644
@@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
 	CONFIG_FILS
 endif
 
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
+WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
+WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
+WPA_SUPPLICANT_CONFIG_ENABLE += \
+	CONFIG_DRIVER_WIRED \
+	CONFIG_MACSEC \
+	CONFIG_DRIVER_MACSEC_LINUX
+else
 WPA_SUPPLICANT_CONFIG_DISABLE += \
 	CONFIG_DRIVER_WIRED \
 	CONFIG_MACSEC \
-	CONFIG_DRIVER_MACSEC
+	CONFIG_DRIVER_MACSEC_LINUX
 endif
 
 ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)
Signature · 6 lines
2.17.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 1/1
#1 lore raw

Hi Yegor,

Quoted 5 lines

From: Yegor Yefremov <[email protected]>

BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX driver. This driver requires libnl.

Quoted 7 lines

Also fix CONFIG_DRIVER_MACSEC option to enable only the generic Linux driver and not QCA extensions.

Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

Thanks for looking into this issue.

Regards,
Sergey
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to yegorslists--- via buildroot
Quoted 22 lines · yegorslists--- via buildroot

From: Yegor Yefremov <[email protected]>

BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX driver. This driver requires libnl.

Also fix CONFIG_DRIVER_MACSEC option to enable only the generic Linux driver and not QCA extensions.

Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

---
  package/wpa_supplicant/Config.in         |  2 ++
  package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
  2 files changed, 11 insertions(+), 2 deletions(-)
package/wpa_supplicant/Config.in +0 -0
index 8f095cdf2d..0094531548 100644

package/wpa_supplicant/Config.in config BR2_PACKAGE_WPA_SUPPLICANT_WEXT · line 44

Quoted 4 lines
package/wpa_supplicant/Config.in +1 -0
@@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 
  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
  	bool "Enable wired support"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl

You also need to add a comment for this.

Quoted 9 lines
package/wpa_supplicant/Config.in +1 -0
+	select BR2_PACKAGE_LIBNL
  	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
  	help
  	  Include the "wired" driver, so the internal IEEE 802.1x
package/wpa_supplicant/wpa_supplicant.mk +0 -0
index a2ca8a0b30..ac66d1f7e0 100644

package/wpa_supplicant/wpa_supplicant.mk WPA_SUPPLICANT_CONFIG_DISABLE += \ · line 69

Quoted 8 lines
package/wpa_supplicant/wpa_supplicant.mk +4 -1
@@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
  	CONFIG_FILS
  endif
 
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
+WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
+WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
+WPA_SUPPLICANT_CONFIG_ENABLE += \

This looks a bit kludgy, just put everything in a single CONFIG_ENABLE.

Applied to master with those two fixed, thanks.

Regards,
Arnout

package/wpa_supplicant/wpa_supplicant.mk WPA_SUPPLICANT_CONFIG_DISABLE += \ · line 80

Quoted 12 lines
package/wpa_supplicant/wpa_supplicant.mk +5 -1
+	CONFIG_DRIVER_WIRED \
+	CONFIG_MACSEC \
+	CONFIG_DRIVER_MACSEC_LINUX
+else
  WPA_SUPPLICANT_CONFIG_DISABLE += \
  	CONFIG_DRIVER_WIRED \
  	CONFIG_MACSEC \
-	CONFIG_DRIVER_MACSEC
+	CONFIG_DRIVER_MACSEC_LINUX
  endif
 
  ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to yegorslists--- via buildroot
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists---" == yegorslists--- via buildroot <[email protected]> writes:

From: Yegor Yefremov <[email protected]> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX driver. This driver requires libnl.

Quoted 7 lines

Also fix CONFIG_DRIVER_MACSEC option to enable only the generic Linux driver and not QCA extensions.

Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0

Committed to 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot