Skip to contentSkip to conversation

mem: child alloc memory should larger than memory.max + memory.swap.max if lite==1

PATCH New Li Wang 3 participants 8 messages Jun 23, 2021 Library code

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH v3 1/3 mem: child alloc memory should larger than memory.max + memory.swap.max if lite==1

oom03 often gets fail while setting 'memory.swap.max = TESTMEM' in CGroup V2, as in that scenario (lite == 1), child_alloc only start a single process to dirty 'TESTMEM + MB' anonymous memory for testing:

testoom(, lite == 1, ,)
? oom(, lite == 1, ,)
? ? child_alloc(, lite == 1,)
? ? ? ? alloc_mem(TESTMEM + MB, )

mem.c:224: TINFO: start normal OOM testing.
mem.c:146: TINFO: expected victim is 80466.
mem.c:38: TINFO: thread (7f411c69d740), allocating 1074790400 bytes.
mem.c:64: TINFO: swapped is 25546752 bytes. <------- swap occuring -----
mem.c:164: TFAIL: victim unexpectedly ended with retcode: 0, expected: 12

TBH, this can not really test the 'memory.swap.max' as expected, since in the kernel side mem_cgroup_out_of_memory split OOM margin into two-part, one for memory.max limit, another for memory.swap.max, if any of them get overflow, then invoke out_of_memory to kill victim-process.

Theoretically, alloc_mem(TESTMEM + MB, ) should work while 'memory.max' is equal to TESTMEM, but Cgroup v2 tracks memory and swap in separate, which splits memory and swap counter. So with swappiness enable (default value is 60 on RHEL), it likely has part of memory swapping out during the allocating, upon that the two limit loss effect@the same time. Unless disable swap completely then memory.max will take effect in precisely.

To get more opportunities to reach the swap limitation, let's scale down the value of 'memory.swap.max' to only 1MB for CGroup v2.

But for CGroup v1, the memory.memsw.limit_in_bytes disallow to less than memory.limit_in_bytes, so we'd better raise the child_alloc to the twofold of TESTMEM, and reset memory.memsw.limit_in_bytes to 'TESTMEM + MB'.

---

Notes:
v2 --> v3
* set memory.memsw.limit_in_bytes to TESTMEM+MB as suggest by Richard
* typo fix and some comments embellishment

 testcases/kernel/mem/lib/mem.c   |  2 +-
 testcases/kernel/mem/oom/oom03.c | 16 +++++++++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)
testcases/kernel/mem/lib/mem.c +1 -1
index 9f946b5c9..ac890491c 100644
@@ -78,7 +78,7 @@ static void child_alloc(int testcase, int lite, int threads)
 	pthread_t *th;
 
 	if (lite) {
-		int ret = alloc_mem(TESTMEM + MB, testcase);
+		int ret = alloc_mem(TESTMEM * 2 + MB, testcase);
 		exit(ret);
 	}
 
testcases/kernel/mem/oom/oom03.c +15 -1
index 939413744..b3770cf8f 100644
@@ -46,7 +46,21 @@ static void verify_oom(void)
 	testoom(0, 0, ENOMEM, 1);
 
 	if (SAFE_CGROUP_HAS(cg, "memory.swap.max")) {
-		SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", TESTMEM);
+		/*
+		 * Cgroup v2 tracks memory and swap in separate, which splits
+		 * memory and swap counter. So with swappiness enable (default
+		 * value is 60 on RHEL), it likely has part of memory swapping
+		 * out during the allocating.
+		 *
+		 * To get more opportunities to reach the swap limitation,
+		 * let's scale down the value of 'memory.swap.max' to only
+		 * 1MB for CGroup v2.
+		 */
+		if (TST_CGROUP_VER(cg, "memory") != TST_CGROUP_V1)
+			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", MB);
+		else
+			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", TESTMEM + MB);
+
 		testoom(0, 1, ENOMEM, 1);
 	}
 
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH v3 2/3 oom: enable lite == 1 for memory.swap.max testing

oom03: adding print info and restore memory.swap.max after testing
oom05: enable lite == 1 for memory.swap.max testing

---
 testcases/kernel/mem/oom/oom03.c | 6 ++++++
 testcases/kernel/mem/oom/oom05.c | 8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
testcases/kernel/mem/oom/oom03.c +6 -0
index b3770cf8f..942b77ba1 100644
@@ -46,6 +46,7 @@ static void verify_oom(void)
 	testoom(0, 0, ENOMEM, 1);
 
 	if (SAFE_CGROUP_HAS(cg, "memory.swap.max")) {
+		tst_res(TINFO, "OOM on MEMCG with special memswap limitation:");
 		/*
 		 * Cgroup v2 tracks memory and swap in separate, which splits
 		 * memory and swap counter. So with swappiness enable (default
@@ -62,6 +63,11 @@ static void verify_oom(void)
 			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", TESTMEM + MB);
 
 		testoom(0, 1, ENOMEM, 1);
+
+		if (TST_CGROUP_VER(cg, "memory") == TST_CGROUP_V1)
+			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", ~0UL);
+		else
+			SAFE_CGROUP_PRINT(cg, "memory.swap.max", "max");
 	}
 
 	/* OOM for MEMCG with mempolicy */
testcases/kernel/mem/oom/oom05.c +6 -2
index 9c9bba7f6..079cab123 100644
@@ -63,8 +63,12 @@ static void verify_oom(void)
 	if (SAFE_CGROUP_HAS(cg, "memory.swap.max")) {
 		tst_res(TINFO, "OOM on CPUSET & MEMCG with "
 				"special memswap limitation:");
-		SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", TESTMEM);
-		testoom(0, 0, ENOMEM, 1);
+		if (TST_CGROUP_VER(cg, "memory") != TST_CGROUP_V1)
+			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", MB);
+		else
+			SAFE_CGROUP_PRINTF(cg, "memory.swap.max", "%lu", TESTMEM + MB);
+
+		testoom(0, 1, ENOMEM, 1);
 
 		tst_res(TINFO, "OOM on CPUSET & MEMCG with "
 				"disabled memswap limitation:");
Signature · 1 line
2.31.1
#2 lore raw

PATCH v3 2/3 oom: enable lite == 1 for memory.swap.max testing

Hi Li,

Quoted 2 lines

oom03: adding print info and restore memory.swap.max after testing
oom05: enable lite == 1 for memory.swap.max testing

Kind regards,
Petr

author
#4 lore raw

PATCH v3 3/3 tst_cgroup: make use of alias in safe_cgroup_has

In reply to Li Wang

This is to fix the check issue of 'memory.swap.max' on CGroup v1.

---
 lib/tst_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/tst_cgroup.c +1 -1
index 18e3b6169..61cc02fa7 100644
@@ -1010,7 +1010,7 @@ int safe_cgroup_has(const char *const file, const int lineno,
 		if (!(alias = cgroup_file_alias(cfile, *dir)))
 		    continue;
 
-		if (!faccessat((*dir)->dir_fd, file_name, F_OK, 0))
+		if (!faccessat((*dir)->dir_fd, alias, F_OK, 0))
 			return 1;
 
 		if (errno == ENOENT)
Signature · 1 line
2.31.1
author
#7 lore raw

PATCH v3 1/3 mem: child alloc memory should larger than memory.max + memory.swap.max if lite==1

Patchset pushed, thanks!

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210623/c2b50fc7/attachment-0001.htm>