Skip to contentSkip to conversation

package/nfs-utils: select BR2_PACKAGE_RPCBIND only if needed

PATCH New Angelo Compagnucci 3 participants 3 messages Nov 16, 2020 – Jan 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/nfs-utils: select BR2_PACKAGE_RPCBIND only if needed

rpcbind is only used by nfsd to export nfs share supporting older v2, v3 protocols.

---
 package/nfs-utils/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/nfs-utils/Config.in +1 -1
index cfca034019..36d799486a 100644
@@ -7,7 +7,7 @@ config BR2_PACKAGE_NFS_UTILS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
-	select BR2_PACKAGE_RPCBIND # runtime
+	select BR2_PACKAGE_RPCBIND if BR2_PACKAGE_NFS_UTILS_RPC_NFSD # runtime# runtime
 	help
 	  The NFS Linux kernel server.
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/nfs-utils: select BR2_PACKAGE_RPCBIND only if needed

Angelo, All,

On 2020-11-16 12:40 +0100, Angelo Compagnucci spake thusly:

Quoted 13 lines

rpcbind is only used by nfsd to export nfs share supporting older v2, v3 protocols.

---
 package/nfs-utils/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/nfs-utils/Config.in +0 -0
index cfca034019..36d799486a 100644

package/nfs-utils/Config.in config BR2_PACKAGE_NFS_UTILS · line 10

Quoted 5 lines
package/nfs-utils/Config.in +1 -1
@@ -7,7 +7,7 @@ config BR2_PACKAGE_NFS_UTILS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
-	select BR2_PACKAGE_RPCBIND # runtime
+	select BR2_PACKAGE_RPCBIND if BR2_PACKAGE_NFS_UTILS_RPC_NFSD # runtime# runtime

Then why is the select not moved to the BR2_PACKAGE_NFS_UTILS_RPC_NFSD symbol itself?

Also, duplicated comment...

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/nfs-utils/Config.in +0 -0
 	help
 	  The NFS Linux kernel server.
 
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'