Skip to contentSkip to conversation

usb: gadget: select CONFIG_CRC32

PATCH In review Arnd Bergmann 2 participants 2 messages Jan 3, 2021 – Jan 5, 2021 USB

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 usb: gadget: select CONFIG_CRC32

From: Arnd Bergmann <[email protected]>

Without crc32 support, this driver fails to link:

arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap':
f_eem.c:(.text+0x11cc): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40):
more undefined references to `crc32_le' follow

Fixes 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/usb/gadget/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/gadget/Kconfig +2 -0
index 7e47e6223089..2d152571a7de 100644
@@ -265,6 +265,7 @@ config USB_CONFIGFS_NCM
 	depends on NET
 	select USB_U_ETHER
 	select USB_F_NCM
+	select CRC32
 	help
 	  NCM is an advanced protocol for Ethernet encapsulation, allows
 	  grouping of several ethernet frames into one USB transfer and

@@ -314,6 +315,7 @@ config USB_CONFIGFS_EEM
 	depends on NET
 	select USB_U_ETHER
 	select USB_F_EEM
+	select CRC32
 	help
 	  CDC EEM is a newer USB standard that is somewhat simpler than CDC ECM
 	  and therefore can be supported by more hardware.  Technically ECM and
Signature · 1 line
2.29.2
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without crc32 support, this driver fails to link:

arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap':
f_eem.c:(.text+0x11cc): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40):
more undefined references to `crc32_le' follow

Fixes 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.")
Signed-off-by Arnd Bergmann <[email protected]>
Acked-by Felipe Balbi <[email protected]>
Signature · 1 line
balbi