Skip to contentSkip to conversation

package/guile: disable jit on ARM with gcc < 5

PATCH New Fabrice Fontaine 2 participants 2 messages Nov 7, 2020 – Nov 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/guile: disable jit on ARM with gcc < 5

jit is enabled by default since version 3.0.0 on x86-64, i686, ARMv7 and AArch64 targets however it raises the following build failure on ARM with gcc 4.8:

jit.c:232:1: error: initializer element is not constant
static const jit_gpr_t THREAD = JIT_V0;
^

This build failure was also reported with ARM on gcc 4.9:
https://www.mail-archive.com/guile-user at gnu.org/msg11497.html

So just disable jit with ARM and gcc < 5

Fixes:
- http://autobuild.buildroot.org/results/ba051bb00a6cad3cfd5ffeb197de20ea0eaef33e

---
 package/guile/guile.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/guile/guile.mk +5 -0
index 5750b85f49..f1623008c8 100644
@@ -38,6 +38,11 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM)$(BR2_OPTIMIZE_S),yy)
 GUILE_CFLAGS += -O2
 endif
 
+# jit triggers build failures on ARM and gcc < 5
+ifeq ($(BR2_arm):$(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y:)
+GUILE_CONF_OPTS += --disable-jit
+endif
+
 # It can use readline, but on the condition that it was build against
 # ncurses. If both aren't present disable readline support since the
 # host readline/ncurses support can poison the build.
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/guile: disable jit on ARM with gcc < 5

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

jit is enabled by default since version 3.0.0 on x86-64, i686, ARMv7 and AArch64 targets however it raises the following build failure on ARM with gcc 4.8:

jit.c:232:1: error: initializer element is not constant
static const jit_gpr_t THREAD = JIT_V0;
^

This build failure was also reported with ARM on gcc 4.9:
https://www.mail-archive.com/guile-user at gnu.org/msg11497.html

Quoted 6 lines

So just disable jit with ARM and gcc < 5

Fixes:
- http://autobuild.buildroot.org/results/ba051bb00a6cad3cfd5ffeb197de20ea0eaef33e

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard