powerpc/papr_scm: Add PAPR command family to pass-through command-set
Subsystems (2)
PATCH 1/1 powerpc/papr_scm: Add PAPR command family to pass-through command-set
Add NVDIMM_FAMILY_PAPR to the list of valid 'dimm_family_mask' acceptable by papr_scm. This is needed as since commit 92fe2aa859f5 ("libnvdimm: Validate command family indices") libnvdimm performs a validation of 'nd_cmd_pkg.nd_family' received as part of ND_CMD_CALL processing to ensure only known command families can use the general ND_CMD_CALL pass-through functionality.
Without this change the ND_CMD_CALL pass-through targeting NVDIMM_FAMILY_PAPR error out with -EINVAL.
--- arch/powerpc/platforms/pseries/papr_scm.c | 3 +++ 1 file changed, 3 insertions(+)
arch/powerpc/platforms/pseries/papr_scm.c +3 -0
@@ -898,6 +898,9 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) p->bus_desc.of_node = p->pdev->dev.of_node; p->bus_desc.provider_name =kstrdup (p->pdev->name,GFP_KERNEL ); +/* Set the dimm command family mask to accept PDSMs */ +set_bit (NVDIMM_FAMILY_PAPR , &p->bus_desc.dimm_family_mask); +if (!p->bus_desc.provider_name)return -ENOMEM ;
Signature · 4 lines
2.26.2 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Hi Dan, Ira and Vishal,
Can you please take a look at this patch. Without it the functionality to report nvdimm health via ndctl breaks on 5.9
Thanks,
~ Vaibhav
Quoted 33 lines · Vaibhav Jain
Add
NVDIMM_FAMILY_PAPRto the list of valid 'dimm_family_mask' acceptable bypapr_scm. This is needed as since commit92fe2aa859f5("libnvdimm: Validate command family indices") libnvdimm performs a validation of 'nd_cmd_pkg.nd_family' received as part ofND_CMD_CALLprocessing to ensure only known command families can use the generalND_CMD_CALLpass-through functionality.Without this change the
ND_CMD_CALLpass-through targetingNVDIMM_FAMILY_PAPRerror out with-EINVAL.Fixes 92fe2aa859f5 ("libnvdimm: Validate command family indices")Signed-off-by Vaibhav Jain <[email protected]>--- arch/powerpc/platforms/pseries/papr_scm.c | 3 +++ 1 file changed, 3 insertions(+)arch/powerpc/platforms/pseries/papr_scm.c +3
-0@@ -898,6 +898,9 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) p->bus_desc.of_node = p->pdev->dev.of_node; p->bus_desc.provider_name =kstrdup (p->pdev->name,GFP_KERNEL ); +/* Set the dimm command family mask to accept PDSMs */ +set_bit (NVDIMM_FAMILY_PAPR , &p->bus_desc.dimm_family_mask); +if (!p->bus_desc.provider_name)return -ENOMEM ;Signature · 1 line
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Ira Weiny
Reviewed-byQuoted 4 lines · Vaibhav Jain
Hi Dan, Ira and Vishal,
Can you please take a look at this patch. Without it the functionality to report nvdimm health via ndctl breaks on 5.9
Sorry...
Quoted 18 lines
Thanks,
~ VaibhavQuoted 12 lines · Vaibhav Jain
Add
NVDIMM_FAMILY_PAPRto the list of valid 'dimm_family_mask' acceptable bypapr_scm. This is needed as since commit92fe2aa859f5("libnvdimm: Validate command family indices") libnvdimm performs a validation of 'nd_cmd_pkg.nd_family' received as part ofND_CMD_CALLprocessing to ensure only known command families can use the generalND_CMD_CALLpass-through functionality.Without this change the
ND_CMD_CALLpass-through targetingNVDIMM_FAMILY_PAPRerror out with-EINVAL.Fixes 92fe2aa859f5 ("libnvdimm: Validate command family indices")Signed-off-by Vaibhav Jain <[email protected]>
LGTM
Quoted 18 lines
Quoted 18 lines
--- arch/powerpc/platforms/pseries/papr_scm.c | 3 +++ 1 file changed, 3 insertions(+)arch/powerpc/platforms/pseries/papr_scm.c +3
-0@@ -898,6 +898,9 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) p->bus_desc.of_node = p->pdev->dev.of_node; p->bus_desc.provider_name =kstrdup (p->pdev->name,GFP_KERNEL ); +/* Set the dimm command family mask to accept PDSMs */ +set_bit (NVDIMM_FAMILY_PAPR , &p->bus_desc.dimm_family_mask); +if (!p->bus_desc.provider_name)return -ENOMEM ;
Quoted 3 lines
Quoted 3 lines
Signature · 1 line
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Michael Ellerman
AppliedQuoted 8 lines · Vaibhav Jain
Add
NVDIMM_FAMILY_PAPRto the list of valid 'dimm_family_mask' acceptable bypapr_scm. This is needed as since commit92fe2aa859f5("libnvdimm: Validate command family indices") libnvdimm performs a validation of 'nd_cmd_pkg.nd_family' received as part ofND_CMD_CALLprocessing to ensure only known command families can use the generalND_CMD_CALLpass-through functionality.[...]
Applied to powerpc/next.
[1/1] powerpc/papr_scm: Add PAPR command family to pass-through command-set
https://git.kernel.org/powerpc/c/13135b461cf205941308984bd3271ec7d403dc40
cheers
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]