dwc3: meson: fix coccinelle WARNING
Subsystems (4)
PATCH 1/11 dwc3: meson: fix coccinelle WARNING
From: Felipe Balbi <[email protected]>
Coccinelle suggests using PTR_ERR_OR_ZERO().
--- drivers/usb/dwc3/dwc3-meson-g12a.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/dwc3/dwc3-meson-g12a.c +1 -4
@@ -626,10 +626,7 @@ static int dwc3_meson_gxl_setup_regmaps(struct dwc3_meson_g12a *priv,/* GXL controls the PHY mode in the PHY registers unlike G12A */ priv->usb_glue_regmap =devm_regmap_init_mmio (priv->dev, base, &phy_meson_g12a_usb_glue_regmap_conf); -if (IS_ERR (priv->usb_glue_regmap)) -return PTR_ERR (priv->usb_glue_regmap); - -return 0 ; +return PTR_ERR_OR_ZERO (priv->usb_glue_regmap); } static int dwc3_meson_g12a_setup_regmaps(struct dwc3_meson_g12a *priv,
Signature · 1 line
2.28.0
PATCH 2/11 dwc3: debug: fix sparse warning
From: Felipe Balbi <[email protected]>
Fix the following sparse warning:
drivers/usb/dwc3/trace.c: note: in included file (through drivers/usb/dwc3/trace.h):drivers/usb/dwc3/debug.h:374:39: warning: cast to non-scalar
--- drivers/usb/dwc3/debug.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/dwc3/debug.h +3 -1
@@ -371,7 +371,9 @@ static inline const char *dwc3_gadget_event_type_string(u8 event)static inline const char *dwc3_decode_event (char *str,size_t size,u32 event,u32 ep0state) { -const union dwc3_event evt = (union dwc3_event ) event; +union dwc3_event evt; + +memcpy (&evt, &event,sizeof (event));if (evt.type.is_devspec)return dwc3_gadget_event_string (str, size, &evt.devt);
Signature · 1 line
2.28.0
PATCH 3/11 dwc3: meson: fix checkpatch errors and warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes.
--- drivers/usb/dwc3/dwc3-meson-g12a.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
drivers/usb/dwc3/dwc3-meson-g12a.c +7 -11
@@ -116,11 +116,11 @@ static struct clk_bulk_data meson_a1_clocks[] = { { .id = "xtal_usb_ctrl" }, }; -static const char *meson_gxm_phy_names[] = { +static const char *const meson_gxm_phy_names[] = {"usb2-phy0" ,"usb2-phy1" ,"usb2-phy2" , }; -static const char *meson_g12a_phy_names[] = { +static const char *const meson_g12a_phy_names[] = {"usb2-phy0" ,"usb2-phy1" ,"usb3-phy0" , };
@@ -132,7 +132,7 @@ static const char *meson_g12a_phy_names[] = {* correctly when only the "usb2-phy1" phy is specified on-par with the * DT bindings. */ -static const char *meson_a1_phy_names[] = { +static const char *const meson_a1_phy_names[] = {"usb2-phy0" ,"usb2-phy1" };
@@ -143,7 +143,7 @@ struct dwc3_meson_g12a_drvdata {bool otg_phy_host_port_disable;struct clk_bulk_data *clks;int num_clks; -const char **phy_names; +const char *const *phy_names;int num_phys;int (*setup_regmaps)(struct dwc3_meson_g12a *priv,void __iomem *base); int (*usb2_init_phy)(struct dwc3_meson_g12a *priv, int i,
@@ -520,11 +520,7 @@ static int dwc3_meson_g12a_role_set(struct usb_role_switch *sw,return 0 ;if (priv->drvdata->otg_phy_host_port_disable) -dev_warn_once (priv->dev,"Manual OTG switch is broken on this " \ -"SoC, when manual switching from " \ -"Host to device, DWC3 controller " \ -"will need to be resetted in order " \ -"to recover usage of the Host port" ); +dev_warn_once (priv->dev,"Broken manual OTG switch\n" );return dwc3_meson_g12a_otg_mode_set (priv, mode); }
@@ -906,8 +902,8 @@ static int __maybe_unused dwc3_meson_g12a_resume(struct device *dev)return ret; } -if (priv->vbus && priv->otg_phy_mode ==PHY_MODE_USB_HOST ) { - ret =regulator_enable (priv->vbus); +if (priv->vbus && priv->otg_phy_mode ==PHY_MODE_USB_HOST ) { + ret =regulator_enable (priv->vbus);if (ret)return ret; }
Signature · 1 line
2.28.0
PATCH 4/11 dwc3: ulpi: fix checkpatch warning
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes.
--- drivers/usb/dwc3/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc3/ulpi.c +1 -1
@@ -19,7 +19,7 @@static int dwc3_ulpi_busyloop (struct dwc3 *dwc) { -unsigned count =1000 ; +unsigned int count =1000 ;u32 reg;while (count--) {
Signature · 1 line
2.28.0
PATCH 5/11 dwc3: trace: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/trace.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/usb/dwc3/trace.h +9 -8
@@ -104,8 +104,8 @@ DECLARE_EVENT_CLASS(dwc3_log_request,TP_STRUCT__entry ( __string(name, req->dep->name) __field(struct dwc3_request *, req) - __field(unsigned, actual) - __field(unsigned, length) + __field(unsigned int, actual) + __field(unsigned int, length) __field(int, status) __field(int, zero) __field(int, short_not_ok)
@@ -246,6 +246,7 @@ DECLARE_EVENT_CLASS(dwc3_log_trb, __entry->dequeue, __entry->bph, __entry->bpl, ({char *s; int pcm = ((__entry->size >> 24) & 3) + 1; + switch (__entry->type) { case USB_ENDPOINT_XFER_INT: case USB_ENDPOINT_XFER_ISOC:
@@ -291,12 +292,12 @@ DECLARE_EVENT_CLASS(dwc3_log_ep,TP_ARGS (dep),TP_STRUCT__entry ( __string(name, dep->name) -__field (unsigned ,maxpacket ) -__field (unsigned, maxpacket_limit) -__field (unsigned, max_streams) -__field (unsigned, maxburst) -__field (unsigned, flags) -__field (unsigned, direction) +__field (unsigned int ,maxpacket ) + __field(unsigned int, maxpacket_limit) + __field(unsigned int, max_streams) + __field(unsigned int, maxburst) + __field(unsigned int, flags) + __field(unsigned int, direction)__field (u8, trb_enqueue)__field (u8, trb_dequeue) ),
Signature · 1 line
2.28.0
PATCH 6/11 dwc3: debug: fix checkpatch warning
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/debug.h +2 -2
@@ -413,8 +413,8 @@ static inline const char *dwc3_gadget_generic_cmd_status_string(int status)#ifdef CONFIG_DEBUG_FS -extern void dwc3_debugfs_init (struct dwc3 *); -extern void dwc3_debugfs_exit (struct dwc3 *); +extern void dwc3_debugfs_init (struct dwc3 *d); +extern void dwc3_debugfs_exit (struct dwc3 *d);#else static inline void dwc3_debugfs_init (struct dwc3 *d) { }
Signature · 1 line
2.28.0
PATCH 7/11 dwc3: core: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/core.h | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-)
drivers/usb/dwc3/core.h +19 -18
@@ -634,7 +634,7 @@ struct dwc3_trb;struct dwc3_event_buffer {void *buf;void *cache; -unsigned length; +unsigned int length;unsigned int lpos;unsigned int count;unsigned int flags;
@@ -694,7 +694,7 @@ struct dwc3_ep {struct dwc3 *dwc;u32 saved_state; -unsigned flags; +unsigned int flags;#define DWC3_EP_ENABLED BIT(0)#define DWC3_EP_STALL BIT(1)#define DWC3_EP_WEDGE BIT(2)
@@ -893,9 +893,9 @@ struct dwc3_request {struct scatterlist *sg;struct scatterlist *start_sg; -unsigned num_pending_sgs; +unsigned int num_pending_sgs;unsigned int num_queued_sgs; -unsigned remaining; +unsigned int remaining;unsigned int status;#define DWC3_REQUEST_STATUS_QUEUED 0
@@ -908,11 +908,11 @@ struct dwc3_request {struct dwc3_trb *trb;dma_addr_t trb_dma; -unsigned num_trbs; +unsigned int num_trbs; - unsigned needs_extra_trb:1; - unsigned direction:1; - unsigned mapped:1; + unsigned int needs_extra_trb:1; + unsigned int direction:1; + unsigned int mapped:1; };/*
@@ -1010,8 +1010,8 @@ struct dwc3_scratchpad_array {* @has_lpm_erratum: true when core was configured with LPM Erratum. Note that * there's now way for software to detect this in runtime. * @is_utmi_l1_suspend: the core asserts output signal -* 0 - utmi_sleep_n -* 1 - utmi_l1_suspend_n +* 0 - utmi_sleep_n +* 1 - utmi_l1_suspend_n * @is_fpga: true when we are using the FPGA board * @pending_events: true when we have pending IRQs to be handled * @pullups_connected: true when Run/Stop bit is set
@@ -1047,13 +1047,13 @@ struct dwc3_scratchpad_array {* instances in park mode. * @tx_de_emphasis_quirk: set if we enable Tx de-emphasis quirk * @tx_de_emphasis: Tx de-emphasis value -* 0 - -6dB de-emphasis -* 1 - -3.5dB de-emphasis -* 2 - No de-emphasis -* 3 - Reserved +* 0 - -6dB de-emphasis +* 1 - -3.5dB de-emphasis +* 2 - No de-emphasis +* 3 - Reserved * @dis_metastability_quirk: set to disable metastability quirk. * @imod_interval: set the interrupt moderation interval in 250ns -* increments or 0 to disable. +* increments or 0 to disable. */ struct dwc3 {struct work_struct drd_work;
@@ -1456,9 +1456,10 @@ void dwc3_gadget_exit(struct dwc3 *dwc);int dwc3_gadget_set_test_mode (struct dwc3 *dwc,int mode);int dwc3_gadget_get_link_state (struct dwc3 *dwc);int dwc3_gadget_set_link_state (struct dwc3 *dwc,enum dwc3_link_state state); -int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned cmd, +int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned int cmd,struct dwc3_gadget_ep_cmd_params *params); -int dwc3_send_gadget_generic_command (struct dwc3 *dwc,unsigned cmd,u32 param); +int dwc3_send_gadget_generic_command (struct dwc3 *dwc,unsigned int cmd, +u32 param);#else static inline int dwc3_gadget_init (struct dwc3 *dwc) {return 0 ; }
@@ -1472,7 +1473,7 @@ static inline int dwc3_gadget_set_link_state(struct dwc3 *dwc, enum dwc3_link_state state) {return 0 ; } -static inline int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned cmd, +static inline int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned int cmd,struct dwc3_gadget_ep_cmd_params *params) {return 0 ; } static inline int dwc3_send_gadget_generic_command(struct dwc3 *dwc,
Signature · 1 line
2.28.0
PATCH 8/11 dwc3: gadget: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/gadget.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-)
drivers/usb/dwc3/gadget.c +17 -15
@@ -227,7 +227,8 @@ void dwc3_gadget_giveback(struct dwc3_ep *dep, struct dwc3_request *req,* Caller should take care of locking. Issue @cmd with a given @param to @dwc * and wait for its completion. */ -int dwc3_send_gadget_generic_command (struct dwc3 *dwc,unsigned cmd,u32 param) +int dwc3_send_gadget_generic_command (struct dwc3 *dwc,unsigned int cmd, +u32 param) {u32 timeout =500 ;int status =0 ;
@@ -268,7 +269,7 @@ static int __dwc3_gadget_wakeup(struct dwc3 *dwc);* Caller should handle locking. This function will issue @cmd with given * @params to @dep and wait for its completion. */ -int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned cmd, +int dwc3_send_gadget_ep_cmd (struct dwc3_ep *dep,unsigned int cmd,struct dwc3_gadget_ep_cmd_params *params) {const struct usb_endpoint_descriptor *desc = dep->endpoint.desc;
@@ -564,6 +565,7 @@ static int dwc3_gadget_set_ep_config(struct dwc3_ep *dep, unsigned int action)/* Burst size is only needed in SuperSpeed mode */ if (dwc->gadget.speed >=USB_SPEED_SUPER ) {u32 burst = dep->endpoint.maxburst; + params.param0 |=DWC3_DEPCFG_BURST_SIZE (burst -1 ); }
@@ -942,9 +944,10 @@ static u32 dwc3_calc_trbs_left(struct dwc3_ep *dep) }static void __dwc3_prepare_one_trb (struct dwc3_ep *dep,struct dwc3_trb *trb, -dma_addr_t dma,unsigned length,unsigned chain,unsigned node, -unsigned stream_id,unsigned short_not_ok, -unsigned no_interrupt,unsigned is_last) +dma_addr_t dma,unsigned int length,unsigned int chain, +unsigned int node,unsigned int stream_id, +unsigned int short_not_ok,unsigned int no_interrupt, +unsigned int is_last) {struct dwc3 *dwc = dep->dwc;struct usb_gadget *gadget = &dwc->gadget;
@@ -1058,15 +1061,15 @@ static void __dwc3_prepare_one_trb(struct dwc3_ep *dep, struct dwc3_trb *trb,* @node: only for isochronous endpoints. First TRB needs different type. */ static void dwc3_prepare_one_trb (struct dwc3_ep *dep, -struct dwc3_request *req,unsigned chain,unsigned node) +struct dwc3_request *req,unsigned int chain,unsigned int node) {struct dwc3_trb *trb; +unsigned int stream_id = req->request.stream_id; +unsigned int short_not_ok = req->request.short_not_ok; +unsigned int no_interrupt = req->request.no_interrupt; +unsigned int is_last = req->request.is_last;unsigned int length;dma_addr_t dma; -unsigned stream_id = req->request.stream_id; -unsigned short_not_ok = req->request.short_not_ok; -unsigned no_interrupt = req->request.no_interrupt; -unsigned is_last = req->request.is_last;if (req->request.num_sgs >0 ) { length =sg_dma_len (req->start_sg);
@@ -1104,7 +1107,7 @@ static void dwc3_prepare_one_trb_sg(struct dwc3_ep *dep,unsigned int length = req->request.length;unsigned int maxp =usb_endpoint_maxp (dep->endpoint.desc);unsigned int rem = length % maxp; -unsigned chain = true; +unsigned int chain = true;/* * IOMMU driver is coalescing the list of sgs which shares a
@@ -1586,9 +1589,8 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)return 0 ;if ((dep->flags &DWC3_EP_PENDING_REQUEST )) { -if (!(dep->flags &DWC3_EP_TRANSFER_STARTED )) { +if (!(dep->flags &DWC3_EP_TRANSFER_STARTED ))return __dwc3_gadget_start_isoc (dep); - } } }
@@ -1726,8 +1728,8 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value, int protocol)if (value) {struct dwc3_trb *trb; -unsigned transfer_in_flight; -unsigned started; +unsigned int transfer_in_flight; +unsigned int started;if (dep->number >1 ) trb =dwc3_ep_prev_trb (dep, dep->trb_enqueue);
Signature · 1 line
2.28.0
PATCH 9/11 dwc3: ep0: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/ep0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/dwc3/ep0.c +3 -3
@@ -105,7 +105,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep *dep,* IRQ we were waiting for is long gone. */ if (dep->flags &DWC3_EP_PENDING_REQUEST ) { -unsigned direction; +unsigned int direction; direction = !!(dep->flags &DWC3_EP0_DIR_IN );
@@ -127,7 +127,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep *dep,* handle it here. */ if (dwc->delayed_status) { -unsigned direction; +unsigned int direction; direction = !dwc->ep0_expect_in; dwc->delayed_status = false;
@@ -172,7 +172,7 @@ static int __dwc3_gadget_ep0_queue(struct dwc3_ep *dep,* XferNotReady(STATUS). */ if (dwc->three_stage_setup) { -unsigned direction; +unsigned int direction; direction = dwc->ep0_expect_in; dwc->ep0state =EP0_DATA_PHASE ;
Signature · 1 line
2.28.0
PATCH 10/11 dwc3: qcom: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/dwc3-qcom.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/usb/dwc3/dwc3-qcom.c +5 -3
@@ -444,7 +444,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) {struct dwc3_qcom *qcom =platform_get_drvdata (pdev);const struct dwc3_acpi_pdata *pdata = qcom->acpi_pdata; -int irq, ret; +int irq; +int ret; + irq =dwc3_qcom_get_irq (pdev,"hs_phy_irq" , pdata ? pdata->hs_phy_irq_index :-1 );if (irq >0 ) {
@@ -563,7 +565,7 @@ static const struct property_entry dwc3_qcom_acpi_properties[] = {static int dwc3_qcom_acpi_register_core (struct platform_device *pdev) { -struct dwc3_qcom *qcom =platform_get_drvdata (pdev); +struct dwc3_qcom *qcom =platform_get_drvdata (pdev);struct device *dev = &pdev->dev;struct resource *res, *child_res =NULL ;int irq;
@@ -623,7 +625,7 @@ static int dwc3_qcom_acpi_register_core(struct platform_device *pdev)static int dwc3_qcom_of_register_core (struct platform_device *pdev) { -struct dwc3_qcom *qcom =platform_get_drvdata (pdev); +struct dwc3_qcom *qcom =platform_get_drvdata (pdev);struct device_node *np = pdev->dev.of_node, *dwc3_np;struct device *dev = &pdev->dev;int ret;
Signature · 1 line
2.28.0
PATCH 11/11 dwc3: debugfs: fix checkpatch warnings
In reply to [email protected]From: Felipe Balbi <[email protected]>
no functional changes
--- drivers/usb/dwc3/debugfs.c | 56 ++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 30 deletions(-)
drivers/usb/dwc3/debugfs.c +26 -30
@@ -397,13 +397,13 @@ static int dwc3_mode_show(struct seq_file *s, void *unused)switch (DWC3_GCTL_PRTCAP (reg)) {case DWC3_GCTL_PRTCAP_HOST : -seq_printf (s,"host\n" ); +seq_puts (s,"host\n" );break ;case DWC3_GCTL_PRTCAP_DEVICE : -seq_printf (s,"device\n" ); +seq_puts (s,"device\n" );break ;case DWC3_GCTL_PRTCAP_OTG : -seq_printf (s,"otg\n" ); +seq_puts (s,"otg\n" );break ;default :seq_printf (s,"UNKNOWN %08x\n" ,DWC3_GCTL_PRTCAP (reg));
@@ -464,22 +464,22 @@ static int dwc3_testmode_show(struct seq_file *s, void *unused)switch (reg) {case 0 : -seq_printf (s,"no test\n" ); +seq_puts (s,"no test\n" );break ;case USB_TEST_J : -seq_printf (s,"test_j\n" ); +seq_puts (s,"test_j\n" );break ;case USB_TEST_K : -seq_printf (s,"test_k\n" ); +seq_puts (s,"test_k\n" );break ;case USB_TEST_SE0_NAK : -seq_printf (s,"test_se0_nak\n" ); +seq_puts (s,"test_se0_nak\n" );break ;case USB_TEST_PACKET : -seq_printf (s,"test_packet\n" ); +seq_puts (s,"test_packet\n" );break ;case USB_TEST_FORCE_ENABLE : -seq_printf (s,"test_force_enable\n" ); +seq_puts (s,"test_force_enable\n" );break ;default :seq_printf (s,"UNKNOWN %d\n" , reg);
@@ -760,27 +760,26 @@ static int dwc3_transfer_type_show(struct seq_file *s, void *unused)unsigned long flags;spin_lock_irqsave (&dwc->lock, flags); -if (!(dep->flags &DWC3_EP_ENABLED ) || - !dep->endpoint.desc) { -seq_printf (s,"--\n" ); +if (!(dep->flags &DWC3_EP_ENABLED ) || !dep->endpoint.desc) { +seq_puts (s,"--\n" ); goto out; }switch (usb_endpoint_type (dep->endpoint.desc)) {case USB_ENDPOINT_XFER_CONTROL : -seq_printf (s,"control\n" ); +seq_puts (s,"control\n" );break ;case USB_ENDPOINT_XFER_ISOC : -seq_printf (s,"isochronous\n" ); +seq_puts (s,"isochronous\n" );break ;case USB_ENDPOINT_XFER_BULK : -seq_printf (s,"bulk\n" ); +seq_puts (s,"bulk\n" );break ;case USB_ENDPOINT_XFER_INT : -seq_printf (s,"interrupt\n" ); +seq_puts (s,"interrupt\n" );break ;default : -seq_printf (s,"--\n" ); +seq_puts (s,"--\n" ); } out:
@@ -798,11 +797,11 @@ static int dwc3_trb_ring_show(struct seq_file *s, void *unused)spin_lock_irqsave (&dwc->lock, flags);if (dep->number <=1 ) { -seq_printf (s,"--\n" ); +seq_puts (s,"--\n" ); goto out; } -seq_printf (s,"buffer_addr,size,type,ioc,isp_imi,csp,chn,lst,hwo\n" ); +seq_puts (s,"buffer_addr,size,type,ioc,isp_imi,csp,chn,lst,hwo\n" );for (i =0 ; i <DWC3_TRB_NUM ; i++) {struct dwc3_trb *trb = &dep->trb_pool[i];
@@ -884,7 +883,7 @@ static void dwc3_debugfs_create_endpoint_files(struct dwc3_ep *dep,const struct file_operations *fops = dwc3_ep_file_map[i].fops;const char *name = dwc3_ep_file_map[i].name; -debugfs_create_file (name,S_IRUGO , parent, dep, fops); +debugfs_create_file (name,0444 , parent, dep, fops); } }
@@ -929,21 +928,18 @@ void dwc3_debugfs_init(struct dwc3 *dwc) root =debugfs_create_dir (dev_name (dwc->dev), usb_debug_root); dwc->root = root; -debugfs_create_regset32 ("regdump" ,S_IRUGO , root, dwc->regset); +debugfs_create_regset32 ("regdump" ,0444 , root, dwc->regset); +debugfs_create_file ("lsp_dump" ,0644 , root, dwc, &dwc3_lsp_fops); -debugfs_create_file ("lsp_dump" ,S_IRUGO |S_IWUSR , root, dwc, - &dwc3_lsp_fops); - -if (IS_ENABLED (CONFIG_USB_DWC3_DUAL_ROLE )) { -debugfs_create_file ("mode" ,S_IRUGO |S_IWUSR , root, dwc, +if (IS_ENABLED (CONFIG_USB_DWC3_DUAL_ROLE )) +debugfs_create_file ("mode" ,0644 , root, dwc, &dwc3_mode_fops); - }if (IS_ENABLED (CONFIG_USB_DWC3_DUAL_ROLE ) ||IS_ENABLED (CONFIG_USB_DWC3_GADGET )) { -debugfs_create_file ("testmode" ,S_IRUGO |S_IWUSR , root, dwc, - &dwc3_testmode_fops); -debugfs_create_file ("link_state" ,S_IRUGO |S_IWUSR , root, dwc, +debugfs_create_file ("testmode" ,0644 , root, dwc, + &dwc3_testmode_fops); +debugfs_create_file ("link_state" ,0644 , root, dwc, &dwc3_link_state_fops);dwc3_debugfs_create_endpoint_dirs (dwc, root); }
Signature · 1 line
2.28.0
Thinh Nguyen
maintainerRe: [PATCH 11/11] dwc3: debugfs: fix checkpatch warnings
Hi Felipe,
Quoted 9 lines · [email protected] wrote:
From: Felipe Balbi <[email protected]>
no functional changes
Signed-off-by Felipe Balbi <[email protected]>--- drivers/usb/dwc3/debugfs.c | 56 ++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 30 deletions(-)
These checkpatch fixes will create many conflicts to the patches I submitted.
Did you get a chance to take a look at them yet before I revise them to be able to rebase on your testing/next branch?
Thanks,
Thinh
Re: [PATCH 11/11] dwc3: debugfs: fix checkpatch warnings
Quoted 13 lines · Thinh Nguyen
Hi Felipe,
Quoted 9 lines · [email protected] wrote:
From: Felipe Balbi <[email protected]>
no functional changes
Signed-off-by Felipe Balbi <[email protected]>--- drivers/usb/dwc3/debugfs.c | 56 ++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 30 deletions(-)
Quoted 5 lines
These checkpatch fixes will create many conflicts to the patches I submitted.
Did you get a chance to take a look at them yet before I revise them to be able to rebase on your testing/next branch?
Which patches specifically do you have in mind? I can rebase my patches on top of yours, shouldn't be a big issue.
Signature · 1 line
balbi
Thinh Nguyen
maintainerRe: [PATCH 11/11] dwc3: debugfs: fix checkpatch warnings
Quoted 14 lines · Felipe Balbi
Quoted 12 lines · Thinh Nguyen
Hi Felipe,
Quoted 9 lines · [email protected] wrote:
From: Felipe Balbi <[email protected]>
no functional changes
Signed-off-by Felipe Balbi <[email protected]>--- drivers/usb/dwc3/debugfs.c | 56 ++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 30 deletions(-)
Quoted 8 lines
Quoted 5 lines
These checkpatch fixes will create many conflicts to the patches I submitted.
Did you get a chance to take a look at them yet before I revise them to be able to rebase on your testing/next branch?
Which patches specifically do you have in mind? I can rebase my patches on top of yours, shouldn't be a big issue.
If possible, can you rebase on top of these 2 series of fixes:
Series 1: [PATCH v2 0/7] usb: dwc3: gadget: Fix TRB preparation
https://lore.kernel.org/linux-usb/[email protected]/T/#t
Series 2: [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling
https://lore.kernel.org/linux-usb/[email protected]/T/#t
If they look ok to you, you can rebase on top of them. That'd help me a bunch.
I'll let the series updating USB 3.2 soak for a little longer to for any comment. I can rebase and resend that series later.
Thanks!
Thinh
Thinh Nguyen
maintainerRe: [PATCH 11/11] dwc3: debugfs: fix checkpatch warnings
Quoted 23 lines · Thinh Nguyen
Quoted 14 lines · Felipe Balbi
Quoted 12 lines · Thinh Nguyen
Hi Felipe,
Quoted 9 lines · [email protected] wrote:
From: Felipe Balbi <[email protected]>
no functional changes
Signed-off-by Felipe Balbi <[email protected]>--- drivers/usb/dwc3/debugfs.c | 56 ++++++++++++++++++-------------------- 1 file changed, 26 insertions(+), 30 deletions(-)Quoted 8 lines
Quoted 5 lines
These checkpatch fixes will create many conflicts to the patches I submitted.
Did you get a chance to take a look at them yet before I revise them to be able to rebase on your testing/next branch?
Which patches specifically do you have in mind? I can rebase my patches on top of yours, shouldn't be a big issue.
Quoted 6 lines
If possible, can you rebase on top of these 2 series of fixes:
Series 1: [PATCH v2 0/7] usb: dwc3: gadget: Fix TRB preparation
https://lore.kernel.org/linux-usb/[email protected]/T/#tSeries 2: [PATCH 0/3] usb: dwc3: gadget: Fix halt/clear_stall handling
Correct link for series 2:
https://lore.kernel.org/linux-usb/[email protected]/T/#t
Quoted 6 lines
If they look ok to you, you can rebase on top of them. That'd help me a bunch.
I'll let the series updating USB 3.2 soak for a little longer to for any comment. I can rebase and resend that series later.
Thanks,
Thinh