Enable thumb build to reduce build size of u-boot.kwb.
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671
https://lists.denx.de/pipermail/u-boot/2018-May/327497.html
---
configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/sheevaplug_defconfig +1 -0
@@ -36,3 +36,4 @@ CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_STORAGE=y CONFIG_LZMA=y +CONFIG_SYS_THUMB_BUILD=y
Signature · 1 line
2.11.0
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
Hi,
Quoted 17 lines · Vagrant Cascadian,
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671
https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>---
configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+)configs/sheevaplug_defconfig +0
-0
configs/sheevaplug_defconfig CONFIG_USB=y
Quoted 5 lines
configs/sheevaplug_defconfig +1
-1@@ -36,3 +36,4 @@ CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_STORAGE=y CONFIG_LZMA=y +CONFIG_SYS_THUMB_BUILD=y --
Stefan sent a patch to move the environment for openrd is it worth doing that instead?
Also isn't there an option to enforce a build size limit so that we notice when we've expanded too far? That's how we noticed the problem for openrd.
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
Quoted 14 lines · Chris Packham
Quoted 12 lines · Vagrant Cascadian,
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671
https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>---
configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+)
Quoted 14 lines
configs/sheevaplug_defconfig CONFIG_USB=y
Quoted 10 lines
configs/sheevaplug_defconfig +1
-1@@ -36,3 +36,4 @@ CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_STORAGE=y CONFIG_LZMA=y +CONFIG_SYS_THUMB_BUILD=y --Stefan sent a patch to move the environment for openrd is it worth doing that instead?
Moving the environment breaks compatibility with older saved environments, so seems like something that should be done as a last resort, in my opinion, since upgrading the bootloader can result in an unbootable system if they depend on the environment.
Enabling THUMB significantly reduced the size of the image, which should reduce having to play whack-a-mole every few releases as u-boot inevitably tends to grow in size over time... at least for a while.
Quoted 2 lines
Also isn't there an option to enforce a build size limit so that we notice when we've expanded too far? That's how we noticed the problem for openrd.
There is, and would obviously be a good thing to add.
I also have very limited time to work on support for boards I don't have the ability to test myself. Essentially, relaying this bug due to a bug report from a Debian user.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180603/102c1aa6/attachment.sig>
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
Quoted 31 lines · Vagrant Cascadian,
Quoted 1 line · Chris Packham
On Mon, 4 Jun 2018, 7:39 AM Vagrant Cascadian, <[email protected]>
Quoted 13 lines · wrote:
Quoted 13 lines
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671
https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>---
configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+)Quoted 14 lines
configs/sheevaplug_defconfig CONFIG_USB=y
Quoted 10 lines
configs/sheevaplug_defconfig +1
-1@@ -36,3 +36,4 @@ CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_STORAGE=y CONFIG_LZMA=y +CONFIG_SYS_THUMB_BUILD=y --Stefan sent a patch to move the environment for openrd is it worth doing that instead?
Quoted 9 lines
Moving the environment breaks compatibility with older saved environments, so seems like something that should be done as a last resort, in my opinion, since upgrading the bootloader can result in an unbootable system if they depend on the environment.
Enabling THUMB significantly reduced the size of the image, which should reduce having to play whack-a-mole every few releases as u-boot inevitably tends to grow in size over time... at least for a while.
Agreed. The DM changes will likely increase the size at least until everything is converted.
Quoted 10 lines
Also isn't there an option to enforce a build size limit so that we notice
Quoted 1 line
when we've expanded too far? That's how we noticed the problem for
openrd.
There is, and would obviously be a good thing to add.
I also have very limited time to work on support for boards I don't have the ability to test myself. Essentially, relaying this bug due to a bug report from a Debian user.
Ok I'll see if i can take a look for kirkwood boards that don't already have this in place.
Quoted 1 line
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
In reply to Vagrant CascadianQuoted 30 lines · Vagrant Cascadian
Quoted 14 lines · Chris Packham
Quoted 12 lines · Vagrant Cascadian,
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671 https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>---
configs/sheevaplug_defconfig | 1 + 1 file changed, 1 insertion(+)Quoted 14 lines
configs/sheevaplug_defconfig CONFIG_USB=y
Quoted 10 lines
configs/sheevaplug_defconfig +1
-1@@ -36,3 +36,4 @@ CONFIG_USB=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_STORAGE=y CONFIG_LZMA=y +CONFIG_SYS_THUMB_BUILD=y --Stefan sent a patch to move the environment for openrd is it worth doing that instead?
Quoted 8 lines
Moving the environment breaks compatibility with older saved environments, so seems like something that should be done as a last resort, in my opinion, since upgrading the bootloader can result in an unbootable system if they depend on the environment.
Enabling THUMB significantly reduced the size of the image, which should reduce having to play whack-a-mole every few releases as u-boot inevitably tends to grow in size over time... at least for a while.
Yes, if THUMB is not enabled for those Kirkwood based boards, please add support for it. This should give us enough space to add DT and DM in the releases.
Thanks,
Stefan
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
Quoted 38 lines · Stefan Roese
Quoted 37 lines · Vagrant Cascadian
Quoted 15 lines · Chris Packham
Quoted 12 lines · Vagrant Cascadian,
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671
https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>---
configs/sheevaplug_defconfig | 1 +
1 file changed, 1 insertion(+)Quoted 15 lines
Quoted 11 lines
configs/sheevaplug_defconfig +0
-0@@ -36,3 +36,4 @@ CONFIG_USB=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_STORAGE=y
CONFIG_LZMA=y
+CONFIG_SYS_THUMB_BUILD=yStefan sent a patch to move the environment for openrd is it worth doing that instead?
Moving the environment breaks compatibility with older saved environments, so seems like something that should be done as a last resort, in my opinion, since upgrading the bootloader can result in an unbootable system if they depend on the environment.
Quoted 7 lines
Quoted 3 lines
Enabling THUMB significantly reduced the size of the image, which should reduce having to play whack-a-mole every few releases as u-boot inevitably tends to grow in size over time... at least for a while.
Yes, if THUMB is not enabled for those Kirkwood based boards, please add support for it. This should give us enough space to add DT and DM in the releases.
BTW: Please add a more descriptive patch subject next time, so that we can better scan the patch content via the subject. Something like this would be good in this case:
arm: kirkwood: Enable THUMB mode on sheevaplug to reduce the image size
Thanks,
Stefan
PATCH 1/1 Enable thumb build to reduce build size of u-boot.kwb.
In reply to Vagrant CascadianQuoted 7 lines · Vagrant Cascadian
Without this, u-boot.kwb overlaps where the u-boot environment is stored, and updating the environment can break u-boot and vice versa.
https://bugs.debian.org/897671 https://lists.denx.de/pipermail/u-boot/2018-May/327497.htmlSigned-off-by Vagrant Cascadian <[email protected]>
Applied to u-boot-marvell/master.
Thanks,
Stefan