Skip to contentSkip to conversation

linux-firmware: bump version

PATCH New Gustavo Zacarias 3 participants 9 messages Sep 15, 2016 – Sep 17, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-firmware: bump version

And copy firmware for BCM43430 and BCM43438, hence rpi3 wifi support at last.

---
 package/linux-firmware/linux-firmware.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/linux-firmware/linux-firmware.mk +3 -2
index 8c983e4..d5a035e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LINUX_FIRMWARE_VERSION = c883a6b6186bb2415761d287cbac773062911212
+LINUX_FIRMWARE_VERSION = c4c07a8d1128d50a5c2885ceea1abbebaa82f820
 LINUX_FIRMWARE_SITE = http://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
 LINUX_FIRMWARE_SITE_METHOD = git
 
@@ -381,7 +381,8 @@ LINUX_FIRMWARE_FILES += \
 	brcm/brcmfmac43242a.bin brcm/brcmfmac43340-sdio.bin \
 	brcm/brcmfmac43362-sdio.bin brcm/brcmfmac43455-sdio.bin \
 	brcm/brcmfmac43569.bin brcm/brcmfmac43570-pcie.bin \
-	brcm/brcmfmac43602-pcie.ap.bin brcm/brcmfmac43602-pcie.bin
+	brcm/brcmfmac43602-pcie.ap.bin brcm/brcmfmac43602-pcie.bin \
+	brcm/brcmfmac43430-sdio.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
 endif
 
Signature · 1 line
2.7.3
#1 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

And copy firmware for BCM43430 and BCM43438, hence rpi3 wifi support at last.

Committed, thanks.

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 4 lines · Peter Korsgaard

Committed, thanks.

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Hi.
Well, without some $WiFi package (hostapd, wpa_supplicant, wireless-tools) just copying the firmware serves no purpose, though it can be done for completeness.
That being said, i lack a rpi3.
Regards.

#3 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 4 lines · Gustavo Zacarias
Quoted 2 lines · Peter Korsgaard

Committed, thanks.

Quoted 8 lines
Quoted 2 lines

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Hi.
Well, without some $WiFi package (hostapd, wpa_supplicant, wireless-tools) just copying the firmware serves no purpose, though it can be done for completeness.
That being said, i lack a rpi3.

And unless that changed recently, just the .bin the patch added wouldn't be sufficient for Pi 3.
Also need:
https://github.com/RPi-Distro/firmware-nonfree/blob/master/brcm80211/brcm/brcmfmac43430-sdio.txt

Yours sincerely,

Floris Bos

#4 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Floris" == Floris Bos <[email protected]> writes:

Quoted 4 lines · Gustavo Zacarias
Quoted 2 lines · Peter Korsgaard

Committed, thanks.

Quoted 8 lines
Quoted 2 lines

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Hi.
Well, without some $WiFi package (hostapd, wpa_supplicant, wireless-tools) just copying the firmware serves no purpose, though it can be done for completeness.
That being said, i lack a rpi3.

Quoted 4 lines

And unless that changed recently, just the .bin the patch added wouldn't be sufficient for Pi 3.
Also need:
https://github.com/RPi-Distro/firmware-nonfree/blob/master/brcm80211/brcm/brcmfmac43430-sdio.txt

Hmm, perhaps. Do you have a rpi 3 to test on? The linux-firmware commit doesn't mention anything about it:

http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/commit/?id=c4c07a8d1128d50a5c2885ceea1abbebaa82f820

But the kernel does reference the .txt file as well:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:BRCMF_FW_NVRAM_DEF(43430, "brcmfmac43430-sdio.bin", "brcmfmac43430-sdio.txt");

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 19 lines · Peter Korsgaard
Quoted 14 lines · Gustavo Zacarias
Quoted 12 lines · Peter Korsgaard
Quoted 5 lines

Committed, thanks.

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Hi.
Well, without some $WiFi package (hostapd, wpa_supplicant, wireless-tools) just copying the firmware serves no purpose, though it can be done for completeness.
That being said, i lack a rpi3.

Quoted 4 lines

And unless that changed recently, just the .bin the patch added wouldn't be sufficient for Pi 3.
Also need:
https://github.com/RPi-Distro/firmware-nonfree/blob/master/brcm80211/brcm/brcmfmac43430-sdio.txt

Quoted 4 lines

Hmm, perhaps. Do you have a rpi 3 to test on? The linux-firmware commit doesn't mention anything about it:

http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/commit/?id=c4c07a8d1128d50a5c2885ceea1abbebaa82f820

==

[    6.785594] usbcore: registered new interface driver brcmfmac
[    6.786851] brcmfmac_sdio mmc1:0001:1: Direct firmware load for 
brcm/brcmfmac43430-sdio.txt failed with error -2
[    7.789831] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): 
clkctl 0x50
[    8.802492] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): 

clkctl 0x50
==

Again, maybe they changed things very recently in a newer kernel branch or something.
But it simply does not work with the standard rpi one unless you also have the .txt

Yours sincerely,

Floris Bos

#6 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Floris" == Floris Bos <[email protected]> writes:

Hi,

Quoted 12 lines
Quoted 4 lines

Hmm, perhaps. Do you have a rpi 3 to test on? The linux-firmware commit doesn't mention anything about it:

http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/commit/?id=c4c07a8d1128d50a5c2885ceea1abbebaa82f820

==

[    6.785594] usbcore: registered new interface driver brcmfmac
[    6.786851] brcmfmac_sdio mmc1:0001:1: Direct firmware load for
brcm/brcmfmac43430-sdio.txt failed with error -2
[    7.789831] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000):
clkctl 0x50
[    8.802492] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000):
Quoted 7 lines

clkctl 0x50
==

Again, maybe they changed things very recently in a newer kernel branch or something.
But it simply does not work with the standard rpi one unless you also have the .txt

Ok, thanks. Does it work with the .bin file from linux-firmware and the .txt file from RPi-Distro?

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#7 lore raw

PATCH 1/1 linux-firmware: bump version

Quoted 18 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Floris" == Floris Bos <[email protected]> writes:

Hi,

Quoted 14 lines
Quoted 4 lines

Hmm, perhaps. Do you have a rpi 3 to test on? The linux-firmware commit doesn't mention anything about it:

http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/commit/?id=c4c07a8d1128d50a5c2885ceea1abbebaa82f820

==

[    6.785594] usbcore: registered new interface driver brcmfmac
[    6.786851] brcmfmac_sdio mmc1:0001:1: Direct firmware load for
brcm/brcmfmac43430-sdio.txt failed with error -2
[    7.789831] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000):
clkctl 0x50
[    8.802492] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000):

clkctl 0x50
==

Quoted 7 lines
Quoted 4 lines

Again, maybe they changed things very recently in a newer kernel branch or something.
But it simply does not work with the standard rpi one unless you also have the .txt

Ok, thanks. Does it work with the .bin file from linux-firmware and the .txt file from RPi-Distro?

Yes, that combination does work.

Yours sincerely,

Floris Bos

#8 lore raw

PATCH 1/1 linux-firmware: bump version

In reply to Gustavo Zacarias
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Quoted 2 lines · Peter Korsgaard

Committed, thanks.

Quoted 7 lines
Quoted 2 lines

Will you send a patch to add BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XX to the rpi3 defconfig?

Hi.
Well, without some $WiFi package (hostapd, wpa_supplicant, wireless-tools) just copying the firmware serves no purpose, though it can be done for completeness.

True. We already enable wpa-supplicant for a number of defconfigs, so probably that is the best option.

Quoted 1 line

That being said, i lack a rpi3.

Me too.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard