Skip to contentSkip to conversation

system: use a menuconfig for the getty options

PATCH New Yann E. MORIN 4 participants 4 messages Sep 1, 2015 – Oct 3, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 system: use a menuconfig for the getty options

Making the getty option a menuconfig instead of a simple config automatically moves its dependees into a menu without the need to manually declare such a menu.

---
 system/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
system/Config.in +1 -3
index fad829d..ea45cf3 100644
@@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
 	default "dash"    if BR2_SYSTEM_BIN_SH_DASH
 	default "zsh"     if BR2_SYSTEM_BIN_SH_ZSH
 
-config BR2_TARGET_GENERIC_GETTY
+menuconfig BR2_TARGET_GENERIC_GETTY
 	bool "Run a getty (login prompt) after boot"
 	default y
 
 if BR2_TARGET_GENERIC_GETTY
-menu "getty options"
 config BR2_TARGET_GENERIC_GETTY_PORT
 	string "TTY port"
 	default "console"
@@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
 	help
 	  Any other flags you want to pass to getty,
 	  Refer to getty --help for details.
-endmenu
 endif
 
 config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 system: use a menuconfig for the getty options

Quoted 5 lines · Yann E. MORIN

Making the getty option a menuconfig instead of a simple config automatically moves its dependees into a menu without the need to manually declare such a menu.

I don't quite like the new title of the menu, but I do think that this is
better than the original.

Regards,
Arnout

Quoted 31 lines
---
 system/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
system/Config.in +1 -3
index fad829d..ea45cf3 100644
@@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
 	default "dash"    if BR2_SYSTEM_BIN_SH_DASH
 	default "zsh"     if BR2_SYSTEM_BIN_SH_ZSH
 
-config BR2_TARGET_GENERIC_GETTY
+menuconfig BR2_TARGET_GENERIC_GETTY
 	bool "Run a getty (login prompt) after boot"
 	default y
 
 if BR2_TARGET_GENERIC_GETTY
-menu "getty options"
 config BR2_TARGET_GENERIC_GETTY_PORT
 	string "TTY port"
 	default "console"
@@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
 	help
 	  Any other flags you want to pass to getty,
 	  Refer to getty --help for details.
-endmenu
 endif
 
 config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 system: use a menuconfig for the getty options

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 29 lines · Yann E. MORIN

Making the getty option a menuconfig instead of a simple config automatically moves its dependees into a menu without the need to manually declare such a menu.

---
 system/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
system/Config.in +1 -2
index fad829d..ea45cf3 100644
@@ -260,12 +260,11 @@ config BR2_SYSTEM_BIN_SH
 	default "dash"    if BR2_SYSTEM_BIN_SH_DASH
 	default "zsh"     if BR2_SYSTEM_BIN_SH_ZSH
 
-config BR2_TARGET_GENERIC_GETTY
+menuconfig BR2_TARGET_GENERIC_GETTY
 	bool "Run a getty (login prompt) after boot"
 	default y
 
 if BR2_TARGET_GENERIC_GETTY
-menu "getty options"
 config BR2_TARGET_GENERIC_GETTY_PORT
 	string "TTY port"
 	default "console"

system/Config.in config BR2_TARGET_GENERIC_GETTY_OPTIONS · line 317

Quoted 7 lines
system/Config.in +0 -1
@@ -313,7 +312,6 @@ config BR2_TARGET_GENERIC_GETTY_OPTIONS
 	help
 	  Any other flags you want to pass to getty,
 	  Refer to getty --help for details.
-endmenu
 endif
 
 config BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW

Regards,

Vincent.

#3 lore raw

PATCH 1/1 system: use a menuconfig for the getty options

In reply to Yann E. MORIN
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Making the getty option a menuconfig instead of a simple config automatically moves its dependees into a menu without the need to manually declare such a menu.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard