Skip to contentSkip to conversation

ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding

PATCH Superseded Robert Jarzmik 2 participants 2 messages Sep 4, 2015 – Sep 7, 2015 1 message not in the archive

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding

Quoted 12 lines · Jarkko Nikula

From: Jarkko Nikula <[email protected]>

Commit 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types") caused build error here because it removed the type LPSS_SSP and I didn't notice the type was used here too.

I believe commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") added it accidentally by copying all enum pxa_ssp_type types from include/linux/pxa2xx_ssp.h even LPSS_SSP was for Intel LPSS SPI devices.

Fix the build error by removing this incorrect binding.

Quoted 7 lines
Cc stable at vger.kernel.org # 4.2

---
Sorry if you got this twice today. I had email problems today and this patch didn't go through to at least some of recipients. Resending from other my another address.

I'll take it through pxa tree, and I'll add this :

Fixes 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types")

Up to my understanding this is the tag stable tree will use to know which kernel version this patch should be applied to.

Cheers.

--
Robert

#2 lore raw

PATCH 1/1 ARM: pxa: ssp: Fix build error by removing originally incorrect DT binding

Quoted 22 lines · Robert Jarzmik
Quoted 12 lines · Jarkko Nikula

From: Jarkko Nikula <[email protected]>

Commit 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types") caused build error here because it removed the type LPSS_SSP and I didn't notice the type was used here too.

I believe commit a6e56c28a178 ("ARM: pxa: ssp: add DT bindings") added it accidentally by copying all enum pxa_ssp_type types from include/linux/pxa2xx_ssp.h even LPSS_SSP was for Intel LPSS SPI devices.

Fix the build error by removing this incorrect binding.

Quoted 7 lines
Cc stable at vger.kernel.org # 4.2

---
Sorry if you got this twice today. I had email problems today and this patch didn't go through to at least some of recipients. Resending from other my another address.

Quoted 6 lines

I'll take it through pxa tree, and I'll add this :

Fixes 03fbf488cece ("spi: pxa2xx: Differentiate Intel LPSS types")

Up to my understanding this is the tag stable tree will use to know which kernel version this patch should be applied to.

Thanks for noticing. I added it and resent the patch as v2.

Signature · 1 line
Jarkko