Skip to contentSkip to conversation

package/heirloom-mailx: fix link issue with getopt

PATCH New Romain Naour 2 participants 2 messages May 16, 2015

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 package/heirloom-mailx: fix link issue with getopt

With NIOS2 toolchain, heirloom-mailx fail to build due to missing -fPIC when linking with its own getopt.

Since static build for heirloom-mailx is disabled, always pass -fPIC in CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/333/33346f4555ed403bab7b739dd5d47814efa8eb4c

Signed-off-by Romain Naour <[email protected]>
---
 package/heirloom-mailx/heirloom-mailx.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
package/heirloom-mailx/heirloom-mailx.mk +4 -1
index 7343479..044cd8c 100644
@@ -18,8 +18,11 @@ define HEIRLOOM_MAILX_CONFIGURE_CMDS
 	(cd $(@D); $(TARGET_CONFIGURE_OPTS) $(SHELL) ./makeconfig)
 endef
 
+# -fPIC is needed to build with NIOS2 toolchains.
 define HEIRLOOM_MAILX_BUILD_CMDS
-	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		CFLAGS="$(TARGET_CFLAGS) -fPIC" \
+		-C $(@D)
 endef
 
 define HEIRLOOM_MAILX_INSTALL_TARGET_CMDS
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 package/heirloom-mailx: fix link issue with getopt

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

With NIOS2 toolchain, heirloom-mailx fail to build due to missing -fPIC when linking with its own getopt.

Quoted 7 lines

Since static build for heirloom-mailx is disabled, always pass -fPIC in CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/333/33346f4555ed403bab7b739dd5d47814efa8eb4c

Signed-off-by Romain Naour <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard