Skip to contentSkip to conversation

package/mono: fixing wrong monolite library path

PATCH New Angelo Compagnucci 3 participants 3 messages Nov 30, 2014

lore
Share & tools
lore

Angelo Compagnucci

author
#0 lore raw

PATCH 1/1 package/mono: fixing wrong monolite library path

Due to a bug in makefile logic, monolite libraries path will not be selected when EXTERNAL_MCS parameter is specified. Setting EXTERNAL_MCS to a non existent binary, makes the internal logic to fallback to monolite, setting correctly both binary and library paths.
This has the benefit to force host-mono to always use monolite as bootstrap compiler also in case a mono compiler is already installed on the system.

Fixes:
http://autobuild.buildroot.net/results/fc00952bef03cf3b4785be1a0d9c08dc84aa3f54/

Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/mono/mono.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mono/mono.mk +1 -1
index df67c33..d4beb5f 100644
@@ -55,7 +55,7 @@ HOST_MONO_CONF_OPTS += \
 	--with-profile4=$(if $(BR2_PACKAGE_MONO_40),yes,no) \
 	--with-profile4_5=$(if $(BR2_PACKAGE_MONO_45),yes,no)
 
-HOST_MONO_MAKE_OPTS += EXTERNAL_MCS="$(@D)/mcs/class/lib/monolite/basic.exe"
+HOST_MONO_MAKE_OPTS += EXTERNAL_MCS=false 
 
 HOST_MONO_DEPENDENCIES = host-monolite host-gettext
Signature · 1 line
2.2.0
#1 lore raw

PATCH 1/1 package/mono: fixing wrong monolite library path

Angelo, Rainer, All,

On 2014-11-30 22:41 +0100, Angelo Compagnucci spake thusly:

Quoted 9 lines

Due to a bug in makefile logic, monolite libraries path will not be selected when EXTERNAL_MCS parameter is specified. Setting EXTERNAL_MCS to a non existent binary, makes the internal logic to fallback to monolite, setting correctly both binary and library paths.
This has the benefit to force host-mono to always use monolite as bootstrap compiler also in case a mono compiler is already installed on the system.

Quoted 4 lines

Fixes:
http://autobuild.buildroot.net/results/fc00952bef03cf3b4785be1a0d9c08dc84aa3f54/

Angelo, it is customary to add a reported-by tag to credit the person that reported a bug. It's done like so:

Reported-by Rainer Berns <[email protected]>

It is also customary to put the reporter in Cc: so he gets a proposed fix and gets to test it.

Rainer, care to test this patch, please? If it works, can you reply to this mail and add your tested-by tag?

It's done like so: Tested-by Your NAME <you@there>

Thank you both! :-)

/me is feeling like being educative tonight. Hihi! ;-)

Regards,
Yann E. MORIN.

Quoted 25 lines
Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/mono/mono.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mono/mono.mk +1 -1
index df67c33..d4beb5f 100644
@@ -55,7 +55,7 @@ HOST_MONO_CONF_OPTS += \
 	--with-profile4=$(if $(BR2_PACKAGE_MONO_40),yes,no) \
 	--with-profile4_5=$(if $(BR2_PACKAGE_MONO_45),yes,no)
 
-HOST_MONO_MAKE_OPTS += EXTERNAL_MCS="$(@D)/mcs/class/lib/monolite/basic.exe"
+HOST_MONO_MAKE_OPTS += EXTERNAL_MCS=false 
 
 HOST_MONO_DEPENDENCIES = host-monolite host-gettext
Signature · 6 lines
2.2.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/mono: fixing wrong monolite library path

In reply to Angelo Compagnucci
Quoted 24 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Angelo" == Angelo Compagnucci <[email protected]> writes:

Due to a bug in makefile logic, monolite libraries path will not be selected when EXTERNAL_MCS parameter is specified. Setting EXTERNAL_MCS to a non existent binary, makes the internal logic to fallback to monolite, setting correctly both binary and library paths.
This has the benefit to force host-mono to always use monolite as bootstrap compiler also in case a mono compiler is already installed on the system.

Fixes:
http://autobuild.buildroot.net/results/fc00952bef03cf3b4785be1a0d9c08dc84aa3f54/

Signed-off-by Angelo Compagnucci <[email protected]>
---
 package/mono/mono.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mono/mono.mk +0 -0
index df67c33..d4beb5f 100644

package/mono/mono.mk HOST_MONO_CONF_OPTS += \ · line 58

Quoted 5 lines
package/mono/mono.mk +1 -1
@@ -55,7 +55,7 @@ HOST_MONO_CONF_OPTS += \
 	--with-profile4=$(if $(BR2_PACKAGE_MONO_40),yes,no) \
 	--with-profile4_5=$(if $(BR2_PACKAGE_MONO_45),yes,no)
 
-HOST_MONO_MAKE_OPTS += EXTERNAL_MCS="$(@D)/mcs/class/lib/monolite/basic.exe"
+HOST_MONO_MAKE_OPTS += EXTERNAL_MCS=false

Committed with reported-by added as suggested by Yann and a comment just above this line explaining what it does, thanks.

Signature · 1 line
Bye, Peter Korsgaard