Skip to contentSkip to conversation

ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"

PATCH New Alexey Brodkin 3 participants 3 messages Sep 15, 2014 – Sep 16, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"

This makes size_t to be "unsigned" ssize_t which makes happy compiler on data type checks.

Fix is taken from current development branch of GCC for ARC and will be a part of the next release of ARC tools, so at that point patch should be dropped.

https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3

Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e

Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

---

Compared to v1 comment is added in the patch itself with more info on its origin and reasoning.

---

 .../arc-2014.08/200-size_type_unsigned_int.patch   | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/gcc/arc-2014.08/200-size_type_unsigned_int.patch
package/gcc/arc-2014.08/200-size_type_unsigned_int.patch new file +22 -0
new file mode 100644
index 0000000..4636524
@@ -0,0 +1,22 @@
+Fixes SIZE_TYPE to be "unsigned int" instead of "long unsigned int".
+
+This makes size_t to be "unsigned" ssize_t which makes happy compiler on data
+type checks.
+
+Fix is taken from current development branch of GCC for ARC and will be a
+part of the next release of ARC tools, so at that point patch should be dropped.
+
+https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3
+---
+
+--- a/gcc/config/arc/arc.h
++++ b/gcc/config/arc/arc.h
+@@ -487,7 +487,7 @@ if (GET_MODE_CLASS (MODE) == MODE_INT		\
+ /* Define this as 1 if `char' should by default be signed; else as 0.  */
+ #define DEFAULT_SIGNED_CHAR 0
+ 
+-#define SIZE_TYPE "long unsigned int"
++#define SIZE_TYPE "unsigned int"
+ #define PTRDIFF_TYPE "long int"
+ #define WCHAR_TYPE "int"
+ #define WCHAR_TYPE_SIZE 32
Signature · 1 line
1.9.3
#1 lore raw

PATCH v2 1/1 ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"

Dear Alexey Brodkin,

Quoted 8 lines · Alexey Brodkin

This makes size_t to be "unsigned" ssize_t which makes happy compiler on data type checks.

Fix is taken from current development branch of GCC for ARC and will be a part of the next release of ARC tools, so at that point patch should be dropped.

https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3

Quoted 7 lines

Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e

Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

though you still forgot to add your SoB in the patch itself. I guess Peter can add it when applying.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"

In reply to Alexey Brodkin
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexey" == Alexey Brodkin <[email protected]> writes:

This makes size_t to be "unsigned" ssize_t which makes happy compiler on data type checks.

Fix is taken from current development branch of GCC for ARC and will be a part of the next release of ARC tools, so at that point patch should be dropped.

https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3

Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e

Quoted 7 lines
Cc Anton Kolesov <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Peter Korsgaard <[email protected]>

---

Compared to v1 comment is added in the patch itself with more info on its origin and reasoning.

Committed, thanks.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard