Skip to contentSkip to conversation

package/pkg-autotools: don't use config.site when cross-compiling

PATCH New Romain Naour 5 participants 9 messages Aug 22, 2014 – Sep 14, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

---
v2:
Use /dev/null for CONFIG_SITE to avoid sourcing a file nammed "no" (ThomasDS and Mike Zick)
Add a note about autoconf version
Add reference to the bug #7262

---
 package/pkg-autotools.mk | 2 ++
 1 file changed, 2 insertions(+)
package/pkg-autotools.mk +2 -0
index bcc648d..a424a1c 100644
@@ -126,6 +126,7 @@ define $(2)_CONFIGURE_CMDS
 	$$(TARGET_CONFIGURE_OPTS) \
 	$$(TARGET_CONFIGURE_ARGS) \
 	$$($$(PKG)_CONF_ENV) \
+	CONFIG_SITE=/dev/null \
 	./configure \
 		--target=$$(GNU_TARGET_NAME) \
 		--host=$$(GNU_TARGET_NAME) \
@@ -159,6 +160,7 @@ define $(2)_CONFIGURE_CMDS
 		CFLAGS="$$(HOST_CFLAGS)" \
 		LDFLAGS="$$(HOST_LDFLAGS)" \
                 $$($$(PKG)_CONF_ENV) \
+		CONFIG_SITE=/dev/null \
 		./configure \
 		--prefix="$$(HOST_DIR)/usr" \
 		--sysconfdir="$$(HOST_DIR)/etc" \
Signature · 1 line
1.9.3
#1 lore raw

PATCH v2 2/2 Revert "package/localedef: don't use config.site when cross-compiling"

CONFIG_SITE is now a part of pkg-autotools infrastructure.

This reverts commit 85448febb3c9f21e6e4082fc344b3ef46261c782.

---
v2: commit log: add missing Sob

---
 package/localedef/localedef.mk | 4 ----
 1 file changed, 4 deletions(-)
package/localedef/localedef.mk +0 -4
index 9a7118a..17ffd14 100644
@@ -8,10 +8,6 @@ LOCALEDEF_VERSION = 2.14.1-r17443-ptx1
 LOCALEDEF_SOURCE  = localedef-eglibc-$(LOCALEDEF_VERSION).tar.bz2
 LOCALEDEF_SITE    = http://www.pengutronix.de/software/ptxdist/temporary-src
 
-# Avoid loading /usr/share/config.site that can redefine libdir when
-# the host arch is a 64bit system.
-HOST_LOCALEDEF_CONF_ENV = CONFIG_SITE="no"
-
 HOST_LOCALEDEF_CONF_OPT += \
 	--prefix=/usr \
 	--with-glibc=./eglibc
Signature · 1 line
1.9.3
#3 lore raw

PATCH v2 2/2 Revert "package/localedef: don't use config.site when cross-compiling"

In reply to Romain Naour
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

CONFIG_SITE is now a part of pkg-autotools infrastructure. This reverts commit 85448febb3c9f21e6e4082fc344b3ef46261c782.

---
v2: commit log: add missing Sob

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

In reply to Romain Naour
Quoted 7 lines · Romain Naour

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Quoted 7 lines

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

#5 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

In reply to Romain Naour

Dear Romain Naour,

Quoted 7 lines · Romain Naour

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Quoted 7 lines

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

I am wondering if this change should go in master (for 2014.08) or in the next branch (for 2014.11). That close to the release, doing a change in the core infrastructure seems a bit invasive to me. What if it breaks the build of other packages? Seems unlikely, I admit, but still. What do others think?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

Hi Thomas,

Le 24/08/2014 18:14, Thomas Petazzoni a ?crit :

Quoted 16 lines

Dear Romain Naour,

Quoted 13 lines · Romain Naour

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

Quoted 7 lines
Quoted 1 line

I am wondering if this change should go in master (for 2014.08) or in the next branch (for 2014.11). That close to the release, doing a change in the core infrastructure seems a bit invasive to me. What if it breaks the build of other packages? Seems unlikely, I admit, but still. What do others think?

I think this patch can go to next since the issue is already fixed in master but just for host-localedef.

Actually, it seems that only host-localedef was affected by this issue.

Best regards,
Romain

Quoted 4 lines

Thanks!

Thomas

#7 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

Hi Thomas, Romain,

Quoted 27 lines · Romain Naour

Hi Thomas,

Le 24/08/2014 18:14, Thomas Petazzoni a ?crit :

Quoted 16 lines

Dear Romain Naour,

Quoted 13 lines · Romain Naour

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

Quoted 7 lines
Quoted 1 line

I am wondering if this change should go in master (for 2014.08) or in the next branch (for 2014.11). That close to the release, doing a change in the core infrastructure seems a bit invasive to me. What if it breaks the build of other packages? Seems unlikely, I admit, but still. What do others think?

Quoted 5 lines

I think this patch can go to next since the issue is already fixed in master but just for host-localedef.

Actually, it seems that only host-localedef was affected by this issue.

I was going to judge 'master', but then I saw Romain's reply. The reported bug is indeed already fixed, and no other problems were reported so far, so I agree now with applying these patches to -next.

Best regards,
Thomas

#8 lore raw

PATCH v2 1/2 package/pkg-autotools: don't use config.site when cross-compiling

In reply to Romain Naour
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

On fedora 20 64bits host, the file /usr/share/config.site contains a fix for installing libraries into /lib/lib64 on 64bits systems that redefine libdir in the generated Makefile

For safety and avoid the bug #7262 [1], disable loading this file when running the configure script for the target and the host.

Quoted 7 lines

Note: configure scripts generated with autoconf < 2.65 will source the /dev/null and print this line:
"configure: loading site script /dev/null"

[1]: https://bugs.busybox.net/show_bug.cgi?id=7262

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard