Skip to contentSkip to conversation

package: libpng: don't append prefix to symbol names in the version script file

PATCH New sonic.adi at gmail.com 2 participants 3 messages Dec 30, 2013 – Jan 14, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package: libpng: don't append prefix to symbol names in the version script file

From: Sonic Zhang <[email protected]>

Even if Blackfin GNU toolchain add prefix '_' to all symbols, symbol prefix is not accepted in the link flag --version-script. Don't append prefix in the symbols in the version script file.

---
 .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
package/libpng/libpng-02-ingore-symbol-prefix.patch new file +26 -0
new file mode 100644
index 0000000..7f2cfff
@@ -0,0 +1,26 @@
+Even if Blackfin GNU toolchain add prefix '_' to all symbols,
+symbol prefix is not accepted in the link flag --version-script.
+Don't append prefix in the symbols in the version script file.
+
+--- libpng-1.6.8/Makefile.am	2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.am	2013-12-30 18:22:15.565795726 +0800
+@@ -225,7 +225,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0'\
+ 		-DPNGLIB_VERSION='@PNGLIB_VERSION@'\
+-		-DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
++		-DSYMBOL_PREFIX=''\
+ 		-DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
+ 
+ if DO_PNG_PREFIX
+--- libpng-1.6.8/Makefile.in	2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.in	2013-12-30 18:22:09.853794547 +0800
+@@ -698,7 +698,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0' \
+ 	-DPNGLIB_VERSION='@PNGLIB_VERSION@' \
+-	-DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
++	-DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
+ 	-DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
+ all: $(BUILT_SOURCES) config.h
+ 	$(MAKE) $(AM_MAKEFLAGS) all-am
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 package: libpng: don't append prefix to symbol names in the version script file

Ping

Sonic Zhang

Quoted 47 lines · On Mon, Dec 30, 2013 at 6:35 PM, <[email protected]> wrote:

From: Sonic Zhang <[email protected]>

Even if Blackfin GNU toolchain add prefix '_' to all symbols, symbol prefix is not accepted in the link flag --version-script. Don't append prefix in the symbols in the version script file.

---
 .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
package/libpng/libpng-02-ingore-symbol-prefix.patch new file +26 -1
new file mode 100644
index 0000000..7f2cfff
@@ -0,0 +1,26 @@
+Even if Blackfin GNU toolchain add prefix '_' to all symbols,
+symbol prefix is not accepted in the link flag --version-script.
+Don't append prefix in the symbols in the version script file.
+
+--- libpng-1.6.8/Makefile.am   2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.am       2013-12-30 18:22:15.565795726 +0800
+@@ -225,7 +225,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0'\
+               -DPNGLIB_VERSION='@PNGLIB_VERSION@'\
+-              -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)'\
++              -DSYMBOL_PREFIX=''\
+               -DPNG_NO_USE_READ_MACROS -DPNG_BUILDING_SYMBOL_TABLE
+
+ if DO_PNG_PREFIX
+--- libpng-1.6.8/Makefile.in   2013-12-30 18:23:08.261797417 +0800
++++ libpng-1.6.8.bak/Makefile.in       2013-12-30 18:22:09.853794547 +0800
+@@ -698,7 +698,7 @@
+ # interfering with the symbol file format.
+ SYMBOL_CFLAGS = -DPNGLIB_LIBNAME='PNG at PNGLIB_MAJOR@@PNGLIB_MINOR at _0' \
+       -DPNGLIB_VERSION='@PNGLIB_VERSION@' \
+-      -DSYMBOL_PREFIX='$(SYMBOL_PREFIX)' -DPNG_NO_USE_READ_MACROS \
++      -DSYMBOL_PREFIX='' -DPNG_NO_USE_READ_MACROS \
+       -DPNG_BUILDING_SYMBOL_TABLE $(am__append_5)
+ all: $(BUILT_SOURCES) config.h
+       $(MAKE) $(AM_MAKEFLAGS) all-am
--

1.7.9.5

#2 lore raw

PATCH 1/1 package: libpng: don't append prefix to symbol names in the version script file

In reply to sonic.adi at gmail.com

package/libpng/libpng-02-ingore-symbol-prefix.patch

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"sonic" == sonic adi <[email protected]> writes:

From: Sonic Zhang <[email protected]>
Even if Blackfin GNU toolchain add prefix '_' to all symbols, symbol prefix is not accepted in the link flag --version-script. Don't append prefix in the symbols in the version script file.

---
 .../libpng/libpng-02-ingore-symbol-prefix.patch    |   26 ++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/libpng/libpng-02-ingore-symbol-prefix.patch
package/libpng/libpng-02-ingore-symbol-prefix.patch new file +0 -0
new file mode 100644
index 0000000..7f2cfff

Committed with the filename typo fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard