Skip to contentSkip to conversation

openpgm: disable on AVR32

PATCH New Alexander Lukichev 3 participants 3 messages Nov 7, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 openpgm: disable on AVR32

openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected.

This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

---
v2:
- removed KConfig comment that openpgm is broken on AVR32, commented instead in its Config.in
- added package name which disables PGM support for zeromq on

    AVR32

v3:
- updated comments and changed !BR_avr32 restriction to !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 as the problem is due to the toolchain, not AVR32 architecture, as suggested by Thomas Petazzoni

---
 package/openpgm/Config.in | 2 ++
 package/zeromq/Config.in  | 1 +
 2 files changed, 3 insertions(+)
package/openpgm/Config.in +2 -0
index cae74f7..e34740c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_OPENPGM
 	bool "openpgm"
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # lacks required builtins
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INET_IPV6
 	depends on BR2_USE_WCHAR
@@ -14,3 +15,4 @@ config BR2_PACKAGE_OPENPGM
 
 comment "openpgm needs a toolchain w/ wchar, threads, IPv6"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR)
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5
package/zeromq/Config.in +1 -0
index 42e13d2..dad1dd4 100644
@@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ
 config BR2_PACKAGE_ZEROMQ_PGM
 	bool "PGM/EPGM support"
 	depends on BR2_PACKAGE_ZEROMQ
+	depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # openpgm
 	select BR2_PACKAGE_OPENPGM
 	help
 	  Add support for Pragmatic General Multicast protocol (RFC 3208)
Signature · 1 line
1.8.0.1
#1 lore raw

PATCH v3 1/1 openpgm: disable on AVR32

Dear Alexander Lukichev,

Quoted 9 lines · Alexander Lukichev

openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected.

Quoted 8 lines

This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v3 1/1 openpgm: disable on AVR32

In reply to Alexander Lukichev
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexander" == Alexander Lukichev <[email protected]> writes:

openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected.

Quoted 6 lines

This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds.

Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/
(at least)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard