Skip to contentSkip to conversation

mmc: sdhci: dove: Fix build breakage

PATCH In review Thierry Reding 3 participants 4 messages Oct 23, 2013 – Oct 28, 2013

Subsystems (2)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 mmc: sdhci: dove: Fix build breakage

Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) converts tasklets to work structs, but typos the conversion in the Dove driver.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/mmc/host/sdhci-dove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-dove.c +1 -1
index 45c7f25..95f1076 100644
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
 {
 	struct sdhci_host *host = data;
 
-	schedule_schedule(&host->card_detect_work);
+	schedule_work(&host->card_detect_work);
 	return IRQ_HANDLED;
 }
Signature · 1 line
1.8.4
#1 lore raw

Soory, I thought I had corrected this typo.

Signed-off-by Jeremie Samuel <[email protected]>
Signature · 4 lines
Jeremie Samuel              Parrot S.A.
Software Engineer           14, quai de Jemmapes
R&D/OS Platform             75010 Paris, France
http://www.parrot.com
Quoted 22 lines · Thierry Reding

Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) converts tasklets to work structs, but typos the conversion in the Dove driver.

Signed-off-by Thierry Reding <[email protected]>
---
  drivers/mmc/host/sdhci-dove.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-dove.c +1 -1
index 45c7f25..95f1076 100644
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
  {
  	struct sdhci_host *host = data;
 
-	schedule_schedule(&host->card_detect_work);
+	schedule_work(&host->card_detect_work);
  	return IRQ_HANDLED;
  }
#2 lore raw
In reply to Thierry Reding

Hi,

Quoted 14 lines · Thierry Reding

Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) converts tasklets to work structs, but typos the conversion in the Dove driver.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/mmc/host/sdhci-dove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-dove.c +0 -0
index 45c7f25..95f1076 100644

drivers/mmc/host/sdhci-dove.c static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data) · line 44

Quoted 7 lines
drivers/mmc/host/sdhci-dove.c +1 -1
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
 {
 	struct sdhci_host *host = data;
 
-	schedule_schedule(&host->card_detect_work);
+	schedule_work(&host->card_detect_work);
 	return IRQ_HANDLED;
 }

Thanks, Thierry -- I hope it's okay with you if I merge your fix into the original patch and add your S-o-b to that patch:

Signed-off-by Anton Vorontsov <[email protected]>
Signed-off-by Jeremie Samuel <[email protected]>
[treding: Fix typo causing sdhci-dove build breakage]
Signed-off-by Thierry Reding <[email protected]>
Signed-off-by Chris Ball <[email protected]>

- Chris.

Signature · 1 line
Chris Ball   <[email protected]>   <http://printf.net/>
author
#3 lore raw
Quoted 28 lines · Chris Ball

Hi,

Quoted 14 lines · Thierry Reding

Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets) converts tasklets to work structs, but typos the conversion in the Dove driver.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/mmc/host/sdhci-dove.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-dove.c +0 -0
index 45c7f25..95f1076 100644

drivers/mmc/host/sdhci-dove.c static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data) · line 44

Quoted 7 lines
drivers/mmc/host/sdhci-dove.c +1 -1
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
 {
 	struct sdhci_host *host = data;
 
-	schedule_schedule(&host->card_detect_work);
+	schedule_work(&host->card_detect_work);
 	return IRQ_HANDLED;
 }

Thanks, Thierry -- I hope it's okay with you if I merge your fix into the original patch and add your S-o-b to that patch:

Quoted 5 lines
Signed-off-by Anton Vorontsov <[email protected]>
Signed-off-by Jeremie Samuel <[email protected]>
[treding: Fix typo causing sdhci-dove build breakage]
Signed-off-by Thierry Reding <[email protected]>
Signed-off-by Chris Ball <[email protected]>

Sure, no problem.

Thierry