Skip to contentSkip to conversation

gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

PATCH New Tony Lindgren 3 participants 3 messages Mar 6, 2012 – Mar 12, 2012

Subsystems (2)
GPIO OMAP GPIO driver
lore
Share & tools
lore

Tony Lindgren

author
#0 lore raw

PATCH 1/1 gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

From: Tony Lindgren <[email protected]>
Date: Mon, 5 Mar 2012 15:32:38 -0800
Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init() is __devinit. Otherwise we get:

WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc() The function __devinit omap_gpio_chip_init() references
a function __init omap_mpuio_alloc_gc().
If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
annotate omap_mpuio_alloc_gc with a matching annotation.

Signed-off-by Tony Lindgren <[email protected]>
drivers/gpio/gpio-omap.c +1 -1
@@ -1081,7 +1081,7 @@ static void omap_gpio_mod_init(struct gpio_bank *bank, int id)
 	}
 }
 
-static __init void
+static __devinit void
 omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
 		    unsigned int num)
 {
#1 lore raw

PATCH 1/1 gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

Quoted 7 lines · Tony Lindgren

From: Tony Lindgren <[email protected]>
Date: Mon, 5 Mar 2012 15:32:38 -0800
Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init() is __devinit. Otherwise we get:

Quoted 8 lines

WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc() The function __devinit omap_gpio_chip_init() references
a function __init omap_mpuio_alloc_gc().
If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
annotate omap_mpuio_alloc_gc with a matching annotation.

Signed-off-by Tony Lindgren <[email protected]>
Acked-by Kevin Hilman <[email protected]>
Quoted 15 lines
drivers/gpio/gpio-omap.c +1 -2
@@ -1081,7 +1081,7 @@ static void omap_gpio_mod_init(struct gpio_bank *bank, int id)
 	}
 }
 
-static __init void
+static __devinit void
 omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
 		    unsigned int num)
 {
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#2 lore raw

PATCH 1/1 gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

Quoted 16 lines · Kevin Hilman
Quoted 14 lines · Tony Lindgren

From: Tony Lindgren <[email protected]>
Date: Mon, 5 Mar 2012 15:32:38 -0800
Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()

Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init() is __devinit. Otherwise we get:

WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc() The function __devinit omap_gpio_chip_init() references
a function __init omap_mpuio_alloc_gc().
If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
annotate omap_mpuio_alloc_gc with a matching annotation.

Quoted 3 lines
Quoted 1 line
Signed-off-by Tony Lindgren <[email protected]>
Acked-by Kevin Hilman <[email protected]>

applied, thx.

g.