Skip to contentSkip to conversation

mioa701: fix camera regression

PATCH New Robert Jarzmik 3 participants 4 messages Jun 2, 2010 – Jun 13, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support
lore
Share & tools
lore

Robert Jarzmik

author maintainer
#0 lore raw

PATCH 1/1 mioa701: fix camera regression

Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the camera is not working anymore.

After the v4l2 migration, the mt9m111 camera board information was not passed to the i2c layer anymore, but stored for future use of v4l2 (through soc_camera).

Because mioa701_i2c_devices[] was tagged as "__initdata", and because after the v4l2 migration, the new structure "iclink" references it, the mt9m111 driver is not probed anymore, as part of "iclink" is not valid (discarded after kernel init).

Although there is not compilation error, nor runtime oops, this patch restores a working camera on the mioa701 board.

Signed-off-by Robert Jarzmik <[email protected]>

--
Eric, could you schedule that into your fix branch please ?

---
 arch/arm/mach-pxa/mioa701.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-pxa/mioa701.c +1 -1
index 7a50ed8..9836921 100644
@@ -696,7 +696,7 @@ static struct i2c_board_info __initdata mioa701_pi2c_devices[] = {
 };
 
 /* Board I2C devices. */
-static struct i2c_board_info __initdata mioa701_i2c_devices[] = {
+static struct i2c_board_info mioa701_i2c_devices[] = {
 	{
 		I2C_BOARD_INFO("mt9m111", 0x5d),
 	},
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 mioa701: fix camera regression

Quoted 13 lines · Robert Jarzmik

Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the camera is not working anymore.

After the v4l2 migration, the mt9m111 camera board information was not passed to the i2c layer anymore, but stored for future use of v4l2 (through soc_camera).

Because mioa701_i2c_devices[] was tagged as "__initdata", and because after the v4l2 migration, the new structure "iclink" references it, the mt9m111 driver is not probed anymore, as part of "iclink" is not valid (discarded after kernel init).

Quoted 4 lines

Although there is not compilation error, nor runtime oops, this patch restores a working camera on the mioa701 board.

Signed-off-by Robert Jarzmik <[email protected]>
Acked-by Guennadi Liakhovetski <[email protected]>
Quoted 29 lines

--
Eric, could you schedule that into your fix branch please ?

---
 arch/arm/mach-pxa/mioa701.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-pxa/mioa701.c +1 -1
index 7a50ed8..9836921 100644
@@ -696,7 +696,7 @@ static struct i2c_board_info __initdata mioa701_pi2c_devices[] = {
 };
 
 /* Board I2C devices. */
-static struct i2c_board_info __initdata mioa701_i2c_devices[] = {
+static struct i2c_board_info mioa701_i2c_devices[] = {
 	{
 		I2C_BOARD_INFO("mt9m111", 0x5d),
 	},
Signature · 7 lines
1.7.0.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

author maintainer
#2 lore raw

PATCH 1/1 mioa701: fix camera regression

Quoted 15 lines · Robert Jarzmik
Quoted 14 lines

Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the camera is not working anymore.

After the v4l2 migration, the mt9m111 camera board information was not passed to the i2c layer anymore, but stored for future use of v4l2 (through soc_camera).

Because mioa701_i2c_devices[] was tagged as "__initdata", and because after the v4l2 migration, the new structure "iclink" references it, the mt9m111 driver is not probed anymore, as part of "iclink" is not valid (discarded after kernel init).

Quoted 10 lines
Quoted 4 lines

Although there is not compilation error, nor runtime oops, this patch restores a working camera on the mioa701 board.

Signed-off-by Robert Jarzmik <[email protected]>
Acked-by Guennadi Liakhovetski <[email protected]>
Quoted 3 lines

--
Eric, could you schedule that into your fix branch please ?

Ping.

--
Robert

#3 lore raw

PATCH 1/1 mioa701: fix camera regression

Quoted 20 lines · Robert Jarzmik
Quoted 20 lines · Robert Jarzmik
Quoted 18 lines

Since commit a48c24a696f0d93c49f913b7818e9819612b1f4e, the camera is not working anymore.

After the v4l2 migration, the mt9m111 camera board information was not passed to the i2c layer anymore, but stored for future use of v4l2 (through soc_camera).

Because mioa701_i2c_devices[] was tagged as "__initdata", and because after the v4l2 migration, the new structure "iclink" references it, the mt9m111 driver is not probed anymore, as part of "iclink" is not valid (discarded after kernel init).

Although there is not compilation error, nor runtime oops, this patch restores a working camera on the mioa701 board.

Signed-off-by Robert Jarzmik <[email protected]>
Quoted 8 lines
Quoted 5 lines
Acked-by Guennadi Liakhovetski <[email protected]>
Quoted 3 lines

--
Eric, could you schedule that into your fix branch please ?

Ping.

Sorry. Now merged.